Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Multipart model rotation on x axis (1.19.2)

ChamoisEST

By ChamoisEST
in Modder Support

 Share

Recommended Posts

ChamoisEST Tree Puncher

ChamoisEST

Posted
Posted (edited)

Hello!

I have a multipart blockstate consisting of two different models - block base model (block/void_filter) and a connector model (block/filter_connector) that is only shown when a condition is true. The connector model should rotate automatically to the side where the condition is true.

While it works great on north, east, south and west sides (y rotation), it doesn't seem to work on up and down sides (x rotation). Is it not possible to rotate a multipart blockstate part on x axis or am I missing something obvious here?

blocstates\void_filter.json

Spoiler 
{
  "multipart": [
    {
      "apply": {
        "model": "miningmadness:block/void_filter"
      }
    },
    {
      "apply": {
        "model": "miningmadness:block/filter_connector",
        "uvlock": false,
        "x": 270
      },
      "when": {
        "up": "true"
      }
    },
    {
      "apply": {
        "model": "miningmadness:block/filter_connector",
        "uvlock": false,
        "x": 90
      },
      "when": {
        "down": "true"
      }
    },
    {
      "apply": {
        "model": "miningmadness:block/filter_connector",
        "uvlock": false
      },
      "when": {
        "north": "true"
      }
    },
    {
      "apply": {
        "model": "miningmadness:block/filter_connector",
        "uvlock": false,
        "y": 90
      },
      "when": {
        "east": "true"
      }
    },
    {
      "apply": {
        "model": "miningmadness:block/filter_connector",
        "uvlock": false,
        "y": 180
      },
      "when": {
        "south": "true"
      }
    },
    {
      "apply": {
        "model": "miningmadness:block/filter_connector",
        "uvlock": false,
        "y": 270
      },
      "when": {
        "west": "true"
      }
    }
  ]
}

 

 

VoidFilterBlock.java

Currently the blockState values are hard-coded just for testing purposes.

Spoiler 
package com.chamoisest.miningmadness.common.block;

import com.chamoisest.miningmadness.common.block.base.BaseCustomEntityBlock;
import com.chamoisest.miningmadness.common.block.entity.VoidFilterBlockEntity;
import com.chamoisest.miningmadness.common.init.MMBlockEntities;
import net.minecraft.core.BlockPos;
import net.minecraft.world.level.BlockGetter;
import net.minecraft.world.level.Level;
import net.minecraft.world.level.block.Block;
import net.minecraft.world.level.block.entity.BlockEntity;
import net.minecraft.world.level.block.entity.BlockEntityTicker;
import net.minecraft.world.level.block.entity.BlockEntityType;
import net.minecraft.world.level.block.state.BlockState;
import net.minecraft.world.level.block.state.StateDefinition;
import net.minecraft.world.level.block.state.properties.BlockStateProperties;
import net.minecraft.world.level.block.state.properties.BooleanProperty;
import net.minecraft.world.phys.shapes.BooleanOp;
import net.minecraft.world.phys.shapes.CollisionContext;
import net.minecraft.world.phys.shapes.Shapes;
import net.minecraft.world.phys.shapes.VoxelShape;
import org.jetbrains.annotations.Nullable;

import java.util.stream.Stream;

public class VoidFilterBlock extends BaseCustomEntityBlock {

    public static final BooleanProperty NORTH = BlockStateProperties.NORTH;
    public static final BooleanProperty SOUTH = BlockStateProperties.SOUTH;
    public static final BooleanProperty EAST = BlockStateProperties.EAST;
    public static final BooleanProperty WEST = BlockStateProperties.WEST;
    public static final BooleanProperty UP = BlockStateProperties.UP;
    public static final BooleanProperty DOWN = BlockStateProperties.DOWN;

    public VoidFilterBlock(Properties pProperties) {
        super(pProperties);
        this.registerDefaultState(this.stateDefinition.any().setValue(NORTH, Boolean.FALSE).setValue(EAST, Boolean.FALSE).setValue(SOUTH, Boolean.FALSE).setValue(WEST, Boolean.FALSE).setValue(UP, Boolean.TRUE).setValue(DOWN, Boolean.TRUE));
    }

    //private static final VoxelShape SHAPE = Block.box(0,0,0,7,7,7);

    private static final VoxelShape SHAPE = Stream.of(
            Block.box(2,2,2,14,14,14)

    ).reduce((v1, v2) -> {
        return Shapes.join(v1, v2, BooleanOp.OR);
    }).get();

    @Override
    public VoxelShape getShape(BlockState pState, BlockGetter pLevel, BlockPos pPos, CollisionContext pContext) {
        return SHAPE;
    }

    @Override
    protected void createBlockStateDefinition(StateDefinition.Builder<Block, BlockState> builder){
        super.createBlockStateDefinition(builder);
        builder.add(NORTH, SOUTH, EAST, WEST, UP, DOWN);
    }

    /* BLOCK ENTITY*/

    @Nullable
    @Override
    public BlockEntity newBlockEntity(BlockPos pos, BlockState state) {
        return new VoidFilterBlockEntity(pos, state);
    }

    @Nullable
    @Override
    public <T extends BlockEntity> BlockEntityTicker<T> getTicker(Level level, BlockState state, BlockEntityType<T> type) {
        return createTickerHelper(type, MMBlockEntities.VOID_FILTER.get(), VoidFilterBlockEntity::tick);
    }
}

 

 

Edited by ChamoisEST
  • ChamoisEST changed the title to Multipart model rotation on x axis (1.19.2)
ChampionAsh5357 Reality Controller

ChampionAsh5357

Posted
Posted
21 hours ago, ChamoisEST said:

Is it not possible to rotate a multipart blockstate part on x axis or am I missing something obvious here?

No, it is. Chorus plants do the exact same thing. I would guess that it might be a transparent texture is being applied since you aren't preserving the UV through the lock.

ChamoisEST Tree Puncher

ChamoisEST

Posted
  • Author
Posted
1 hour ago, ChampionAsh5357 said:

No, it is. Chorus plants do the exact same thing. I would guess that it might be a transparent texture is being applied since you aren't preserving the UV through the lock.

The texture isn't transparent. It's there, it just isn't rotated. If I also add a y rotation, it still rotates on the y axis, but still no rotation on the x axis.

The image in the spoiler shows what it looks like right now (should've added it in the original post, just forgot). Since UP and DOWN are both true and the rest are false, the only connections should be on the top and bottom. Instead, both of the connectors show up in the front, overlapping each other.

Spoiler

filter-not-correct.png

 

ChampionAsh5357 Reality Controller

ChampionAsh5357

Posted
Posted
2 hours ago, ChamoisEST said:

The image in the spoiler shows what it looks like right now (should've added it in the original post, just forgot). Since UP and DOWN are both true and the rest are false, the only connections should be on the top and bottom. Instead, both of the connectors show up in the front, overlapping each other.

 

If they were both on the front, there should be some z-fighting which it doesn't look like there is. I'm curious, if you load up a debug world, fly over to all your block states, and then look at the results using f3, which models are properly rendered and which aren't? Based on your blockstate json, I see nothing wrong unless I'm missing something in the block model itself.

ChamoisEST Tree Puncher

ChamoisEST

Posted
  • Author
Posted
18 hours ago, ChampionAsh5357 said:

If they were both on the front, there should be some z-fighting which it doesn't look like there is. I'm curious, if you load up a debug world, fly over to all your block states, and then look at the results using f3, which models are properly rendered and which aren't? Based on your blockstate json, I see nothing wrong unless I'm missing something in the block model itself.

The ones where UP and DOWN are false are properly rendered. Whenever either one of those is true, the model's front face is rendered, whether the front face actually needs to be rendered or not.

Filter_connector model json:

Spoiler 
{
	"credit": "Made with Blockbench",
	"texture_size": [32, 32],
	"textures": {
		"0": "miningmadness:block/filter_connector",
		"particle": "miningmadness:block/filter_connector"
	},
	"elements": [
		{
			"from": [14, 5, 5],
			"to": [15, 11, 11],
			"faces": {
				"north": {"uv": [6, 6, 6.5, 9], "texture": "#0"},
				"east": {"uv": [4, 0, 7, 3], "texture": "#0"},
				"south": {"uv": [6.5, 6, 7, 9], "texture": "#0"},
				"west": {"uv": [4, 3, 7, 6], "texture": "#0"},
				"up": {"uv": [7.5, 3, 7, 0], "texture": "#0"},
				"down": {"uv": [7.5, 3, 7, 6], "texture": "#0"}
			}
		},
		{
			"from": [15, 4, 4],
			"to": [16, 12, 12],
			"faces": {
				"north": {"uv": [4, 6, 4.5, 10], "texture": "#0"},
				"east": {"uv": [0, 0, 4, 4], "texture": "#0"},
				"south": {"uv": [4.5, 6, 5, 10], "texture": "#0"},
				"west": {"uv": [0, 4, 4, 8], "texture": "#0"},
				"up": {"uv": [5.5, 10, 5, 6], "texture": "#0"},
				"down": {"uv": [6, 6, 5.5, 10], "texture": "#0"}
			}
		}
	],
	"groups": [
		{
			"name": "Connector",
			"origin": [8, 8, 8],
			"color": 0,
			"children": [0, 1]
		}
	]
}

 

 

ChamoisEST Tree Puncher

ChamoisEST

Posted
  • Author
Posted
47 minutes ago, ChampionAsh5357 said:

Hmm, it's strange that it isn't working since I don't notice anything wrong. Another curiosity, is the json in the `build/resources` folder the same as the blockstate json in the `src/main/resources`.

Yes, it seems to be same.

ChampionAsh5357 Reality Controller

ChampionAsh5357

Posted
Posted

Ah ha! I figured it out! The initial position of your model is facing east, not north. As such, when rotating in the x axis, it just rotates left and right, which makes sense since you don't see any difference except for maybe the texture looking slightly different.

Try using this for the filter connector instead, I've adjust the base model to point north: 

{
	"credit": "Made with Blockbench",
	"texture_size": [32, 32],
	"textures": {
		"0": "miningmadness:block/filter_connector",
		"particle": "miningmadness:block/filter_connector"
	},
	"elements": [
		{
			"from": [5, 5, 1],
			"to": [11, 11, 2],
			"rotation": {"angle": 0, "axis": "y", "origin": [8, 8, 8]},
			"faces": {
				"north": {"uv": [4, 0, 7, 3], "texture": "#0"},
				"east": {"uv": [6.5, 6, 7, 9], "texture": "#0"},
				"south": {"uv": [4, 3, 7, 6], "texture": "#0"},
				"west": {"uv": [6, 6, 6.5, 9], "texture": "#0"},
				"up": {"uv": [7.5, 3, 7, 0], "rotation": 270, "texture": "#0"},
				"down": {"uv": [7.5, 3, 7, 6], "rotation": 90, "texture": "#0"}
			}
		},
		{
			"from": [4, 4, 0],
			"to": [12, 12, 1],
			"rotation": {"angle": 0, "axis": "y", "origin": [8, 8, 8]},
			"faces": {
				"north": {"uv": [0, 0, 4, 4], "texture": "#0"},
				"east": {"uv": [4.5, 6, 5, 10], "texture": "#0"},
				"south": {"uv": [0, 4, 4, 8], "texture": "#0"},
				"west": {"uv": [4, 6, 4.5, 10], "texture": "#0"},
				"up": {"uv": [5.5, 10, 5, 6], "rotation": 270, "texture": "#0"},
				"down": {"uv": [6, 6, 5.5, 10], "rotation": 90, "texture": "#0"}
			}
		}
	],
	"groups": [
		{
			"name": "Connector",
			"origin": [8, 8, 8],
			"color": 0,
			"children": [0, 1]
		}
	]
}

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept