Jump to content

[Solved] Unregistering commands from CommandDispatcher


Frozen Storm

Recommended Posts

I'm trying to unregister a command I'd previously registered with the CommandDispatcher using something like

private static int registerAlias(CommandDispatcher<CommandSourceStack> dispatcher, String alias, String command) {
	dispatcher.register(Commands.literal(alias)
		.executes((commandContext) -> {
			dispatcher.execute(command, commandContext.getSource());
			return Command.SINGLE_SUCCESS;
		})
	);
	return Command.SINGLE_SUCCESS;
}

The dispatcher doesn't seem to have an unregister method. The closest I found was the removeCommand method here, but that seems to be a Bukkit thing. So I tried another solution that does something similar with reflection:

@SuppressWarnings("unchecked")
private static int unregisterAlias(CommandDispatcher<CommandSourceStack> dispatcher, String alias) {
	Object node = dispatcher.getRoot().getChild(alias);
	if (node != null) {
		try {
			if (node instanceof LiteralCommandNode<?>) {
				Field literals = CommandNode.class.getDeclaredField("literals");
				literals.setAccessible(true);
				((Map<String, ?>) literals.get(node)).remove(alias, node);
			} else if (node instanceof ArgumentCommandNode<?, ?>) {
				Field arguments = CommandNode.class.getDeclaredField("arguments");
				arguments.setAccessible(true);
				((Map<String, ?>) arguments.get(node)).remove(alias, node);
			}
			Field children = CommandNode.class.getDeclaredField("children");
			children.setAccessible(true);
			((Map<String, ?>) children.get(node)).remove(alias, node);
		} catch (ReflectiveOperationException e) {
			throw new RuntimeException("Error removing command: " + alias, e);
		}
	}
	return Command.SINGLE_SUCCESS;
}

However, this didn't work. The method was executed without errors (I checked with the Debugger), but the command was still working ingame, meaning it wasn't actually removed from the dispatcher. How would I actually remove a registered command from a CommandDispatcher?

Edited by Frozen Storm
Resolved
Link to comment
Share on other sites

What the heck are you trying to do? If you want to remove a command that you added, just remove or comment out the code that registers that command! If you are trying to completely remove a command during runtime, that is probably impossible.

Edited by Hipposgrumm

I'm not good at modding, but at least I can read a crash report (well enough). That's something, right?

Link to comment
Share on other sites

Yes, I'm trying to remove a command during runtime. The command is added (registered) either at game start or during runtime with the registerAlias method, and I'd like to be able to remove it without having to restart the game.

Edited by Frozen Storm
Link to comment
Share on other sites

I managed to accomplish this by simply reregistering the command to a command that simply prints an error message to the player:

 

dispatcher.register(Commands.literal(alias)
  .executes(commandContext -> {
    Minecraft.getInstance().player.sendSystemMessage(Component.literal("Alias " + alias " has been removed."));
    return Command.SINGLE_SUCCESS;
  })
);

 

Link to comment
Share on other sites

  • Frozen Storm changed the title to [Solved] Unregistering commands from CommandDispatcher

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I downloaded forge for 1.21 because I wanted to play the new update with a few mods. When I load up the game on the forge installation, the game seems to launch fine, but then freezes and goes into that "not responding" state a few seconds after sitting on the menu. It stays on not responding forever, and I have to close the game myself. The normal vanilla game without forge loads and works perfectly fine, though. The exit code I receive is either 1 or -805306369, depending on how I close the game. When I force close with task manager, I get exit code 1. When I close using the not responding menu (close the program or wait for it to respond), I get exit code -805306369. I tried taking all of the mods out to see if they were the problem, but the same issue still persists even with 0 mods in the mods folder. The pastebin linked is the log from when I launched the game with forge after taking all of the mods out of the mods folder. (Nothing ever shows up in the crash-reports folder, but I do have this from the logs): https://pastebin.com/9bL8awvE I had to delete some of the bottom of the log to be able to upload it onto pastebin, but anything deleted was identical to the lines there at the bottom. Some things I have tried include: Allocating more ram, updating display drivers, updating java version (currently have Java 21, tried switching to java 17 but that did not work either), removing or changing settings on programs that may conflict with minecraft (followed this list https://minecrafthopper.net/help/known-incompatible-software/). None have worked so far. I'm aware of course that this is a beta version of forge, but I just wanted to see if there was something I could do to fix this, or if I will just need to wait for a more stable, non beta version to be released.  
    • sorry if this is an incorrect log or wrong tag ive never used this before and im new to modding latest log: file:///C:/Users/jason/curseforge/minecraft/Instances/Cottage Witch/logs/latest.log
    • Hi its me from my first account. I added creative core but when i start minecraft he gives me an error. Now i can't send you the log but I will later 
    • I want my mod to add two new NBT values to Block Displays and Item Displays (Like left-rotation, scale, transformation, etc.), which I call texture_repetition and texture_shift (both Vector3f variables). Texture_repetition allows the Display to repeat its texture or only show part of it, and the texture_shift value allows you to shift to the part of the texture you want the display to show. I already tried Mixins, and I assume I need to use the renderstate() function and entityData variable, but entityData is protected, which means I can not edit it using Mixins. How would I add these NBT values to the Display class without using the entityData class? (These two data values, if coded correctly, could allow slabs/stairs/walls of any block to be represented using Displays without being limited by the vanilla inventory options)
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.