[1.19.2] Custom shader not rendering on BlockItem

[SnakerBone]

Hi, so I recently made a shader with OpenGL and I'm able to get it to render on the block in the world but I'm having trouble trying to get the actual BlockItem to render. I'm also using GeckoLib & CodeChickenLib, heres what it looks like in game:

Here's my code:

Spoiler

// start Block

package au.com.snaker.snakerbone.block.swirl;

import au.com.snaker.snakerbone.registry.SnakerBoneContentRegistry;
import net.minecraft.core.BlockPos;
import net.minecraft.world.level.block.BaseEntityBlock;
import net.minecraft.world.level.block.RenderShape;
import net.minecraft.world.level.block.entity.BlockEntity;
import net.minecraft.world.level.block.state.BlockState;
import org.jetbrains.annotations.Nullable;

import static net.minecraft.world.level.material.Material.METAL;

public class SwirlBlock extends BaseEntityBlock {
    public SwirlBlock() {

        super(Properties.of(METAL).requiresCorrectToolForDrops().strength(5));

    }

    @Nullable
    @Override
    public BlockEntity newBlockEntity(BlockPos pos, BlockState state) {

        return SnakerBoneContentRegistry.SWIRL_BLOCK_ENTITY.get().create(pos, state);

    }

    @Override
    public RenderShape getRenderShape(BlockState state) {

        return RenderShape.ENTITYBLOCK_ANIMATED;

    }
}

// endregion

// start BlockEntity

package au.com.snaker.snakerbone.block.swirl;

import au.com.snaker.snakerbone.registry.SnakerBoneContentRegistry;
import net.minecraft.core.BlockPos;
import net.minecraft.world.level.block.entity.BlockEntity;
import net.minecraft.world.level.block.state.BlockState;
import software.bernie.geckolib3.core.IAnimatable;
import software.bernie.geckolib3.core.PlayState;
import software.bernie.geckolib3.core.controller.AnimationController;
import software.bernie.geckolib3.core.event.predicate.AnimationEvent;
import software.bernie.geckolib3.core.manager.AnimationData;
import software.bernie.geckolib3.core.manager.AnimationFactory;
import software.bernie.geckolib3.util.GeckoLibUtil;

public class SwirlBlockEntity extends BlockEntity implements IAnimatable {

    private final AnimationFactory FACTORY = GeckoLibUtil.createFactory(this);

    public SwirlBlockEntity(BlockPos pos, BlockState state) {

        super(SnakerBoneContentRegistry.SWIRL_BLOCK_ENTITY.get(), pos, state);

    }

    private <E extends IAnimatable> PlayState predicate(AnimationEvent<E> entity) {

        return PlayState.CONTINUE;

    }

    @Override
    public void registerControllers(AnimationData data) {

        data.addAnimationController(new AnimationController<>(this, "controller", 0, this::predicate));

    }

    @Override
    public AnimationFactory getFactory() {

        return FACTORY;

    }
}

// endregion

// start BlockRenderer

package au.com.snaker.snakerbone.block.swirl.render;

import au.com.snaker.snakerbone.block.swirl.SwirlBlockEntity;
import au.com.snaker.snakerbone.block.swirl.model.SwirlBlockModel;
import com.mojang.blaze3d.vertex.PoseStack;
import com.mojang.blaze3d.vertex.VertexConsumer;
import net.minecraft.client.renderer.MultiBufferSource;
import net.minecraft.client.renderer.RenderType;
import net.minecraft.client.renderer.blockentity.BlockEntityRendererProvider;
import net.minecraft.resources.ResourceLocation;
import org.jetbrains.annotations.Nullable;
import software.bernie.geckolib3.renderers.geo.GeoBlockRenderer;

import static au.com.snaker.snakerbone.client.SnakerBoneShaders.SWIRLY;

public class SwirlBlockRenderer extends GeoBlockRenderer<SwirlBlockEntity> {
    public SwirlBlockRenderer(BlockEntityRendererProvider.Context rendererProvider) {

        super(rendererProvider, new SwirlBlockModel());

    }

    @Override
    public RenderType getRenderType(SwirlBlockEntity animatable, float partialTick, PoseStack poseStack, @Nullable MultiBufferSource bufferSource, @Nullable VertexConsumer buffer, int packedLight, ResourceLocation texture) {

        return SWIRLY;

    }
}

// endregion

// start BlockModel 

package au.com.snaker.snakerbone.block.swirl.model;

import au.com.snaker.snakerbone.block.swirl.SwirlBlockEntity;
import au.com.snaker.snakerbone.util.SnakerBoneResourceLocation;
import net.minecraft.resources.ResourceLocation;
import software.bernie.geckolib3.model.AnimatedGeoModel;

public class SwirlBlockModel extends AnimatedGeoModel<SwirlBlockEntity> {

    public static final ResourceLocation MODEL = new SnakerBoneResourceLocation("geo/block.geo.json");
    private static final ResourceLocation TEXTURE = new SnakerBoneResourceLocation("textures/model/black.png");
    private static final ResourceLocation ANIMATION = new SnakerBoneResourceLocation("animations/dummy.animation.json");

    @Override
    public ResourceLocation getModelResource(SwirlBlockEntity object) {

        return MODEL;

    }

    @Override
    public ResourceLocation getTextureResource(SwirlBlockEntity object) {

        return TEXTURE;

    }

    @Override
    public ResourceLocation getAnimationResource(SwirlBlockEntity animatable) {

        return ANIMATION;

    }
}

// endregion

// start Shaders

package au.com.snaker.snakerbone.client;

import au.com.snaker.snakerbone.entity.mob.SnakerBoneMobVariants;
import au.com.snaker.snakerbone.util.SnakerBoneResourceLocation;
import au.com.snaker.snakerbone.util.SnakerBoneTools;
import codechicken.lib.render.shader.CCShaderInstance;
import codechicken.lib.render.shader.CCUniform;
import com.google.common.collect.Maps;
import com.mojang.blaze3d.vertex.DefaultVertexFormat;
import com.mojang.blaze3d.vertex.VertexFormat;
import net.minecraft.Util;
import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.RenderStateShard;
import net.minecraft.client.renderer.RenderType;
import net.minecraft.resources.ResourceLocation;
import net.minecraftforge.client.event.RegisterShadersEvent;

import java.util.Map;

import static au.com.snaker.snakerbone.SnakerBone.MODID;
import static au.com.snaker.snakerbone.client.SnakerBoneRenderHelper.PublicRenderStateShards.*;

public class SnakerBoneShaders {
    public static CCShaderInstance swirl;
    public static CCUniform swirlTime;

    public static RenderType SWIRLY = RenderType.create("swirly_shader", DefaultVertexFormat.BLOCK, VertexFormat.Mode.QUADS, 256, false, false, RenderType.CompositeState.builder()
            .setShaderState(new RenderStateShard.ShaderStateShard(() -> swirl))
            .setTextureState(new RenderStateShard.TextureStateShard(new ResourceLocation(MODID, "textures/model/black.png"), false, false))
            .setLightmapState(LIGHTMAP)
            .setCullState(NO_CULL)
            .setOverlayState(OVERLAY)
            .createCompositeState(false));
  
      public static void register(RegisterShadersEvent event) {

        event.registerShader(CCShaderInstance.create(event.getResourceManager(), new SnakerBoneResourceLocation("swirl"), DefaultVertexFormat.POSITION_TEX), shaderObj -> {
            swirl = (CCShaderInstance) shaderObj;
            swirlTime = swirl.getUniform("Time");
            swirl.onApply(() -> swirlTime.glUniform1f((SnakerBoneTools.ticksElapsed + Minecraft.getInstance().getFrameTime()) / 20));
        });
     }
}

// endregion

// start ModEventSubscriptions

package au.com.snaker.snakerbone.subscriptions;

import au.com.snaker.snakerbone.SnakerBone;
import au.com.snaker.snakerbone.block.swirl.render.SwirlBlockRenderer;
import au.com.snaker.snakerbone.entity.boss.utterfly.Utterfly;
import au.com.snaker.snakerbone.entity.boss.utterfly.render.UtterflyRenderer;
import au.com.snaker.snakerbone.entity.creature.flutterfly.Flutterfly;
import au.com.snaker.snakerbone.entity.creature.flutterfly.render.FlutterflyRenderer;
import au.com.snaker.snakerbone.entity.creature.glider.Glider;
import au.com.snaker.snakerbone.entity.creature.glider.render.GliderRenderer;
import au.com.snaker.snakerbone.entity.mob.cosmo.Cosmo;
import au.com.snaker.snakerbone.entity.mob.cosmo.render.CosmoRenderer;
import au.com.snaker.snakerbone.entity.mob.flare.Flare;
import au.com.snaker.snakerbone.entity.mob.flare.render.FlareRenderer;
import au.com.snaker.snakerbone.entity.mob.snipe.Snipe;
import au.com.snaker.snakerbone.entity.mob.snipe.render.SnipeRenderer;
import au.com.snaker.snakerbone.entity.projectile.explosive_homming_arrow.render.ExplosiveHommingArrowRenderer;
import au.com.snaker.snakerbone.entity.projectile.homming_arrow.render.HommingArrowRenderer;
import au.com.snaker.snakerbone.entity.projectile.laser.render.LaserRenderer;
import au.com.snaker.snakerbone.registry.SnakerBoneContentRegistry;
import au.com.snaker.snakerbone.registry.SnakerBoneEntityRegistry;
import net.minecraft.client.renderer.entity.EntityRenderers;
import net.minecraft.world.entity.SpawnPlacements;
import net.minecraft.world.level.levelgen.Heightmap;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.client.event.EntityRenderersEvent;
import net.minecraftforge.event.entity.EntityAttributeCreationEvent;
import net.minecraftforge.event.entity.SpawnPlacementRegisterEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent;

public class SnakerBoneSubscriptions {
    @Mod.EventBusSubscriber(modid = SnakerBone.MODID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT)
    public static class SnakerBoneModClientEvents {
        @SubscribeEvent
        public static void registerRenderers(final EntityRenderersEvent.RegisterRenderers event) {
            event.registerBlockEntityRenderer(SnakerBoneContentRegistry.SWIRL_BLOCK_ENTITY.get(), SwirlBlockRenderer::new);
        }
    }
}

// endregion

 

I'm also not missing any block/item JSON's so I'm kind of confused. I have been able to get this working in 1.16 but I cant seem to get it working in 1.19.2

Any help appreciated. Thanks 🙂

[ChampionAsh5357]

You need to add a BEWLR to the item by extending BlockItem, overriding `Item#initializeClient`, have `#getCustomRenderer` return your BEWLR extension, then render the itemstack using your BER there.

[SnakerBone]

9 hours ago, ChampionAsh5357 said:

You need to add a BEWLR to the item by extending BlockItem, overriding `Item#initializeClient`, have `#getCustomRenderer` return your BEWLR extension, then render the itemstack using your BER there.

Hi, thanks for your reply. I have done this however I am still having the same problem. Here's my new code:

Spoiler

// BlockItem

package au.com.snaker.snakerbone.block.swirl;

import au.com.snaker.snakerbone.block.swirl.render.SwirlBlockItemRenderer;
import net.minecraft.client.renderer.BlockEntityWithoutLevelRenderer;
import net.minecraft.world.item.BlockItem;
import net.minecraft.world.level.block.Block;
import net.minecraftforge.client.extensions.common.IClientItemExtensions;
import software.bernie.geckolib3.core.IAnimatable;
import software.bernie.geckolib3.core.PlayState;
import software.bernie.geckolib3.core.controller.AnimationController;
import software.bernie.geckolib3.core.event.predicate.AnimationEvent;
import software.bernie.geckolib3.core.manager.AnimationData;
import software.bernie.geckolib3.core.manager.AnimationFactory;
import software.bernie.geckolib3.util.GeckoLibUtil;

import java.util.function.Consumer;

import static au.com.snaker.snakerbone.util.SnakerBonePolicy.WarningSuppression.CUSTOM_SET;

public class SwirlBlockItem extends BlockItem implements IAnimatable {

    private final AnimationFactory FACTORY = GeckoLibUtil.createFactory(this);

    public SwirlBlockItem(Block block, Properties properties) {

        super(block, properties);

    }

    /**
     * This has no animations to play so we will continue...
     **/
    private <E extends IAnimatable> PlayState predicate(AnimationEvent<E> entity) {

        return PlayState.CONTINUE;

    }

    @Override
    public void initializeClient(Consumer<IClientItemExtensions> consumer) {

        super.initializeClient(consumer);

        consumer.accept(new IClientItemExtensions() {

            private final BlockEntityWithoutLevelRenderer bewlr = new SwirlBlockItemRenderer();

            @Override
            public BlockEntityWithoutLevelRenderer getCustomRenderer() {

                return bewlr;

            }

        });

    };

    @Override
    public void registerControllers(AnimationData data) {

        data.addAnimationController(new AnimationController<>(this, "controller", 0, this::predicate));

    }

    @Override
    public AnimationFactory getFactory() {

        return FACTORY;

    }
}

 

Spoiler

// BlockItem Renderer

package au.com.snaker.snakerbone.block.swirl.render;

import au.com.snaker.snakerbone.block.swirl.SwirlBlockItem;
import au.com.snaker.snakerbone.block.swirl.model.SwirlBlockItemModel;
import com.mojang.blaze3d.vertex.PoseStack;
import com.mojang.blaze3d.vertex.VertexConsumer;
import net.minecraft.client.renderer.MultiBufferSource;
import net.minecraft.client.renderer.RenderType;
import net.minecraft.resources.ResourceLocation;
import org.jetbrains.annotations.Nullable;
import software.bernie.geckolib3.renderers.geo.GeoItemRenderer;

import static au.com.snaker.snakerbone.client.SnakerBoneShaders.SWIRLY;

public class SwirlBlockItemRenderer extends GeoItemRenderer<SwirlBlockItem> {
    public SwirlBlockItemRenderer() {

        super(new SwirlBlockItemModel());

    }

    @Override
    public RenderType getRenderType(SwirlBlockItem animatable, float partialTick, PoseStack poseStack, @Nullable MultiBufferSource bufferSource, @Nullable VertexConsumer buffer, int packedLight, ResourceLocation texture) {

        return SWIRLY;

    }
}

 

Spoiler

// BlockItem Model

package au.com.snaker.snakerbone.block.swirl.model;

import au.com.snaker.snakerbone.block.swirl.SwirlBlockItem;
import au.com.snaker.snakerbone.util.SnakerBoneResourceLocation;
import net.minecraft.resources.ResourceLocation;
import software.bernie.geckolib3.model.AnimatedGeoModel;

public class SwirlBlockItemModel extends AnimatedGeoModel<SwirlBlockItem> {
    private static final ResourceLocation MODEL = new SnakerBoneResourceLocation("geo/block.geo.json");
    private static final ResourceLocation TEXTURE = new SnakerBoneResourceLocation("textures/model/black.png");
    private static final ResourceLocation ANIMATION = new SnakerBoneResourceLocation("animations/dummy.animation.json");

    @Override
    public ResourceLocation getModelResource(SwirlBlockItem object) {

        return MODEL;

    }

    @Override
    public ResourceLocation getTextureResource(SwirlBlockItem object) {

        return TEXTURE;

    }

    @Override
    public ResourceLocation getAnimationResource(SwirlBlockItem animatable) {

        return ANIMATION;

    }
}

 

I'm think I might be missing something. Please let me know if that's the case

Edited March 4, 2023 by SnakerBone
formatting mistake

[SnakerBone]

Figured it out. I had to put "parent": "builtin/entity" in the block models json. My bad XD