Instantaneous Mob Effect does not work.

[DouglasRafael]

Instant Mob Effect does not work. What's my mistake? the Tick effect is always activated, but the instantaneous one is not.

 

Spoiler

public class ModEffects {
    public static final DeferredRegister<MobEffect> MOB_EFFECTS
            = DeferredRegister.create(ForgeRegistries.MOB_EFFECTS, ModCraft.MOD_ID);

    public static final RegistryObject<MobEffect> CUTT_EFFECT = MOB_EFFECTS.register("cutt_effect",
            () -> new CuttEffect(MobEffectCategory.HARMFUL, 3124687));
}

 

 

 

Spoiler

public class CuttEffect extends InstantenousMobEffect {

    public CuttEffect(MobEffectCategory effectCategory, int i) {
        super(effectCategory, i);
    }

    @Override
    public void applyEffectTick(LivingEntity pLivingEntity, int pAmplifier) {
        if (!pLivingEntity.level.isClientSide() && Minecraft.getInstance().level != null) {
            Minecraft.getInstance().player.sendSystemMessage(Component.literal("TICK Activated!")); // works
        }
        super.applyEffectTick(pLivingEntity, pAmplifier);
    }

    @Override
    public void applyInstantenousEffect(@Nullable Entity p_19462_, @Nullable Entity p_19463_, LivingEntity pLivingEntity, int pAmplifier, double p_19466_) {
        if (!pLivingEntity.level.isClientSide() && Minecraft.getInstance().level != null) {
            Minecraft.getInstance().player.sendSystemMessage(Component.literal("INSTANTANEOUS Activated!")); // don t works
        }
        super.applyInstantenousEffect(p_19462_, p_19463_, pLivingEntity, pAmplifier, p_19466_);
    }

    @Override
    public boolean isInstantenous() {
        return true;
    }


}

 

 

 

 

[ChampionAsh5357]

First, #applyInstantenousEffect is only called in certain cases, hence the logic needs to be in both methods. Second, your logic makes absolutely no sense because you're check if the instance is on the server, then immediately checking if the client instance is not null, which is bad sided logic. You check the side and send the information on that side, meaning only the server. Additionally, you don't even need to check the side since the logic will only be called on the server in most cases, besides from maybe the particle.

[DouglasRafael]

I was using particles, but I summarized the code (making the code simple).

I don't understand, use both methods? Would it be this: 

 

Spoiler

@Override
    public void applyEffectTick(LivingEntity pLivingEntity, int pAmplifier) {
        applyInstantenousEffect(null,null,pLivingEntity, pAmplifier, pAmplifier); // don't work.
        super.applyEffectTick(pLivingEntity, pAmplifier);
    }

 

 

[ChampionAsh5357]

No, look at how MobEffect handles instant health and damage. That should give you a good idea on how to structure your code.