Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

Instant Mob Effect does not work. What's my mistake? the Tick effect is always activated, but the instantaneous one is not.

 

Spoiler
public class ModEffects {
    public static final DeferredRegister<MobEffect> MOB_EFFECTS
            = DeferredRegister.create(ForgeRegistries.MOB_EFFECTS, ModCraft.MOD_ID);

    public static final RegistryObject<MobEffect> CUTT_EFFECT = MOB_EFFECTS.register("cutt_effect",
            () -> new CuttEffect(MobEffectCategory.HARMFUL, 3124687));
}

 

 

 

Spoiler
public class CuttEffect extends InstantenousMobEffect {

    public CuttEffect(MobEffectCategory effectCategory, int i) {
        super(effectCategory, i);
    }

    @Override
    public void applyEffectTick(LivingEntity pLivingEntity, int pAmplifier) {
        if (!pLivingEntity.level.isClientSide() && Minecraft.getInstance().level != null) {
            Minecraft.getInstance().player.sendSystemMessage(Component.literal("TICK Activated!")); // works
        }
        super.applyEffectTick(pLivingEntity, pAmplifier);
    }

    @Override
    public void applyInstantenousEffect(@Nullable Entity p_19462_, @Nullable Entity p_19463_, LivingEntity pLivingEntity, int pAmplifier, double p_19466_) {
        if (!pLivingEntity.level.isClientSide() && Minecraft.getInstance().level != null) {
            Minecraft.getInstance().player.sendSystemMessage(Component.literal("INSTANTANEOUS Activated!")); // don t works
        }
        super.applyInstantenousEffect(p_19462_, p_19463_, pLivingEntity, pAmplifier, p_19466_);
    }

    @Override
    public boolean isInstantenous() {
        return true;
    }


}

 

 

 

 

First, #applyInstantenousEffect is only called in certain cases, hence the logic needs to be in both methods. Second, your logic makes absolutely no sense because you're check if the instance is on the server, then immediately checking if the client instance is not null, which is bad sided logic. You check the side and send the information on that side, meaning only the server. Additionally, you don't even need to check the side since the logic will only be called on the server in most cases, besides from maybe the particle.

  • Author

I was using particles, but I summarized the code (making the code simple).

I don't understand, use both methods? Would it be this: 

 

Spoiler
@Override
    public void applyEffectTick(LivingEntity pLivingEntity, int pAmplifier) {
        applyInstantenousEffect(null,null,pLivingEntity, pAmplifier, pAmplifier); // don't work.
        super.applyEffectTick(pLivingEntity, pAmplifier);
    }

 

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.