Flower generation do not work 1.19.2

[Sych]

I added a custom flower and tried to add custom generation, but I cannot find my custom flower in the world so I think something wrong with my code. The custom flower works properly and I can place it manually, so I think everything is good with that part of the code. Here is my code.

ModConfiguredFeatures.java

package com.gosastudio.beering.world.feature;

import com.google.common.base.Suppliers;
import com.gosastudio.beering.Beering;
import com.gosastudio.beering.block.ModBlocks;
import net.minecraft.core.Registry;
import net.minecraft.data.worldgen.features.OreFeatures;
import net.minecraft.data.worldgen.placement.PlacementUtils;
import net.minecraft.tags.BlockTags;
import net.minecraft.util.valueproviders.ConstantInt;
import net.minecraft.util.valueproviders.UniformInt;
import net.minecraft.world.level.block.Blocks;
import net.minecraft.world.level.levelgen.GeodeBlockSettings;
import net.minecraft.world.level.levelgen.GeodeCrackSettings;
import net.minecraft.world.level.levelgen.GeodeLayerSettings;
import net.minecraft.world.level.levelgen.feature.ConfiguredFeature;
import net.minecraft.world.level.levelgen.feature.Feature;
import net.minecraft.world.level.levelgen.feature.WeightedPlacedFeature;
import net.minecraft.world.level.levelgen.feature.configurations.*;
import net.minecraft.world.level.levelgen.feature.featuresize.TwoLayersFeatureSize;
import net.minecraft.world.level.levelgen.feature.foliageplacers.BlobFoliagePlacer;
import net.minecraft.world.level.levelgen.feature.stateproviders.BlockStateProvider;
import net.minecraft.world.level.levelgen.feature.trunkplacers.StraightTrunkPlacer;
import net.minecraft.world.level.levelgen.structure.templatesystem.BlockMatchTest;
import net.minecraftforge.eventbus.api.IEventBus;
import net.minecraftforge.registries.DeferredRegister;
import net.minecraftforge.registries.RegistryObject;

import java.util.List;
import java.util.Random;
import java.util.function.Consumer;
import java.util.function.Supplier;


public class ModConfiguredFeatures{
    public static final DeferredRegister<ConfiguredFeature<?, ?>> CONFIGURED_FEATURES =
            DeferredRegister.create(Registry.CONFIGURED_FEATURE_REGISTRY, Beering.MOD_ID);


    public static final RegistryObject<ConfiguredFeature<?, ?>> HOP_WILD_CROP = CONFIGURED_FEATURES.register("hop_wild_crop",
            () -> new ConfiguredFeature<>(Feature.FLOWER,
                    new RandomPatchConfiguration(64, 6, 2, PlacementUtils.onlyWhenEmpty(Feature.SIMPLE_BLOCK,
                            new SimpleBlockConfiguration(BlockStateProvider.simple(ModBlocks.HOP_WILD_CROP.get()))))));

    public static void register(IEventBus eventBus){
        CONFIGURED_FEATURES.register(eventBus);
    }
}

ModPlacedFeatures.java

package com.gosastudio.beering.world.feature;

import com.gosastudio.beering.Beering;
import com.gosastudio.beering.block.ModBlocks;
import net.minecraft.core.Registry;
import net.minecraft.data.worldgen.placement.PlacementUtils;
import net.minecraft.data.worldgen.placement.VegetationPlacements;
import net.minecraft.world.level.levelgen.VerticalAnchor;
import net.minecraft.world.level.levelgen.placement.*;
import net.minecraftforge.eventbus.api.IEventBus;
import net.minecraftforge.registries.DeferredRegister;
import net.minecraftforge.registries.RegistryObject;

import java.util.List;


public class ModPlacedFeatures {

    public static final DeferredRegister<PlacedFeature> PLACED_FEATURES =
            DeferredRegister.create(Registry.PLACED_FEATURE_REGISTRY, Beering.MOD_ID);


    public static final RegistryObject<PlacedFeature> HOP_WILD_CROP_PLACED = PLACED_FEATURES.register("hop_wild_crop_placed",
            () -> new PlacedFeature(ModConfiguredFeatures.HOP_WILD_CROP.getHolder().get(),
                    List.of(RarityFilter.onAverageOnceEvery(5), InSquarePlacement.spread(), PlacementUtils.HEIGHTMAP, BiomeFilter.biome())));


    public static void register(IEventBus eventBus){
        PLACED_FEATURES.register(eventBus);
    }
}

add_hop_wild_crop.json

{
  "type": "forge:add_features",
  "biomes": "#forge:is_plains",
  "features": "beering:hop_wild_crop_placed",
  "step": "vegetal_decoration"
}

 

[ChampionAsh5357]

First, configured features and placed features should be added in JSON now (biome modifiers support this and 1.19.3 onward does not allow in-code datapack objects).

Second, your crops only has a 20% change of spawning one patch per chunk, so you would have to be somewhat lucky since you may lose out to other vegetation. I would remove the rarity filter so that you can confirm it works first.

[Sych]

Thanks for your answer, but the problem was much easier. I messed up the add_hop_wild_crop.json path, my bad. Next time I will check not only the code but also the path. Thanks again for your help and time.