Jump to content

[1.19] [Solved, looking for better solution] Detect holding RMB for a certain amount of time


Recommended Posts

Posted (edited)

When I hold RMB while holding a Stick (minecraft:stick) and looking at the top side of a #minecraft:planks block, I want minecraft:smoke particles to spawn on top of the block (kinda like a minecraft:fire block was on top); after a certain amount of time, I want it to remove a Stick (minecraft:stick) from my selected slot and add a Stick on Fire (chem:stick_on_fire) to my inventory.

Here's my StickItem.java:

package com.nutronstar45.chem.item.custom;

import com.nutronstar45.chem.item.ModItems;

import net.minecraft.core.BlockPos;
import net.minecraft.core.Direction;
import net.minecraft.network.chat.Component;
import net.minecraft.tags.BlockTags;
import net.minecraft.world.InteractionHand;
import net.minecraft.world.InteractionResult;
import net.minecraft.world.entity.player.Player;
import net.minecraft.world.item.Item;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.item.context.UseOnContext;
import net.minecraft.world.level.Level;
import net.minecraft.world.level.block.state.BlockState;
import net.minecraft.world.phys.HitResult;

public class StickItem extends Item {
	public StickItem(Properties properties) {
		super(properties);
	}
	
	@Override
	public InteractionResult useOn(UseOnContext context) {
		Player player = context.getPlayer();
		Level level = context.getLevel();
		InteractionHand hand = context.getHand();
		HitResult targetedBlock = player.pick(5.0D, 0.0F, false);
		Direction direction = context.getClickedFace();
		BlockPos blockPos = context.getClickedPos();
		BlockState blockState = level.getBlockState(blockPos);

		if (!level.isClientSide()
				&& hand == InteractionHand.MAIN_HAND
				&& targetedBlock.getType() == HitResult.Type.BLOCK
				&& direction.getName() == "up"
				&& blockState.is(BlockTags.PLANKS)) {
			player.getItemInHand(hand).shrink(1);
			player.addItem(new ItemStack(ModItems.STICK_ON_FIRE.get()));
			player.sendSystemMessage(Component.literal("useOn"));
			
			return InteractionResult.SUCCESS;
		}
		
		return InteractionResult.PASS;
	}
}

When I hold RMB while holding a Stick (minecraft:stick) and looking at the top side of a #minecraft:planks block, it instantly removes a Stick (minecraft:stick) from my selected slot and adds a Stick on Fire (chem:stick_on_fire) to my inventory, and there is no particle either.

Edited by NutronStar45
Solved
Link to comment
Share on other sites

I solved the problem, but I think there is a better solution.

StickItem.java:

package com.nutronstar45.chem.item.custom;

import com.nutronstar45.chem.block.ModBlocks;
import com.nutronstar45.chem.item.ModItems;

import net.minecraft.core.BlockPos;
import net.minecraft.core.Direction;
import net.minecraft.tags.BlockTags;
import net.minecraft.world.InteractionHand;
import net.minecraft.world.entity.player.Player;
import net.minecraft.world.item.BlockItem;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.level.block.state.BlockState;
import net.minecraft.world.phys.BlockHitResult;
import net.minecraft.world.phys.HitResult;

public class StickItem extends BlockItem {
    private static final int START_FIRE_TIME = 30;
    private int ticksUntilFire;
    
    public StickItem(Properties properties) {
        super(ModBlocks.STICK.get(), properties);
    }
    
    private boolean targetingPlanks(Player player) {
        BlockHitResult targetedBlock = (BlockHitResult)player.pick(5.0D, 0.0F, false);
        Direction direction = targetedBlock.getDirection();
        BlockPos blockPos = targetedBlock.getBlockPos();
        BlockState blockState = player.getLevel().getBlockState(blockPos);
        return targetedBlock.getType() == HitResult.Type.BLOCK
                && direction.getName() == "up"
                && blockState.is(BlockTags.PLANKS);
    }
    
    // Fires when a player is holding a Stick
    public void tick(Player player, boolean isKeyUseDown) {
        if (!player.getLevel().isClientSide()) {
            if (isKeyUseDown && targetingPlanks(player)) {
                if (ticksUntilFire > 0) {
                    --ticksUntilFire;
                }
                else {
                    startFire(player);
                    ticksUntilFire = START_FIRE_TIME;
                }
            }
            else {
                ticksUntilFire = START_FIRE_TIME;
            }
        }
    }
    
    private void startFire(Player player) {
        player.getItemInHand(InteractionHand.MAIN_HAND).shrink(1);
        player.addItem(new ItemStack(ModItems.STICK_ON_FIRE.get()));
    }
}

ModEvents.java:

package com.nutronstar45.chem.event;

import com.nutronstar45.chem.Chem;
import com.nutronstar45.chem.item.custom.StickItem;

import net.minecraft.client.KeyMapping;
import net.minecraft.client.Minecraft;
import net.minecraftforge.event.TickEvent.Phase;
import net.minecraftforge.event.TickEvent.PlayerTickEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;

@Mod.EventBusSubscriber(modid = Chem.MODID)
public class ModEvents {
    @SubscribeEvent
    public static void onPlayerTick(PlayerTickEvent event) {
        Minecraft instance = Minecraft.getInstance();
        KeyMapping keyUse = instance.options.keyUse;
        if (event.player.getMainHandItem().getItem() instanceof StickItem) {
            StickItem stickItem = (StickItem)event.player.getMainHandItem().getItem();
            if (event.phase == Phase.START) {
                stickItem.tick(event.player, keyUse.isDown());
            }
        }
    }
}

 

Link to comment
Share on other sites

  • NutronStar45 changed the title to [1.19] [Solved, looking for better solution] Detect holding RMB for a certain amount of time

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I have a structure, and sometimes several mobs spawn there. This is a boss and must spawn alone. Here is the code for spawning entities in the structure { "type": "minecraft:jigsaw", "start_pool": "egyptcraft:boss_pyramid/start_pool", "size": 5, "max_distance_from_center": 80, "biomes": "#egyptcraft:has_structure/boss_pyramid", "step": "surface_structures", "start_height": { "absolute": 0 }, "project_start_to_heightmap": "WORLD_SURFACE_WG", "use_expansion_hack": false, "spawn_overrides": { "monster": { "bounding_box": "full", "spawns": [ { "type": "egyptcraft:anubis", "maxCount": 1, "minCount": 1, "weight": 100 } ] } } } Maybe it's something else?
    • I have OreGenEvent.GenerateMinable event, I need to get a chance to spawn (generate) every ore that is processed in this event. Also e.getType().name().toString() is name this is the same block name by which it can be entered in the Block.getByID?  forge 1.12.2 59(recommended)
    • Hello everybody! Out of nowhere my minecraft doesn't allow me to play on forge 1.19.2 I tried to reinstall minecraft, doesn't have any mod right now on the forge version. Tried the newest version of forge, tried recommended version as well. I have the newest version of Java as well...   I dont know why it stopped working but it just stopped completly out of nowhere...   Thank you so much for your help guys ❤️
    • Hello, my world is crashing at 0% loaded and I don't know why. (Forge 43.2.14, 1.19.2) I have two worlds that I play on, and one works and the other doesn't, even with the same mod list. Here's the crash report: https://pastebin.com/AUbRwkGj
    • Minecraft 1.12.2 Very frustrating error. only ever occurs on one device. Started yesterday without prompting (maybe java updated or something?) Says things that have been imported actually arent when running client Reinstalled Intellij, cleared cache, cleaned and rebuilt gradle, redownloaded the entire file from git. Nothing works. (I believe I have the right plugins installed, dependencies OK, and am using corretto 1.8).   One thing I did for more of the below errors was just to explicitly import them, which was working up until this little guy who literally does not exist in forge to import. the class inhereting something inhereting it refers to import net.minecraftforge.registries.IForgeRegistryEntry.Impl, not net.minecraftforge.registries.IForgeRegistryEntry$Impl as the output implies. also I didn't even have to manually import these things for it to work on my other device. (which is just importing the minecraft package that contains them), but here I did have to just to get rid of a few errors--not even make anything work?? I dont know. (edited) here's the aforementioned "below error" (one of many like it): error: cannot access net.minecraftforge.registries.IForgeRegistryEntry.Impl public class BlockBase extends Block {        ^   class file for net.minecraftforge.registries.IForgeRegistryEntry$Impl not found Here's the class BlockBase:   package com.quantum.exodus.common.blocks; import com.quantum.exodus.ExodusMod; import net.minecraft.block.Block; import net.minecraft.block.material.Material; import net.minecraft.creativetab.CreativeTabs; import net.minecraft.item.Item; import net.minecraft.item.ItemBlock; import net.minecraftforge.registries.IForgeRegistryEntry.Impl; public class BlockBase extends Block { protected String name; public BlockBase(Material material, String name) { super(material); this.name = name; setTranslationKey(name); setRegistryName(name); } public void registerItemModel(Item itemBlock) { ExodusMod.proxy.registerItemRenderer(itemBlock, 0, name); } public Item createItemBlock() { return new ItemBlock(this).setRegistryName(getRegistryName()); } @Override public BlockBase setCreativeTab(CreativeTabs tab) { super.setCreativeTab(tab); return this; } }
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.