Jump to content

Recommended Posts

Posted

Well I have custom Ores that generate, and custom trees, but not sure how to set up the generator for flowers instead of ores or trees? I guess the answer to your question is no, I don't know how to use setBlock to make blocks randomly generate.

Posted

GoToLink, if you want to give a quick rundown of how to generate blocks on the surface, I think many people would appreciate it. I don't think there are any good tutorials out there on the subject.

Posted

What I've done for my plants to generate is firstly a thought process: I want them to spawn in groups, and scattered around the surface. More translated to code I think of every chunk having a 1 in so many chance to spawn a group. When it has to spawn a group, it'll generate a number between 7 - 14 which is the number of plants that (most of the times) will be generated. When you have that number, you can illiterate that many times in a for loop and generate a random x and z every time you do so. The y is the height of the topmost block +1, or World#getHeightValue(x, z). This comes down to this code:

if(rand.nextInt(40) == 0) {
                    int plantsInGroup = 7 + rand.nextInt(; //beteen 7 and 14 plants per group.
                    for(int i = 0; i < plantsInGroup; i++) {
                        int x = chunkX * 16 + rand.nextInt(20);//in an area of 20x20
                        int z = chunkZ * 16 + rand.nextInt(20);
                        int y = world.getHeightValue(x, z);
                        if(y > 0 && (BlockYourFlower)Block.blocksList[idOfYourFlower].canPlantGrowOnThisBlockID(world.getBlockId(x, y - 1, z))) {
                            world.setBlock(x, y, z, idOfYourFlower, 0, 2);
                        }
                    }
                }

 

I gave the explanation at the beginning to show you that with a good rundown of the problem you don't always need a tutorial for it.

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Posted

Thanks MineMaarten :) I actually found an example online that uses a different method, although I'm not sure if it is better, here it is:

 

WorldGenClass

@Override
public void generate(Random random, int chunkX, int chunkZ, World world,
	IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {
	switch(world.provider.dimensionId){
	//case -1: generateNether(world, random,chunkX*16,chunkZ16);
	case 0 : generateSurface(world, random, chunkX*16, chunkZ*16);
	}
}

private void generateSurface(World world, Random random, int BlockX, int BlockZ){


     for(int i = 0; i < 2; i++){
int posX = BlockX + random.nextInt(16);
int posZ = BlockZ + random.nextInt(16);
int posY = 50 + random.nextInt(25);

(new WorldGenCustomFlower(TutorialMod.GlowFlower.blockID)).generate(world, random, posX, posY, posZ);

 

WorldFlowerGenClass

public class WorldGenCustomFlower extends WorldGenerator {
/** The ID of the plant block used in this plant generator. */
    private int GlowFlowerBlockId;

    public WorldGenCustomFlower(int par1)
    {
        this.GlowFlowerBlockId = par1;
    }

    public boolean generate(World par1World, Random par2Random, int par3, int par4, int par5)
    {
    	BiomeGenBase b = par1World.getBiomeGenForCoords(par3, par5);
        if(b.biomeName.equals("Plains") || b.biomeName.equals("Extreme Hills") || b.biomeName.equals("Forest")) {
    	for (int l = 0; l < 2; ++l)
        {
            int i1 = par3 + par2Random.nextInt(1) - par2Random.nextInt(1);
            int j1 = par4 + par2Random.nextInt(1) - par2Random.nextInt(1);
            int k1 = par5 + par2Random.nextInt(1) - par2Random.nextInt(1);

            if (par1World.isAirBlock(i1, j1, k1) && TutorialMod.GlowFlower.canPlaceBlockAt(par1World, i1, j1, k1))
            {
                int l1 = 1 + par2Random.nextInt(par2Random.nextInt(3) + 1);

                for (int i2 = 0; i2 < l1; ++i2)
                {
                    if (TutorialMod.GlowFlower.canBlockStay(par1World, i1, j1 + i2, k1))
                    {
                        par1World.setBlock(i1, j1 + i2, k1, TutorialMod.GlowFlower.blockID, 0, 1);
                    }
                }
            }
        }
        }

        return true;
    }
}

Posted

As I read it I'm doubting if it would work, but if it does, it looks fine. This code also takes spawnable Biomes in account. There are some dirtynesses going on though:

int i1 = par3 + par2Random.nextInt(1) - par2Random.nextInt(1);

Random#nextInt(1) will always return 0, not very random. Maybe it's meant as an extra option, that you can change this 1.

 

public WorldGenCustomFlower(int par1)
{
     this.GlowFlowerBlockId = par1;
}

(...)

if (TutorialMod.GlowFlower.canBlockStay(par1World, i1, j1 + i2, k1))
{
par1World.setBlock(i1, j1 + i2, k1, TutorialMod.GlowFlower.blockID, 0, 1);
}

What's the point in giving a blockID in the constructor if you're not going to use it...

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • i managed to fix it by reinstalling the modpack and re-add all the extra mods I've had previously.
    • Ah, it appears I spoke too soon, I still need a little help here. I now have the forceloading working reliably.  However, I've realized it's not always the first tick that loads the entity.  I've seen it take anywhere from 2-20ish to actually go through, in which time my debugging has revealed that the chunk is loaded, but during which time calling  serverLevelIn.getEntity(uuidIn) returns a null result.  I suspect this has to do with queuing and how entities are loaded into the game.  While not optimal, it's acceptable, and I don't think there's a whole ton I can do to avoid it. However, my concern is that occasionally teleporting an entity in this manner causes a lag spike.  It's not every time and gives the appearance of being correlated with when other chunks are loading in.  It's also not typically a long spike, but can last a second or two, which is less than ideal.  The gist of how I'm summoning is here (although I've omitted some parts that weren't relevant.  The lag occurs before the actual summon so I'm pretty confident it's the loading, and not the actual summon call). ChunkPos chunkPos = new ChunkPos(entityPosIn); if (serverLevelIn.areEntitiesLoaded(chunkPos.toLong())) { boolean isSummoned = // The method I'm using for actual summoning is called here. Apart from a few checks, the bulk of it is shown later on. if (isSummoned) { // Code that runs here just notifies the player of the summon, clears it from the queue, and removes the forceload } } else { // I continue forcing the chunk until the summon succeeds, to make sure it isn't inadvertently cleared ForgeChunkManager.forceChunk(serverLevelIn, MODID, summonPosIn, chunkPos.x, chunkPos.z, true, true); } The summon code itself uses serverLevelIn.getEntity(uuidIn) to retrieve the entity, and moves it as such.  It is then moved thusly: if (entity.isAlive()) { entity.moveTo(posIn.getX(), posIn.getY(), posIn.getZ()); serverLevelIn.playSound(null, entity, SoundEvents.ENDERMAN_TELEPORT, SoundSource.NEUTRAL, 1.0F, 1.0F); return true; } I originally was calling .getEntity() more frequently and didn't have the check for whether or not entities were loaded in place to prevent unnecessary code calls, but even with those safety measures in place, the lag still persists.  Could this just be an issue with 1.18's lack of optimization in certain areas?  Is there anything I can do to mitigate it?  Is there a performance boosting mod I could recommend alongside my own to reduce the chunk loading lag? At the end of the day, it does work, and I'm putting measures in place to prevent players from abusing the system to cause lag (i.e. each player can only have one queued summon at a time-- trying to summon another replaces the first call).  It's also not an unacceptable level of lag, IMO, given the infrequency of such calls, and the fact that I'm providing the option to toggle off the feature if server admins don't want it used.  However, no amount of lag is ideal, so if possible I'd love to find a more elegant solution-- or at least a mod recommendation to help improve it. Thanks!
    • When i start my forge server its on but when i try to join its come a error Internal Exception: java.lang.OutOfMemoryError: Requested array size exceeds VM limit Server infos: Linux Minecraft version 1.20.1 -Xmx11G -Xms8G
    • Also add the latest.log from your logs-folder
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.