Jump to content
Currently supported: All versions

Combine FML's IPlayerTracker and IConnectionHandler into forge events

HoBoS_TaCo

By HoBoS_TaCo
in Suggestions

 Share

Recommended Posts

HoBoS_TaCo Creeper Killer

HoBoS_TaCo

Posted
Posted

As 1.7 is nearly upon us it also gives us the opportunity to refactor some packages. I propose to combine FML's network handlers into forge events along with the addition of a ServerListPingEvent. Below I have outlined what I hope to put in my pull request, depending on how much 1.7 changes things. If you think these handlers should remain in FML, I could just convert IPlayerTracker to events and add the extra data shown below along with the ServerListPingEvent.

 

 

(Client) net.minecraftforge.client.event.network.ClientConnectionOpenedRemoteEvent

- Was IConnectionHandler.connectionOpened(NetHandler netClientHandler, String server, int port, INetworkManager manager)

- Event would have access to:

  - NetClientHandler, was NetHandler. No longer need to cast to NetClientHandler.

  - Server IP address as string

  - Server Port as integer

  - INetworkManager

 

(Client) net.minecraftforge.client.event.network.ClientConnectionOpenedIntegratedEvent

- Was IConnectionHandler.connectionOpened(NetHandler netClientHandler, MinecraftServer server, INetworkManager manager)

- Event would have access to:

  - NetClientHandler, was NetHandler. No longer need to cast to NetClientHandler.

  - Server as IntegratedServer, was MinecraftServer. No longer need to cast to IntegratedServer.

  - INetworkManager

 

(Server) net.minecraftforge.common.event.network.ServerReceiveConnectionEvent

- Was IConnectionHandler.connectionReceived(NetLoginHandler netHandler, INetworkManager manager)

- Cancellable event, a custom kick message could be assigned

- Event would have access to:

  - NetLoginHandler

  - TcpConnection (INetworkManager is an interface of TcpConnection, any reason to not use TcpConnection?)

 

 

(Server) net.minecraftforge.common.event.network.PlayerLoginEvent

- Was IConnectionHandler.playerLoggedIn(Player player, NetHandler netHandler, INetworkManager manager)

- Can be combined with IPlayerTracker.onPlayerLogin(EntityPlayer player)

- Event would have access to:

  - EntityPlayerMP

  - NetServerHandler, was NetHandler. No longer need to cast to NetServerHandler.

  - INetworkManager

  - MinecraftServer

 

(Client) net.minecraftforge.client.event.network.ClientLoginEvent

- Was IConnectionHandler.clientLoggedIn(NetHandler clientHandler, INetworkManager manager, Packet1Login login)

- Event would have access to:

  - NetClientHandler, was NetHandler. No longer need to cast to NetClientHandler.

  - INetworkManager

  - Packet1Login

 

(Server) net.minecraftforge.common.event.network.PlayerLogoutEvent

- Was IPlayerTracker.onPlayerLogout(EntityPlayer player)

- Event would have access to:

  - NetClientHandler, was NetHandler. No longer need to cast to NetClientHandler.

  - INetworkManager

  - MinecraftServer

 

(Both) net.minecraftforge.common.event.network.ConnectionClosedEvent

- Was IConnectionHandler.connectionClosed(INetworkManager manager)

- Event would have access to:

  - INetworkManager

 

(Server) net.minecraftforge.common.event.network.PlayerChangedDimensionEvent

- Was IPlayerTracker.onPlayerChangedDimension(EntityPlayer player)

- Event would have access to:

  - EntityPlayerMP

  - MinecraftServer

  - Teleporter

  - Old dimension id

  - New dimension id

 

(Server) net.minecraftforge.common.event.network.PlayerRespawnEvent

- Was IPlayerTracker.onPlayerRespawn(EntityPlayer player)

- Event would have access to:

  - EntityPlayerMP

  - MinecraftServer

  - world the player is being respawned into.

  - boolean for if the player beat the game.

 

 

(Server) net.minecraftforge.common.event.network.ServerChatRecievedEvent

- Was ServerChatEvent,changed the name to match the client event and move to network package

 

 

(Client) net.minecraftforge.client.event.network.ClientChatRecievedEvent

- Move to network package

 

 

(Server) net.minecraftforge.common.event.network.ServerListPingEvent

- Event would have access to:

  - Pinger's address

  - Able to send back a custom MOTD

  - Able to send back a custom number of current players

  - Able to send back a custom number of maximum players

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • Paint_Ninja
      How do I change the look of the FML Early Loading Screen?

      By Paint_Ninja · Posted

      1) Update to the latest build of Forge for your MC version. The recommended build actually means minimum recommended. I can’t remember if it was backported to 1.20.1 or not, but we did clean up the early loading screen a bit in newer builds to look less cluttered. 2) Change the accessibility setting in game to black background. The early loading screen will then be black instead of red.
    • Suamere
      Mixins won't work (Like at all)

      By Suamere · Posted

      I'm sure this entire community knows exactly who you are, what mixin you're talking about, and how deer function in minecraft.  But being new here, and I am ignorant about all of those things. That said, I'd love to review your mixin.  I'm also having mixin issues, and I feel that if I can help you, perhaps both of our problems might get solved. Can you provide some links and context for people who aren't aware of your renown?  I'm asking humbly because I know you probably have better things to do, and you just want somebody to fix things for you.
    • Suamere
      Mixin only works in dev 1.21.4-54.1.0

      By Suamere · Posted

      I am working in the latest MDK.  Minecraft 1.21.4, Forge 54.1.0. I am trying to create a mixin.  The implementation doesn't matter.  Assume it is doing nothing more than logging to the console: @Mixin(LevelRenderer.class) public abstract class LevelRendererMixin { private static final Logger LOGGER = LogManager.getLogger("LevelRendererMixin"); @Inject(method = "renderLevel", at = @At("TAIL")) private void onRenderLevel( com.mojang.blaze3d.resource.GraphicsResourceAllocator allocator, net.minecraft.client.DeltaTracker deltaTracker, boolean someFlag, Camera camera, GameRenderer gameRenderer, Matrix4f matrix1, Matrix4f matrix2, CallbackInfo ci ) { Assuming my whole implementation is just to write something to console, it works perfectly fine in when I debug (runClient) in IntelliJ.  Whenever the Minecraft `renderLevel` runs every frame, my logging is overlaid at "TAIL". Yes, this spams the sht out of the console. But when I `build` and use the jar as a mod, it does not.  The mixin annotation processor shows to be loading, and my other parts of my mod work, but the nothing gets logged by my mixin. I am apparently generating a proper `refmap` and it's in the jar root.  Other files are also in the jar appropriately, including mods.toml.  And all the naming and reference paths are correct. I had to add this to my build.gradle to get my refmap into the jar ([name] obviously replaced): tasks.register("copyRefmap", Copy) { dependsOn tasks.named("compileJava") from("${project.buildDir}/tmp/compileJava") { include "mixins.[name].refmap.json" } into("${project.buildDir}/resources/main") } tasks.named("processResources", ProcessResources).configure { dependsOn(tasks.named("copyRefmap")) } tasks.named("jar", Jar).configure { // Include the generated refmap from build/resources/main into the jar. from("${project.buildDir}/resources/main") { include "mixins.[name].refmap.json" } }   Just for fun, here is my refmap in case something looks wrong to anybody:   { "mappings": { "com/[name]/mixin/LevelRendererMixin": { "renderLevel": "Lnet/minecraft/client/renderer/LevelRenderer;m_109599_(Lcom/mojang/blaze3d/resource/GraphicsResourceAllocator;Lnet/minecraft/client/DeltaTracker;ZLnet/minecraft/client/Camera;Lnet/minecraft/client/renderer/GameRenderer;Lorg/joml/Matrix4f;Lorg/joml/Matrix4f;)V" } }, "data": { "searge": { "com/[name]/mixin/LevelRendererMixin": { "renderLevel": "Lnet/minecraft/client/renderer/LevelRenderer;m_109599_(Lcom/mojang/blaze3d/resource/GraphicsResourceAllocator;Lnet/minecraft/client/DeltaTracker;ZLnet/minecraft/client/Camera;Lnet/minecraft/client/renderer/GameRenderer;Lorg/joml/Matrix4f;Lorg/joml/Matrix4f;)V" } } } } TLDR; My mixin works in dev, but not when built and run in an official Forge/Minecraft environment.  Like it's not overlaying/replacing the minecraft function. What are some typical other things to check when a mixin works in dev, but not after build?
    • Suamere
      Cannot resolve symbol RenderLevelStageEvent

      By Suamere · Posted

      Thank you, Ugdhar.  But that only confirms the problem.  Both in the github and in my IDE, if I search for objects extended from net.minecraftforge.client.event, it isn't there.  Though the javadocs (at least at nekoyue) say it should be. Maybe since it definitely isn't there, is there some other way anybody knows to highlight some blocks (without mixins and drawing artificial faces on the camera).
    • Juaum124
      Minecraft disconnecting me in a singleplayer world

      By Juaum124 · Posted

      But I don't have Create installed.  

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept