Arrow Projectile Entity fades back

FloxRoxX · November 29, 2013

Hi all,

iam working on a custom bow with an custom arrow with rendering and so on.

So as far as iam i have everything working but as i shoot my arrow and it hits a block it will move about 2 blocks back from its destination.

So for better explanation i have a screenshot for this:

As you can see the arrows are floating in the air after they have hit the grey block at the wall...

For making the Bow and arrow i copied the classes from:

net.minecraft.entity.projectile.EntityArrow.java

net.minecraft.item.ItemBow.java

net.minecraft.client.renderer.entity.RenderArrow.java

and made my own classes out of it. So now iam a little bit confused about that because that are all original classes...

Anyone knows this behaviour or knows a fix for this ?

EDIT: The problem must have something to do with the arrow speed. If i charge the bow with full thrust the arrow will flip back more as if i charge it only a little....

firstdwarf · December 1, 2013

Without posting your code, it's difficult to figure out exactly what is causing your problem.

If I understand correctly, you're saying that whenever the EntityArrow hits a target, the arrow instantly floats in midair several blocks before the target? If so, it's possible that the error is caused by an incorrect variable.

From my limited understanding of the EntityArrow class, the motion of the entity should be tracked in the setThrowableHeading method. In the onUpdate method, it checks if the position vector has collided with a solid block's vector, in which case it sets the boolean inGround to true. From there, the client renders an arrow in whichever block the vector collided with. If it's teleporting, you may have the location where the arrow sticks somehow translated before the arrow is rendered in the block.

If your error is that the arrow visibly bounces off the target, it may be because inGround is never set to true. If this is the case, most likely you misplaced a variable in the if statements prior to it.

My best advice would be to go over your variables with a fine-toothed comb and make sure that they are the same as EntityArrow's. Unless you are trying to change what the arrow does, every method should be identical to the original class. Furthermore, you can test other sections of your code in-game. Does the arrow still damage entities? Does it stick properly in them? Can you shoot yourself by shooting up? Does it stick properly in you?

After double-checking your classes and doing more testing to try to figure out exactly what's wrong, I suggest you start up your mod in debug mode and change the appropriate method in real time.

Good luck! You can figure this out; if you'd like more help from me and others, post your code to make our lives easier.

GotoLink · December 1, 2013

Use the classes or extend them if you need to change things.

FloxRoxX · December 1, 2013

Allright, i have tested some stuff and think the best is to put the code up here because i dont know where the problem is.

What i also noticed is, that if the arrows float in the air its only graphically. I can grab them up at the wall if i go there and also if i wait some time they will be moved back in the wall where i have shoot them but this needs about 20 seconds.

Here is the code:

Main class:

package floxroxx.itemmod;

import java.util.Random;

import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.EnumToolMaterial;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.network.packet.Packet23VehicleSpawn;
import net.minecraft.world.World;
import net.minecraftforge.common.MinecraftForge;
import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.Mod.EventHandler;
import cpw.mods.fml.common.Mod.Instance;
import cpw.mods.fml.common.SidedProxy;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.event.FMLPostInitializationEvent;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;
import cpw.mods.fml.common.network.NetworkMod;
import cpw.mods.fml.common.registry.EntityRegistry;
import cpw.mods.fml.common.registry.GameRegistry;
import cpw.mods.fml.common.registry.LanguageRegistry;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

@Mod(modid= "ItemMod", name="ItemMod", version="0.0.0.1")
@NetworkMod(clientSideRequired=true)
public class itemmod {

//Item Register Bows
public static Item WoodenBow = new WoodenBow(3070);

//Item Register arrows
public static Item Woodenarrow = new woodarrow(3090);


  // The instance of your mod that Forge uses.
    @Instance(value = "ItemModID")
    public static itemmod instance;
   
    // Says where the client and server 'proxy' code is loaded.
    @SidedProxy(clientSide="floxroxx.client.ClientItemProxy", serverSide="floxroxx.itemmod.CommonProxy")
    public static CommonProxy proxy;
   
    @EventHandler // used in 1.6.2
    //@PreInit    // used in 1.5.2
    public void preInit(FMLPreInitializationEvent event) {
    	

    	//Items Registrieren Bow
    	LanguageRegistry.addName(WoodenBow, "Wooden Bow");

    	
    	//Items Registrieren Arrow
    	LanguageRegistry.addName(Woodenarrow, "Wooden Arrow");
    	
    	EntityRegistry.registerGlobalEntityID(EntityWoodArrow.class, "WoodArrow", EntityRegistry.findGlobalUniqueEntityId());
    	EntityRegistry.registerModEntity(EntityWoodArrow.class, "EntityWoodArrow", 5001, this, 128, 1, true);
    	LanguageRegistry.instance().addStringLocalization("entity.itemmod.woodarrow.name","Wooden Arrow");  	
    } 
    
    @EventHandler // used in 1.6.2
    //@Init       // used in 1.5.2
    public void load(FMLInitializationEvent event) {
            proxy.registerRenderers();
            
    }
   
    @EventHandler // used in 1.6.2
    //@PostInit   // used in 1.5.2
    public void postInit(FMLPostInitializationEvent event) {
            // Stub Method
    }
}

ClientProxy:

package floxroxx.client;

import net.minecraftforge.client.MinecraftForgeClient;
import cpw.mods.fml.client.registry.RenderingRegistry;
import floxroxx.itemmod.CommonProxy;
import floxroxx.itemmod.itemmod;

public class ClientItemProxy extends CommonProxy{


@Override
public void registerRenderers() {
	// Hier werden spaeter renderer fuer entities gebaut
	RenderingRegistry.registerEntityRenderingHandler(floxroxx.itemmod.EntityWoodArrow.class, new RenderWoodArrow());

}

}

RenderWoodArrow Class:

package floxroxx.client;


import net.minecraft.client.renderer.Tessellator;
import net.minecraft.client.renderer.entity.Render;
import net.minecraft.entity.Entity;
import net.minecraft.util.MathHelper;
import net.minecraft.util.ResourceLocation;

import org.lwjgl.opengl.GL11;
import org.lwjgl.opengl.GL12;

import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import floxroxx.itemmod.EntityWoodArrow;

@SideOnly(Side.CLIENT)
public class RenderWoodArrow extends Render
{
    private static final ResourceLocation arrowTextures = new ResourceLocation("textures/entity/woodarrow.png");

    public void renderArrow(EntityWoodArrow par1EntityArrow, double par2, double par4, double par6, float par8, float par9)
    {
        this.bindEntityTexture(par1EntityArrow);
        GL11.glPushMatrix();
        GL11.glTranslatef((float)par2, (float)par4, (float)par6);
        GL11.glRotatef(par1EntityArrow.prevRotationYaw + (par1EntityArrow.rotationYaw - par1EntityArrow.prevRotationYaw) * par9 - 90.0F, 0.0F, 1.0F, 0.0F);
        GL11.glRotatef(par1EntityArrow.prevRotationPitch + (par1EntityArrow.rotationPitch - par1EntityArrow.prevRotationPitch) * par9, 0.0F, 0.0F, 1.0F);
        Tessellator tessellator = Tessellator.instance;
        byte b0 = 0;
        float f2 = 0.0F;
        float f3 = 0.5F;
        float f4 = (float)(0 + b0 * 10) / 32.0F;
        float f5 = (float)(5 + b0 * 10) / 32.0F;
        float f6 = 0.0F;
        float f7 = 0.15625F;
        float f8 = (float)(5 + b0 * 10) / 32.0F;
        float f9 = (float)(10 + b0 * 10) / 32.0F;
        float f10 = 0.05625F;
        GL11.glEnable(GL12.GL_RESCALE_NORMAL);
        float f11 = (float)par1EntityArrow.arrowShake - par9;

        if (f11 > 0.0F)
        {
            float f12 = -MathHelper.sin(f11 * 3.0F) * f11;
            GL11.glRotatef(f12, 0.0F, 0.0F, 1.0F);
        }

        GL11.glRotatef(45.0F, 1.0F, 0.0F, 0.0F);
        GL11.glScalef(f10, f10, f10);
        GL11.glTranslatef(-4.0F, 0.0F, 0.0F);
        GL11.glNormal3f(f10, 0.0F, 0.0F);
        tessellator.startDrawingQuads();
        tessellator.addVertexWithUV(-7.0D, -2.0D, -2.0D, (double)f6, (double)f8);
        tessellator.addVertexWithUV(-7.0D, -2.0D, 2.0D, (double)f7, (double)f8);
        tessellator.addVertexWithUV(-7.0D, 2.0D, 2.0D, (double)f7, (double)f9);
        tessellator.addVertexWithUV(-7.0D, 2.0D, -2.0D, (double)f6, (double)f9);
        tessellator.draw();
        GL11.glNormal3f(-f10, 0.0F, 0.0F);
        tessellator.startDrawingQuads();
        tessellator.addVertexWithUV(-7.0D, 2.0D, -2.0D, (double)f6, (double)f8);
        tessellator.addVertexWithUV(-7.0D, 2.0D, 2.0D, (double)f7, (double)f8);
        tessellator.addVertexWithUV(-7.0D, -2.0D, 2.0D, (double)f7, (double)f9);
        tessellator.addVertexWithUV(-7.0D, -2.0D, -2.0D, (double)f6, (double)f9);
        tessellator.draw();

        for (int i = 0; i < 4; ++i)
        {
            GL11.glRotatef(90.0F, 1.0F, 0.0F, 0.0F);
            GL11.glNormal3f(0.0F, 0.0F, f10);
            tessellator.startDrawingQuads();
            tessellator.addVertexWithUV(-8.0D, -2.0D, 0.0D, (double)f2, (double)f4);
            tessellator.addVertexWithUV(8.0D, -2.0D, 0.0D, (double)f3, (double)f4);
            tessellator.addVertexWithUV(8.0D, 2.0D, 0.0D, (double)f3, (double)f5);
            tessellator.addVertexWithUV(-8.0D, 2.0D, 0.0D, (double)f2, (double)f5);
            tessellator.draw();
        }

        GL11.glDisable(GL12.GL_RESCALE_NORMAL);
        GL11.glPopMatrix();
    }

    protected ResourceLocation getArrowTextures(EntityWoodArrow par1EntityArrow)
    {
        return arrowTextures;
    }

    /**
     * Returns the location of an entity's texture. Doesn't seem to be called unless you call Render.bindEntityTexture.
     */
    protected ResourceLocation getEntityTexture(Entity par1Entity)
    {
        return this.getArrowTextures((EntityWoodArrow)par1Entity);
    }

    /**
     * Actually renders the given argument. This is a synthetic bridge method, always casting down its argument and then
     * handing it off to a worker function which does the actual work. In all probabilty, the class Render is generic
     * (Render<T extends Entity) and this method has signature public void doRender(T entity, double d, double d1,
     * double d2, float f, float f1). But JAD is pre 1.5 so doesn't do that.
     */
    public void doRender(Entity par1Entity, double par2, double par4, double par6, float par8, float par9)
    {
        this.renderArrow((EntityWoodArrow)par1Entity, par2, par4, par6, par8, par9);
    }
}

EntityWoodArrow Class:

package floxroxx.itemmod;




import java.util.List;

import net.minecraft.block.Block;
import net.minecraft.enchantment.EnchantmentThorns;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.IProjectile;
import net.minecraft.entity.monster.EntityEnderman;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.network.packet.Packet70GameEvent;
import net.minecraft.util.AxisAlignedBB;
import net.minecraft.util.DamageSource;
import net.minecraft.util.MathHelper;
import net.minecraft.util.MovingObjectPosition;
import net.minecraft.util.Vec3;
import net.minecraft.world.World;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;




public class EntityWoodArrow extends Entity implements IProjectile
{
    private int xTile = -1;
    private int yTile = -1;
    private int zTile = -1;
    private int inTile;
    private int inData;
    private boolean inGround;

    /** 1 if the player can pick up the arrow */
    public int canBePickedUp;

    /** Seems to be some sort of timer for animating an arrow. */
    public int arrowShake;

    /** The owner of this arrow. */
    public Entity shootingEntity;
    private int ticksInGround;
    private int ticksInAir;
    private double damage = 2.0D;

    /** The amount of knockback an arrow applies when it hits a mob. */
    private int knockbackStrength;

    public EntityWoodArrow(World par1World)
    {
        super(par1World);
        this.renderDistanceWeight = 10.0D;
        this.setSize(0.5F, 0.5F);
    }

    public EntityWoodArrow(World par1World, double par2, double par4, double par6)
    {
        super(par1World);
        this.renderDistanceWeight = 10.0D;
        this.setSize(0.5F, 0.5F);
        this.setPosition(par2, par4, par6);
        this.yOffset = 0.0F;
    }

    public EntityWoodArrow(World par1World, EntityLivingBase par2EntityLivingBase, EntityLivingBase par3EntityLivingBase, float par4, float par5)
    {
        super(par1World);
        this.renderDistanceWeight = 10.0D;
        this.shootingEntity = par2EntityLivingBase;

        if (par2EntityLivingBase instanceof EntityPlayer)
        {
            this.canBePickedUp = 1;
        }

        this.posY = par2EntityLivingBase.posY + (double)par2EntityLivingBase.getEyeHeight() - 0.10000000149011612D;
        double d0 = par3EntityLivingBase.posX - par2EntityLivingBase.posX;
        double d1 = par3EntityLivingBase.boundingBox.minY + (double)(par3EntityLivingBase.height / 3.0F) - this.posY;
        double d2 = par3EntityLivingBase.posZ - par2EntityLivingBase.posZ;
        double d3 = (double)MathHelper.sqrt_double(d0 * d0 + d2 * d2);

        if (d3 >= 1.0E-7D)
        {
            float f2 = (float)(Math.atan2(d2, d0) * 180.0D / Math.PI) - 90.0F;
            float f3 = (float)(-(Math.atan2(d1, d3) * 180.0D / Math.PI));
            double d4 = d0 / d3;
            double d5 = d2 / d3;
            this.setLocationAndAngles(par2EntityLivingBase.posX + d4, this.posY, par2EntityLivingBase.posZ + d5, f2, f3);
            this.yOffset = 0.0F;
            float f4 = (float)d3 * 0.2F;
            this.setThrowableHeading(d0, d1 + (double)f4, d2, par4, par5);
        }
    }

    public EntityWoodArrow(World par1World, EntityLivingBase par2EntityLivingBase, float par3)
    {
        super(par1World);
        this.renderDistanceWeight = 10.0D;
        this.shootingEntity = par2EntityLivingBase;

        if (par2EntityLivingBase instanceof EntityPlayer)
        {
            this.canBePickedUp = 1;
        }

        this.setSize(0.5F, 0.5F);
        this.setLocationAndAngles(par2EntityLivingBase.posX, par2EntityLivingBase.posY + (double)par2EntityLivingBase.getEyeHeight(), par2EntityLivingBase.posZ, par2EntityLivingBase.rotationYaw, par2EntityLivingBase.rotationPitch);
        this.posX -= (double)(MathHelper.cos(this.rotationYaw / 180.0F * (float)Math.PI) * 0.16F);
        this.posY -= 0.10000000149011612D;
        this.posZ -= (double)(MathHelper.sin(this.rotationYaw / 180.0F * (float)Math.PI) * 0.16F);
        this.setPosition(this.posX, this.posY, this.posZ);
        this.yOffset = 0.0F;
        this.motionX = (double)(-MathHelper.sin(this.rotationYaw / 180.0F * (float)Math.PI) * MathHelper.cos(this.rotationPitch / 180.0F * (float)Math.PI));
        this.motionZ = (double)(MathHelper.cos(this.rotationYaw / 180.0F * (float)Math.PI) * MathHelper.cos(this.rotationPitch / 180.0F * (float)Math.PI));
        this.motionY = (double)(-MathHelper.sin(this.rotationPitch / 180.0F * (float)Math.PI));
        this.setThrowableHeading(this.motionX, this.motionY, this.motionZ, par3 * 1.5F, 1.0F);
    }

    protected void entityInit()
    {
        this.dataWatcher.addObject(16, Byte.valueOf((byte)0));
    }

    /**
     * Similar to setArrowHeading, it's point the throwable entity to a x, y, z direction.
     */
    public void setThrowableHeading(double par1, double par3, double par5, float par7, float par8)
    {
        float f2 = MathHelper.sqrt_double(par1 * par1 + par3 * par3 + par5 * par5);
        par1 /= (double)f2;
        par3 /= (double)f2;
        par5 /= (double)f2;
        par1 += this.rand.nextGaussian() * (double)(this.rand.nextBoolean() ? -1 : 1) * 0.007499999832361937D * (double)par8;
        par3 += this.rand.nextGaussian() * (double)(this.rand.nextBoolean() ? -1 : 1) * 0.007499999832361937D * (double)par8;
        par5 += this.rand.nextGaussian() * (double)(this.rand.nextBoolean() ? -1 : 1) * 0.007499999832361937D * (double)par8;
        par1 *= (double)par7;
        par3 *= (double)par7;
        par5 *= (double)par7;
        this.motionX = par1;
        this.motionY = par3;
        this.motionZ = par5;
        float f3 = MathHelper.sqrt_double(par1 * par1 + par5 * par5);
        this.prevRotationYaw = this.rotationYaw = (float)(Math.atan2(par1, par5) * 180.0D / Math.PI);
        this.prevRotationPitch = this.rotationPitch = (float)(Math.atan2(par3, (double)f3) * 180.0D / Math.PI);
        this.ticksInGround = 0;
    }

    @SideOnly(Side.CLIENT)

    /**
     * Sets the position and rotation. Only difference from the other one is no bounding on the rotation. Args: posX,
     * posY, posZ, yaw, pitch
     */
    public void setPositionAndRotation2(double par1, double par3, double par5, float par7, float par8, int par9)
    {
        this.setPosition(par1, par3, par5);
        this.setRotation(par7, par8);
    }

    @SideOnly(Side.CLIENT)

    /**
     * Sets the velocity to the args. Args: x, y, z
     */
    public void setVelocity(double par1, double par3, double par5)
    {
        this.motionX = par1;
        this.motionY = par3;
        this.motionZ = par5;

        if (this.prevRotationPitch == 0.0F && this.prevRotationYaw == 0.0F)
        {
            float f = MathHelper.sqrt_double(par1 * par1 + par5 * par5);
            this.prevRotationYaw = this.rotationYaw = (float)(Math.atan2(par1, par5) * 180.0D / Math.PI);
            this.prevRotationPitch = this.rotationPitch = (float)(Math.atan2(par3, (double)f) * 180.0D / Math.PI);
            this.prevRotationPitch = this.rotationPitch;
            this.prevRotationYaw = this.rotationYaw;
            this.setLocationAndAngles(this.posX, this.posY, this.posZ, this.rotationYaw, this.rotationPitch);
            this.ticksInGround = 0;
        }
    }

    /**
     * Called to update the entity's position/logic.
     */
    public void onUpdate()
    {
        super.onUpdate();

        if (this.prevRotationPitch == 0.0F && this.prevRotationYaw == 0.0F)
        {
            float f = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionZ * this.motionZ);
            this.prevRotationYaw = this.rotationYaw = (float)(Math.atan2(this.motionX, this.motionZ) * 180.0D / Math.PI);
            this.prevRotationPitch = this.rotationPitch = (float)(Math.atan2(this.motionY, (double)f) * 180.0D / Math.PI);
        }

        int i = this.worldObj.getBlockId(this.xTile, this.yTile, this.zTile);

        if (i > 0)
        {
            Block.blocksList[i].setBlockBoundsBasedOnState(this.worldObj, this.xTile, this.yTile, this.zTile);
            AxisAlignedBB axisalignedbb = Block.blocksList[i].getCollisionBoundingBoxFromPool(this.worldObj, this.xTile, this.yTile, this.zTile);

            if (axisalignedbb != null && axisalignedbb.isVecInside(this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX, this.posY, this.posZ)))
            {
                this.inGround = true;
            }
        }

        if (this.arrowShake > 0)
        {
            --this.arrowShake;
        }
/////////////////////////////
        if (this.inGround)
        {
            int j = this.worldObj.getBlockId(this.xTile, this.yTile, this.zTile);
            int k = this.worldObj.getBlockMetadata(this.xTile, this.yTile, this.zTile);

            if (j == this.inTile && k == this.inData)
            {
                ++this.ticksInGround;

                if (this.ticksInGround == 1000)
                {
                    this.setDead();
                }
            }
            else
            {
                this.inGround = false;
                this.motionX *= (double)(this.rand.nextFloat() * 0.2F);
                this.motionY *= (double)(this.rand.nextFloat() * 0.2F);
                this.motionZ *= (double)(this.rand.nextFloat() * 0.2F);
                this.ticksInGround = 0;
                this.ticksInAir = 0;
            }
        }
        else
        {
            ++this.ticksInAir;
            Vec3 vec3 = this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX, this.posY, this.posZ);
            Vec3 vec31 = this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX + this.motionX, this.posY + this.motionY, this.posZ + this.motionZ);
            MovingObjectPosition movingobjectposition = this.worldObj.rayTraceBlocks_do_do(vec3, vec31, false, true);
            vec3 = this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX, this.posY, this.posZ);
            vec31 = this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX + this.motionX, this.posY + this.motionY, this.posZ + this.motionZ);

            if (movingobjectposition != null)
            {
                vec31 = this.worldObj.getWorldVec3Pool().getVecFromPool(movingobjectposition.hitVec.xCoord, movingobjectposition.hitVec.yCoord, movingobjectposition.hitVec.zCoord);
            }

            Entity entity = null;
            List list = this.worldObj.getEntitiesWithinAABBExcludingEntity(this, this.boundingBox.addCoord(this.motionX, this.motionY, this.motionZ).expand(1.0D, 1.0D, 1.0D));
            double d0 = 0.0D;
            int l;
            float f1;

            for (l = 0; l < list.size(); ++l)
            {
                Entity entity1 = (Entity)list.get(l);

                if (entity1.canBeCollidedWith() && (entity1 != this.shootingEntity || this.ticksInAir >= 5))
                {
                    f1 = 0.3F;
                    AxisAlignedBB axisalignedbb1 = entity1.boundingBox.expand((double)f1, (double)f1, (double)f1);
                    MovingObjectPosition movingobjectposition1 = axisalignedbb1.calculateIntercept(vec3, vec31);

                    if (movingobjectposition1 != null)
                    {
                        double d1 = vec3.distanceTo(movingobjectposition1.hitVec);

                        if (d1 < d0 || d0 == 0.0D)
                        {
                            entity = entity1;
                            d0 = d1;
                        }
                    }
                }
            }

            if (entity != null)
            {
                movingobjectposition = new MovingObjectPosition(entity);
            }

            if (movingobjectposition != null && movingobjectposition.entityHit != null && movingobjectposition.entityHit instanceof EntityPlayer)
            {
                EntityPlayer entityplayer = (EntityPlayer)movingobjectposition.entityHit;

                if (entityplayer.capabilities.disableDamage || this.shootingEntity instanceof EntityPlayer && !((EntityPlayer)this.shootingEntity).canAttackPlayer(entityplayer))
                {
                    movingobjectposition = null;
                }
            }

            float f2;
            float f3;

            if (movingobjectposition != null)
            {
                if (movingobjectposition.entityHit != null)
                {
                    f2 = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionY * this.motionY + this.motionZ * this.motionZ);
                    int i1 = MathHelper.ceiling_double_int((double)f2 * this.damage);

                    if (this.getIsCritical())
                    {
                        i1 += this.rand.nextInt(i1 / 2 + 2);
                    }

                    DamageSource damagesource = null;

                    if (this.shootingEntity == null)
                    {
                        damagesource = DamageSource.causeThrownDamage(this, this);
                    }
                    else
                    {
                        damagesource = DamageSource.causeThrownDamage(this, this.shootingEntity);
                    }

                    if (this.isBurning() && !(movingobjectposition.entityHit instanceof EntityEnderman))
                    {
                        movingobjectposition.entityHit.setFire(5);
                    }

                    if (movingobjectposition.entityHit.attackEntityFrom(damagesource, (float)i1))
                    {
                        if (movingobjectposition.entityHit instanceof EntityLivingBase)
                        {
                            EntityLivingBase entitylivingbase = (EntityLivingBase)movingobjectposition.entityHit;

                            if (!this.worldObj.isRemote)
                            {
                                entitylivingbase.setArrowCountInEntity(entitylivingbase.getArrowCountInEntity() + 1);
                            }

                            if (this.knockbackStrength > 0)
                            {
                                f3 = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionZ * this.motionZ);

                                if (f3 > 0.0F)
                                {
                                    movingobjectposition.entityHit.addVelocity(this.motionX * (double)this.knockbackStrength * 0.6000000238418579D / (double)f3, 0.1D, this.motionZ * (double)this.knockbackStrength * 0.6000000238418579D / (double)f3);
                                }
                            }

                            if (this.shootingEntity != null)
                            {
                                EnchantmentThorns.func_92096_a(this.shootingEntity, entitylivingbase, this.rand);
                            }

                            if (this.shootingEntity != null && movingobjectposition.entityHit != this.shootingEntity && movingobjectposition.entityHit instanceof EntityPlayer && this.shootingEntity instanceof EntityPlayerMP)
                            {
                                ((EntityPlayerMP)this.shootingEntity).playerNetServerHandler.sendPacketToPlayer(new Packet70GameEvent(6, 0));
                            }
                        }

                        this.playSound("random.bowhit", 1.0F, 1.2F / (this.rand.nextFloat() * 0.2F + 0.9F));

                        if (!(movingobjectposition.entityHit instanceof EntityEnderman))
                        {
                            this.setDead();
                        }
                    }
                    else
                    {
                        this.motionX *= -0.10000000149011612D;
                        this.motionY *= -0.10000000149011612D;
                        this.motionZ *= -0.10000000149011612D;
                        this.rotationYaw += 180.0F;
                        this.prevRotationYaw += 180.0F;
                        this.ticksInAir = 0;
                    }
                }
                else
                {
                    this.xTile = movingobjectposition.blockX;
                    this.yTile = movingobjectposition.blockY;
                    this.zTile = movingobjectposition.blockZ;
                    this.inTile = this.worldObj.getBlockId(this.xTile, this.yTile, this.zTile);
                    this.inData = this.worldObj.getBlockMetadata(this.xTile, this.yTile, this.zTile);
                    this.motionX = (double)((float)(movingobjectposition.hitVec.xCoord - this.posX));
                    this.motionY = (double)((float)(movingobjectposition.hitVec.yCoord - this.posY));
                    this.motionZ = (double)((float)(movingobjectposition.hitVec.zCoord - this.posZ));
                    f2 = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionY * this.motionY + this.motionZ * this.motionZ);
                    this.posX -= this.motionX / (double)f2 * 0.05000000074505806D;
                    this.posY -= this.motionY / (double)f2 * 0.05000000074505806D;
                    this.posZ -= this.motionZ / (double)f2 * 0.05000000074505806D;
                    this.playSound("random.bowhit", 1.0F, 1.2F / (this.rand.nextFloat() * 0.2F + 0.9F));
                    this.inGround = true;
                    this.arrowShake = 7;
                    this.setIsCritical(false);

                    if (this.inTile != 0)
                    {
                        Block.blocksList[this.inTile].onEntityCollidedWithBlock(this.worldObj, this.xTile, this.yTile, this.zTile, this);
                    }
                }
            }

            if (this.getIsCritical())
            {
                for (l = 0; l < 4; ++l)
                {
                    this.worldObj.spawnParticle("crit", this.posX + this.motionX * (double)l / 4.0D, this.posY + this.motionY * (double)l / 4.0D, this.posZ + this.motionZ * (double)l / 4.0D, -this.motionX, -this.motionY + 0.2D, -this.motionZ);
                }
            }

            this.posX += this.motionX;
            this.posY += this.motionY;
            this.posZ += this.motionZ;
            f2 = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionZ * this.motionZ);
            this.rotationYaw = (float)(Math.atan2(this.motionX, this.motionZ) * 180.0D / Math.PI);

            for (this.rotationPitch = (float)(Math.atan2(this.motionY, (double)f2) * 180.0D / Math.PI); this.rotationPitch - this.prevRotationPitch < -180.0F; this.prevRotationPitch -= 360.0F)
            {
                ;
            }

            while (this.rotationPitch - this.prevRotationPitch >= 180.0F)
            {
                this.prevRotationPitch += 360.0F;
            }

            while (this.rotationYaw - this.prevRotationYaw < -180.0F)
            {
                this.prevRotationYaw -= 360.0F;
            }

            while (this.rotationYaw - this.prevRotationYaw >= 180.0F)
            {
                this.prevRotationYaw += 360.0F;
            }

            this.rotationPitch = this.prevRotationPitch + (this.rotationPitch - this.prevRotationPitch) * 0.2F;
            this.rotationYaw = this.prevRotationYaw + (this.rotationYaw - this.prevRotationYaw) * 0.2F;
            float f4 = 0.99F;
            f1 = 0.05F;

            if (this.isInWater())
            {
                for (int j1 = 0; j1 < 4; ++j1)
                {
                    f3 = 0.25F;
                    this.worldObj.spawnParticle("bubble", this.posX - this.motionX * (double)f3, this.posY - this.motionY * (double)f3, this.posZ - this.motionZ * (double)f3, this.motionX, this.motionY, this.motionZ);
                }

                f4 = 0.8F;
            }

            this.motionX *= (double)f4;
            this.motionY *= (double)f4;
            this.motionZ *= (double)f4;
            this.motionY -= (double)f1;
            this.setPosition(this.posX, this.posY, this.posZ);
            this.doBlockCollisions();
        }
    }
/////////////////////////////////////
    /**
     * (abstract) Protected helper method to write subclass entity data to NBT.
     */
    public void writeEntityToNBT(NBTTagCompound par1NBTTagCompound)
    {
        par1NBTTagCompound.setShort("xTile", (short)this.xTile);
        par1NBTTagCompound.setShort("yTile", (short)this.yTile);
        par1NBTTagCompound.setShort("zTile", (short)this.zTile);
        par1NBTTagCompound.setByte("inTile", (byte)this.inTile);
        par1NBTTagCompound.setByte("inData", (byte)this.inData);
        par1NBTTagCompound.setByte("shake", (byte)this.arrowShake);
        par1NBTTagCompound.setByte("inGround", (byte)(this.inGround ? 1 : 0));
        par1NBTTagCompound.setByte("pickup", (byte)this.canBePickedUp);
        par1NBTTagCompound.setDouble("damage", this.damage);
    }

    /**
     * (abstract) Protected helper method to read subclass entity data from NBT.
     */
    public void readEntityFromNBT(NBTTagCompound par1NBTTagCompound)
    {
        this.xTile = par1NBTTagCompound.getShort("xTile");
        this.yTile = par1NBTTagCompound.getShort("yTile");
        this.zTile = par1NBTTagCompound.getShort("zTile");
        this.inTile = par1NBTTagCompound.getByte("inTile") & 255;
        this.inData = par1NBTTagCompound.getByte("inData") & 255;
        this.arrowShake = par1NBTTagCompound.getByte("shake") & 255;
        this.inGround = par1NBTTagCompound.getByte("inGround") == 1;

        if (par1NBTTagCompound.hasKey("damage"))
        {
            this.damage = par1NBTTagCompound.getDouble("damage");
        }

        if (par1NBTTagCompound.hasKey("pickup"))
        {
            this.canBePickedUp = par1NBTTagCompound.getByte("pickup");
        }
        else if (par1NBTTagCompound.hasKey("player"))
        {
            this.canBePickedUp = par1NBTTagCompound.getBoolean("player") ? 1 : 0;
        }
    }

    /**
     * Called by a player entity when they collide with an entity
     */
    public void onCollideWithPlayer(EntityPlayer par1EntityPlayer)
    {
        if (!this.worldObj.isRemote && this.inGround && this.arrowShake <= 0)
        {
            boolean flag = this.canBePickedUp == 1 || this.canBePickedUp == 2 && par1EntityPlayer.capabilities.isCreativeMode;

            if (this.canBePickedUp == 1 && !par1EntityPlayer.inventory.addItemStackToInventory(new ItemStack(itemmod.Woodenarrow, 1)))
            {
                flag = false;
            }

            if (flag)
            {
                this.playSound("random.pop", 0.2F, ((this.rand.nextFloat() - this.rand.nextFloat()) * 0.7F + 1.0F) * 2.0F);
                par1EntityPlayer.onItemPickup(this, 1);
                this.setDead();
            }
        }
    }

    /**
     * returns if this entity triggers Block.onEntityWalking on the blocks they walk on. used for spiders and wolves to
     * prevent them from trampling crops
     */
    protected boolean canTriggerWalking()
    {
        return false;
    }

    @SideOnly(Side.CLIENT)
    public float getShadowSize()
    {
        return 0.0F;
    }

    public void setDamage(double par1)
    {
        this.damage = par1;
    }

    public double getDamage()
    {
        return this.damage;
    }

    /**
     * Sets the amount of knockback the arrow applies when it hits a mob.
     */
    public void setKnockbackStrength(int par1)
    {
        this.knockbackStrength = par1;
    }

    /**
     * If returns false, the item will not inflict any damage against entities.
     */
    public boolean canAttackWithItem()
    {
        return false;
    }

    /**
     * Whether the arrow has a stream of critical hit particles flying behind it.
     */
    public void setIsCritical(boolean par1)
    {
        byte b0 = this.dataWatcher.getWatchableObjectByte(16);

        if (par1)
        {
            this.dataWatcher.updateObject(16, Byte.valueOf((byte)(b0 | 1)));
        }
        else
        {
            this.dataWatcher.updateObject(16, Byte.valueOf((byte)(b0 & -2)));
        }
    }

    /**
     * Whether the arrow has a stream of critical hit particles flying behind it.
     */
    public boolean getIsCritical()
    {
        byte b0 = this.dataWatcher.getWatchableObjectByte(16);
        return (b0 & 1) != 0;
    }
}

WoodenBow Class:

package floxroxx.itemmod;

import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnchantmentHelper;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.projectile.EntityArrow;
import net.minecraft.item.EnumAction;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.util.Icon;
import net.minecraft.world.World;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.event.entity.player.ArrowLooseEvent;
import net.minecraftforge.event.entity.player.ArrowNockEvent;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;


public class WoodenBow extends Item 
{

    public static final String[] bowPullIconNameArray = new String[] {"pulling_0", "pulling_1", "pulling_2"};
    @SideOnly(Side.CLIENT)
    private Icon[] iconArray;
    
public WoodenBow (int id)
{
	super(id);
	setMaxStackSize(1);
	setCreativeTab(itemmod.ItemMod);
	setUnlocalizedName("WoodenBow");

	this.bFull3D = true;
	//setTextureName("itemmod:WoodenBow");
	//setMaxDamage(384);

}

   /**
     * called when the player releases the use item button. Args: itemstack, world, entityplayer, itemInUseCount
     */
    public void onPlayerStoppedUsing(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer, int par4)
    {
        int j = this.getMaxItemUseDuration(par1ItemStack) - par4;

        ArrowLooseEvent event = new ArrowLooseEvent(par3EntityPlayer, par1ItemStack, j);
        MinecraftForge.EVENT_BUS.post(event);
        if (event.isCanceled())
        {
            return;
        }
        j = event.charge;

        boolean flag = par3EntityPlayer.capabilities.isCreativeMode || EnchantmentHelper.getEnchantmentLevel(Enchantment.infinity.effectId, par1ItemStack) > 0;

        if (flag || par3EntityPlayer.inventory.hasItem(itemmod.Woodenarrow.itemID))
        {
            float f = (float)j / 20.0F;
            f = (f * f + f * 2.0F) / 3.0F;

            if ((double)f < 0.1D)
            {
                return;
            }

            if (f > 1.0F)
            {
                f = 1.0F;
            }

            EntityWoodArrow entityarrow = new EntityWoodArrow(par2World, par3EntityPlayer, f * 2.0F);

            if (f == 1.0F)
            {
                entityarrow.setIsCritical(true);
            }

            int k = EnchantmentHelper.getEnchantmentLevel(Enchantment.power.effectId, par1ItemStack);

            if (k > 0)
            {
                entityarrow.setDamage(entityarrow.getDamage() + (double)k * 0.5D + 0.5D);
            }

            int l = EnchantmentHelper.getEnchantmentLevel(Enchantment.punch.effectId, par1ItemStack);

            if (l > 0)
            {
                entityarrow.setKnockbackStrength(l);
            }

            if (EnchantmentHelper.getEnchantmentLevel(Enchantment.flame.effectId, par1ItemStack) > 0)
            {
                entityarrow.setFire(100);
            }

            par1ItemStack.damageItem(1, par3EntityPlayer);
            par2World.playSoundAtEntity(par3EntityPlayer, "random.bow", 1.0F, 1.0F / (itemRand.nextFloat() * 0.4F + 1.2F) + f * 0.5F);

            if (flag)
            {
                entityarrow.canBePickedUp = 2;
            }
            else
            {
                par3EntityPlayer.inventory.consumeInventoryItem(itemmod.Woodenarrow.itemID);
            }

            if (!par2World.isRemote)
            {
                par2World.spawnEntityInWorld(entityarrow);
            }
        }
    }

    public ItemStack onEaten(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)
    {
        return par1ItemStack;
    }

    /**
     * How long it takes to use or consume an item
     */
    public int getMaxItemUseDuration(ItemStack par1ItemStack)
    {
        return 72000;
    }

    /**
     * returns the action that specifies what animation to play when the items is being used
     */
    public EnumAction getItemUseAction(ItemStack par1ItemStack)
    {
        return EnumAction.bow;
    }

    /**
     * Called whenever this item is equipped and the right mouse button is pressed. Args: itemStack, world, entityPlayer
     */
    
    public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)
    {
        ArrowNockEvent event = new ArrowNockEvent(par3EntityPlayer, par1ItemStack);
        MinecraftForge.EVENT_BUS.post(event);
        if (event.isCanceled())
        {
            return event.result;
        }

        if (par3EntityPlayer.capabilities.isCreativeMode || par3EntityPlayer.inventory.hasItem(itemmod.Woodenarrow.itemID))
        {
            par3EntityPlayer.setItemInUse(par1ItemStack, this.getMaxItemUseDuration(par1ItemStack));
        }

        return par1ItemStack;
    }

    /**
     * Return the enchantability factor of the item, most of the time is based on material.
     */
    public int getItemEnchantability()
    {
        return 1;
    }

    @SideOnly(Side.CLIENT)
    public void registerIcons(IconRegister par1IconRegister)
    {
        this.itemIcon = par1IconRegister.registerIcon("itemmod:woodenbow_standby");
        this.iconArray = new Icon[bowPullIconNameArray.length];

        for (int i = 0; i < this.iconArray.length; ++i)
        {
            this.iconArray[i] = par1IconRegister.registerIcon("itemmod:woodenbow_" + bowPullIconNameArray[i]);
        }
    }

//    @SideOnly(Side.CLIENT)
//
//    /**
//     * Returns True is the item is renderer in full 3D when hold.
//     */
//    public boolean isFull3D()
//    {
//        return true;
//    }
    

    @SideOnly(Side.CLIENT)

    /**
     * used to cycle through icons based on their used duration, i.e. for the bow
     */
    public Icon getIcon(ItemStack stack, int renderPass, EntityPlayer player, ItemStack usingItem, int useRemaining)
    {
                             if(player.getItemInUse() == null) return this.itemIcon;
                             int Pulling = stack.getMaxItemUseDuration() - useRemaining;
                             if (Pulling >= 18)
                             {
                                             return iconArray[2];
                             }
                             else if (Pulling > 13)
                             {
                                             return iconArray[1];
                             }
                             else if (Pulling > 0)
                             {
                                             return iconArray[0];
                             }              
                             return itemIcon;
                             }
}

And last but not least... woodarrow class

package floxroxx.itemmod;

import net.minecraft.item.Item;


public class woodarrow extends Item 
{

public woodarrow(int id)
{
	super(id);

	setMaxStackSize(64);
	setCreativeTab(itemmod.ItemMod);
	setUnlocalizedName("woodarrow");
	setTextureName("itemmod:woodarrow");
}

}

It is all original code so far BUT i had to change a little single thing:

At the EntityWoodArrow class i had to change DamageSource.causeArrowDamage to DamageSource.causeThrownDamage because all i tried it would not work other ways... it could be, that this is maybe the mayor problem on this thing.... iam still confused....

GotoLink · December 1, 2013

EntityRegistry.registerGlobalEntityID(EntityWoodArrow.class, "WoodArrow", EntityRegistry.findGlobalUniqueEntityId());
    	EntityRegistry.registerModEntity(EntityWoodArrow.class, "EntityWoodArrow", 5001, this, 128, 1, true);

You are registering twice...

Remove the first line.

FloxRoxX · December 2, 2013

Code: [select]

EntityRegistry.registerGlobalEntityID(EntityWoodArrow.class, "WoodArrow", EntityRegistry.findGlobalUniqueEntityId());

EntityRegistry.registerModEntity(EntityWoodArrow.class, "EntityWoodArrow", 5001, this, 128, 1, true);

You are registering twice...

Remove the first line.

Oh thanks i forgot to remove that while testing

Iam still trying to figure out whats causing all this...

TheGreyGhost · December 2, 2013

What i also noticed is, that if the arrows float in the air its only graphically. I can grab them up at the wall if i go there and also if i wait some time they will be moved back in the wall where i have shoot them but this needs about 20 seconds.

That smells very much like a client-server mismatch to me. The server periodically resynchronises the position of all entities to the client using Packet34EntityTeleport (every 20 seconds in fact) - EntityTrackerEntry.sendLocationToAllClients().

This part of the code in onUpdate should cause the arrow to stick in the block.

if (axisalignedbb != null && axisalignedbb.isVecInside(this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX, this.posY, this.posZ)))

{

this.inGround = true;

}

It's not clear to me why it's not working properly. Probably either the arrow is bouncing off for a frame or two before it stops moving, or your renderer is actually taking the arrow's position immediately before it hit the wall, but I can't see from the code which. You might gain some insight by adding System.out.println to various parts of the onUpdate code to see what's happening to the position every tick.

-TGG

FloxRoxX · December 2, 2013

Hello TheGreyGhost,

Iam currently at work i will try and error this today evening .

That smells very much like a client-server mismatch to me

Very interesting for that iam just copied original classes

FloxRoxX · December 2, 2013

OK i just have played around with the code a bit and put in about 40 debug points into the Entity class.

The result was that i made no progess... I could not find any clue on the behaviour from the arrows fading back into air.

Also i searched the forum for about an hour about arrow entities and i found many opened threads with about the same problem but no solutions.

Isn't here in this forum anyone that had the same problem and a solution for this ?

Does anyone knows a mod with custom arrows that is open source ? Maybe finding the solution while scrolling above their mods....

gcewing · December 2, 2013

This may sound silly, but have you made sure that the same thing doesn't happen with vanilla arrows?

I had a problem with very similar symptoms some time back while working on SG Craft. It turned out to be a bug in vanilla Minecraft, that was fixed in 1.5.2 according to the changelog. What version of Minecraft are you modding?

FloxRoxX · December 2, 2013

This may sound silly, but have you made sure that the same thing doesn't happen with vanilla arrows?

I had a problem with very similar symptoms some time back while working on SG Craft. It turned out to be a bug in vanilla Minecraft, that was fixed in 1.5.2 according to the changelog. What version of Minecraft are you modding?

Yep i have my vanilla bow always in the inventory to feel unhappy why the original one is working

Else i found something very interesting. If i change this line at my WoodenBow.class i get 2 arrows shoot, one correct and on is in the air. (The one that is correctly placed cannot be picked up)

if (!par2World.isRemote)
            {
                par2World.spawnEntityInWorld(entityarrow);
            }

changed to

//if (!par2World.isRemote)
     //{
           par2World.spawnEntityInWorld(entityarrow);
     //}

TheGreyGhost · December 3, 2013

Hi

Could you post a zip of all your code somewhere, or share it on GitHub? If so I'll download it and try it myself in the next day. You've got my Sherlock Holmes neurons quivering now :-)

-TGG

FloxRoxX · December 4, 2013

Hello TheGreyGhost,

thanks in advance for helping me

I zipped my whole forge folder with the project inside.

Here is the download link for this:http://abetterworld.de/files/minecraftforge-src-TGG.zip

It includes my testing world + some blocks + the bow and arrow + a bowrenderer for 3rd person

I made an extra Creative tab for the items so you dont have to search ingame

The bowrenderer can be disabled in the clientproxy in case you want to test without that(that one is also a bit buggy in multiplayer but renders just fine at singleplayer)

If something is missing just tell me

TheGreyGhost · December 4, 2013

Hi

I've managed to download and compile your code and I can recreate the problem you're seeing.

It's bedtime for me now but I will give it a crack tomorrow night.

-TGG

TheGreyGhost · December 5, 2013

Hi

Well I found it

The culprit is not in your code at all. It's here in EntityTrackerEntry:

    public void sendLocationToAllClients(List par1List) 
{

// ...etc ...
                if (this.ticks > 0 || this.myEntity instanceof EntityArrow)    // this line here
                {
                  if (j1 >= -128 && j1 < 128 && k1 >= -128 && k1 < 128 && l1 >= -128 && l1 < 128 && this.ticksSinceLastForcedTeleport <= 400 && !this.ridingEntity)
                    {
                        if (flag && flag1)
                        {
                          object = new Packet33RelEntityMoveLook(this.myEntity.entityId, (byte)j1, (byte)k1, (byte)l1, (byte)l, (byte)i1);
                        }
                        else if (flag)
                        {
                          object = new Packet31RelEntityMove(this.myEntity.entityId, (byte)j1, (byte)k1, (byte)l1);
                        }
                        else if (flag1)
                        {
                          object = new Packet32EntityLook(this.myEntity.entityId, (byte)l, (byte)i1);
                        }
                    }
                    else
                    {
                        this.ticksSinceLastForcedTeleport = 0;
                        object = new Packet34EntityTeleport(this.myEntity.entityId, i, j, k, (byte)l, (byte)i1);
                    }
                }
// etc

This controls when the server sends position updates to the client. In order to save packet size, it usually sends the change in position (eg "increase x by 2"), not the actual position ("set x = 53.4").

this.ticks is the length of time that this tracker has been tracking the entity. The server normally doesn't send a position update for the entity unless it has had at least one tick (this.ticks > 0).

But for some reason, EntityArrow is designed differently. It must send a position update even on the first tick. If it doesn't, the first position change is lost and from then on the position is wrong on the client, which is what you're seeing.

So rather than fix the problem properly, the code author introduced a "dirty" fix ("kludge") to solve the symptoms, i.e. the check for instance of EntityArrow.

If I change that line to

               if (this.ticks > 0 || this.myEntity instanceof EntityArrow || this.myEntity instanceof EntityWoodArrow)    // this line here

then the problem disappears.

A more practical solution for you is to make sure you define your EntityWoodArrow as

class EntityWoodArrow extends EntityArrow.

-TGG

FloxRoxX · December 8, 2013

Hello TGG,

wow... i would never had looked in this class....

i found some time to try it out and it worked

now the only thing is, if you are not in creative mode the arrow fires not straight. I think i will figure this one out soon why this happens but thanks so much helping me with this.

I hope this will help also a lot of ppl out there if they want to make custom arrows!

EDIT: Okay editing the EntityTracker works but if i try to extend with EntityArrow it wont work. The Arrow is directly hitting myself. Editing MC classes isnt that good so i will try on extending... but it does not work.

TheGreyGhost · December 9, 2013

Hi

The arrow hits yourself when you try to shoot it?

In EntityWoodArrow.onUpdate, this code should prevent that

List list = this.worldObj.getEntitiesWithinAABBExcludingEntity(this, this.boundingBox.addCoord(this.motionX, this.motionY, this.motionZ).expand(1.0D, 1.0D, 1.0D));
// ..etc ..            
            for (l = 0; l < list.size(); ++l)
            {
                Entity entity1 = (Entity)list.get(l);

                if (entity1.canBeCollidedWith() && (entity1 != this.shootingEntity || this.ticksInAir >= 5))

i.e. entity1 != this.ShootingEntity

when entity1 is your player, and it matches the ShootingEntity (which is your player). Your player should be immune from being hit for 5 ticks.

Set a breakpoint just after that line, and see which part is not matching properly?

-TGG

Chazzilla · January 11, 2015

I'm having the same problem and I have used every solution you have posted but it won't work. Note that Minecraft crashes when I use the Arrow Render, so I am using a snowball one. My code:

Main class: Note that I am using the youth digital template

package mymod;

import java.awt.Color;

import mymod.biome.MyBiome;

import mymod.blocks.MyBlock;

import mymod.entity.happiny.MyModelMinion;

import mymod.entity.happiny.MyRenderMinon;

import mymod.entity.happinyAI.MyEntityMinion;

import mymod.entity.projectile.MyArrow;

import mymod.entity.projectile.RenderMyArrow;

import mymod.entity.projectile.Renderer;

import mymod.items.MyBow;

import mymod.items.MyFood;

import mymod.items.MyItem;

import mymod.items.MySword;

import mymod.proxies.CommonProxy;

import net.minecraft.item.EnumToolMaterial;

import net.minecraft.item.Item;

import net.minecraft.item.ItemBow;

import net.minecraft.item.ItemStack;

import net.minecraft.src.ModLoader;

import net.minecraft.world.biome.BiomeGenBase;

import net.minecraftforge.common.EnumHelper;

import cpw.mods.fml.client.registry.RenderingRegistry;

import cpw.mods.fml.common.Mod;

import cpw.mods.fml.common.Mod.EventHandler;

import cpw.mods.fml.common.SidedProxy;

import cpw.mods.fml.common.event.FMLInitializationEvent;

import cpw.mods.fml.common.event.FMLPostInitializationEvent;

import cpw.mods.fml.common.event.FMLPreInitializationEvent;

import cpw.mods.fml.common.network.NetworkMod;

import cpw.mods.fml.common.registry.EntityRegistry;

import cpw.mods.fml.common.registry.GameRegistry;

import cpw.mods.fml.common.registry.LanguageRegistry;

import net.minecraft.client.renderer.entity.RenderArrow;

import net.minecraft.creativetab.CreativeTabs;

import net.minecraft.entity.Entity;

import net.minecraft.entity.EntityEggInfo;

import net.minecraft.entity.EntityList;

import net.minecraft.entity.EnumCreatureType;

import net.minecraft.block.Block;

import net.minecraft.block.material.Material;

import net.minecraftforge.common.MinecraftForge;

/* MOD INFO */

@Mod( modid = "mymod", name = "The Happiny Mod", version = "In Progress")

@NetworkMod(clientSideRequired=true, serverSideRequired=false)

public class Main {

/* PROXY INFO */

@SidedProxy(clientSide = "mymod.proxies.ClientProxy", serverSide = "mymod.proxies.CommonProxy")

public static CommonProxy proxy;

// DECLARE THE MOD ID

static int MyEntityID = 300;

// SEARCH FOR UNIQUE ID

public static int getUniqueEntityId() {

do {

MyEntityID++;

}

while (EntityList.getStringFromID(MyEntityID) != null);

return MyEntityID++;

}

// DECLARE A NEW EGG

public static void registerEntityEgg(Class <? extends Entity> entity, int primaryColor, int secondaryColor) {

int id = getUniqueEntityId();

EntityList.IDtoClassMapping.put(id, entity);

EntityList.entityEggs.put(id, new EntityEggInfo(id, primaryColor, secondaryColor));

}

/**

* DECLARATION SECTION

* *********************************************************** */

public static BiomeGenBase MyBiome_1;

public static mymod.items.MyBow MyBow;// = (ItemBow) (new MyBow(3)).setUnlocalizedName("MyBow").setTextureName("MyItem_2");

public static Item MyItem_2;

public static Item MyItem_1;

public static Block MyBlock_1;

public static Block MyBlock_2;

public static Block MyBlock_3;

public static Item MyItem_3;

public static Item MySword_1;

/* ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ */

@EventHandler

public void preInit( FMLPreInitializationEvent event )

{

/**

* LOAD SECTION

* *********************************************************** */

MyBlock_1 = new MyBlock(251, Material.rock, "MyBlock_1").setStepSound(Block.soundStoneFootstep);

GameRegistry.registerBlock(MyBlock_1, "MyBlock_1");

LanguageRegistry.addName(MyBlock_1, "Rainbow Ore");

MinecraftForge.setBlockHarvestLevel(MyBlock_1, "pickaxe", 0);

MyBlock_2 = new MyBlock(252, Material.grass, "MyBlock_2").setLightValue(0.65F).setStepSound(Block.soundSnowFootstep);

GameRegistry.registerBlock(MyBlock_2, "MyBlock_2");

LanguageRegistry.addName(MyBlock_2, "Grass From Happiny World");

MinecraftForge.setBlockHarvestLevel(MyBlock_2, "shovel", 0);

MyBlock_3 = new MyBlock(253, Material.grass, "MyBlock_3").setLightValue(0.65F).setStepSound(Block.soundSnowFootstep);

GameRegistry.registerBlock(MyBlock_3, "MyBlock_3");

LanguageRegistry.addName(MyBlock_3, "Dirt From Happiny World");

MinecraftForge.setBlockHarvestLevel(MyBlock_3, "shovel", 0);

EntityRegistry.registerGlobalEntityID(MyEntityMinion.class, "Minion", EntityRegistry.findGlobalUniqueEntityId());

registerEntityEgg(MyEntityMinion.class, (new Color(255, 0, 0)).getRGB(), (new Color(0, 0, 0)).getRGB());

RenderingRegistry.registerEntityRenderingHandler(MyEntityMinion.class, new MyRenderMinon(new MyModelMinion(), 0.3F));

ModLoader.addLocalization("entity.Minion.name", "Happiny Villager");

MyItem_1 = new MyFood(2040, 8, 3.5F, true, "MyItem_1");

GameRegistry.registerItem(MyItem_1, "MyItem_1");

LanguageRegistry.addName(MyItem_1, "Rainbow");

MySword_1 = new MySword(2030, EnumToolMaterial.EMERALD, "MySword_1").setCreativeTab(CreativeTabs.tabCombat);

GameRegistry.registerItem(MySword_1, "MySword_1");

LanguageRegistry.addName(MySword_1, "Rainbow Sword");

MyItem_3 = new MyItem(2031, "MyItem_3").setCreativeTab(CreativeTabs.tabCombat);

GameRegistry.registerItem(MyItem_3, "MyItem_3");

LanguageRegistry.addName(MyItem_3, "Happiny Arrow");

MyBow = (mymod.items.MyBow) new MyBow(700).setUnlocalizedName("MyBow");

GameRegistry.registerItem(MyBow, "MyBow");

LanguageRegistry.addName(MyBow, "Happiny Bow");

MyBiome_1 = new MyBiome(30);

GameRegistry.addBiome(MyBiome_1);

EntityRegistry.registerGlobalEntityID(MyArrow.class, "MyProjectile_1", 1);

EntityRegistry.registerModEntity(MyArrow.class, "MyProjectile_1", 1, this, 256, 1, true);

LanguageRegistry.instance().addStringLocalization("entity.modid.MyProjectile_1.name", "My Awesome Projectile");

RenderingRegistry.registerEntityRenderingHandler(MyArrow.class, new Renderer(MyItem_3));

/* ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ */

}

@EventHandler

public static void init( FMLInitializationEvent event )

{

/**

* RECIPES SECTION

* *********************************************************** */

/* ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ */

/**

* EXTRA METHODS SECTION

* *********************************************************** */

/* ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ */

}

@EventHandler

public static void postInit( FMLPostInitializationEvent event )

{

}

Render Class:

package mymod.entity.projectile;

import cpw.mods.fml.relauncher.Side;

import cpw.mods.fml.relauncher.SideOnly;

import net.minecraft.client.renderer.Tessellator;

import net.minecraft.client.renderer.entity.Render;

import net.minecraft.client.renderer.texture.TextureMap;

import net.minecraft.entity.Entity;

import net.minecraft.entity.projectile.EntityPotion;

import net.minecraft.item.Item;

import net.minecraft.item.ItemPotion;

import net.minecraft.potion.PotionHelper;

import net.minecraft.util.Icon;

import net.minecraft.util.ResourceLocation;

import org.lwjgl.opengl.GL11;

import org.lwjgl.opengl.GL12;

@SideOnly(Side.CLIENT)

public class Renderer extends Render

{

private Item field_94151_a;

private int field_94150_f;

public Renderer(Item par1Item, int par2)

{

this.field_94151_a = par1Item;

this.field_94150_f = par2;

}

public Renderer(Item par1Item)

{

this(par1Item, 0);

}

/**

* Actually renders the given argument. This is a synthetic bridge method, always casting down its argument and then

* handing it off to a worker function which does the actual work. In all probabilty, the class Render is generic

* (Render<T extends Entity) and this method has signature public void doRender(T entity, double d, double d1,

* double d2, float f, float f1). But JAD is pre 1.5 so doesn't do that.

*/

public void doRender(Entity par1Entity, double par2, double par4, double par6, float par8, float par9)

{

Icon icon = this.field_94151_a.getIconFromDamage(this.field_94150_f);

if (icon != null)

{

GL11.glPushMatrix();

GL11.glTranslatef((float)par2, (float)par4, (float)par6);

GL11.glEnable(GL12.GL_RESCALE_NORMAL);

GL11.glScalef(0.5F, 0.5F, 0.5F);

this.bindEntityTexture(par1Entity);

Tessellator tessellator = Tessellator.instance;

if (icon == ItemPotion.func_94589_d("bottle_splash"))

{

int i = PotionHelper.func_77915_a(((EntityPotion)par1Entity).getPotionDamage(), false);

float f2 = (float)(i >> 16 & 255) / 255.0F;

float f3 = (float)(i >> 8 & 255) / 255.0F;

float f4 = (float)(i & 255) / 255.0F;

GL11.glColor3f(f2, f3, f4);

GL11.glPushMatrix();

this.func_77026_a(tessellator, ItemPotion.func_94589_d("overlay"));

GL11.glPopMatrix();

GL11.glColor3f(1.0F, 1.0F, 1.0F);

}

this.func_77026_a(tessellator, icon);

GL11.glDisable(GL12.GL_RESCALE_NORMAL);

GL11.glPopMatrix();

}

/**

* Returns the location of an entity's texture. Doesn't seem to be called unless you call Render.bindEntityTexture.

*/

protected ResourceLocation getEntityTexture(Entity par1Entity)

{

return TextureMap.locationItemsTexture;

}

private void func_77026_a(Tessellator par1Tessellator, Icon par2Icon)

{

float f = par2Icon.getMinU();

float f1 = par2Icon.getMaxU();

float f2 = par2Icon.getMinV();

float f3 = par2Icon.getMaxV();

float f4 = 1.0F;

float f5 = 0.5F;

float f6 = 0.25F;

GL11.glRotatef(180.0F - this.renderManager.playerViewY, 0.0F, 1.0F, 0.0F);

GL11.glRotatef(-this.renderManager.playerViewX, 1.0F, 0.0F, 0.0F);

par1Tessellator.startDrawingQuads();

par1Tessellator.setNormal(0.0F, 1.0F, 0.0F);

par1Tessellator.addVertexWithUV((double)(0.0F - f5), (double)(0.0F - f6), 0.0D, (double)f, (double)f3);

par1Tessellator.addVertexWithUV((double)(f4 - f5), (double)(0.0F - f6), 0.0D, (double)f1, (double)f3);

par1Tessellator.addVertexWithUV((double)(f4 - f5), (double)(f4 - f6), 0.0D, (double)f1, (double)f2);

par1Tessellator.addVertexWithUV((double)(0.0F - f5), (double)(f4 - f6), 0.0D, (double)f, (double)f2);

par1Tessellator.draw();

}

Entity Class:

package mymod.entity.projectile;

import cpw.mods.fml.relauncher.Side;

import cpw.mods.fml.relauncher.SideOnly;

import java.util.List;

import net.minecraft.block.Block;

import net.minecraft.enchantment.EnchantmentThorns;

import net.minecraft.entity.Entity;

import net.minecraft.entity.EntityLivingBase;

import net.minecraft.entity.IProjectile;

import net.minecraft.entity.monster.EntityEnderman;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.entity.player.EntityPlayerMP;

import net.minecraft.item.Item;

import net.minecraft.item.ItemStack;

import net.minecraft.nbt.NBTTagCompound;

import net.minecraft.network.packet.Packet70GameEvent;

import net.minecraft.util.AxisAlignedBB;

import net.minecraft.util.DamageSource;

import net.minecraft.util.MathHelper;

import net.minecraft.util.MovingObjectPosition;

import net.minecraft.util.Vec3;

import net.minecraft.world.World;

public class MyArrow extends Entity implements IProjectile

{

private int xTile = -1;

private int yTile = -1;

private int zTile = -1;

private int inTile;

private int inData;

private boolean inGround;

/** 1 if the player can pick up the arrow */

public int canBePickedUp;

/** Seems to be some sort of timer for animating an arrow. */

public int arrowShake;

/** The owner of this arrow. */

public Entity shootingEntity;

private int ticksInGround;

private int ticksInAir;

private double damage = 2.0D;

/** The amount of knockback an arrow applies when it hits a mob. */

private int knockbackStrength;

public MyArrow(World par1World)

{

super(par1World);

this.renderDistanceWeight = 10.0D;

this.setSize(0.5F, 0.5F);

}

public MyArrow(World par1World, double par2, double par4, double par6)

{

super(par1World);

this.renderDistanceWeight = 10.0D;

this.setSize(0.5F, 0.5F);

this.setPosition(par2, par4, par6);

this.yOffset = 0.0F;

}

public MyArrow(World par1World, EntityLivingBase par2EntityLivingBase, EntityLivingBase par3EntityLivingBase, float par4, float par5)

{

super(par1World);

this.renderDistanceWeight = 10.0D;

this.shootingEntity = par2EntityLivingBase;

if (par2EntityLivingBase instanceof EntityPlayer)

{

this.canBePickedUp = 1;

}

this.posY = par2EntityLivingBase.posY + (double)par2EntityLivingBase.getEyeHeight() - 0.10000000149011612D;

double d0 = par3EntityLivingBase.posX - par2EntityLivingBase.posX;

double d1 = par3EntityLivingBase.boundingBox.minY + (double)(par3EntityLivingBase.height / 3.0F) - this.posY;

double d2 = par3EntityLivingBase.posZ - par2EntityLivingBase.posZ;

double d3 = (double)MathHelper.sqrt_double(d0 * d0 + d2 * d2);

if (d3 >= 1.0E-7D)

{

float f2 = (float)(Math.atan2(d2, d0) * 180.0D / Math.PI) - 90.0F;

float f3 = (float)(-(Math.atan2(d1, d3) * 180.0D / Math.PI));

double d4 = d0 / d3;

double d5 = d2 / d3;

this.setLocationAndAngles(par2EntityLivingBase.posX + d4, this.posY, par2EntityLivingBase.posZ + d5, f2, f3);

this.yOffset = 0.0F;

float f4 = (float)d3 * 0.2F;

this.setThrowableHeading(d0, d1 + (double)f4, d2, par4, par5);

}

public MyArrow(World par1World, EntityLivingBase par2EntityLivingBase, float par3)

{

super(par1World);

this.renderDistanceWeight = 10.0D;

this.shootingEntity = par2EntityLivingBase;

if (par2EntityLivingBase instanceof EntityPlayer)

{

this.canBePickedUp = 1;

}

this.setSize(0.5F, 0.5F);

this.setLocationAndAngles(par2EntityLivingBase.posX, par2EntityLivingBase.posY + (double)par2EntityLivingBase.getEyeHeight(), par2EntityLivingBase.posZ, par2EntityLivingBase.rotationYaw, par2EntityLivingBase.rotationPitch);

this.posX -= (double)(MathHelper.cos(this.rotationYaw / 180.0F * (float)Math.PI) * 0.16F);

this.posY -= 0.10000000149011612D;

this.posZ -= (double)(MathHelper.sin(this.rotationYaw / 180.0F * (float)Math.PI) * 0.16F);

this.setPosition(this.posX, this.posY, this.posZ);

this.yOffset = 0.0F;

this.motionX = (double)(-MathHelper.sin(this.rotationYaw / 180.0F * (float)Math.PI) * MathHelper.cos(this.rotationPitch / 180.0F * (float)Math.PI));

this.motionZ = (double)(MathHelper.cos(this.rotationYaw / 180.0F * (float)Math.PI) * MathHelper.cos(this.rotationPitch / 180.0F * (float)Math.PI));

this.motionY = (double)(-MathHelper.sin(this.rotationPitch / 180.0F * (float)Math.PI));

this.setThrowableHeading(this.motionX, this.motionY, this.motionZ, par3 * 1.5F, 1.0F);

}

protected void entityInit()

{

this.dataWatcher.addObject(16, Byte.valueOf((byte)0));

}

/**

* Similar to setArrowHeading, it's point the throwable entity to a x, y, z direction.

*/

public void setThrowableHeading(double par1, double par3, double par5, float par7, float par8)

{

float f2 = MathHelper.sqrt_double(par1 * par1 + par3 * par3 + par5 * par5);

par1 /= (double)f2;

par3 /= (double)f2;

par5 /= (double)f2;

par1 += this.rand.nextGaussian() * (double)(this.rand.nextBoolean() ? -1 : 1) * 0.007499999832361937D * (double)par8;

par3 += this.rand.nextGaussian() * (double)(this.rand.nextBoolean() ? -1 : 1) * 0.007499999832361937D * (double)par8;

par5 += this.rand.nextGaussian() * (double)(this.rand.nextBoolean() ? -1 : 1) * 0.007499999832361937D * (double)par8;

par1 *= (double)par7;

par3 *= (double)par7;

par5 *= (double)par7;

this.motionX = par1;

this.motionY = par3;

this.motionZ = par5;

float f3 = MathHelper.sqrt_double(par1 * par1 + par5 * par5);

this.prevRotationYaw = this.rotationYaw = (float)(Math.atan2(par1, par5) * 180.0D / Math.PI);

this.prevRotationPitch = this.rotationPitch = (float)(Math.atan2(par3, (double)f3) * 180.0D / Math.PI);

this.ticksInGround = 0;

}

@SideOnly(Side.CLIENT)

/**

* Sets the position and rotation. Only difference from the other one is no bounding on the rotation. Args: posX,

* posY, posZ, yaw, pitch

*/

public void setPositionAndRotation2(double par1, double par3, double par5, float par7, float par8, int par9)

{

this.setPosition(par1, par3, par5);

this.setRotation(par7, par8);

}

@SideOnly(Side.CLIENT)

/**

* Sets the velocity to the args. Args: x, y, z

*/

public void setVelocity(double par1, double par3, double par5)

{

this.motionX = par1;

this.motionY = par3;

this.motionZ = par5;

if (this.prevRotationPitch == 0.0F && this.prevRotationYaw == 0.0F)

{

float f = MathHelper.sqrt_double(par1 * par1 + par5 * par5);

this.prevRotationYaw = this.rotationYaw = (float)(Math.atan2(par1, par5) * 180.0D / Math.PI);

this.prevRotationPitch = this.rotationPitch = (float)(Math.atan2(par3, (double)f) * 180.0D / Math.PI);

this.prevRotationPitch = this.rotationPitch;

this.prevRotationYaw = this.rotationYaw;

this.setLocationAndAngles(this.posX, this.posY, this.posZ, this.rotationYaw, this.rotationPitch);

this.ticksInGround = 0;

}

/**

* Called to update the entity's position/logic.

*/

public void onUpdate()

{

super.onUpdate();

if (this.prevRotationPitch == 0.0F && this.prevRotationYaw == 0.0F)

{

float f = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionZ * this.motionZ);

this.prevRotationYaw = this.rotationYaw = (float)(Math.atan2(this.motionX, this.motionZ) * 180.0D / Math.PI);

this.prevRotationPitch = this.rotationPitch = (float)(Math.atan2(this.motionY, (double)f) * 180.0D / Math.PI);

}

int i = this.worldObj.getBlockId(this.xTile, this.yTile, this.zTile);

if (i > 0)

{

Block.blocksList.setBlockBoundsBasedOnState(this.worldObj, this.xTile, this.yTile, this.zTile);

AxisAlignedBB axisalignedbb = Block.blocksList.getCollisionBoundingBoxFromPool(this.worldObj, this.xTile, this.yTile, this.zTile);

if (axisalignedbb != null && axisalignedbb.isVecInside(this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX, this.posY, this.posZ)))

{

this.inGround = true;

}

if (this.arrowShake > 0)

{

--this.arrowShake;

}

if (this.inGround)

{

int j = this.worldObj.getBlockId(this.xTile, this.yTile, this.zTile);

int k = this.worldObj.getBlockMetadata(this.xTile, this.yTile, this.zTile);

if (j == this.inTile && k == this.inData)

{

++this.ticksInGround;

if (this.ticksInGround == 1200)

{

this.setDead();

}

else

{

this.inGround = false;

this.motionX *= (double)(this.rand.nextFloat() * 0.2F);

this.motionY *= (double)(this.rand.nextFloat() * 0.2F);

this.motionZ *= (double)(this.rand.nextFloat() * 0.2F);

this.ticksInGround = 0;

this.ticksInAir = 0;

}

else

{

++this.ticksInAir;

Vec3 vec3 = this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX, this.posY, this.posZ);

Vec3 vec31 = this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX + this.motionX, this.posY + this.motionY, this.posZ + this.motionZ);

MovingObjectPosition movingobjectposition = this.worldObj.rayTraceBlocks_do_do(vec3, vec31, false, true);

vec3 = this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX, this.posY, this.posZ);

vec31 = this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX + this.motionX, this.posY + this.motionY, this.posZ + this.motionZ);

if (movingobjectposition != null)

{

vec31 = this.worldObj.getWorldVec3Pool().getVecFromPool(movingobjectposition.hitVec.xCoord, movingobjectposition.hitVec.yCoord, movingobjectposition.hitVec.zCoord);

}

Entity entity = null;

List list = this.worldObj.getEntitiesWithinAABBExcludingEntity(this, this.boundingBox.addCoord(this.motionX, this.motionY, this.motionZ).expand(1.0D, 1.0D, 1.0D));

double d0 = 0.0D;

int l;

float f1;

for (l = 0; l < list.size(); ++l)

{

Entity entity1 = (Entity)list.get(l);

if (entity1.canBeCollidedWith() && (entity1 != this.shootingEntity || this.ticksInAir >= 5))

{

f1 = 0.3F;

AxisAlignedBB axisalignedbb1 = entity1.boundingBox.expand((double)f1, (double)f1, (double)f1);

MovingObjectPosition movingobjectposition1 = axisalignedbb1.calculateIntercept(vec3, vec31);

if (movingobjectposition1 != null)

{

double d1 = vec3.distanceTo(movingobjectposition1.hitVec);

if (d1 < d0 || d0 == 0.0D)

{

entity = entity1;

d0 = d1;

}

if (entity != null)

{

movingobjectposition = new MovingObjectPosition(entity);

}

if (movingobjectposition != null && movingobjectposition.entityHit != null && movingobjectposition.entityHit instanceof EntityPlayer)

{

EntityPlayer entityplayer = (EntityPlayer)movingobjectposition.entityHit;

if (entityplayer.capabilities.disableDamage || this.shootingEntity instanceof EntityPlayer && !((EntityPlayer)this.shootingEntity).canAttackPlayer(entityplayer))

{

movingobjectposition = null;

}

float f2;

float f3;

if (movingobjectposition != null)

{

if (movingobjectposition.entityHit != null)

{

f2 = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionY * this.motionY + this.motionZ * this.motionZ);

int i1 = MathHelper.ceiling_double_int((double)f2 * this.damage);

if (this.getIsCritical())

{

i1 += this.rand.nextInt(i1 / 2 + 2);

}

DamageSource damagesource = null;

if (this.isBurning() && !(movingobjectposition.entityHit instanceof EntityEnderman))

{

movingobjectposition.entityHit.setFire(5);

}

damagesource = damagesource.causeThrownDamage(this, shootingEntity);

if (movingobjectposition.entityHit.attackEntityFrom(damagesource, (float)i1))

{

if (movingobjectposition.entityHit instanceof EntityLivingBase)

{

EntityLivingBase entitylivingbase = (EntityLivingBase)movingobjectposition.entityHit;

if (!this.worldObj.isRemote)

{

entitylivingbase.setArrowCountInEntity(entitylivingbase.getArrowCountInEntity() + 1);

}

if (this.knockbackStrength > 0)

{

f3 = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionZ * this.motionZ);

if (f3 > 0.0F)

{

movingobjectposition.entityHit.addVelocity(this.motionX * (double)this.knockbackStrength * 0.6000000238418579D / (double)f3, 0.1D, this.motionZ * (double)this.knockbackStrength * 0.6000000238418579D / (double)f3);

}

if (this.shootingEntity != null)

{

EnchantmentThorns.func_92096_a(this.shootingEntity, entitylivingbase, this.rand);

}

if (this.shootingEntity != null && movingobjectposition.entityHit != this.shootingEntity && movingobjectposition.entityHit instanceof EntityPlayer && this.shootingEntity instanceof EntityPlayerMP)

{

((EntityPlayerMP)this.shootingEntity).playerNetServerHandler.sendPacketToPlayer(new Packet70GameEvent(6, 0));

}

this.playSound("random.bowhit", 1.0F, 1.2F / (this.rand.nextFloat() * 0.2F + 0.9F));

if (!(movingobjectposition.entityHit instanceof EntityEnderman))

{

this.setDead();

}

else

{

this.motionX *= -0.10000000149011612D;

this.motionY *= -0.10000000149011612D;

this.motionZ *= -0.10000000149011612D;

this.rotationYaw += 180.0F;

this.prevRotationYaw += 180.0F;

this.ticksInAir = 0;

}

else

{

this.xTile = movingobjectposition.blockX;

this.yTile = movingobjectposition.blockY;

this.zTile = movingobjectposition.blockZ;

this.inTile = this.worldObj.getBlockId(this.xTile, this.yTile, this.zTile);

this.inData = this.worldObj.getBlockMetadata(this.xTile, this.yTile, this.zTile);

this.motionX = (double)((float)(movingobjectposition.hitVec.xCoord - this.posX));

this.motionY = (double)((float)(movingobjectposition.hitVec.yCoord - this.posY));

this.motionZ = (double)((float)(movingobjectposition.hitVec.zCoord - this.posZ));

f2 = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionY * this.motionY + this.motionZ * this.motionZ);

this.posX -= this.motionX / (double)f2 * 0.05000000074505806D;

this.posY -= this.motionY / (double)f2 * 0.05000000074505806D;

this.posZ -= this.motionZ / (double)f2 * 0.05000000074505806D;

this.playSound("random.bowhit", 1.0F, 1.2F / (this.rand.nextFloat() * 0.2F + 0.9F));

this.inGround = true;

this.arrowShake = 7;

this.setIsCritical(false);

if (this.inTile != 0)

{

Block.blocksList[this.inTile].onEntityCollidedWithBlock(this.worldObj, this.xTile, this.yTile, this.zTile, this);

}

if (this.getIsCritical())

{

for (l = 0; l < 4; ++l)

{

this.worldObj.spawnParticle("crit", this.posX + this.motionX * (double)l / 4.0D, this.posY + this.motionY * (double)l / 4.0D, this.posZ + this.motionZ * (double)l / 4.0D, -this.motionX, -this.motionY + 0.2D, -this.motionZ);

}

this.posX += this.motionX;

this.posY += this.motionY;

this.posZ += this.motionZ;

f2 = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionZ * this.motionZ);

this.rotationYaw = (float)(Math.atan2(this.motionX, this.motionZ) * 180.0D / Math.PI);

for (this.rotationPitch = (float)(Math.atan2(this.motionY, (double)f2) * 180.0D / Math.PI); this.rotationPitch - this.prevRotationPitch < -180.0F; this.prevRotationPitch -= 360.0F)

{

;

}

while (this.rotationPitch - this.prevRotationPitch >= 180.0F)

{

this.prevRotationPitch += 360.0F;

}

while (this.rotationYaw - this.prevRotationYaw < -180.0F)

{

this.prevRotationYaw -= 360.0F;

}

while (this.rotationYaw - this.prevRotationYaw >= 180.0F)

{

this.prevRotationYaw += 360.0F;

}

this.rotationPitch = this.prevRotationPitch + (this.rotationPitch - this.prevRotationPitch) * 0.2F;

this.rotationYaw = this.prevRotationYaw + (this.rotationYaw - this.prevRotationYaw) * 0.2F;

float f4 = 0.99F;

f1 = 0.05F;

if (this.isInWater())

{

for (int j1 = 0; j1 < 4; ++j1)

{

f3 = 0.25F;

this.worldObj.spawnParticle("bubble", this.posX - this.motionX * (double)f3, this.posY - this.motionY * (double)f3, this.posZ - this.motionZ * (double)f3, this.motionX, this.motionY, this.motionZ);

}

f4 = 0.8F;

}

this.motionX *= (double)f4;

this.motionY *= (double)f4;

this.motionZ *= (double)f4;

this.motionY -= (double)f1;

this.setPosition(this.posX, this.posY, this.posZ);

this.doBlockCollisions();

}

/**

* (abstract) Protected helper method to write subclass entity data to NBT.

*/

public void writeEntityToNBT(NBTTagCompound par1NBTTagCompound)

{

par1NBTTagCompound.setShort("xTile", (short)this.xTile);

par1NBTTagCompound.setShort("yTile", (short)this.yTile);

par1NBTTagCompound.setShort("zTile", (short)this.zTile);

par1NBTTagCompound.setByte("inTile", (byte)this.inTile);

par1NBTTagCompound.setByte("inData", (byte)this.inData);

par1NBTTagCompound.setByte("shake", (byte)this.arrowShake);

par1NBTTagCompound.setByte("inGround", (byte)(this.inGround ? 1 : 0));

par1NBTTagCompound.setByte("pickup", (byte)this.canBePickedUp);

par1NBTTagCompound.setDouble("damage", this.damage);

}

/**

* (abstract) Protected helper method to read subclass entity data from NBT.

*/

public void readEntityFromNBT(NBTTagCompound par1NBTTagCompound)

{

this.xTile = par1NBTTagCompound.getShort("xTile");

this.yTile = par1NBTTagCompound.getShort("yTile");

this.zTile = par1NBTTagCompound.getShort("zTile");

this.inTile = par1NBTTagCompound.getByte("inTile") & 255;

this.inData = par1NBTTagCompound.getByte("inData") & 255;

this.arrowShake = par1NBTTagCompound.getByte("shake") & 255;

this.inGround = par1NBTTagCompound.getByte("inGround") == 1;

if (par1NBTTagCompound.hasKey("damage"))

{

this.damage = par1NBTTagCompound.getDouble("damage");

}

if (par1NBTTagCompound.hasKey("pickup"))

{

this.canBePickedUp = par1NBTTagCompound.getByte("pickup");

}

else if (par1NBTTagCompound.hasKey("player"))

{

this.canBePickedUp = par1NBTTagCompound.getBoolean("player") ? 1 : 0;

}

/**

* Called by a player entity when they collide with an entity

*/

public void onCollideWithPlayer(EntityPlayer par1EntityPlayer)

{

if (!this.worldObj.isRemote && this.inGround && this.arrowShake <= 0)

{

boolean flag = this.canBePickedUp == 1 || this.canBePickedUp == 2 && par1EntityPlayer.capabilities.isCreativeMode;

if (this.canBePickedUp == 1 && !par1EntityPlayer.inventory.addItemStackToInventory(new ItemStack(Item.arrow, 1)))

{

flag = false;

}

if (flag)

{

this.playSound("random.pop", 0.2F, ((this.rand.nextFloat() - this.rand.nextFloat()) * 0.7F + 1.0F) * 2.0F);

par1EntityPlayer.onItemPickup(this, 1);

this.setDead();

}

/**

* returns if this entity triggers Block.onEntityWalking on the blocks they walk on. used for spiders and wolves to

* prevent them from trampling crops

*/

protected boolean canTriggerWalking()

{

return false;

}

@SideOnly(Side.CLIENT)

public float getShadowSize()

{

return 0.0F;

}

public void setDamage(double par1)

{

this.damage = par1;

}

public double getDamage()

{

return this.damage;

}

/**

* Sets the amount of knockback the arrow applies when it hits a mob.

*/

public void setKnockbackStrength(int par1)

{

this.knockbackStrength = par1;

}

/**

* If returns false, the item will not inflict any damage against entities.

*/

public boolean canAttackWithItem()

{

return false;

}

/**

* Whether the arrow has a stream of critical hit particles flying behind it.

*/

public void setIsCritical(boolean par1)

{

byte b0 = this.dataWatcher.getWatchableObjectByte(16);

if (par1)

{

this.dataWatcher.updateObject(16, Byte.valueOf((byte)(b0 | 1)));

}

else

{

this.dataWatcher.updateObject(16, Byte.valueOf((byte)(b0 & -2)));

}

/**

* Whether the arrow has a stream of critical hit particles flying behind it.

*/

public boolean getIsCritical()

{

byte b0 = this.dataWatcher.getWatchableObjectByte(16);

return (b0 & 1) != 0;

}

Bow Class:

package mymod.items;

import cpw.mods.fml.relauncher.Side;

import cpw.mods.fml.relauncher.SideOnly;

import mymod.Main;

import mymod.entity.projectile.MyArrow;

import net.minecraft.client.renderer.texture.IconRegister;

import net.minecraft.creativetab.CreativeTabs;

import net.minecraft.enchantment.Enchantment;

import net.minecraft.enchantment.EnchantmentHelper;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.entity.projectile.EntityArrow;

import net.minecraft.item.EnumAction;

import net.minecraft.item.Item;

import net.minecraft.item.ItemBow;

import net.minecraft.item.ItemStack;

import net.minecraft.util.Icon;

import net.minecraft.world.World;

import net.minecraftforge.common.MinecraftForge;

import net.minecraftforge.event.entity.player.ArrowLooseEvent;

import net.minecraftforge.event.entity.player.ArrowNockEvent;

public class MyBow extends ItemBow

{

public static final String[] bowPullIconNameArray = new String[] {"pulling_0", "pulling_1", "pulling_2", "pulling_3"};

@SideOnly(Side.CLIENT)

private Icon[] iconArray;

private boolean power;

public MyBow(int par1)

{

super(par1);

this.maxStackSize = 1;

this.setMaxDamage(434);

this.setCreativeTab(CreativeTabs.tabCombat);

}

/**

* called when the player releases the use item button. Args: itemstack, world, entityplayer, itemInUseCount

*/

public void onPlayerStoppedUsing(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer, int par4)

{

int j = this.getMaxItemUseDuration(par1ItemStack) - par4;

ArrowLooseEvent event = new ArrowLooseEvent(par3EntityPlayer, par1ItemStack, j);

MinecraftForge.EVENT_BUS.post(event);

if (event.isCanceled())

{

return;

}

j = event.charge;

boolean flag = par3EntityPlayer.capabilities.isCreativeMode || EnchantmentHelper.getEnchantmentLevel(Enchantment.infinity.effectId, par1ItemStack) > 0;

if (flag || par3EntityPlayer.inventory.hasItem(Main.MyItem_3.itemID))

{

if(power){

//entityarrow.setDamage(entityarrow.getDamage() + (double)5 * 0.5D + 0.5D);

//entityarrow.setFire(100);

}

float f = (float)j / 20.0F;

f = (f * f + f * 2.0F) / 3.0F;

if ((double)f < 0.1D)

{

return;

}

if (f > 1.0F)

{

f = 1.0F;

}

MyArrow entityarrow = new MyArrow(par2World, par3EntityPlayer, f * 2.0F);

if (f == 1.0F)

{

entityarrow.setIsCritical(true);

}

int k = EnchantmentHelper.getEnchantmentLevel(Enchantment.power.effectId, par1ItemStack);

if (k > 0)

{

entityarrow.setDamage(entityarrow.getDamage() + (double)k * 0.5D + 0.5D);

}

int l = EnchantmentHelper.getEnchantmentLevel(Enchantment.punch.effectId, par1ItemStack);

if (l > 0)

{

entityarrow.setKnockbackStrength(l);

}

if (EnchantmentHelper.getEnchantmentLevel(Enchantment.flame.effectId, par1ItemStack) > 0)

{

entityarrow.setFire(100);

}

par1ItemStack.damageItem(1, par3EntityPlayer);

par2World.playSoundAtEntity(par3EntityPlayer, "random.bow", 1.0F, 1.0F / (itemRand.nextFloat() * 0.4F + 1.2F) + f * 0.5F);

if (flag)

{

entityarrow.canBePickedUp = 2;

}

else

{

par3EntityPlayer.inventory.consumeInventoryItem(Main.MyItem_3.itemID);

}

if (!par2World.isRemote)

{

par2World.spawnEntityInWorld(entityarrow);

}

public ItemStack onEaten(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)

{

return par1ItemStack;

}

/**

* How long it takes to use or consume an item

*/

public int getMaxItemUseDuration(ItemStack par1ItemStack)

{

return 72000;

}

/**

* returns the action that specifies what animation to play when the items is being used

*/

public EnumAction getItemUseAction(ItemStack par1ItemStack)

{

return EnumAction.bow;

}

/**

* Called whenever this item is equipped and the right mouse button is pressed. Args: itemStack, world, entityPlayer

*/

public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)

{

ArrowNockEvent event = new ArrowNockEvent(par3EntityPlayer, par1ItemStack);

MinecraftForge.EVENT_BUS.post(event);

if (event.isCanceled())

{

return event.result;

}

if (par3EntityPlayer.capabilities.isCreativeMode || par3EntityPlayer.inventory.hasItem(Main.MyItem_3.itemID))

{

par3EntityPlayer.setItemInUse(par1ItemStack, this.getMaxItemUseDuration(par1ItemStack));

}

return par1ItemStack;

}

/**

* Return the enchantability factor of the item, most of the time is based on material.

*/

public int getItemEnchantability()

{

return 1;

}

public void registerIcons(IconRegister par1IconRegister)

{

this.itemIcon = par1IconRegister.registerIcon("mymod:" + (this.getUnlocalizedName().substring(5)) + "_standby");

this.iconArray = new Icon[bowPullIconNameArray.length];

for (int i = 0; i < this.iconArray.length; ++i)

{

this.iconArray = par1IconRegister.registerIcon("mymod:" + (this.getUnlocalizedName().substring(5)) + "_" + bowPullIconNameArray);

}

@Override

@SideOnly(Side.CLIENT)

public Icon getIcon(ItemStack stack, int renderPass, EntityPlayer player, ItemStack usingItem, int useRemaining) {

if (usingItem == null) { return itemIcon; }

int ticksInUse = stack.getMaxItemUseDuration() - useRemaining;

if(ticksInUse > 30){

return iconArray[3];

} else if (ticksInUse > 18) {

return iconArray[2];

} else if (ticksInUse > 14) {

return iconArray[1];

} else if (ticksInUse > 0) {

return iconArray[0];

} else {

return itemIcon;

}

I hope you can help me!

Sign In

Arrow Projectile Entity fades back

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Join the conversation

Announcements

Recently Browsing

Posts

Topics

Who's Online (See full list)

Important Information