Hello, thank you for reading!

I am working with a custom crop that functions similar to potatoes in terms of drops. With what I have right now, when I run DataGen I get an error that says:

java.lang.IllegalStateException: Created block loot tables for non-blocks: [pokemonmd:blocks/oranian_berry_crop]

This seems to be a related to how I register my crop block here https://github.com/SpikybumJolteon/PokemonMD-1.20.1/blob/master/src/main/java/net/spikybumjolteon/pokemonmd/common/core/ModBlocks.java

private static <T extends Block> RegistryObject<T> registerNoItem(String name, Supplier<? extends T> sup) {
        return BLOCKS.register(name, sup);
    }

public static final RegistryObject<Block> ORANIAN_BERRY_CROP = registerNoItem("oranian_berry_crop",
            () -> new OranianBerryCropBlock(BlockBehaviour.Properties.copy(Blocks.POTATOES).noOcclusion().noCollission()));

When I switch registration to this function, DataGen works just fine but it creates the block in Creative Mode Tab:

private static <T extends Block> RegistryObject<T> register(String name, Supplier<? extends T> sup) {
        return register(name, sup, ModBlocks::itemDefault);
    }

    private static <T extends Block> RegistryObject<T> register(String name, Supplier<? extends T> sup, Function<RegistryObject<T>, Supplier<? extends Item>> itemCreator) {
        RegistryObject<T> ret = registerNoItem(name, sup);
        ITEMS.register(name, itemCreator.apply(ret));
        return ret;
    }

Here is the Loot Table DataGen I have https://github.com/SpikybumJolteon/PokemonMD-1.20.1/blob/master/src/main/java/net/spikybumjolteon/pokemonmd/datagen/ModLootTableProvider.java

LootItemCondition.Builder lootitemcondition$builder = LootItemBlockStatePropertyCondition
                    .hasBlockStateProperties(ModBlocks.ORANIAN_BERRY_CROP.get())
                    .setProperties(StatePropertiesPredicate.Builder.properties().hasProperty(OranianBerryCropBlock.AGE, OranianBerryCropBlock.MAX_AGE));

            this.add(ModBlocks.ORANIAN_BERRY_CROP.get(), this.applyExplosionDecay(ModBlocks.ORANIAN_BERRY_CROP.get(),
                    LootTable.lootTable().withPool(LootPool.lootPool()
                            .add(LootItem.lootTableItem(ModItems.ORANIAN_BERRY.get())))
                            .withPool(LootPool.lootPool().when(lootitemcondition$builder)
                                    .add(LootItem.lootTableItem(ModItems.ORANIAN_BERRY.get())
                                            .apply(ApplyBonusCount.addBonusBinomialDistributionCount(Enchantments.BLOCK_FORTUNE, 0.5714286F, 3))))
                            .withPool(LootPool.lootPool().when(lootitemcondition$builder).add(LootItem.lootTableItem(ModItems.REVIVE_SEED.get())
                                    .when(LootItemRandomChanceCondition.randomChance(0.9F))))));

What is the proper way to register the Crop Block so the DataGen Loot Table will run while still omitting the block from Creative Tab?

Apologies in advance if I am doing something wrong with this post or with Github, as I am very new to Github and only just returned to programming after 2 years since 1.15.

 

Should I just try to change my Creative Tab item listing to suppress listing the Crop Block and just go with it generating an item block for it?

It's an old thread but there is no posted answer and I was experiencing this mysterious error message today as well.
The error message in question:

java.lang.IllegalStateException: Created block loot tables for non-blocks:

This is triggered when a loot table is being generated for a block that is unknown to the builder. To tell the builder a block exists, you need to override the getKnownBlocks method. For example, consider the following class snippet where we define a DeferredRegister for blocks:

public class ModBlocks {
    public static final DeferredRegister<Block> BLOCKS =
            DeferredRegister.create(ForgeRegistries.BLOCKS, MOD_ID);   
      
    public static final RegistryObject<Block> MY_BLOCK = registerBlock("my_block",
            () -> new Block(BlockBehaviour.Properties.ofFullCopy(Blocks.GRANITE)));

    // ... Other blocks 
      
    public static void register(IEventBus eventBus) {
        BLOCKS.register(eventBus);
    }
}

We need to then tell the loot table builder that this block should have a loot table generated in our loot table generation class. This might look look like:

public class ModBlockLootTables extends BlockLootSubProvider {
    private final List<Block> VANILLA_BLOCKS_CHANGED = List.of(Blocks.CLAY);

    public ModBlockLootTables() {
        super(Set.of(), FeatureFlags.REGISTRY.allFlags());
    }

    @Override
    protected void generate() {
        // Some vanilla block with a loot table we are changing:
        this.add(Blocks.CLAY, block -> createSingleItemTableWithSilkTouch(block, Items.CLAY_BALL, ConstantValue.exactly(9.0F)));
        // Our block we are also defining a loot table for:
        this.dropSelf(ModBlocks.MY_BLOCK.get());
        
        // ... Other blocks
    }

    @Override
    protected @NotNull Iterable<Block> getKnownBlocks() {
        ArrayList<Block> iterableBlocks = new ArrayList<>(); // define empty list
        // Iterate through each block registered into ModBlocks.BLOCKS and add it into our list:
        ModBlocks.BLOCKS.getEntries().stream().map(RegistryObject::get).forEach(iterableBlocks::add);
        // The above line requires that we need to have defined a loot table for every block in ModBlocks.BLOCKS.
        // Also add the vanilla blocks we are updating:
        iterableBlocks.addAll(VANILLA_BLOCKS_CHANGED);

        return iterableBlocks;
    }
}

Note that in this example, I demonstrate additionally how if you are overwriting a loot table for a vanilla block, you must also tell the builder that vanilla block exists.

This solution does depend on some quirks of a developer's implementation; if you're looking for more detail, feel free to visit my GitHub for where these code snippets originate: Tech++

Hope this helps.

Edited April 1, 20241 yr by deddybones
Added some comments to the code

Thank you so much for replying to this. I tried out your recommendation in place of what I had and it fixed my problem!

It helped me better understand streams/lambda and see what I had done wrong.