Jump to content

Recommended Posts

Posted (edited)

Hi, I'm trying to get into Mixin.

My test code accesses the private attribute fps in the Minecraft class.
In the development environment (IntelliJ), it outputs the FPS, as I expected it would.
But when I try it in the normal Minecraft, it crashes, and I'm not sure why.

The Mixin Code:

@Mixin(Minecraft.class)
public interface MinecraftMixin {

    @Accessor("fps")
    int getFps();
}

How I call the mixin code:

@SubscribeEvent
public void onTick(ClientTickEvent event) {

    if (Minecraft.getInstance().player == null) {
        return;
    }

    if (Minecraft.getInstance().player.isCrouching()) {
        int test = ((MinecraftMixin)Minecraft.getInstance()).getFps();
        LOGGER.info(String.valueOf(test));
    }
}

Crashlog:

https://paste.ee/p/PtO7B

Edited by Top-Set98

๐ŸŸ๐Ÿ ๐Ÿก

Posted
On 5/28/2024 at 5:55 PM, a_random_something said:

Having the same problem. Could you let me know if you ever figure it out? :)

If I find something, of course.

ย 

I have tried a bit but I can't get mixin to run on 1.20.6 even with the latest version: 1.20.6 - 50.1.1.

๐ŸŸ๐Ÿ ๐Ÿก

  • 2 weeks later...
Posted (edited)

I figured it out! Here's how I solved it:

I added:

"refmap": "<your_mod_id>.mixins.refmap.json" to my mixin json file and that solved it. You'll also need to add:

add sourceSets.main, '<your_mod_id>.mixins.refmap.json' to your build.gradle in the "mixin" block

ย 

my mixin file looks like this:

ย 

{
  "required": true,
  "minVersion": "0.8",
  "package": "<your_package>.<your_modid>.mixin",
  "compatibilityLevel": "JAVA_16",
  "refmap": "<your_mod_id>.mixins.refmap.json",
  "mixins": [
    "YourMixin1",
    "YourMixin2"
  ],
  "client": [
  ],
  "injectors": {
    "defaultRequire": 1
  }
}

This was in 1.19.2, but I don't think it should be too different

Edited by a_random_something
Posted (edited)

My sample mod has the refmap in the mixin json file as well as "add sourceSets.main" in the "mixin" block. It is like in the documentation.

ย 

mixinย json:

{
    "required": true,
    "minVersion": "0.8",
    "package": "com.example.examplemod.mixin",
    "compatibilityLevel": "JAVA_17",
    "refmap": "mixins.ExampleMod.refmap.json",
    "mixins": [
      "MinecraftMixin"
    ],
    "injectors": {
      "defaultRequire": 1
    }
  }

ย 

mixin block in build.gradle


mixin {
    // MixinGradle Settings
    add sourceSets.main, 'mixins.ExampleMod.refmap.json'
    config 'mixins.ExampleMod.json'
}

ย 

On 6/18/2024 at 12:41 AM, a_random_something said:

This was in 1.19.2, but I don't think it should be too different


I tried it on another Minecraft version (1.19.2 and 1.20.1) and it works.
As soon as I try Minecraft version 1.20.6 or higher it does not work anymore.

Edited by Top-Set98

๐ŸŸ๐Ÿ ๐Ÿก

  • 3 weeks later...
Posted

Try modify the build.gradle by:

1. Addย 

'MixinConfigs'            : "${mod_id}.mixins.json"

to the attributes array

tasks.named('jar', Jar).configure {
    manifest {
        attributes([
				....
		  ])
    }
}

2. Add a new block after the mixin block

sourceSets {
    main {
        ext.refMap = "${modid}.refmap.json"
    }
}

ย 

  • Thanks 1
Posted

Thank you very much!

After adding MixinConfigs to the attributes array, it works now.

Does the development environment load the MixinConfigs automatically or why is it only needed for normal Minecraft?

๐ŸŸ๐Ÿ ๐Ÿก

Posted
On 7/13/2024 at 3:13 AM, Top-Set98 said:

Does the development environment load the MixinConfigs automatically or why is it only needed for normal Minecraft?

The compiler seems could auto load the MixinConfigs in the version below 1.20.6, but it didnt work from 1.20.6. I just modified the jar file to zip and found the META-INF/MANIFEST.MF is lack of "MixinConfigs" compared with the lower version, while the build.gradle are same. So I manual added it to fix the problem.

I dont know the implmentation of this process, but a different is in 1.20.6 the jar task deleted the reobfJar task, maybe this leads the problem?

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I canโ€™t control it. I then discovered that the issue is that the server doesnโ€™t detect that Iโ€™m riding the wolf, so Iโ€™m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesnโ€™t register it correctly. Iโ€™m a bit new to Java, and Iโ€™ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } } ย 
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.