Jump to content

Do action on client player LivingDeathEvent


Naamah

Recommended Posts

Hello, I've been trying to get this to work forever. I have some code that gives an item when a player joins and I've been using that as a base, but it hasn't been working.

This is my current code:

@SubscribeEvent
    public void playerKilled(LivingDeathEvent event){
        if (event.getEntity() instanceof Player && !event.getEntity().isDeadOrDying()) {
            Player player = (Player) event.getEntity();
            if (player.getInventory().contains(new ItemStack(ModItems.FIRE_PROTECTION_POPPET.get()))) {
                player.getInventory().removeItem(new ItemStack(ModItems.FIRE_PROTECTION_POPPET.get()));
            }
        }
    }

In a sense, I am trying to "use up" the item when the player dies without them literally dying (like the totem of undying). I'm not exactly sure how to check the way the totem of undying works, but any tips would be appreciated.

tenor.gif?itemid=27352888

 

Not even gonna lie, I think I have autism

Link to comment
Share on other sites

14 hours ago, Naamah said:

Hello, I've been trying to get this to work forever. I have some code that gives an item when a player joins and I've been using that as a base, but it hasn't been working.

This is my current code:

@SubscribeEvent
    public void playerKilled(LivingDeathEvent event){
        if (event.getEntity() instanceof Player && !event.getEntity().isDeadOrDying()) {
            Player player = (Player) event.getEntity();
            if (player.getInventory().contains(new ItemStack(ModItems.FIRE_PROTECTION_POPPET.get()))) {
                player.getInventory().removeItem(new ItemStack(ModItems.FIRE_PROTECTION_POPPET.get()));
            }
        }
    }

In a sense, I am trying to "use up" the item when the player dies without them literally dying (like the totem of undying). I'm not exactly sure how to check the way the totem of undying works, but any tips would be appreciated.

when you say that it isnt working what specifically isnt working because you are now talking about remaking totem of undying for your custom item. Im going to assume you are wondering how to make your player not die. Just cancel the event. You can read the docs on LivingDeathEvent here

for future reference, you need to look up the class in your IDE. For IntelliJ its Ctrl+N

  • Like 1
Link to comment
Share on other sites

Posted (edited)
14 hours ago, sfxprt2 said:

when you say that it isnt working what specifically isnt working because you are now talking about remaking totem of undying for your custom item. Im going to assume you are wondering how to make your player not die. Just cancel the event. You can read the docs on LivingDeathEvent here

for future reference, you need to look up the class in your IDE. For IntelliJ its Ctrl+N

Thanks for the response. I ended up going with this:
 

public class PlayerDeathHandler {

    @SubscribeEvent
    public void playerKilled(LivingDeathEvent event) {
        if (event.getEntity() instanceof Player player) {
            ItemStack poppetStack = new ItemStack(ModItems.DEATH_PROTECTION_POPPET.get());

            if (player.getInventory().contains(poppetStack)) {
                event.setCanceled(true);
                
                player.setHealth(player.getMaxHealth());
                
                for (int i = 0; i < player.getInventory().getContainerSize(); i++) {
                    ItemStack stackInSlot = player.getInventory().getItem(i);
                    if (stackInSlot.getItem() == poppetStack.getItem()) {
                        stackInSlot.shrink(1);
                        if (stackInSlot.isEmpty()) {
                            player.getInventory().setItem(i, ItemStack.EMPTY);
                        }
                        break;
                    }
                }
            }
        }
    }
}

It works like a charm, but are there any issues that COULD arise using this? I don't have much experience with Forge, so I'm not sure about the common issues and whatnot.

Edited by Naamah

tenor.gif?itemid=27352888

 

Not even gonna lie, I think I have autism

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Please share a link to your crash report on https://paste.ee, as explained in the FAQ. Dumping it directly into the thread often triggers the anti-spam and makes it hard to read due to word wrapping
    • Hi all, I'm running a 1.20.1 Minecraft Forge server with a hosting website and something seems to have gone wrong. It started as an occasional crash that has now become extremely frequent and I don't know what exactly is causing it. I already tried disabling watchdog but the server crashes anyway. Oddly it only occasionally generates a crash report after a crash occurs. Based on viewing the server console's research usage it seems that the CPU spikes astronomically high (100% usage), especially when chunks are being loaded or when a new person joins the server. I downloaded Spark to create a profile (https://spark.lucko.me/bBlWe7ou29) but I lack experience with this mod and don't understand what I'm looking at/how this should help me diagnose the issue. I am using a lot of mods so I'm guessing there is some sort of issue there or a corrupted chunk (although MCRF found no chunk errors). We actually don't experience any lag until the crash occurs, so it's some sort of sudden spike in resource usage. Based on the crash report I've already tried removing Canary and Modernfix but there was no change. Thanks for any help you can provide. Specs:  4 cores x 4200MHz AMD Ryzen 9 5950X 4GB RAM Crash report:  
    • will test that once i get home, thanks
    • I am getting this exception (I am new and just trying to create an item) Caused by: java.io.FileNotFoundException: abrasmagics:models/item/ingot_test.json at net.minecraft.client.resources.SimpleReloadableResourceManager.getResource(SimpleReloadableResourceManager.java:69) ~[SimpleReloadableResourceManager.class:?] at net.minecraft.client.renderer.block.model.ModelBakery.loadModel(ModelBakery.java:334) ~[ModelBakery.class:?] at net.minecraftforge.client.model.ModelLoader.access$1400(ModelLoader.java:115) ~[ModelLoader.class:?] at net.minecraftforge.client.model.ModelLoader$VanillaLoader.loadModel(ModelLoader.java:861) ~[ModelLoader$VanillaLoader.class:?] at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:157) ~[ModelLoaderRegistry.class:?]   However the directory is set up correctly and the file does exist   idk how to upload images so here is a treeview of the directories:   src ├───main │ ├───java │ │ └───net │ │ └───abrasmods │ │ └───abrasmagics │ │ ├───init │ │ ├───items │ │ └───utils │ │ ├───handlers │ │ ├───misc │ │ └───proxy │ └───resources │ └───assets │ └───abrasmagics │ ├───models │ │ ├───block │ │ └───item │ └───textures └───test ├───java └───resources   the file ingot_test.json is under models/item. The directory seems fine and the file does exist so anyone plz help.   i am using intellij and is coding for 1.12.2
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.