1.21.4 - Item textures not displaying

[chxr]

I recently updated my mod from 1.21 to 1.21.4. Didn't change anything on the data generation code (even though methods are now marked as deprecated) and had to change the block and item registration to explicitly add the id to avoid the "null pointer exception no id supplied" error

The problem is that the block models work fine, as they did before, textures and all, but not the item ones. Is it because of this registration change? Did something in the datapack structure change on minecraft itself?

 

Here is one of the registration lines im using as reference:

 

RegistryObject<Item> CUSTOMITEM = ITEMS.register("item", () -> new RawMaterial(new Item.Properties().useItemDescriptionPrefix().setId(ResourceKey.create(Registries.ITEM, ResourceLocation.fromNamespaceAndPath(MOD_ID, "item"))))));

 

and same for blocks:

 

private static <T extends Block> RegistryObject<Item> registerBlockItem(String name, RegistryObject<T> block) {

    //T is the block type. It will register the block and the block item.

    return ModItems.ITEMS.register(name, () -> new BlockItem(block.get(), new Item.Properties().useBlockDescriptionPrefix().setId(ResourceKey.create(Registries.ITEM, ResourceLocation.fromNamespaceAndPath(MOD_ID, name)))));

}

RegistryObject<Block> CUSTOMORE = registerBlock("ore", () -> new CustomOre(Block.Properties.ofFullCopy(Blocks.STONE).setId(ResourceKey.create(Registries.BLOCK, ResourceLocation.fromNamespaceAndPath(MOD_ID,"ore"))))));

 

Note that this made the translation keys i had pre 1.21.4 correctly show the translatable component, so im guessing that is okay, but just in case.

 

Edited January 23 by chxr

[Ezio214]

I haven't tested it but under https://minecraft.wiki/w/Items_model_definition it says now:

Quote

The item model definitions are stored as JSON files in a resource pack in the assets/<namespace>/items folder.

 

So I guess the resource location must have changed with 1.24.4, which means you need to move your models/item/ to the new source.

But as I said I haven't tested this so it also may be that this wont work. Nevertheless give it a try 

 

 

EDIT (important)

So now I tested it and found out how it works
 

Let the model files (e.g. the .json from blockbench) within "assets/<your_mod_id>/models/item"

In addition to that do the following:

Every model you added will need a new file under "assets/<your_mod_id>/items" That file is also a JSON and looks like this:

{
	"model": {
		"type": "minecraft:model",
		"model": "your_mod_id:item/custom_item"
	}
}

- "type" can be minecraft:model, minecraft:composite, minecraft:condition, minecraft:select, minecraft:range_dispatch, minecraft:empty, minecraft:bundle/selected_item or minecraft:special. (In most cases you would need minecraft:model)

- "model" is the path to your actual model for this item. For example the value above would point to "assets/your_mod_id/models/item/custom_item"

Edited January 23 by Ezio214
additional information