Jump to content

Recommended Posts

Posted

I'm currently messing around with the persisted NBT tag in the player, and the integer won't save:

	NBTTagCompound nbt = player.getEntityData().getCompoundTag(EntityPlayer.PERSISTED_NBT_TAG);
	nbt.setInteger("EnderStorageExp", nbt.getInteger("EnderStorageExp") + 1);

 

I have this code inside of a packet that gets called pretty frequently. Here's the full class:

package enderstorage.network;

import io.netty.buffer.ByteBuf;
import io.netty.channel.ChannelHandlerContext;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.nbt.NBTTagCompound;
import enderstorage.EnderStorage;

public class PacketRequestChangeExp extends AbstractPacket {
public int exp = 0;

public PacketRequestChangeExp setExp(int exp) {
	this.exp = exp;
	return this;
}

@Override
public void encodeInto(ChannelHandlerContext ctx, ByteBuf buffer) {
	buffer.writeInt(exp);
}

@Override
public void decodeInto(ChannelHandlerContext ctx, ByteBuf buffer) {
	exp = buffer.readInt();
}

@Override
public void handleClientSide(EntityPlayer player) {
}

@Override
public void handleServerSide(EntityPlayer player) {
	NBTTagCompound nbt = player.getEntityData().getCompoundTag(EntityPlayer.PERSISTED_NBT_TAG);
	nbt.setInteger("EnderStorageExp", nbt.getInteger("EnderStorageExp") + 1);
	EnderStorage.packetHandler.sendTo(new PacketRefreshExp().setExp(nbt.getInteger("EnderStorageExp")), (EntityPlayerMP) player);
}
}

 

The default value of the tag is 0. When it's 0 and the code it called, it goes up to 1. If it's 1, it just keeps setting itself to 1.

Kain

Posted

It would appear you aren't storing your key, not the integer, so when you call the get method it just returns 0 by default. Never done anything like this before though so I couldn't shed any light on how to fix that.

Random question, maybe the cause it isn't stored? Why is this:

public PacketRequestChangeExp setExp(int exp) {
	this.exp = exp;
	return this;
}

returning a packetrequest object if you never use it? It looks like it is meant to be a void, and you use it like that is there any reason it is set up this way?

Posted

The exp field isn't used in anything right now.

 

It returns itself so I can do this:

packetHandler.setToServer(new PacketRequestChangeExp().setExp(10));

Kain

Posted

@Override
// why are you handling the server side only, or at all, when you should just be setting the server side
// data directly via a method to setXP? Are you setting xp on the client side and then sending a packet?
public void handleServerSide(EntityPlayer player) {
NBTTagCompound nbt = player.getEntityData().getCompoundTag(EntityPlayer.PERSISTED_NBT_TAG);
// and here, you are only adding 1 rather than the exp amount from the packet
// so it doesn't matter what you "set" the packet xp to
nbt.setInteger("EnderStorageExp", nbt.getInteger("EnderStorageExp") + 1);
// here you send a packet to the client, but you never handle that packet
EnderStorage.packetHandler.sendTo(new PacketRefreshExp().setExp(nbt.getInteger("EnderStorageExp")), (EntityPlayerMP) player);
}

@Override
public void handleClientSide(EntityPlayer player) {
// see? nothing here...
}

Can you show the code where you add or set the xp initially, rather than just your packet class? Where are you sending this packet from?

Posted

I'm sending this from a GUI

package enderstorage.gui;

import net.minecraft.client.gui.GuiButton;
import net.minecraft.client.gui.inventory.GuiContainer;
import net.minecraft.client.resources.I18n;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.util.ResourceLocation;

import org.lwjgl.opengl.GL11;

import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import enderstorage.EnderStorage;
import enderstorage.container.ContainerExpEnderChest;
import enderstorage.network.PacketRequestChangeExp;
import enderstorage.network.PacketRequestRefresh;
import enderstorage.tileentity.TileEntityExpEnderChest;

//854, 480
@SideOnly(Side.CLIENT)
public class GuiExpEnderChest extends GuiContainer {
private static final ResourceLocation texture = new ResourceLocation("enderstorage:textures/gui/expEnderChest.png");
private EntityPlayer player;

public GuiExpEnderChest(TileEntityExpEnderChest chest, EntityPlayer player) {
	super(new ContainerExpEnderChest(chest));
	this.ySize = 88;
	this.player = player;
}

public void initGui() {
	super.initGui();
	this.buttonList.add(new GuiButton(0, this.width / 2 - 83, this.height / 2 - 10, 20, 20, I18n.format("<<<", new Object[0])));
	this.buttonList.add(new GuiButton(1, this.width / 2 - 63, this.height / 2 - 10, 20, 20, I18n.format("<<", new Object[0])));
	this.buttonList.add(new GuiButton(2, this.width / 2 - 43, this.height / 2 - 10, 20, 20, I18n.format("<", new Object[0])));
	this.buttonList.add(new GuiButton(3, this.width / 2 + 63, this.height / 2 - 10, 20, 20, I18n.format(">>>", new Object[0])));
	this.buttonList.add(new GuiButton(4, this.width / 2 + 43, this.height / 2 - 10, 20, 20, I18n.format(">>", new Object[0])));
	this.buttonList.add(new GuiButton(5, this.width / 2 + 23, this.height / 2 - 10, 20, 20, I18n.format(">", new Object[0])));
	EnderStorage.packetHandler.sendToServer(new PacketRequestRefresh());
}

protected void drawGuiContainerForegroundLayer(int p_146979_1_, int p_146979_2_) {
	String s = I18n.format("container.expEnderChest", new Object[0]);
	this.fontRendererObj.drawString(s, this.xSize / 2 - this.fontRendererObj.getStringWidth(s) / 2, 6, 4210752);
	s = I18n.format("container.expEnderChest.stored", new Object[0]);
	this.fontRendererObj.drawString(s, this.xSize / 2 - this.fontRendererObj.getStringWidth(s) / 2, 35, 4210752);
	s = "" + EnderStorage.currentStored;
	int x = this.xSize / 2 - this.fontRendererObj.getStringWidth(s) / 2;
	int y = 45;
	this.fontRendererObj.drawString(s, x + 1, y, 0);
	this.fontRendererObj.drawString(s, x - 1, y, 0);
	this.fontRendererObj.drawString(s, x, y + 1, 0);
	this.fontRendererObj.drawString(s, x, y - 1, 0);
	this.fontRendererObj.drawString(s, x, y, 8453920);
}

protected void drawGuiContainerBackgroundLayer(float p_146976_1_, int p_146976_2_, int p_146976_3_) {
	GL11.glColor4f(1.0F, 1.0F, 1.0F, 1.0F);
	this.mc.getTextureManager().bindTexture(texture);
	int k = (this.width - this.xSize) / 2;
	int l = (this.height - this.ySize) / 2;
	this.drawTexturedModalRect(k, l, 0, 0, this.xSize, this.ySize);
}

protected void actionPerformed(GuiButton b) {
	switch(b.id) {
	case (0):
		EnderStorage.packetHandler.sendToServer(new PacketRequestChangeExp().setExp(-10));
		break;
	case (1):
		EnderStorage.packetHandler.sendToServer(new PacketRequestChangeExp().setExp(-5));
		break;
	case (2):
		EnderStorage.packetHandler.sendToServer(new PacketRequestChangeExp().setExp(-1));
		break;
	case (3):
		EnderStorage.packetHandler.sendToServer(new PacketRequestChangeExp().setExp(10));
		break;
	case (4):
		EnderStorage.packetHandler.sendToServer(new PacketRequestChangeExp().setExp(5));
		break;
	case (5):
		EnderStorage.packetHandler.sendToServer(new PacketRequestChangeExp().setExp(1));
		break;
	}
}
}

 

I'm not using the exp field because I'm just testing with it.

 

Also the PacketRefreshExp is sent to the client so it'll display it on their gui.

Kain

Posted

I'm not sending the exact packet back. This is the PacketRefreshExp code:

package enderstorage.network;

import io.netty.buffer.ByteBuf;
import io.netty.channel.ChannelHandlerContext;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.nbt.NBTTagCompound;
import enderstorage.EnderStorage;

public class PacketRequestChangeExp extends AbstractPacket {
public int exp = 0;

public PacketRequestChangeExp setExp(int exp) {
	this.exp = exp;
	return this;
}

@Override
public void encodeInto(ChannelHandlerContext ctx, ByteBuf buffer) {
	buffer.writeInt(exp);
}

@Override
public void decodeInto(ChannelHandlerContext ctx, ByteBuf buffer) {
	exp = buffer.readInt();
}

@Override
public void handleClientSide(EntityPlayer player) {
}

@Override
public void handleServerSide(EntityPlayer player) {
	NBTTagCompound nbt = player.getEntityData().getCompoundTag(EntityPlayer.PERSISTED_NBT_TAG);
	System.err.println("Stored: " + nbt.getInteger("EnderStorageExp"));
	nbt.setInteger("EnderStorageExp", nbt.getInteger("EnderStorageExp") + 1);
	EnderStorage.packetHandler.sendTo(new PacketRefreshExp().setExp(nbt.getInteger("EnderStorageExp")), (EntityPlayerMP) player);
}
}

 

As stated before, I'm not using the exp field because I'm testing with it.

 

Additionally, it updates the client just fine.

Kain

Posted

Sorry, I'm getting a bit sleepy.

 

package enderstorage.network;

import io.netty.buffer.ByteBuf;
import io.netty.channel.ChannelHandlerContext;
import net.minecraft.entity.player.EntityPlayer;
import enderstorage.EnderStorage;

public class PacketRefreshExp extends AbstractPacket {
public int exp = 0;

public PacketRefreshExp setExp(int exp) {
	this.exp = exp;
	return this;
}

@Override
public void encodeInto(ChannelHandlerContext ctx, ByteBuf buffer) {
	buffer.writeInt(exp);
}

@Override
public void decodeInto(ChannelHandlerContext ctx, ByteBuf buffer) {
	exp = buffer.readInt();
}

@Override
public void handleClientSide(EntityPlayer player) {
	EnderStorage.currentStored = exp;
}

@Override
public void handleServerSide(EntityPlayer player) {
}
}

Kain

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • The specific issue is that items in my inventory wont stack properly. For instance, if I punch a tree down to collect wood, the first block I collected goes to my hand. So when I punch the second block of wood to collect it, it drops, but instead of stacking with the piece of wood already in my hand, it goes to the second slot in my hotbar instead. Another example is that I'll get some dirt, and then when I'm placing it down later I'll accidentally place a block where I don't want it. When I harvest it again, it doesn't go back to the stack that it came from on my hotbar, where it should have gone, but rather into my inventory. That means that if my inventory is full, then the dirt wont be picked up even though there should be space available in the stack I'm holding. The forge version I'm using is 40.3.0, for java 1.18.2. I'll leave the mods I'm using here, and I'd appreciate it if anybody can point me in the right direction in regards to figuring out how to fix this. I forgot to mention that I think it only happens on my server but I&#39;m not entirely sure. PLEASE HELP ME! LIST OF THE MODS. aaa_particles Adorn AdvancementPlaques AI-Improvements AkashicTome alexsdelight alexsmobs AmbientSounds amwplushies Animalistic another_furniture AppleSkin Aquaculture aquamirae architectury artifacts Atlas-Lib AutoLeveling AutoRegLib auudio balm betterfpsdist biggerstacks biomancy BiomesOPlenty blockui blueprint Bookshelf born_in_chaos Botania braincell BrassAmberBattleTowers brutalbosses camera CasinoCraft cfm (MrCrayfish’s Furniture Mod) chat_heads citadel cloth-config Clumps CMDCam CNB cobweb collective comforts convenientcurioscontainer cookingforblockheads coroutil CosmeticArmorReworked CozyHome CrabbersDelight crashexploitfixer crashutilities Create CreativeCore creeperoverhaul cristellib crittersandcompanions Croptopia CroptopiaAdditions CullLessLeaves curios curiouslanterns curiouslights Curses' Naturals CustomNPCs CyclopsCore dannys_expansion decocraft Decoration Mod DecorationDelightRefurbished Decorative Blocks Disenchanting DistantHorizons doubledoors DramaticDoors drippyloadingscreen durabilitytooltip dynamic-fps dynamiclights DynamicTrees DynamicTreesBOP DynamicTreesPlus Easy Dungeons EasyAnvils EasyMagic easy_npc eatinganimation ecologics effective_fg elevatorid embeddium emotecraft enchantlimiter EnchantmentDescriptions EnderMail engineersdecor entityculling entity_model_features entity_texture_features epicfight EvilCraft exlinefurniture expandability explosiveenhancement factory-blocks fairylights fancymenu FancyVideo FarmersDelight fast-ip-ping FastSuite ferritecore finsandtails FixMySpawnR Forge Middle Ages fossil FpsReducer2 furnish GamingDeco geckolib goblintraders goldenfood goodall H.e.b habitat harvest-with-ease hexerei hole_filler huge-structure-blocks HunterIllager iammusicplayer Iceberg illuminations immersive_paintings incubation infinitybuttons inventoryhud InventoryProfilesNext invocore ItemBorders itemzoom Jade jei (Just Enough Items) JetAndEliasArmors journeymap JRFTL justzoom kiwiboi Kobolds konkrete kotlinforforge lazydfu LegendaryTooltips libIPN lightspeed lmft lodestone LongNbtKiller LuckPerms Lucky77 MagmaMonsters malum ManyIdeasCore ManyIdeasDoors marbledsarsenal marg mcw-furniture mcw-lights mcw-paths mcw-stairs mcw-trapdoors mcw-windows meetyourfight melody memoryleakfix Mimic minecraft-comes-alive MineTraps minibosses MmmMmmMmmMmm MOAdecor (ART, BATH, COOKERY, GARDEN, HOLIDAYS, LIGHTS, SCIENCE) MobCatcher modonomicon mods_optimizer morehitboxes mowziesmobs MutantMonsters mysticalworld naturalist NaturesAura neapolitan NekosEnchantedBooks neoncraft2 nerb nifty NightConfigFixes nightlights nocube's_villagers_sell_animals NoSeeNoTick notenoughanimations obscure_api oculus oresabovediamonds otyacraftengine Paraglider Patchouli physics-mod Pillagers Gun PizzaCraft placeableitems Placebo player-animation-lib pneumaticcraft-repressurized polymorph PrettyPipes Prism projectbrazier Psychadelic-Chemistry PuzzlesLib realmrpg_imps_and_demons RecipesLibrary reeves-furniture RegionsUnexplored restrictedportals revive-me Scary_Mobs_And_Bosses selene shetiphiancore ShoulderSurfing smoothboot
    • Hi everyone, I'm currently developing a Forge 1.21 mod for Minecraft and I want to display a custom HUD overlay for a minigame. My goal: When the game starts, all players should see an item/block icon (from the base game, not a custom texture) plus its name/text in the HUD – similar to how the bossbar overlay works. The HUD should appear centered above the hotbar (or at a similar prominent spot), and update dynamically (icon and name change as the target item changes). What I've tried: I looked at many online tutorials and several GitHub repos (e.g. SeasonHUD, MiniHUD), but most of them use NeoForge or Forge versions <1.20 that provide the IGuiOverlay API (e.g. implements IGuiOverlay, RegisterGuiOverlaysEvent). In Forge 1.21, it seems that neither IGuiOverlay nor RegisterGuiOverlaysEvent exist anymore – at least, I can't import them and they are missing from the docs and code completion. I tried using RenderLevelStageEvent as a workaround but it is probably not intended for custom HUDs. I am not using NeoForge, and switching the project to NeoForge is currently not an option for me. I tried to look at the original minecraft source code to see how elements like hearts, hotbar etc are drawn on the screen but I am too new to Minecraft modding to understand. What I'm looking for: What is the correct way to add a custom HUD element (icon + text) in Forge 1.21, given that the previous overlay API is missing? Is there a new recommended event, callback, or method in Forge 1.21 for custom HUD overlays, or is everyone just using a workaround? Is there a minimal open-source example repo for Forge 1.21 that demonstrates a working HUD overlay without relying on NeoForge or deprecated Forge APIs? My ideal solution: Centered HUD element with an in-game item/block icon (from the base game's assets, e.g. a diamond or any ItemStack / Item) and its name as text, with a transparent background rectangle. It should be visible to the players when the mini game is running. Easy to update the item (e.g. static variable or other method), so it can change dynamically during the game. Any help, code snippets, or up-to-date references would be really appreciated! If this is simply not possible right now in Forge 1.21, it would also help to know that for sure. Thank you very much in advance!
    • The simple answer is there is not an easy way. You would need to know how to program in Java, as well as at least some familiarity with how Forge works so you could port the differences. You would also need the sourcecode for the original mod, and permission from the author to modify it, if they did not use some sort of open source license. So it's not impossible, but it would take some effort, but doing so would open up a whole new world of possibilities for you!
    • Does it still crash if you remove holdmyitems? Looks like that mod doesn't work on a server as far as I can tell from the error.  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.