Jump to content

[1.7.2][UNSOLVED] Container - Basic Issue


kenbeannet

Recommended Posts

Having an issue with my MarketContainer.  When I open the GUI items are shifted 3 to the left.  If I have something in Hot bar slot 0, and I open the GUI.  The item is in my inventory, 3rd row, Slot 7.  Way off.  If I open my real inventory (e), its now moved from my hotbar.  I have no idea whats going on, tried IRC, no luck.  Code Git is below.

 

https://github.com/KenBeanNet/SimCraft/tree/master/java/mods/simcraft

Link to comment
Share on other sites

Given that your chest inventory size is 6:

//merges the item into player inventory since its in the tileEntity
                if (slot < 6) {
                        if (!this.mergeItemStack(stackInSlot, 9, 45, true)) {//should be 6 and 42
                                return null;
                        }
                }
                //places it into the tileEntity is possible since its in the player inventory
                else if (!this.mergeItemStack(stackInSlot, 0, 9, false)) {//should be 6 instead of 9
                        return null;
                }

Link to comment
Share on other sites

Goto,

 

While I agree that your findings are correct, that did not solve my issue.  There is still some bug existing that when I put items on my hot bar (Slots 0 and 1) then open the container, they appear in the bottom right of my inventory (Slots like 25 and 26).  Then if I open my inventory again, I get a duplicate item. 

 

My GUI only has 6 slots, and my Container code only has 6 slots.  Yet, if I put 6 as my size, I get out of array index.  Which I think is leading me to the source of the problem, but still unsure.

Link to comment
Share on other sites

If you have a array which has 6 thingys, it ranges from 0-5. So if you do something like this: YOUR_ARRAY[6], it will try to find slot 7 but that doesn't exist. So that's why you get a ArrayIndexOutOfBoundsException.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

Can you post the full crash log? Then i can figure out where the problem occurs

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

12:45:52] [server thread/ERROR]: Encountered an unexpected exception

net.minecraft.util.ReportedException: Ticking memory connection

at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:206) ~[NetworkSystem.class:?]

at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:762) ~[MinecraftServer.class:?]

at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:650) ~[MinecraftServer.class:?]

at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:120) ~[integratedServer.class:?]

at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:528) [MinecraftServer.class:?]

at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:787) [MinecraftServer$2.class:?]

Caused by: java.lang.ArrayIndexOutOfBoundsException: 6

at mods.simcraft.tileentity.MarketTileEntity.getStackInSlot(MarketTileEntity.java:33) ~[MarketTileEntity.class:?]

at net.minecraft.inventory.Slot.getStack(Slot.java:98) ~[slot.class:?]

at net.minecraft.inventory.Container.getInventory(Container.java:73) ~[Container.class:?]

at net.minecraft.inventory.Container.addCraftingToCrafters(Container.java:59) ~[Container.class:?]

at cpw.mods.fml.common.network.internal.FMLNetworkHandler.openGui(FMLNetworkHandler.java:88) ~[FMLNetworkHandler.class:?]

at net.minecraft.entity.player.EntityPlayer.openGui(EntityPlayer.java:2476) ~[EntityPlayer.class:?]

at mods.simcraft.blocks.MarketBlock.onBlockActivated(MarketBlock.java:37) ~[MarketBlock.class:?]

at net.minecraft.server.management.ItemInWorldManager.activateBlockOrUseItem(ItemInWorldManager.java:411) ~[itemInWorldManager.class:?]

at net.minecraft.network.NetHandlerPlayServer.processPlayerBlockPlacement(NetHandlerPlayServer.java:596) ~[NetHandlerPlayServer.class:?]

at net.minecraft.network.play.client.C08PacketPlayerBlockPlacement.processPacket(C08PacketPlayerBlockPlacement.java:74) ~[C08PacketPlayerBlockPlacement.class:?]

at net.minecraft.network.play.client.C08PacketPlayerBlockPlacement.processPacket(C08PacketPlayerBlockPlacement.java:122) ~[C08PacketPlayerBlockPlacement.class:?]

at net.minecraft.network.NetworkManager.processReceivedPackets(NetworkManager.java:242) ~[NetworkManager.class:?]

at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:190) ~[NetworkSystem.class:?]

... 5 more

 

Line 33 in MarketTile is return chestContents[var1];

Link to comment
Share on other sites

The only thing i can think of, is that you look through all of your classes related to the market, and look for something that looks for chestContents[6] and change it to chestContents[5].

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

Can you post a screenshot? I don't exactly know what you mean.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

Eh.  Just put something in the main bar slot 0.  Open the container.  The item is now no longer in slot 0, its in slot like 33 (last row in your inventory, 3rd from the right side).  Somehow it gets the wrong number and throws it off completely.  Then you close your inventory, log out and in, and its back in the correct spot.  Its only like changing it on the clientside, not server.

Link to comment
Share on other sites

Still having issue.  My code can be gotten on https://github.com/KenBeanNet/SimCraft/tree/master/java/mods/simcraft.

 

To recap,  The container is not function correctly.  When I open the container, items are in the wrong positions.  Its like the code for displaying from the inventory is incorrect, but its copied and pasted from the original minecraft code.

 

Any help, I appreciate.

Link to comment
Share on other sites

Part of your problem is that the slot indices you are using for your chest inventory are messed up; they should start at zero and increment by 1 each iteration, just like the vanilla player inventory. Take a look:

for (int chestRow = 0; chestRow < 2; chestRow++) { // iterates from 0 to 1, we'll label this 'a'
for (int chestCol = 0; chestCol < 3; chestCol++) { // iterates from 0 to 2, we'll label this 'b'
// values of your indices (b + a * 2) for a = 0, b = (0 to 2) are 0, 1, 2
// values of your indices (b + a * 2) for a = 1, b = (0 to 2) are 2, 3, 4
addSlotToContainer(new Slot(chestInventory, chestCol + chestRow * 2, 12 + chestCol * 18, 8 + chestRow * 18));
}
}

for (int y = 0; y < rows; y++) {
for (int x = 0; x < cols; x++) {
// these start at 9 (0 + 1 * 9), go up to 17 (8 + 1 * 9), move to the next row at 18 (0 + 2 * 9), etc.
// meaning the player inventory slots are indices 9-35 (inclusive, so 27 slots)
addSlotToContainer(new Slot(playerInventory, x + (y + 1) * cols, 133 + x * 18, 122 + y * 18));
}
}
// why does it start at 9? the action bar takes slots 0-8:
for (int x = 0; x < cols; x++) {
addSlotToContainer(new Slot(playerInventory, x, 133 + x * 18, 179));
}

 

EDIT: Furthermore, looking at your TileEntity, you never use markDirty() when the inventory changes. I use it in the following two methods for my TileEntity-based inventories:

@Override
public ItemStack decrStackSize(int slot, int amount) {
ItemStack stack = getStackInSlot(slot);
if (stack != null) {
if(stack.stackSize > amount) {
stack = stack.splitStack(amount);
markDirty();
} else {
setInventorySlotContents(slot, null);
}
}
return stack;
}

@Override
public void setInventorySlotContents(int slot, ItemStack itemstack) {
inventory[slot] = itemstack;
if (itemstack != null && itemstack.stackSize > getInventoryStackLimit()) {
itemstack.stackSize = getInventoryStackLimit();
}
markDirty();
}

 

Link to comment
Share on other sites

Cool,

 

Let me first say thank you for at least investigating.  I spent hour and hours on this stupid bug.  I am starting to think its packet related somehow.  I just made the changes you suggested.  I am still having the issue.

 

I put items in Slots 0, 1, 2 (Hotbar).  When I open the container, they appear in slot 33,34,35 (last slots in inventory).  It appears to be moving them backwards somehow.  Yet,  When I click slot 0, the item disappears but does not appear in my hand. If I click slot 33, 34, or 35, nothing happens.  Any thoughts?

 

new code

protected void bindPlayerInventory(IInventory playerInventory, IInventory chestInventory)
    {
    	for (int j = 0; j < 2; ++j)
        {
            for (int k = 0; k < 3; ++k)
            {
                this.addSlotToContainer(new Slot(chestInventory, k + j * 3, 8 + k * 18, 18 + j * 18));
            }
        }
    	
    	for (int j = 0; j < 3; ++j)
        {
            for (int k = 0; k < 9; ++k)
            {
                this.addSlotToContainer(new Slot(playerInventory, k + j * 9 + 9, 133 + k * 18, 122 + j * 18));
            }
        }

        for (int j = 0; j < 9; ++j)
        {
            this.addSlotToContainer(new Slot(playerInventory, j, 133 + j * 18, 179));
        }
    }

Link to comment
Share on other sites

There shouldn't be any packets involved at all, at least not that you need to worry about. IInventory-Container-GuiContainer are a slick package that handle everything you need internally, for the most part.

 

Have you tried using the standard gui positions for the player inventory? Your slot positions are way off, probably off the screen:

 

// Main, yours: 133 + k * 18, 122 + j * 18

// Main, mine: 8 + k * 18, 84 + j * 18

// Action bar, yours: 133 + j * 18, 179

// Action bar, mine: 8 + j * 18, 142

Link to comment
Share on other sites

Maybe your processing the Slots on the Gui Image displayed?  Not sure if this is the root of my problem though.  Just by changing the cordinates shouldn't really change where the items appear.

 

The key is, when I open the inventory the real way (e), my items are moved to the new place where they appear in the custom made container.  So the items are defiantly moving.

 

I am thinking that something I do when the player logs in, is throwing off the Inventory and in turn messing with the custom container.  I mean, if we think about it, this is a very BASIC thing.  And its becoming such a major issue.

Link to comment
Share on other sites

Still trying for a solution.  Something must be throwing it off, and I really think its NOT with the container.  It has to do with networking (Offset Packets).  Maybe I am writing a Int and only reading a short (I did check though).  Maybe I am not registering the GUI correctly?  Not returning the correct information somewhere?  I dunno.

Link to comment
Share on other sites

  • 2 weeks later...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello, I'm Richard, a doctor based in Texas, navigating the complexities of life as a single parent to my 7-year-old daughter. Recently, I decided to invest my pension funds with Coinberry, hoping to supplement my income from my medical practice. Little did I anticipate the tumultuous journey that awaited me. Initially, Coinberry seemed like a promising platform, offering opportunities to invest in cryptocurrencies such as Ethereum (ETH). Entrusting them with $38,000 worth of ETH, I envisioned a future where financial stability and security would complement my responsibilities as a healthcare provider and father. However, my optimism quickly turned to despair when Coinberry's actions took a sinister turn. I found myself on the brink of losing my entire investment—$38,000 worth of ETH—due to what appeared to be a series of manipulative maneuvers. The situation seemed dire, and I was at a loss for how to reclaim what was rightfully mine. Amidst the chaos and desperation, a ray of hope emerged in the form of RESILIENT SHIELD RECOVERY.. Recommended to me by others who had faced similar ordeals, I reached out to them with a flicker of optimism. Their response was nothing short of remarkable. RESILIENT SHIELD RECOVERY. swiftly embarked on a mission to trace the intricate path of my lost funds. Their expertise in blockchain analytics and forensic investigation proved invaluable as they meticulously tracked the movement of ETH across various soft wallets. Within a remarkably short span of three days, they achieved the seemingly impossible—they recovered a substantial portion of my funds. The relief and gratitude I felt cannot be overstated. RESILIENT SHIELD RECOVERY. not only restored my financial stability but also provided me with a renewed sense of security. Their professionalism and efficiency in handling my case were exemplary, guiding me through the intricate process of fund recovery with empathy and clarity. Beyond their role as financial saviors, RESILIENT SHIELD RECOVERY. imparted invaluable lessons on cybersecurity and risk management. They emphasized the importance of vigilance in the digital realm, advocating for measures such as two-factor authentication and secure password practices to safeguard against future threats. Their insights were not only practical but also empowering, equipping me with the knowledge to make informed decisions in my future financial endeavors. As I reflect on this challenging chapter in my life, I am reminded of the resilience inherent in the human spirit. My experience with Coinberry and subsequent salvation by RESILIENT SHIELD RECOVERY. has reinforced the importance of due diligence and caution in investment decisions. It has also underscored the critical role that trusted allies like RESILIENT SHIELD RECOVERY. play in navigating the complexities of financial fraud and cybercrime. To anyone facing similar challenges or contemplating investments in the digital realm, I offer a word of caution and encouragement. Trust your instincts, conduct thorough research, and seek guidance from reputable professionals like RESILIENT SHIELD RECOVERY. when needed. Their expertise and dedication are invaluable assets in safeguarding your financial future. While the scars of this experience may linger, I am grateful for the silver lining provided by RESILIENT SHIELD RECOVERY.. They have not only restored my faith in financial security but also empowered me to protect my daughter's future with renewed vigor and determination. Together, we forge ahead, fortified by hard-earned lessons.  
    • Fast Leaf Decay (by olafskiii) Rubidium (by Asek3) Artifacts (by ochotonida) Framework (by MrCrayfish) Max Health Fix (by DarkhaxDev) Embeddium/Rubidium Extras (by Txni) Essential Mod (by SparkUniverse_) Immersive Aircraft [Fabric/Forge] (by Conczin) Cherished Worlds (Fabric/Forge/NeoForge/Quilt) (by TheIllusiveC4) ExpandAbility (by florensie) Sophisticated Core (by P3pp3rF1y) Tinkers' Levelling Addon (by Pyre540) Better Advancements (by way2muchnoise) Immersive Melodies [Fabric/Forge] (by Conczin) Citadel (by sbom_xela) Vampirism - Become a vampire! (by maxanier) FerriteCore ((Neo)Forge) (by malte0811) CoroUtil (by Corosus) Create Big Cannons (by rbasamoyai) Controlling (by Jaredlll08) Cloth Config API (Fabric/Forge/NeoForge) (by shedaniel) Mekanism (by bradyaidanc) BetterF3 (by cominixo) Supplementaries (by MehVahdJukaar) Chest Cavity - Forge Port (by booneldanforever) ConnectedTexturesMod (by tterrag1098) NetherPortalFix (by BlayTheNinth) Spartan Weaponry (by ObliviousSpartan) Charm of Undying (Fabric/Forge/Quilt) (by TheIllusiveC4) Plushie Mod (by Link4real) JourneyMap (by techbrew) Farmer's Delight (by vectorwing) Connectivity[Forge/Fabric] (by someaddon) Create : Misc & Things (by To0pa) Create: Steam 'n' Rails (by IThundxr) Shutup Experimental Settings! (by Corgi_Taco) Alex's Mobs (by sbom_xela) Quark (by Vazkii) Tool Belt (by gigaherz) Just Enough Items (JEI) (by mezz) Bookshelf (by DarkhaxDev) FastWorkbench (by Shadows_of_Fire) Tinkers Construct (by mDiyo) Collective (by Serilum) Inventory HUD+ (by dmitrylovin) Explorer's Compass (by Chaosyr) playerAnimator (by KosmX) Size Devices (by DaFlame_rl) Jade 🔍 (by Snownee) Create Slice & Dice (by possible_triangle) Create Jetpack (by possible_triangle) Carry On (by Tschipp) Moonlight Lib (by MehVahdJukaar) Kotlin for Forge (by thedarkcolour) CraftTweaker (by Jaredlll08) Just Enough Resources (JER) (by way2muchnoise) AI Improvements (by QueenOfMissiles) Patchouli (by Vazkii) Catalogue (by MrCrayfish) Tool Stats (by DarkhaxDev) It Takes a Pillage (by izofar) JEITweaker (by Jaredlll08) Waystones (by BlayTheNinth) Vampires Need Umbrellas (by focamacho) Oculus (by Asek3) Mantle (by mDiyo) Mob Grinding Utils (by vadis365) Chiseled (by freepeopleworking) AutoRegLib (by Vazkii) Mystical Agriculture (by BlakeBr0) Embeddium/Rubidium Dynamic Lights (by Txni) Flywheel (Legacy) (by jozufozu) Builder's Delight (Forge) (by Tynoxs) Apotheosis (by Shadows_of_Fire) What Are They Up To (Watut) (by Corosus) Create: Interiors (by sudolev) FastFurnace (by Shadows_of_Fire) Balm (Forge Edition) (by BlayTheNinth) Clumps (by Jaredlll08) Iris & Oculus Flywheel Compat (by leon_mout) Configured (by MrCrayfish) Tinkers' Expansion (by Insane96) Crafting on a stick (by OfekN_) MrCrayfish's Gun Mod (by MrCrayfish) Create: Crystal Clear (by singularity_cyvack) FTB Library (Forge) (by FTB) AppleSkin (by squeek502) Curios API (Forge/NeoForge) (by TheIllusiveC4) Better Third Person (by Socolio) Caelus API (Forge/NeoForge) (by TheIllusiveC4) Sons Of Sins (by Furti_Two) SwingThroughGrass (by exidex) AttributeFix (by DarkhaxDev) Quests Additions (Forge) (by NaturaSpell) Building Gadgets (by Direwolf20) Enchantment Descriptions (by DarkhaxDev) Skin Layers 3D (Fabric/Forge) (by tr7zw) Bad Wither No Cookie - Reloaded (by Kreezxil) Placebo (by Shadows_of_Fire) FTB Teams (Forge) (by FTB) Mod Name Tooltip (by mezz) Enigmatic Graves (by Quarris) Sophisticated Backpacks (by P3pp3rF1y) GeckoLib (by Gecko) Builders Crafts & Additions (by MRHminer) Immersive Portals (for Forge) (by qouteall) Architectury API (Fabric/Forge/NeoForge) (by shedaniel) Lazy DataFixerUpper(LazyDFU) [FORGE] (by Corgi_Taco) Create Ore Excavation (by tom54541) Tinkers' Rapier (by sz0999312) Mowzie's Mobs (by bobmowzie) Better Combat [Fabric & Forge] (by daedelus_dev) Create Stuff & Additions (by Furti_Two) Cucumber Library (by BlakeBr0) FPS Reducer (by bre2el) Item Filters (by LatvianModder) FTB Quests (Forge) (by FTB) L_Ender 's Cataclysm (by mcl_ender) Starter Kit (by Serilum) Feature NBT Deadlock Be Gone (by telepathicgrunt) Materialis (by RCXcrafter) KleeSlabs (by BlayTheNinth) Pehkui (by Virtuoel) Grappling Hook Mod (by yyonne) Security Craft (by Geforce132) Ars Nouveau (by baileyholl2) Mouse Tweaks (by YaLTeR) Werewolves - Become a Beast! (by Cheaterpaul) Elytra Slot (Fabric/Forge/Quilt) (by TheIllusiveC4) Create (by simibubi) Budschie's Morph Mod (by budschie_) Ore Excavation (by Funwayguy) Create Confectionery (by Furti_Two)
    • Hello, im kind of a newbie on creating mods, and i been trying to make simples mods so far, Right now, i'm creating a mod which detect an specific type of mob and kill it if reach a certain number, by far the mod is detecting the mob and counting them but at the time it reach the limit number, it don't do anything. The Game don't tweak, don't crash, just i't don't run the method i call, which is kill().   public InteractionResultHolder<ItemStack> use(Level pLevel, Player pPlayer, InteractionHand pUsedHand) { final var TotalCows = pLevel.getNearbyEntities(Cow.class, TargetingConditions.forNonCombat(), pPlayer, pPlayer.getBoundingBox().inflate(5)); if(pLevel.isClientSide){ if(pPlayer.getItemInHand(InteractionHand.MAIN_HAND).getItem() == this.asItem()){ if(!TotalCows.isEmpty()){ if(TotalCows.get(0).isAlive()){ TotalCows.get(0).kill(); } }else{ pPlayer.sendSystemMessage(Component.literal("No hay vacas")); } } } The sendSystemMessage is get triggered, and when i change the method .kill() by any other like send a message it got called, can i get some tips, and a clue of what i'm missing
    • UPD: I DID IT   @Override public void applyEffectTick(LivingEntity livingEntity, int pAmplifier) { Level level = livingEntity.level(); if (!level.isClientSide()) { Holder<DamageType> entropyHolder = level .registryAccess() .registryOrThrow(Registries.DAMAGE_TYPE) .getHolderOrThrow(GTDamageTypes.ENTROPY_KEY); livingEntity.hurt(new DamageSource(entropyHolder), 1); } super.applyEffectTick(livingEntity, pAmplifier); }  
    • So I came to this public class ModDamageTypes{ public static void bootstrap(BootstapContext<DamageType> context) { context.register(GTDamageTypes.ENTROPY_KEY, new DamageType(GrimTales.MOD_ID + "_entropy", 0.1f)); } } public class GTDamageTypes implements DamageTypes { public static final ResourceKey<DamageType> ENTROPY_KEY = register("entropy"); private static ResourceKey<DamageType> register(String name) { return ResourceKey.create(Registries.DAMAGE_TYPE, new ResourceLocation(GrimTales.MOD_ID, name)); } } public class ModWorldGenProvider extends DatapackBuiltinEntriesProvider { public static final RegistrySetBuilder BUILDER = new RegistrySetBuilder() .add(Registries.DAMAGE_TYPE, ModDamageTypes::bootstrap); public ModWorldGenProvider(PackOutput output, CompletableFuture<HolderLookup.Provider> registries) { super(output, registries, BUILDER, Set.of(GrimTales.MOD_ID)); } But! I still have an issue that, I cannot just use Holder.direct, due to it will create error that "Required type:  Holder<DamageType>  Provided : Holder<ResourceKey<DamageType>>" And I still have no clue how to fix it
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.