Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.6.4] Moving container slots


Jeerdus
 Share

Recommended Posts

Good day!

I am working on a mod, which contains a machine in which there's a button which extends the GUI with few more slots. I made the GUI part, but now I'm struggling with the container slots. I don't know how to make them appear nor disappear. I got an idea that I could somehow move them from like x: -1000 and y: -1000 to the correct slot, but my code didn't work. (I used simple if statement)

Could you please suggest me some ways of doing it?

Thanks!

Link to comment
Share on other sites

Sorry, I couldn't reply until now.

My container code is:

package elementum;

import java.util.ArrayList;
import java.util.List;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.ICrafting;
import net.minecraft.inventory.Slot;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.item.crafting.FurnaceRecipes;
import net.minecraft.tileentity.TileEntityFurnace;

public class ContainerChargingStation extends Container
{
private TileEntityChargingStation tileentity;
private int chargingBurnTime;
private int lastItemBurnTime;
private int curAmount;

public ContainerChargingStation(InventoryPlayer inventoryplayer, TileEntityChargingStation tileentityInputFurnace)
{
         chargingBurnTime = 0;
         lastItemBurnTime = 0;
         curAmount = 0;
         tileentity = tileentityInputFurnace;
         this.addSlotToContainer(new Slot(tileentityInputFurnace, 0, 98, 34));
         this.addSlotToContainer(new Slot(tileentityInputFurnace, 1, 8, 62));
         for (int i = 0; i < 3; i++)
         {
                 for (int k = 0; k < 9; k++)
                 {
                         this.addSlotToContainer(new Slot(inventoryplayer, k + i * 9 + 9, 8 + k * 18, 84 + i * 18));
                 }
         }
         for (int j = 0; j < 9; j++)
         {
                 this.addSlotToContainer(new Slot(inventoryplayer, j, 8 + j * 18, 142));
         }
         
     	if(tileentity.upgradeScreenOpened){
    		this.addSlotToContainer(new Slot(tileentityInputFurnace, 2, 179, 5));
    		this.addSlotToContainer(new Slot(tileentityInputFurnace, 3, 179, 23));
    		this.addSlotToContainer(new Slot(tileentityInputFurnace, 4, 179, 41));
    		this.addSlotToContainer(new Slot(tileentityInputFurnace, 5, 179, 59));
    	}
     	else
     	{
    		this.addSlotToContainer(new Slot(tileentityInputFurnace, 2, Integer.MIN_VALUE, Integer.MIN_VALUE));
    		this.addSlotToContainer(new Slot(tileentityInputFurnace, 3, Integer.MIN_VALUE, Integer.MIN_VALUE));
    		this.addSlotToContainer(new Slot(tileentityInputFurnace, 4, Integer.MIN_VALUE, Integer.MIN_VALUE));
    		this.addSlotToContainer(new Slot(tileentityInputFurnace, 5, Integer.MIN_VALUE, Integer.MIN_VALUE));
    	}	
        	 
}
public void addCraftingToCrafters(ICrafting par1ICrafting)
{
         super.addCraftingToCrafters(par1ICrafting);
         par1ICrafting.sendProgressBarUpdate(this, 0, this.tileentity.chargingBurnTime);
         par1ICrafting.sendProgressBarUpdate(this, 1, this.tileentity.currentItemBurnTime);
         par1ICrafting.sendProgressBarUpdate(this, 2, this.tileentity.currentAmount);
}

public void detectAndSendChanges()
{
         super.detectAndSendChanges();
         for (int var1 = 0; var1 < this.crafters.size(); ++var1)
         {
                 ICrafting var2 = (ICrafting)this.crafters.get(var1);
                 if (this.chargingBurnTime != this.tileentity.chargingBurnTime)
                 {
                         var2.sendProgressBarUpdate(this, 0, this.tileentity.chargingBurnTime);
                 }
                 if (this.lastItemBurnTime != this.tileentity.currentItemBurnTime)
                 {
                         var2.sendProgressBarUpdate(this, 1, this.tileentity.currentItemBurnTime);
                 }
                 if (this.curAmount != this.tileentity.currentAmount)
                 {
                         var2.sendProgressBarUpdate(this, 2, this.tileentity.currentAmount);
                 }
         }
         this.chargingBurnTime = this.tileentity.chargingBurnTime;
         this.lastItemBurnTime = this.tileentity.currentItemBurnTime;
         this.curAmount = this.tileentity.currentAmount;
}

public void updateProgressBar(int i, int j)
{
         if (i == 0)
         {
                 tileentity.chargingBurnTime = j;
         }
         if (i == 1)
         {
                 tileentity.currentItemBurnTime = j;
         }
         if (i == 2)
         {
                 tileentity.currentAmount = j;
         }
}

public ItemStack transferStackInSlot(EntityPlayer player, int slotNum)
{	
ItemStack itemstack = null;
Slot slot = (Slot)this.inventorySlots.get(slotNum);

if(slot != null && slot.getHasStack()){
	ItemStack itemstack1 = slot.getStack();
	itemstack = itemstack1.copy();

	if(slotNum == 0 || slotNum == 1 || slotNum == 2 || slotNum == 3 || slotNum == 4 || slotNum == 5){
		if(!this.mergeItemStack(itemstack1, 6, 42, true))
		{
			return null;
		}

		slot.onSlotChange(itemstack1, itemstack);
	}
	else if(slotNum != 1 && slotNum != 0){
		if(TileEntityChargingStation.isItemFuel(itemstack1)){
			if (!this.mergeItemStack(itemstack1, 1, 2, false)){
				return null;
			}
		}
		else if(TileEntityChargingStation.isChargable(itemstack1)){
			if (!this.mergeItemStack(itemstack1, 0, 1, false)){
				return null;
			}
		}
		else if(slotNum >= 6 && slotNum < 33){
			if(!this.mergeItemStack(itemstack1, 33, 42, false)){
				return null;
			}
		}
		else if(slotNum >= 33 && slotNum > 42 && !this.mergeItemStack(itemstack1, 33, 42, false)){
			if(!this.mergeItemStack(itemstack1, 6, 33, false)){
				return null;
			}
		}
	}
	else if(!this.mergeItemStack(itemstack1, 6, 33, false)){
		return null;
	}
	if(itemstack1.stackSize == 0){
		slot.putStack((ItemStack)null);
	}
	else{
		slot.onSlotChanged();
	}
	if(itemstack1.stackSize == itemstack.stackSize){
		return null;
	}

	slot.onPickupFromSlot(player, itemstack1);
}


return itemstack;

    
}
public boolean canInteractWith(EntityPlayer entityplayer)
{
         return tileentity.isUseableByPlayer(entityplayer);
}
}

 

If you would need any other file just say.

Link to comment
Share on other sites

Your slot indexes are all messed up. You keep repeating the same ones. In your loop you reused index 0-20 because your loop does not increment the slot indexes properly.

 

Try this:

         int slot = 0;
         this.addSlotToContainer(new Slot(tileentityInputFurnace, slot++, 98, 34));
         this.addSlotToContainer(new Slot(tileentityInputFurnace, slot++, 8, 62));
         for (int i = 0; i < 3; i++)
         {
                 for (int k = 0; k < 9; k++)
                 {
                         this.addSlotToContainer(new Slot(inventoryplayer, slot++, 8 + k * 18, 84 + i * 18));
                 }
         }
         for (int j = 0; j < 9; j++)
         {
                 this.addSlotToContainer(new Slot(inventoryplayer, slot++, 8 + j * 18, 142));
         }
         
     	if(tileentity.upgradeScreenOpened){
    		this.addSlotToContainer(new Slot(tileentityInputFurnace, slot++, 179, 5));
    		this.addSlotToContainer(new Slot(tileentityInputFurnace, slot++, 179, 23));
    		this.addSlotToContainer(new Slot(tileentityInputFurnace, slot++, 179, 41));
    		this.addSlotToContainer(new Slot(tileentityInputFurnace, slot++, 179, 59));
    	}
     ...

Link to comment
Share on other sites

I can't seem to be able to receive the packet. I am sending it, but it isn't receiving.

 

Container:

package elementum;

import java.util.ArrayList;
import java.util.List;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.ICrafting;
import net.minecraft.inventory.Slot;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.item.crafting.FurnaceRecipes;
import net.minecraft.tileentity.TileEntityFurnace;

public class ContainerChargingStation extends Container
{
private TileEntityChargingStation tileentity;
private int chargingBurnTime;
private int lastItemBurnTime;
private int curAmount;

public ContainerChargingStation(InventoryPlayer inventoryplayer, TileEntityChargingStation tileentityInputFurnace)
{
         chargingBurnTime = 0;
         lastItemBurnTime = 0;
         curAmount = 0;
         tileentity = tileentityInputFurnace;
         this.addSlotToContainer(new Slot(tileentityInputFurnace, 0, 98, 34));
         this.addSlotToContainer(new Slot(tileentityInputFurnace, 1, 8, 62));
     	 this.addSlotToContainer(new Slot(tileentityInputFurnace, 2, 179, 5));
     	 this.addSlotToContainer(new Slot(tileentityInputFurnace, 3, 179, 23));
     	 this.addSlotToContainer(new Slot(tileentityInputFurnace, 4, 179, 41));
     	 this.addSlotToContainer(new Slot(tileentityInputFurnace, 5, 179, 59));
     	 
         for (int i = 0; i < 3; i++)
         {
                 for (int k = 0; k < 9; k++)
                 {
                         this.addSlotToContainer(new Slot(inventoryplayer, k + i * 9 + 9, 8 + k * 18, 84 + i * 18));
                 }
         }
         
         for (int j = 0; j < 9; j++)
         {
                 this.addSlotToContainer(new Slot(inventoryplayer, j, 8 + j * 18, 142));
         }
         
         reloadSlots();
}

public void reloadSlots() {
    if(tileentity.upgradeScreenOpened){
   	 ((Slot)inventorySlots.get(2)).xDisplayPosition = 179;
   	 ((Slot)inventorySlots.get(3)).xDisplayPosition = 179;
   	 ((Slot)inventorySlots.get(4)).xDisplayPosition = 179;
   	 ((Slot)inventorySlots.get(5)).xDisplayPosition = 179;
   	 System.out.println("TRUE");
    }
    else if(!tileentity.upgradeScreenOpened){
   	 ((Slot)inventorySlots.get(2)).xDisplayPosition = Integer.MIN_VALUE;
   	 ((Slot)inventorySlots.get(3)).xDisplayPosition = Integer.MIN_VALUE;
   	 ((Slot)inventorySlots.get(4)).xDisplayPosition = Integer.MIN_VALUE;
   	 ((Slot)inventorySlots.get(5)).xDisplayPosition = Integer.MIN_VALUE;
   	 System.out.println("FALSE");
    }
}

public void receiveButtonEvent(byte buttonID){
if(buttonID == 0){
	reloadSlots();
	System.out.println("Recieved");
}
}

public void addCraftingToCrafters(ICrafting par1ICrafting)
{
         super.addCraftingToCrafters(par1ICrafting);
         par1ICrafting.sendProgressBarUpdate(this, 0, this.tileentity.chargingBurnTime);
         par1ICrafting.sendProgressBarUpdate(this, 1, this.tileentity.currentItemBurnTime);
         par1ICrafting.sendProgressBarUpdate(this, 2, this.tileentity.currentAmount);
}

public void detectAndSendChanges()
{
         super.detectAndSendChanges();
         for (int var1 = 0; var1 < this.crafters.size(); ++var1)
         {
                 ICrafting var2 = (ICrafting)this.crafters.get(var1);
                 if (this.chargingBurnTime != this.tileentity.chargingBurnTime)
                 {
                         var2.sendProgressBarUpdate(this, 0, this.tileentity.chargingBurnTime);
                 }
                 if (this.lastItemBurnTime != this.tileentity.currentItemBurnTime)
                 {
                         var2.sendProgressBarUpdate(this, 1, this.tileentity.currentItemBurnTime);
                 }
                 if (this.curAmount != this.tileentity.currentAmount)
                 {
                         var2.sendProgressBarUpdate(this, 2, this.tileentity.currentAmount);
                 }
         }
         this.chargingBurnTime = this.tileentity.chargingBurnTime;
         this.lastItemBurnTime = this.tileentity.currentItemBurnTime;
         this.curAmount = this.tileentity.currentAmount;
}

public void updateProgressBar(int i, int j)
{
         if (i == 0)
         {
                 tileentity.chargingBurnTime = j;
         }
         if (i == 1)
         {
                 tileentity.currentItemBurnTime = j;
         }
         if (i == 2)
         {
                 tileentity.currentAmount = j;
         }
}

public ItemStack transferStackInSlot(EntityPlayer player, int slotNum)
{	
ItemStack itemstack = null;
Slot slot = (Slot)this.inventorySlots.get(slotNum);

if(slot != null && slot.getHasStack()){
	ItemStack itemstack1 = slot.getStack();
	itemstack = itemstack1.copy();

	if(slotNum == 0 || slotNum == 1 || slotNum == 2 || slotNum == 3 || slotNum == 4 || slotNum == 5){
		if(!this.mergeItemStack(itemstack1, 6, 42, true))
		{
			return null;
		}

		slot.onSlotChange(itemstack1, itemstack);
	}
	else if(slotNum != 1 && slotNum != 0){
		if(TileEntityChargingStation.isItemFuel(itemstack1)){
			if (!this.mergeItemStack(itemstack1, 1, 2, false)){
				return null;
			}
		}
		else if(TileEntityChargingStation.isChargable(itemstack1)){
			if (!this.mergeItemStack(itemstack1, 0, 1, false)){
				return null;
			}
		}
		else if(slotNum >= 6 && slotNum < 33){
			if(!this.mergeItemStack(itemstack1, 33, 42, false)){
				return null;
			}
		}
		else if(slotNum >= 33 && slotNum > 42 && !this.mergeItemStack(itemstack1, 33, 42, false)){
			if(!this.mergeItemStack(itemstack1, 6, 33, false)){
				return null;
			}
		}
	}
	else if(!this.mergeItemStack(itemstack1, 6, 33, false)){
		return null;
	}
	if(itemstack1.stackSize == 0){
		slot.putStack((ItemStack)null);
	}
	else{
		slot.onSlotChanged();
	}
	if(itemstack1.stackSize == itemstack.stackSize){
		return null;
	}

	slot.onPickupFromSlot(player, itemstack1);
}


return itemstack;

    
}
public boolean canInteractWith(EntityPlayer entityplayer)
{
         return tileentity.isUseableByPlayer(entityplayer);
}

public TileEntityChargingStation getMachine() {
return tileentity;
}
}

 

GUI:

package elementum;

import java.util.ArrayList;

import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.inventory.GuiContainer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.util.ResourceLocation;
import net.minecraft.util.StatCollector;

import org.lwjgl.opengl.GL11;

public class GuiChargingStation extends GuiContainer
{	
private ResourceLocation chargingStationTexture = new ResourceLocation("cyborg53373_elementum","textures/gui/chargingStationGUI.png");
private TileEntityChargingStation machine;
private int xSize2;

public GuiChargingStation(InventoryPlayer inventoryplayer, TileEntityChargingStation tileentityChargingStation)
{
         super(new ContainerChargingStation(inventoryplayer, tileentityChargingStation));
         machine = tileentityChargingStation;
         xSize = 203;
         xSize2 = xSize - 27;
}

protected void drawGuiContainerForegroundLayer(int x, int y)
{	
         fontRenderer.drawString(StatCollector.translateToLocal("Coal Charging Station"), 34, 3, 0x404040);
         //fontRenderer.drawString(StatCollector.translateToLocal("Inventory"), 8, (ySize - 96) + 2, 0x404040);
         
         ArrayList<String> text01 = new ArrayList<String>();
    	 text01.add(String.valueOf(machine.currentAmount) + "/" + String.valueOf(machine.maxAmount));

    	 ArrayList<String> text02 = new ArrayList<String>();
    	 text02.add("Click to show upgrade slots");
    	 
    	 ArrayList<String> text03 = new ArrayList<String>();
    	 text03.add("Click to hide upgrade slots");
    	 
    	 int x1 = x - guiLeft;
         int y1 = y - guiTop;
         
         if(x1 >= 61 && x1 <= 77 && y1 >= 16 && y1 <= 68){
         	drawHoveringText(text01, x - guiLeft, y - guiTop, fontRenderer);
         }
         
         if(x1 >= xSize2 - 15 && x1 <= xSize2 - 7 && y1 >= 7 && y1 <= 15){
          	if(!machine.upgradeScreenOpened){
          		drawHoveringText(text02, x - guiLeft, y - guiTop, fontRenderer);
          	}
          	else if(machine.upgradeScreenOpened){
          		drawHoveringText(text03, x - guiLeft, y - guiTop, fontRenderer);
          	}
         }
}

protected void drawGuiContainerBackgroundLayer(float f, int x, int y)
{
         GL11.glColor4f(1.0F, 1.0F, 1.0F, 1.0F);
         //mc.renderEngine.bindTexture(tif);
         Minecraft.getMinecraft().getTextureManager().bindTexture(chargingStationTexture);
         int l = (width - xSize) / 2;
         int i1 = (height - ySize) / 2;
         drawTexturedModalRect(l, i1, 0, 0, xSize2, ySize);
         if (machine.isBurning())
         {
                 int j1 = machine.getBurnTimeRemainingScaled(12);
                 drawTexturedModalRect(l + 9, (i1 + 45 + 12) - j1, 176, 12 - j1, 14, j1 + 2);
         }
         int k1 = machine.getCookProgressScaled(52);
         drawTexturedModalRect(l + 61, i1 + 16, 176, 14, 44, 51 - k1);
         
         
         int srcX = 27;
         int srcY = 177;
         int butX = l + xSize2 - 15;
         int butY = i1 + 7;
         int butW = 8;
         int butH = 8;
         
         if(butX <= x && x <= butX + butW && butY <= y && y <= butY + butH){
        	 srcY += 8;
         }
         
         if(machine.upgradeScreenOpened){
        	 drawTexturedModalRect(butX, butY, srcX, srcY + 16, butW, butH);
        	 drawTexturedModalRect(l + xSize2 - 3, i1, 0, 174, 27, 82);
         }
         
         else if(!machine.upgradeScreenOpened){
        	 drawTexturedModalRect(butX, butY, srcX, srcY, butW, butH);
         }	 
}

protected void mouseClicked(int x, int y, int button) {
	super.mouseClicked(x, y, button);
        int l = (width - xSize) / 2;
        int i1 = (height - ySize) / 2;
	if(l + xSize2 - 15 <= x && x <= l + xSize2 - 7 && i1 + 7 <= y && y <= i1 + 15 && !machine.upgradeScreenOpened){
		machine.upgradeScreenOpened = true;
		this.mc.sndManager.playSoundFX("random.click", 1.0F, 1.0F);
		PacketHandler.sendButtonPacket((byte)0);
		System.out.println("Sent");
	}
	else if(l + xSize2 - 15 <= x && x <= l + xSize2 - 7 && i1 + 7 <= y && y <= i1 + 15 && machine.upgradeScreenOpened){
		machine.upgradeScreenOpened = false;
		this.mc.sndManager.playSoundFX("random.click", 1.0F, 1.0F);
		PacketHandler.sendButtonPacket((byte)0);
		System.out.println("Sent");
	}
}

public void onGuiClosed() {
	super.onGuiClosed();
	//machine.upgradeScreenOpened = false;
}
}

 

PacketHandler:

package elementum;

import java.io.ByteArrayOutputStream;
import java.io.DataOutputStream;
import java.io.IOException;

import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.network.INetworkManager;
import net.minecraft.network.packet.Packet250CustomPayload;

import com.google.common.io.ByteArrayDataInput;
import com.google.common.io.ByteStreams;

import cpw.mods.fml.common.network.IPacketHandler;
import cpw.mods.fml.common.network.PacketDispatcher;
import cpw.mods.fml.common.network.Player;
import elementum.ModInfo;

public class PacketHandler implements IPacketHandler {

@Override
public void onPacketData(INetworkManager manager, Packet250CustomPayload packet, Player player) {
	ByteArrayDataInput reader = ByteStreams.newDataInput(packet.data);

	EntityPlayer entityPlayer = (EntityPlayer)player;

	byte packetId = reader.readByte();		

	switch (packetId) {
	case 0:
		int entityId = reader.readInt();
		Entity entity = entityPlayer.worldObj.getEntityByID(entityId);			
		break;
	case 1:
		byte buttonId = reader.readByte();
		Container container = entityPlayer.openContainer;
		if (container != null && container instanceof ContainerChargingStation) {
			((ContainerChargingStation) container).receiveButtonEvent(buttonId);
		}
		break;
}
}

public static void sendButtonPacket(byte id) {
	ByteArrayOutputStream byteStream = new ByteArrayOutputStream();
	DataOutputStream dataStream = new DataOutputStream(byteStream);

	try {
		dataStream.writeByte((byte)1);
		dataStream.writeByte(id);			

		PacketDispatcher.sendPacketToServer(PacketDispatcher.getPacket(ModInfo.CHANNEL, byteStream.toByteArray()));
	}catch(IOException ex) {
		System.err.append("Failed to send button click packet");
	}		
}	

}

Link to comment
Share on other sites

Then you are doing something wrong. I provided you with a working example. If you want further testing, provide a github repo that is properly set up so all you have to do is clone it and setup gradle. Then I can test. Debugging without being able to run your mod is a pain.

Link to comment
Share on other sites

I don't think I can use ForgeGradle with 1.6.4. But I can give you the instructions:

Assets are basically textures, so all you have to do is to copy the "cyborg53373_elementum" folder inside the "assets" folder into your "src/minecraft/assets" folder.

The "elementum" folder is the code, you put that whole folder into "src/minecraft" folder. And that's pretty much it.

Link to comment
Share on other sites

I've putted the code into the detectAndSendChanges method.

Here's the code:

public void detectAndSendChanges()
{
         super.detectAndSendChanges();         
         if(tileentity.upgradeScreenOpened && !this.upgradeScreen){
        	 this.upgradeScreen = true;
        	 reloadSlots();
        	 System.out.println("Sent");
         }
         else if(!tileentity.upgradeScreenOpened && this.upgradeScreen){
        	 this.upgradeScreen = false;
        	 reloadSlots();
        	 System.out.println("Sent");
         }
         System.out.println("Detected; "+ this.upgradeScreen + "; " + tileentity.upgradeScreenOpened);
}

 

But I found out that it doesn't detect when the tileentity.upgradeScreenOpened boolean changes. It always says in the console that it's "false".

Am I doing something wrong?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.