hi,

So i'm making meth in my mod, but i don't want to make it a potion or a food, but still have an animation when you consume it for it to give you potion effects. The reason for this is because i want the potion animation, but the potion class extension makes it a water bottle or something weird.

 

Right now, the only method i found was to consume it the moment the player right clicks, but i want some animation between the right click and the consumation (if that's a word).

 

this is what i have:

 

 

package com.pandassaurus.breakingbad.item;

import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Items;
import net.minecraft.item.*;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.world.World;

import java.util.Iterator;
import java.util.List;

/**
* User: Pandassaurus
* Date: 3/4/14
*/
public class CrystalMeth extends Item {

    public CrystalMeth(int i) {
        this.setCreativeTab(CreativeTabs.tabMisc);
    }

    public EnumAction getItemUseAction(ItemStack par1ItemStack) {
        return EnumAction.drink;
    }

    @Override
    public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer) {
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.confusion.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.moveSpeed.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.damageBoost.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.digSpeed.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.harm.getId(), 1, 1));
        return par1ItemStack;
    }


    //TODO CODE- DEATH BY OVERDOSE
    //TODO CODE- FIX THIS DAMN THING
}

 

 

 

Also, can you link me to a tutorial on how to add sounds?

 

thanks,

Pandassaurus

You should replace your onrightclick method with onItemUseFirst and onUsingItemTick (see them in Item.class) and here is a sounds tut : http://www.minecraftforum.net/topic/1886370-forge16x-mazs-tutorials-custom-sounds-fluids190713/

 

Edit: some stuff maybe outdated, so try to search for the equivalents.

Thanks, that seemed to help a bit. Now, i right click and it does the animation, but after those 32 ticks of the maxitemduration, it stops and does nothing, and i don't know why.

 

here's the code:

 

 

package com.pandassaurus.breakingbad.item.meth;

import com.pandassaurus.breakingbad.BreakingBad;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Items;
import net.minecraft.item.*;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.world.World;

import java.util.Iterator;
import java.util.List;

/**
* User: Pandassaurus
* Date: 3/4/14
*/
public class CrystalMeth extends Item {

    public CrystalMeth(int i) {
        this.setCreativeTab(BreakingBad.BreakingBadTab_);
    }

    public EnumAction getItemUseAction(ItemStack par1ItemStack) {
        return EnumAction.block;
    }

    @Override
    public int getMaxItemUseDuration(ItemStack par1ItemStack) {
        return 32;
    }

    @Override
    public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer) {
        par3EntityPlayer.setItemInUse(par1ItemStack, this.getMaxItemUseDuration(par1ItemStack));
        return par1ItemStack;
    }


    @Override
    public void onUsingTick(ItemStack stack, EntityPlayer player, int count) {
        if (count > 32) {
            player.setItemInUse(null, 0);
            player.addPotionEffect(new PotionEffect(Potion.confusion.getId(), 2000, 2));
            player.addPotionEffect(new PotionEffect(Potion.moveSpeed.getId(), 2000, 2));
            player.addPotionEffect(new PotionEffect(Potion.damageBoost.getId(), 2000, 2));
            player.addPotionEffect(new PotionEffect(Potion.digSpeed.getId(), 2000, 2));
            player.addPotionEffect(new PotionEffect(Potion.harm.getId(), 1, 1));
            --stack.stackSize;
        }
    }



  /*  @Override
    public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer) {
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.confusion.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.moveSpeed.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.damageBoost.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.digSpeed.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.harm.getId(), 1, 1));
        --par1ItemStack.stackSize;
        return par1ItemStack;
    }             */


    //TODO CODE- DEATH BY OVERDOSE
    //TODO CODE- FIX THIS DAMN THING
}

 

 

thanks a lot, and i will check out the sound tutorial now as well.

-Pandassaurus

You need to define the behavior in onPlayerStoppedUsing.

Ok, so i defined it as so:

 

 

package com.pandassaurus.breakingbad.item.meth;

import com.pandassaurus.breakingbad.BreakingBad;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Items;
import net.minecraft.item.*;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.world.World;

import java.util.Iterator;
import java.util.List;

/**
* User: Pandassaurus
* Date: 3/4/14
*/
public class CrystalMeth extends Item {

    public CrystalMeth(int i) {
        this.setCreativeTab(BreakingBad.BreakingBadTab_);
    }

    public EnumAction getItemUseAction(ItemStack par1ItemStack) {
        return EnumAction.block;
    }

    @Override
    public int getMaxItemUseDuration(ItemStack par1ItemStack) {
        return 32;
    }

    @Override
    public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer) {
        par3EntityPlayer.setItemInUse(par1ItemStack, this.getMaxItemUseDuration(par1ItemStack));
        return par1ItemStack;
    }


    @Override
    public void onUsingTick(ItemStack stack, EntityPlayer player, int count) {
        player.playSound("mob.pig.say", 3, 3);
        if (count > stack.getMaxItemUseDuration()) {
          player.clearItemInUse();
        }
    }

    @Override
    public void onPlayerStoppedUsing(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer, int par4) {
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.confusion.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.moveSpeed.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.damageBoost.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.digSpeed.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.harm.getId(), 1, 1));
        --par1ItemStack.stackSize;
    }

    /*  @Override
    public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer) {
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.confusion.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.moveSpeed.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.damageBoost.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.digSpeed.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.harm.getId(), 1, 1));
        --par1ItemStack.stackSize;
        return par1ItemStack;
    }             */


    //TODO CODE- DEATH BY OVERDOSE
    //TODO CODE- FIX THIS DAMN THING
}

 

 

but onPlayerStoppedUsing just looks for the use button to be released, and doesn't take into account the maxUseDuration. Is there another function that does so, or am i missing something?

 

thanks a lot,

-Pandassaurus

You could just extend ItemFood to take advantage of the automated handling when the item use count reaches the max use duration... otherwise you will have to code it yourself probably using the Item#onUpdate method.

Yes thanks that worked out great.

 

For anyone who wanted to know what it looked like at the end:

 

package com.pandassaurus.breakingbad.item.meth;

import com.pandassaurus.breakingbad.BreakingBad;
import com.pandassaurus.breakingbad.handlers.SoundHandler;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Items;
import net.minecraft.item.*;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.world.World;

import java.util.Iterator;
import java.util.List;

/**
* User: Pandassaurus
* Date: 3/4/14
*/
public class CrystalMeth extends ItemFood {


    public CrystalMeth(int p_i45339_1_, float p_i45339_2_, boolean p_i45339_3_) {
        super(p_i45339_1_, p_i45339_2_, p_i45339_3_);
        this.setCreativeTab(BreakingBad.BreakingBadTab_);
    }

    public EnumAction getItemUseAction(ItemStack par1ItemStack) {
        return EnumAction.block;
    }

    @Override
    public int getMaxItemUseDuration(ItemStack par1ItemStack) {
        return 20;
    }

    @Override
    public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer) {
        SoundHandler.onEntityPlay("methsnort", par2World, par3EntityPlayer, 5, 1);
        par3EntityPlayer.setItemInUse(par1ItemStack, getMaxItemUseDuration(par1ItemStack));
        return par1ItemStack;
    }


    @Override
    protected void onFoodEaten(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer) {
        --par1ItemStack.stackSize;
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.confusion.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.moveSpeed.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.damageBoost.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.digSpeed.getId(), 2000, 2));
        par3EntityPlayer.addPotionEffect(new PotionEffect(Potion.harm.getId(), 1, 1));
        SoundHandler.onEntityPlay("tightyeah", par2World, par3EntityPlayer, 5, 1);
    }

    //TODO CODE- DEATH BY OVERDOSE
}

 

 

thanks to everyone who helped!

-Pandassaurus