Jump to content

[Resolved][1.7.2] Custom Log causing crash when rendered


Recommended Posts

Posted

Hi all, sorry for appearing so often with these questions.

I'm trying to make a custom log that will replace an oak log and keep it's orientation (right click an oak tree with an axe, the bark is stripped off and will regrow over time) but so far, although eclipse isn't throwing up any errors with the code, I've clearly buggered up somewhere. The texture icon fails to load and if the block is displayed in a creative tab, search tab or such, the client crashes out immediately.

 

Block Class:

 

  Reveal hidden contents

 

 

Main Class:

 

  Reveal hidden contents

 

 

Console Log:

 

  Reveal hidden contents

 

 

Image:

<assets.bigassbarrels.textures.blocks>

StrippedLog.png

 

Cheers again for any help offered, Modding is proving frustrating, but bloody fun too!

Posted

Cheers Link, the trouble I'm getting there though, is that Eclipse screams at me that BlockRotatedPillar must implement getSideIcon() (I was looking at the wood log source code to try and make this function in an identical manner, just without the metadata subblocks. :/

 

  On 3/14/2014 at 6:40 PM, diesieben07 said:

This people, is why you use @Override.

I did originally have @Override on each method originally, I majorly derped a bit then, I made the assumption that the client side annotation would override as well.

Posted

Everybody using eclipse and others like it should know this. The @Override annotation is put there as an error catcher!!! if you remove it, then you are ignoring some serious error you might be creating. Obviously any attempt to subclass a class and override methods (usually what you want) will be caught and signalled as errors only if the annotation is left in place. If it is removed, fine. Just beware that you are not actually overriding any method (you are creating a similar method). And your method may never be called. Worse, the original method will still be called. So, don't remove @Override!!!

Posted

Cheers for explaining @Override's functionality in greater depth Sequiturian.

I've tried extending blockLog instead of blockRotatedPillar,  but I get all kinds of issues with methods not accepting overrides unless they're made final,  usually happens with the protected ones.  I think I'll have to try and transplant over more code than I first thought.  I'll update this thread if I can get it working.  Cheers to everyone who has taken the time to reply so far though!

Posted

I have the same problem when using getSideIcon in any class. I've tried using @Override and also tried changing it to getIcon instead, as suggested, but as you've said, it still doesn't work. I doesn't work even if you do a direct copy of the vanilla code. Have you found any solution yet?

Posted

Hi Silas, Not Yet I'm afraid, assigning text name is working if I have it instead of any GetIcon/GetSideIcon code.

At the moment that best I've managed is to isolate it down to a NullPointer exception in the getIcon return so for some reason, the icons array is getting filled with Null Objects. I can't say if this is the same problem for you, we could both be missing something completely obvious.

Posted

getSideIcon is not a method in block or BlockFire. Why would expect to implement a nonexistent method? Did you mean GetIcon(side,meta) or GetFireIcon(index)?

 

Let me speak plainer Ingrish, @Override is used for methods you are wanting/expecting/desiring/needing to override. There is nothing that says you cannot implement your own private or public methods in your extended class.

Posted

In my case, I'm using getSideIcon when extendind BlockRotatedPillar and getIcon with plain old Block. Neither one is working and it appears to be when I'm calling RegisterIcon()

 

Here's the class as it currently stands, commenting out the fuctions was the only way to stop it auto-crashing the game until I can work out what's up when I try to register the icons.

 

package minothor.bab.blocks;

import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import net.minecraft.util.IIcon;
import net.minecraft.block.*;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.world.World;

public class blockStrippedOak extends Block{


public blockStrippedOak() {
	super(Material.wood);
	setBlockName("BlockStrippedOak");
	setHarvestLevel("axe",0);
	setHardness(0.5F);
	setStepSound(Block.soundTypeWood);
	// TODO Auto-generated constructor stub

}

@SideOnly(Side.CLIENT)
protected IIcon[] icons;


@SideOnly(Side.CLIENT)
public void registerIcons(IIconRegister par1IconRegister)
{
	this.icons = new IIcon[2];
	System.out.println("Icon Array Length: "+ icons.length);
	this.icons[0] = par1IconRegister.registerIcon("bigassbarrels" + ":" + "StrippedLog");
	System.out.println("icons 0 :" + icons[0]);
	this.icons[1] = par1IconRegister.registerIcon("bigassbarrels" + ":" + "StrippedLog");
	System.out.println("icons 1 :" + icons[1]);
}

/*@SideOnly(Side.CLIENT)
@Override
public IIcon getIcon(int side, int meta)
{
	switch(side)
	{
	case 0:
		return this.icons[0];
	case 1:
		return this.icons[0];
	default:
		return this.icons[1];

	}
}
 */
public int onBlockPlaced (World world, int x, int y, int z, int side, float hitX, float hitY, float hitZ, int metaD)
{
	// This metadata code comes from Natura's Darkwood Log, pasted here as a reminder and notepad of sorts.
	/*int j1 = par9 & 3;
        byte b0 = 0;

        switch (par5)
        {
        case 0:
        case 1:
            b0 = 0;
            break;
        case 2:
        case 3:
            b0 = 8;
            break;
        case 4:
        case 5:
            b0 = 4;
        }

        return j1 | b0;
	 */
	System.out.println("Placed against side: " + side);
	System.out.println("Side / 2: " + (side/2));
	System.out.println("Side % 2: " + (side%2));
	return metaD;
}

}

Posted

Here's the Latest run:

 

package minothor.bab.blocks;

import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import net.minecraft.util.IIcon;
import net.minecraft.block.*;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.world.World;

public class blockStrippedOak extends BlockRotatedPillar{


public blockStrippedOak() {
	super(Material.wood);
	setBlockName("BlockStrippedOak");
	setHarvestLevel("axe",0);
	setHardness(0.5F);
	setStepSound(Block.soundTypeWood);
	// TODO Auto-generated constructor stub

}

@SideOnly(Side.CLIENT)
protected IIcon[] icons;


@SideOnly(Side.CLIENT)
@Override
public void registerIcons(IIconRegister par1IconRegister)
{
	this.icons = new IIcon[2];
	System.out.println("Icon Array Length: "+ icons.length);
	this.icons[0] = par1IconRegister.registerIcon("bigassbarrels" + ":" + "StrippedLog");
	System.out.println("icons 0 :" + icons[0]);
	this.icons[1] = par1IconRegister.registerIcon("bigassbarrels" + ":" + "StrippedLog");
	System.out.println("icons 1 :" + icons[1]);
}

@SideOnly(Side.CLIENT)
@Override
public IIcon getSideIcon(int side)
{
	switch(side)
	{
	case 0:
		return this.icons[0];
	case 1:
		return this.icons[0];
	default:
		return this.icons[1];

	}
}
public int onBlockPlaced (World world, int x, int y, int z, int side, float hitX, float hitY, float hitZ, int metaD)
{
	/*int j1 = par9 & 3;
        byte b0 = 0;

        switch (par5)
        {
        case 0:
        case 1:
            b0 = 0;
            break;
        case 2:
        case 3:
            b0 = 8;
            break;
        case 4:
        case 5:
            b0 = 4;
        }

        return j1 | b0;
	 */
	System.out.println("Placed against side: " + side);
	System.out.println("Side / 2: " + (side/2));
	System.out.println("Side % 2: " + (side%2));
	return metaD;
}

}

 

and the console output:

 

  Reveal hidden contents

 

Posted

getSideIcon and getTopIcon only pass in the lower 2 bits of meta data. No side information is passed. All sides are expected to use the same icon, only the metadata bits determine the look of the side. In other words, It's bark (side) or rings (top).

Posted

Cheers Sequiturian! That explanation of what the parameters are was the final piece of the puzzle for me!

I've now got the custom texture icon working and I've changed the block to extend BlockLog.

All I need to do now is work out how to correctly reference the vanilla tree_top.png texture.

I'll see if I can dig the original out of the TextureAtlas.

 

blockStrippedOak class now:

 

package minothor.bab.blocks;

import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import net.minecraft.util.IIcon;
import net.minecraft.block.*;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.world.World;

public class blockStrippedOak extends BlockLog{


public blockStrippedOak() {
	super();
	setBlockName("BlockStrippedOak");
	setHarvestLevel("axe",0);
	setHardness(0.5F);
	setStepSound(Block.soundTypeWood);

}

@SideOnly(Side.CLIENT)
protected IIcon[] icons;


@SideOnly(Side.CLIENT)
@Override
public void registerBlockIcons(IIconRegister par1IconRegister)
{
	this.icons = new IIcon[2];
	//System.out.println("Icon Array Length: "+ icons.length);
	this.icons[0] = par1IconRegister.registerIcon("minecraft:Tree_Top");
	System.out.println("icons 0 :" + icons[0]);
	this.icons[1] = par1IconRegister.registerIcon("bigassbarrels:StrippedLog");
	//System.out.println("icons 1 :" + icons[1]);
}

@SideOnly(Side.CLIENT)
@Override
public IIcon getSideIcon(int metaD)
{
	return this.icons[1];
}

@SideOnly(Side.CLIENT)
@Override
public IIcon getTopIcon(int metaD)
{
	return this.icons[0];
}


public int onBlockPlaced (World world, int x, int y, int z, int side, float hitX, float hitY, float hitZ, int metaD)
{
	/*int j1 = par9 & 3;
        byte b0 = 0;

        switch (par5)
        {
        case 0:
        case 1:
            b0 = 0;
            break;
        case 2:
        case 3:
            b0 = 8;
            break;
        case 4:
        case 5:
            b0 = 4;
        }

        return j1 | b0;
	 */
	System.out.println("Placed against side: " + side);
	System.out.println("Side / 2: " + (side/2));
	System.out.println("Side % 2: " + (side%2));
	return metaD;
}

}

 

Console Log:

 

  Reveal hidden contents

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Ready to unlock unbeatable savings on Temu? Our exclusive Temu code [ald244107] is your ultimate secret weapon for a $100 OFF discount, plus so much more this year! Whether you're making your first purchase or returning for another shopping spree, this verified promo code gives you an instant boost, with up to 50% off your next order and even deeper discounts on clearance items. With Temu coupon code [ald244107], you're not just getting a flat $100 discount; you're stacking it on top of already fantastic sales! New users can grab an extra 100% off selected products, while loyal customers automatically qualify for that sweet $100 OFF when they apply the code at checkout. Imagine slashing prices by up to 90% on everything from trending electronics and stylish fashion to essential home goods and top-rated beauty products, all available across the USA, Canada, UK, and countless other countries! 🔥 Top Temu Code [ald244107] Benefits:  * For New Users: Use ald244107 for 50% off your first order + an additional $100 OFF.  * For Existing Customers: Apply ald244107 to get an instant $100 OFF on your next purchase.  * Global Reach: Valid across the USA, UK, Canada, Germany, France, Japan, Chile, Colombia, Malaysia, Mexico, South Korea, Philippines, Saudi Arabia, Qatar, Pakistan, and many more.  * Best of 2025: Secure up to $200 OFF plus incredible bonus discounts with ald244107. Maximize Your Savings: Featured Temu Deals for 2025 (Code: ald244107)  * ✅ Temu Flash Sales: Don't miss out! Score $100 off during limited-time offers with ald244107.  * ✅ Temu First Order Bonanza: Use ald244107 for a powerful 50% + $100 OFF on your initial purchase.  * ✅ Temu US Shopper Advantage: Instantly save $100 on your orders with ald244107.  * ✅ International Temu Discounts: ald244107 works seamlessly to give you savings in Japan, Germany, Chile, and beyond.  * ✅ Temu Community Favorite: Enjoy $100 OFF for both new and old users, a widely praised deal!  * ✅ Temu Coupon Bundles 2025: Combine $100 OFF with up to 50% slash deals for ultimate savings.  * ✅ 100% OFF Free Gift Code: Use ald244107 to claim a free gift – no invitation or referral needed!  * ✅ Temu Welcome Bonus: Get a delightful $100 OFF instantly upon signing up for an account.  * ✅ Free Temu Code for New Accounts: Apply ald244107 for immediate, hassle-free savings.  * ✅ Temu Clearance Blowout 2025: Use ald244107 for jaw-dropping 85–100% discounts on clearance items. This Temu code [ald244107] is more than just a discount; it's your all-access pass to complimentary shipping, exclusive first-order perks, and stackable coupon bundles across an immense selection of electronics, trendy fashion, essential home goods, and premium beauty products. Truly unlock up to 90% OFF plus an additional $100 OFF on eligible orders! 💡 Pro Tip: Always remember to apply ald244107 during checkout on the Temu app or website. Your instant $100 discount activates automatically, even if you're a returning customer! Where Does Temu Code [ald244107] Work? (Global Availability)  * 🇺🇸 Temu USA – ald244107  * 🇯🇵 Temu Japan – ald244107  * 🇲🇽 Temu Mexico – ald244107  * 🇨🇱 Temu Chile – ald244107  * 🇨🇴 Temu Colombia – ald244107  * 🇲🇾 Temu Malaysia – ald244107  * 🇵🇭 Temu Philippines – ald244107  * 🇰🇷 Temu Korea – ald244107  * 🇵🇰 Temu Pakistan – ald244107  * 🇫🇮 Temu Finland – ald244107  * 🇸🇦 Temu Saudi Arabia – ald244107  * 🇶🇦 Temu Qatar – ald244107  * 🇫🇷 Temu France – ald244107  * 🇩🇪 Temu Germany – ald244107 Hear From Happy Shoppers: User Reviews We love hearing about your experiences! Here's what some satisfied customers are saying about using the Temu code [ald244107]:  * Alice W., USA ⭐️⭐️⭐️⭐️⭐️ (5/5) "Great experience! Temu's promo code {ald244107} saved me a lot on my first order. Highly recommend this offer!"  * James T., UK ⭐️⭐️⭐️⭐️ (4/5) "Very happy with the quality and prices on Temu. The $100 credits offer was a nice bonus using {ald244107}. Will shop again."  * Sara M., Canada ⭐️⭐️⭐️ (3/5) "Got some decent deals with the {ald244107} code, though shipping took a bit longer than expected. Overall satisfied with the credits." Trending Verified Temu Deals for 2025 Stay ahead of the curve with the most popular and verified Temu deals for 2025. Our community consistently confirms the effectiveness of Temu code [ald244107] for maximum savings across a wide range of products. Don't miss out on these trending opportunities to save big! FAQs: Everything You Need to Know About Temu Code [ald244107] Q: What is Temu code [ald244107] and what does it offer? A: Temu code [ald244107] is a verified promo code that provides users with a $100 discount, plus additional savings of up to 50% or even 90% on various items. It's valid for both new and existing customers on the Temu platform. Q: How do I apply Temu code [ald244107]? A: Simply enter [ald244107] in the coupon or promo code field during checkout on the Temu app or website to apply your discounts automatically. Q: Does Temu code [ald244107] benefit new users specifically? A: Yes, ald244107 offers fantastic benefits for new users, including an exclusive 50% off their very first order in addition to the $100 discount. Q: Is Temu code [ald244107] also valid for existing customers? A: Absolutely! Loyal Temu customers can also enjoy a flat $100 OFF discount by seamlessly applying ald244107 at checkout. Q: In which countries can I use Temu code [ald244107]? A: This code boasts widespread global availability, working in numerous countries including the USA, UK, Canada, Germany, France, Japan, Saudi Arabia, Qatar, and many more listed above. Q: Can Temu code [ald244107] be combined with other offers? A: Temu code [ald244107] is strategically designed to provide savings on top of existing deals, making it often stackable with other promotions for truly maximizing your discounts. Unlock Huge Savings with Temu Code [ald244107] – Your Best Bet for 2025! Don't let these incredible savings slip away! Whether you're exploring Temu for the first time or returning for more great finds, the Temu code [ald244107] is your ultimate tool for significant discounts, exciting free gifts, and unbeatable deals. Apply it today and see how much you can save! Happy shopping! [ald244107]  
    • I've tried the java version you linked to and got a new exit code of 127 Here is the new console log I also tried making sure that I had Java 8 selected with the version of Java 8 I already had installed and got the same exit code Here is the console log with that installation in case it has any differences I do notice both say 'Java checker returned some invalid data we don't understand:' followed by 'Minecraft might not start properly.' which could be some issues.  
    • Thank you so much! I didnt see it in the log😭😭  
    • So im completely new to modding in general, i have some experience in Behavior packs in minecraft bedrock and i would like to modify entities stats and attributes like in a behavior pack (health, damage, speed, xp drop...). The problem is that i cant find any information online on how to do that, and I have no clue on what to do and where to start. I am currently modding in 1.20.4 with IntelliJ if that helps. My final objective is to buff mobs health and damage (double it for exemple), but since there is no entity file anywhere i don't know how to change it... 😢
    • Hey there, nothing to do with the code, I am just suggesting you use Intelij IDEA. Trust me, it is the best.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.