[solved] packet channel behaving strangely

[Athire]

hello guys! I've been struggling with this issue for the last few days. So I have a keybind which should be sending a packet to the server when the key is pressed ( for multiplayer compatibility). One issue is that it isn't sending when the key is pressed, but the main reason I am here is because whenever i send a packet on a different channel, my packet handler executes that channel's function as well as the keybinding packet's function. To be more specific, I have a few channels: "manaChannel" handles updates to the player's mana, "spellChannel" changes the player's active spell, and my new one "useAbility"  is supposed to execute that ability when the key is pressed. If i send a packet on "manaChannel" or "spellChannel", my packet handler executes the function for both the received channel and my "useAbility" channel. I don't quite know how this can happen, not only do I use an if statement to check for the channel, but I changed it to an else-if block when this problem started. It still executes both! My first thought was that multiple packets were being received simultaneously, so I put a "system.out.println();" at the begining of my packet handler to report the channel of the received packet. I put similar statements in each else-if statement, as can be seen in my code. When I run the program and send a packet on one of the other channels, the system.out line prints that the correct channel is being received, and then it passes into the correct if statement AND the "useAbility" if statement. For example the console will print:

 

Packet recieved on channel: spellchannel

[sTDOUT] Packet recieved in changeActiveSpell

[sTDOUT] Packet entered spellChannel block

[sTDOUT] Packet entered useSpell block with channel: spellchannel

2014-03-17 16:05:22 [iNFO] [sTDOUT] Packet recieved in useSpell

 

In this case, changeActiveSpell is the function which executes the code for spellchannel and useSpell is the function which should only execute for packets of the channel "useAbility".

 

Here is the relevant code (on a side note I just figured out how to use spoilers. If they don't work and I end up posting a big chunk of code I apologize D: )

 

Here is the onPacketData portion of my packet handler

 

 

@Override

public void onPacketData(INetworkManager manager, Packet250CustomPayload packet, Player player)

{

 

System.out.println("Packet recieved on channel: "+packet.channel);

// This is a good place to parse through channels if you have multiple channels

 

if (packet.channel.equals("manachannel"))

{

System.out.println("Packet entered manaChannel block");

handleExtendedProperties(packet, player);   

 

}

else if(packet.channel.equals("spellchannel"))

{

 

changeActiveSpell(packet,player);

System.out.println("Packet entered spellChannel block");

}

else if(packet.channel.equals( "mobVelocity"))

{

System.out.println("Packet entered mobVelocity block");

handleMobVelocity(packet, player);

}

// System.out.println("Packet nearing useSpell block with channel: "+packet.channel);

else if(packet.channel.equals("useAbility"));

{

 

System.out.println("Packet entered useSpell block with channel: "+packet.channel);

useSpell(packet, player);

}

}

 

 

 

Here is the keybinding where the packet should send but doesn't

 

 

public static void playerTick(EntityPlayer player)

{

World par2World = player.worldObj;

magicPlayer props= magicPlayer.get(player);

//player.addChatMessage("Acive Spell: "+props.activeSpellID);

//int slotNum=spellSlotKeyBinding.id;

boolean hasScreenOpen=false;

if(par2World.isRemote)

{

if(Minecraft.getMinecraft().currentScreen== null)

{

hasScreenOpen=false;

System.out.println("currentScreen = null");

}

else

hasScreenOpen=true;

}

 

if(!hasScreenOpen)

{

 

        if(spellSlotKeyBinding.keyPressed1)

        {

        System.out.println("keyPressed1 is true");

       

        ByteArrayOutputStream bos = new ByteArrayOutputStream(;

    DataOutputStream outputStream = new DataOutputStream(bos);

 

   

    try {

    System.out.println("Writing output: 1");

    outputStream.writeInt(1);

   

    } catch (Exception ex) {

    ex.printStackTrace();

    }

 

    Packet250CustomPayload packet = new Packet250CustomPayload("useAbility", bos.toByteArray());

   

    //if (player.worldObj.isRemote) { <-- Does not work in singleplayer, commented out for now

    System.out.println("Sending packet on channel useSpell");

    PacketDispatcher.sendPacketToServer(packet);

    //}

 

 

 

Here is where I declare the packet channels in my main mod class:

 

 

 

@NetworkMod(clientSideRequired= true, serverSideRequired= false, channels={"manachannel","spellchannel", "mobVelocity", "useAbility"}, packetHandler = manaPacketHandler.class)

 

 

 

 

Thank you in advance to anyone who can help me! I'm still a bit new to the whole packet handling thing but I think I'm getting the hang of them (all of the other channels seemed to work before this last one was created). This problem has just been so strange that I haven't been able to figure it out! Thank you guys again!

[Athire]

By the way I'm in 1.6.4! Sorry for not including that earlier

[GotoLink]

else if(packet.channel.equals("useAbility"));

This part ends with ";". Not good.

[Athire]

Oh wow  can't believe I missed that! That's coding 101! I'm a bit new to java but I've done a lot of C++, I really should have caught that! Thank you, it's always helpful to have an extra set of eyes!