Hello i wont lie i am new to modding but i have come here to get help so if your going just tell me to learn java i know that is what i am trying to do.Ok now my problem is i am trying to create an item that when you right click opens a GUI. Now i don't know weather i have made the GUI wrong or the item right click wrong.

Here is my code.

 

---------------------------------------------------------------------------------------------------------------------

package portalgestures;

 

 

 

import net.minecraft.creativetab.CreativeTabs;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.init.Items;

import net.minecraft.item.Item;

import net.minecraft.item.ItemStack;

import net.minecraft.world.World;

import cpw.mods.fml.common.Mod;

import cpw.mods.fml.common.Mod.EventHandler; // used in 1.6.2

//import cpw.mods.fml.common.Mod.PreInit;    // used in 1.5.2

//import cpw.mods.fml.common.Mod.Init;      // used in 1.5.2

//import cpw.mods.fml.common.Mod.PostInit;  // used in 1.5.2

import cpw.mods.fml.common.Mod.Instance;

import cpw.mods.fml.common.SidedProxy;

import cpw.mods.fml.common.event.FMLInitializationEvent;

import cpw.mods.fml.common.event.FMLPostInitializationEvent;

import cpw.mods.fml.common.event.FMLPreInitializationEvent;

import cpw.mods.fml.common.network.NetworkRegistry;

import cpw.mods.fml.common.network.internal.FMLNetworkHandler;

import cpw.mods.fml.common.registry.GameRegistry;

 

 

@Mod(modid = Portalgestures.modid, version = Portalgestures.version)

public class Portalgestures {

 

public static final String modid = "Portalgestures";

public static final String version = "0.0.0.0.0";

 

public static Portalgestures instance;

     

        @Instance(value = "portalgestures")

     

       

    public static Item portalgesturesInterface;

   

    public static final int guiPortalgestures = 0;

 

       

        @SidedProxy(clientSide="portalgestures.client.ClientProxy", serverSide="portalgestures.CommonProxy")

        public static CommonProxy proxy;

       

        public static CreativeTabs portalgestures = new CreativeTabs("portalgesturesTab"){

    public Item getTabIconItem() {

    return Items.nether_star;

    }

   

        };

        @EventHandler

    public void preInit(FMLPreInitializationEvent e){

        portalgesturesInterface = new Item().setUnlocalizedName("portalgesturesInterface").setCreativeTab(portalgestures).setTextureName("portalgestures:portalgestures Interface");

    GameRegistry.registerItem(portalgesturesInterface, "portalgesturesInterface");  }

       

        public ItemStack onItemRightClick(ItemStack itemstack, World world, EntityPlayer player)  {     

 

        {

        if(!world.isRemote)

                FMLNetworkHandler.openGui(player, Portalgestures.instance, Portalgestures.guiPortalgestures, world, x, y, z);

       

        }

           

       

 

      return itemstack;

     

}

       

 

        @EventHandler

    public void Init(FMLPreInitializationEvent e) {

        instance = this;

       

       

       

        NetworkRegistry.INSTANCE.registerGuiHandler(this, new LookeGuiHandler());

        }

       

        @EventHandler

        public void load(FMLInitializationEvent event) {

                proxy.registerRenderers();

        }

       

        @EventHandler

        public void postInit(FMLPostInitializationEvent event) {

                // Stub Method

        }

}

 

---------------------------------------------------------------------------------------------------------------------------------

package portalgestures;

 

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.world.World;

import cpw.mods.fml.common.network.IGuiHandler;

 

public class LookeGuiHandler implements IGuiHandler {

 

@Override

public Object getServerGuiElement(int ID, EntityPlayer player, World world,int x, int y, int z) {

 

 

switch(ID) {

  case Portalgestures.guiPortalgestures:

  return new Object();

 

}

 

return null;

}

 

@Override

public Object getClientGuiElement(int ID, EntityPlayer player, World world,int x, int y, int z) {

 

switch(ID) {

  case Portalgestures.guiPortalgestures:

  return new GuiPortalgestures();

 

}

 

 

 

return null;

}

 

}

-----------------------------------------------------------------------------------------------------------------------------------------

package portalgestures;

 

import net.minecraft.client.gui.GuiScreen;

import net.minecraft.inventory.Container;

import net.minecraft.util.ResourceLocation;

 

public class GuiPortalgestures extends GuiScreen{

 

public final ResourceLocation texture = new ResourceLocation(Portalgestures.modid, "textures/portalgestures/textures/gui" );

 

 

 

 

public void drawGuiContainerBackgroundLayer(float var1, int var2, int var3) {

 

}

 

}

 

 

 

 

-----------------------------------------------------------------------------------------------------------------------------------

package portalgestures;

 

public class CommonProxy {

 

        // Client stuff

        public void registerRenderers() {

                // Nothing here as the server doesn't render graphics or entities!

        }

}

--------------------------------------------------------------------------------------------------------------------------

Dude.

Learn basic Java before coming to mod.

 

You don't put another method inside a method, to use the onItemRightClick you need to create your own Item class.

can you elaborate a bit more on how i would do that or if you could link a tutorial that would be awesome!

 

Seriously, do your research. It's not that hard.

 

http://lmgtfy.com/?q=minecraft+forge+item

I applaud for the cool link but seriously i wanted to know how you make a class for an item instead of doing what i was doing (which works)

Did you even bother to look at any of the google results? *sigh* if I really must... http://www.minecraftforge.net/wiki/Basic_Items

 

That's how you make an item. The tutorial shows you how to create an item class and use it from your code. And BTW, your code will not work. onItemRightClick needs to go inside your custom item class, _not_ your main mod class. In there, it won't do anything.

 

Also, protip: make sure you use @Override on methods where applicable (look it up).

Ah, didn't realize that, sorry. I think it's time someone should do it anyway... I think I will. I'll tell you when it's updated.

thnx becuse all the item tutorials i have found put all the code for the item in the main mod file.

Uhh... what tutorials are you following? That shouldn't work at all.

lol it works for me this tutorial:https://www.youtube.com/watch?v=4VzP6AohgXQ

I just updated the Basic Items tutorial to 1.7. Try following it now. http://www.minecraftforge.net/wiki/Basic_Items