Search the Forums BEFORE making a new post.

[Solved] Bounding boxes [1.7.2]

Posted March 27, 201411 yr

Hello, i made a block with a custom model and it's larger then a standard block. When i made the bounding boxes larger, the collision boees weren't right. To solve that issue, i did a trick which sets some blocks above it, with the same type, but with a different metadata. It then created another problem: the bounding boxes weren't right any more. All the blocks have the same bounding boxes, but i wan't them to be differently based on metadata.

To summary, all the blocks have a bounding box of 1x7x1, instead of the block above, that should have a bounding box, which is like 1 block down.

Code:

[spoiler=BlockStreetlight]

package larsg310.mods.moderncities.block;

import larsg310.mods.moderncities.ModernCities;
import larsg310.mods.moderncities.lib.Names;
import larsg310.mods.moderncities.lib.RenderIds;
import larsg310.mods.moderncities.tileentity.TileEntityStreetlight;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.init.Blocks;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.MathHelper;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;

public class BlockStreetlight extends Block
{
public BlockStreetlight()
{
	super(Material.iron);
	this.setCreativeTab(ModernCities.CREATIVE_TAB);
	this.setBlockName(Names.STREETLIGHT);
}

public TileEntity createTileEntity(World world, int meta)
{
	if (meta <= 5) return new TileEntityStreetlight();
	return null;
}

public boolean hasTileEntity(int meta)
{
	if (meta <= 5) return true;
	return false;
}

private void setDefaultDirection(World world, int x, int y, int z)
{
	if (!world.isRemote)
	{
		Block block = world.getBlock(x, y, z - 1);
		Block block1 = world.getBlock(x, y, z + 1);
		Block block2 = world.getBlock(x - 1, y, z);
		Block block3 = world.getBlock(x + 1, y, z);
		byte b0 = 3;

		if (block.func_149730_j() && !block1.func_149730_j())
		{
			b0 = 3;
		}

		if (block1.func_149730_j() && !block.func_149730_j())
		{
			b0 = 2;
		}

		if (block2.func_149730_j() && !block3.func_149730_j())
		{
			b0 = 5;
		}

		if (block3.func_149730_j() && !block2.func_149730_j())
		{
			b0 = 4;
		}

		world.setBlockMetadataWithNotify(x, y, z, b0, 2);
	}
}

public void onBlockPlacedBy(World world, int x, int y, int z, EntityLivingBase player, ItemStack itemstack)
{
	int l = MathHelper.floor_double((double) (player.rotationYaw * 4.0F / 360.0F) + 0.5D) & 3;

	if (l == 0)
	{
		world.setBlockMetadataWithNotify(x, y, z, 2, 2);
	}

	if (l == 1)
	{
		world.setBlockMetadataWithNotify(x, y, z, 5, 2);
	}

	if (l == 2)
	{
		world.setBlockMetadataWithNotify(x, y, z, 3, 2);
	}

	if (l == 3)
	{
		world.setBlockMetadataWithNotify(x, y, z, 4, 2);
	}
	world.setBlock(x, y + 1, z, ModBlocks.STREETLIGHT, 6, 3);
	world.setBlock(x, y + 2, z, ModBlocks.STREETLIGHT, 7, 3);
	world.setBlock(x, y + 3, z, ModBlocks.STREETLIGHT, 8, 3);
	world.setBlock(x, y + 4, z, ModBlocks.STREETLIGHT, 9, 3);
	world.setBlock(x, y + 5, z, ModBlocks.STREETLIGHT, 10, 3);
	world.setBlock(x, y + 6, z, ModBlocks.STREETLIGHT, 11, 3);
}

public void onBlockAdded(World world, int x, int y, int z)
{
	super.onBlockAdded(world, x, y, z);
	this.setDefaultDirection(world, x, y, z);
}

public boolean renderAsNormalBlock()
{
	return false;
}

public boolean isOpaqueCube()
{
	return false;
}

public int getRenderId()
{
	return RenderIds.STREETLIGHT;
}

public boolean shouldSideBeRendered(IBlockAccess world, int x, int y, int z, int side)
{
	return false;
}

public void setBlockBoundsBasedOnState(IBlockAccess world, int x, int y, int z)
{
	int meta = world.getBlockMetadata(x, y, z);
	if (meta <= 5) this.setBlockBounds(0, 0, 0, 1, 7, 1);
	if (meta == 6) this.setBlockBounds(0, -1, 0, 1, 6, 1);
	if (meta == 7) this.setBlockBounds(0, -2, 0, 1, 5, 1);
	if (meta ==  this.setBlockBounds(0, -3, 0, 1, 4, 1);
	if (meta == 9) this.setBlockBounds(0, -4, 0, 1, 3, 1);
	if (meta == 10) this.setBlockBounds(0, -5, 0, 1, 2, 1);
	if (meta == 11) this.setBlockBounds(0, -6, 0, 1, 1, 1);
}

public void breakBlock(World world, int x, int y, int z, Block block, int field)
{
	Block blockAbove = world.getBlock(x, y + 1, z);
	Block blockBelow = world.getBlock(x, y - 1, z);

	world.setBlock(x, y, z, Blocks.air);
	super.breakBlock(world, x, y, z, block, field);
	if (blockAbove == this) blockAbove.breakBlock(world, x, y + 1, z, block, field);
	if (blockBelow == this) blockBelow.breakBlock(world, x, y - 1, z, block, field);
}
}

If you need more code or information, i'll be happy to provide it.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

1.12 -> 1.13 primer by williewillus.

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

http://www.howoldisminecraft1710.today/

Quote

March 27, 201411 yr

Use

setBlockBoundBasedOnState()

. You'll get a world object and the position with this method, so you can find out the metadata.

Here is an example of this method: (Used in my SignCraft-Mod)

@Override
public void setBlockBoundsBasedOnState(IBlockAccess world, int x, int y, int z)
    {
    	int meta = world.getBlockMetadata(x, y, z);
    	float p0 = 0.0F;
    	float p16 = 1.0F;
    	float p2 = 0.125F;
    	this.setBlockBounds(0.0F, 0.0F, 0.0F, 1.0F, 1.0F, 1.0F);
    	
    	if (meta == 0)
    	{
    		this.setBlockBounds(p0, p0, p0, p16, p16, p2);
    	}

    	if (meta == 3)
    	{
    		this.setBlockBounds(p0, p0, p0, p2, p16, p16);
    	}
    	
    	if (meta == 2)
    	{
    		this.setBlockBounds(p0, p0, p16 - p2, p16, p16, p16);
    	}
    	
    	if (meta == 1)
    	{
    		this.setBlockBounds(p16, p0, p0, p16 - p2, p16, p16);
    	}
    }

width=356 height=100 http://i.imgur.com/wNvtGZw.png[/img]

MODS and MODDING TUTORIALS

Quote

March 27, 201411 yr

Author

Use

setBlockBoundBasedOnState()

. You'll get a world object and the position with this method, so you can find out the metadata.

Here is an example of this method: (Used in my SignCraft-Mod)

@Override
public void setBlockBoundsBasedOnState(IBlockAccess world, int x, int y, int z)
    {
    	int meta = world.getBlockMetadata(x, y, z);
    	float p0 = 0.0F;
    	float p16 = 1.0F;
    	float p2 = 0.125F;
    	this.setBlockBounds(0.0F, 0.0F, 0.0F, 1.0F, 1.0F, 1.0F);
    	
    	if (meta == 0)
    	{
    		this.setBlockBounds(p0, p0, p0, p16, p16, p2);
    	}

    	if (meta == 3)
    	{
    		this.setBlockBounds(p0, p0, p0, p2, p16, p16);
    	}
    	
    	if (meta == 2)
    	{
    		this.setBlockBounds(p0, p0, p16 - p2, p16, p16, p16);
    	}
    	
    	if (meta == 1)
    	{
    		this.setBlockBounds(p16, p0, p0, p16 - p2, p16, p16);
    	}
    }

Ughh Ughh...

public void setBlockBoundsBasedOnState(IBlockAccess world, int x, int y, int z)
{
	int meta = world.getBlockMetadata(x, y, z);
	if (meta <= 5) this.setBlockBounds(0, 0, 0, 1, 7, 1);
	if (meta == 6) this.setBlockBounds(0, -1, 0, 1, 6, 1);
	if (meta == 7) this.setBlockBounds(0, -2, 0, 1, 5, 1);
	if (meta ==  this.setBlockBounds(0, -3, 0, 1, 4, 1);
	if (meta == 9) this.setBlockBounds(0, -4, 0, 1, 3, 1);
	if (meta == 10) this.setBlockBounds(0, -5, 0, 1, 2, 1);
	if (meta == 11) this.setBlockBounds(0, -6, 0, 1, 1, 1);
}

But that doesn't work. Anyone know why?

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

1.12 -> 1.13 primer by williewillus.

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

http://www.howoldisminecraft1710.today/

Quote

March 27, 201411 yr

Author

After some research, i found out that it takes the first "this.setBlockBounds()" method, and not doing the rest. Anyone know why?

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

1.12 -> 1.13 primer by williewillus.

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

http://www.howoldisminecraft1710.today/

Quote

March 27, 201411 yr

So, you mean that meta is always <= 5?

Or that (eg) this.setBlockBounds(0, -1, 0, 1, 6, 1); doesn't set the bounds to what you expect?

-TGG

Quote

March 27, 201411 yr

Why not use a switch?

Quote

March 28, 201411 yr

Author

Hi

So, you mean that meta is always <= 5?

Or that (eg) this.setBlockBounds(0, -1, 0, 1, 6, 1); doesn't set the bounds to what you expect?

-TGG

Yes, they all get the bounding box of meta <= 5. But i don't know why. I use this code:

public void onBlockPlacedBy(World world, int x, int y, int z, EntityLivingBase player, ItemStack itemstack)
{
	int l = MathHelper.floor_double((double) (player.rotationYaw * 4.0F / 360.0F) + 0.5D) & 3;

	if (l == 0)
	{
		world.setBlockMetadataWithNotify(x, y, z, 2, 2);
	}

	if (l == 1)
	{
		world.setBlockMetadataWithNotify(x, y, z, 5, 2);
	}

	if (l == 2)
	{
		world.setBlockMetadataWithNotify(x, y, z, 3, 2);
	}

	if (l == 3)
	{
		world.setBlockMetadataWithNotify(x, y, z, 4, 2);
	}
	world.setBlock(x, y + 1, z, ModBlocks.STREETLIGHT, 6, 3);
	world.setBlock(x, y + 2, z, ModBlocks.STREETLIGHT, 7, 3);
	world.setBlock(x, y + 3, z, ModBlocks.STREETLIGHT, 8, 3);
	world.setBlock(x, y + 4, z, ModBlocks.STREETLIGHT, 9, 3);
	world.setBlock(x, y + 5, z, ModBlocks.STREETLIGHT, 10, 3);
	world.setBlock(x, y + 6, z, ModBlocks.STREETLIGHT, 11, 3);
}

to set the bottom block to a different metadata based on direction, and i set all blocks above it to a different meta, so it should never be the same meta. Any guesses why thy all get the same bounding box?

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

1.12 -> 1.13 primer by williewillus.

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

http://www.howoldisminecraft1710.today/

Quote

March 28, 201411 yr

Author

I figured it out! When the block is placed, it calls this code:

public void onBlockPlacedBy(World world, int x, int y, int z, EntityLivingBase player, ItemStack itemstack)
{
	int l = MathHelper.floor_double((double) (player.rotationYaw * 4.0F / 360.0F) + 0.5D) & 3;

	if (l == 0)
	{
		world.setBlockMetadataWithNotify(x, y, z, 2, 2);
	}

	if (l == 1)
	{
		world.setBlockMetadataWithNotify(x, y, z, 5, 2);
	}

	if (l == 2)
	{
		world.setBlockMetadataWithNotify(x, y, z, 3, 2);
	}

	if (l == 3)
	{
		world.setBlockMetadataWithNotify(x, y, z, 4, 2);
	}
	world.setBlock(x, y + 1, z, ModBlocks.STREETLIGHT, 6, 3);
	world.setBlock(x, y + 2, z, ModBlocks.STREETLIGHT, 7, 3);
	world.setBlock(x, y + 3, z, ModBlocks.STREETLIGHT, 8, 3);
	world.setBlock(x, y + 4, z, ModBlocks.STREETLIGHT, 9, 3);
	world.setBlock(x, y + 5, z, ModBlocks.STREETLIGHT, 10, 3);
	world.setBlock(x, y + 6, z, ModBlocks.STREETLIGHT, 11, 3);
}

When the blocks above it were placed, that block wasn't placed by the player, so it calls the onBlockAdded method, which sets the metadata to 2,3,4 or 5. And that was the problem. I solved it by replacing:

world.setBlock(x, y + 1, z, ModBlocks.STREETLIGHT, 6, 3);
	world.setBlock(x, y + 2, z, ModBlocks.STREETLIGHT, 7, 3);
	world.setBlock(x, y + 3, z, ModBlocks.STREETLIGHT, 8, 3);
	world.setBlock(x, y + 4, z, ModBlocks.STREETLIGHT, 9, 3);
	world.setBlock(x, y + 5, z, ModBlocks.STREETLIGHT, 10, 3);
	world.setBlock(x, y + 6, z, ModBlocks.STREETLIGHT, 11, 3);

by:

for(int i = 1; i < 7; i++)
	{
		world.setBlock(x, y + i, z, ModBlocks.STREETLIGHT, 0, 3);
		world.setBlockMetadataWithNotify(x, y+i, z, 5+i, 3);
	}

which just set's the metadata to the appropriate value, after the onBlockAdded method sets it to 2,3,4 or 5.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

1.12 -> 1.13 primer by williewillus.

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

http://www.howoldisminecraft1710.today/

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/17541-solved-bounding-boxes-172/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

New Forum Design/Update: Issues and Suggestions

Hiho,

first of all I want to say that the new forum design looks really good.

However, there are currently two issues:

In the "Unread" section, the "Mark all as Read" feature seems to be missing - or am I just overlooking it somewhere?
Some threads don’t automatically get marked as read when you open them. So the post still shows up in "Unread," even though you’ve already viewed it.
Example Thread: https://forums.minecraftforge.net/topic/159415-cannot-find-client-log-entries/

Then I have a smaller suggestion, referring to the Text Editor:

It is possible to move out the "Inline Code"-Feature from the "More Formatting Options" and add it directly to the Text Editor Tool Bar?
Same for "Quote"-Feature inside the Create Section

These two features are used quite often (at least by me) - as far as I remember, they were also available in the old forum design.

@Paint_Ninja @LexManos

By TileEntity · Posted 21 minutes ago21 min
Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

That fixed it! it's still being weird and not actually printing anything to CMD but the logs look fine and eventually the gui generated looking normal. Thanks for your help I've done that on linux before but windows servers have always just worked with one click for some reason for me

By Linksapprentice · 3 hours ago3 hr
Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

Make sure you are using Java 17 JDK

In the start script, replace the word "java" with the java 17 path (javaw.exe) and put it into quotation marks

By TileEntity · 6 hours ago6 hr
NEED HELP ASAP - Failed to load datapacks, can't proceed with server load. You can either fix your datapacks or reset to vanilla

There are client-side-only mods in your server - start with removing justenoughbreeding

By TileEntity · 6 hours ago6 hr
NEED HELP ASAP - Failed to load datapacks, can't proceed with server load. You can either fix your datapacks or reset to vanilla

Hey there, I have a big modpack I'm trying to run that I've put together with two other rather large communities- we have a grand opening scheduled for next week so it's really important that this gets solved ASAP.

The game runs fine in singleplayer, but when trying to run as a server using a hosting website, I've run into quite a massive error log. I've whittled it down to this point- I'm currently not sure what to do, as I believe the main error is relating to the datapack message, but I don't know for sure. Removing the datapack folder doesn't change the message either.

https://mclo.gs/2aTdXII

If the fix is something very simple, I apologize. I'm not too experienced with hosting websites and running large modpacks like this on a server.
I'm also not completely sure of which mods are client-only- a large handful of which are already disabled but I could be missing some. I just don't know which ones they would be, if that's causing the issue.

By nyxxiea · Posted 11 hours ago11 hr

TileEntity

Sign In

[Solved] Bounding boxes [1.7.2]

Featured Replies

Join the conversation

Posts

New Forum Design/Update: Issues and Suggestions

Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

NEED HELP ASAP - Failed to load datapacks, can't proceed with server load. You can either fix your datapacks or reset to vanilla

NEED HELP ASAP - Failed to load datapacks, can't proceed with server load. You can either fix your datapacks or reset to vanilla

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)