I am trying to give a person an item if they right click on a block. I have this:

 

@Override

public boolean onBlockActivated(World par1World, int x, int y, int z, EntityPlayer par5EntityPlayer, int par6, float par7, float par8, float par9) {

ItemStack heldItem = par5EntityPlayer.inventory.getCurrentItem();

ItemStack CDOrb = new ItemStack(MagicksMod.CDiamondOrb, 1);

if (heldItem == new ItemStack(MagicksMod.CDiamondOrb, 1)){

par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(Items.diamond));

}

 

 

 

return false;

}

 

But it doesn't work. What am I doing wrong?

 

PS It doesn't have any error, it just doesn't do anything.

That doesn't work because they are 2 different objects. Try someting like this:

@Override
public boolean onBlockActivated(World par1World, int x, int y, int z, EntityPlayer par5EntityPlayer, int par6, float par7, float par8, float par9){
   if(!par1World.isRemote){
        ItemStack heldItem = par5EntityPlayer.inventory.getCurrentItem();
        ItemStack CDOrb = new ItemStack(MagicksMod.CDiamondOrb, 1);
        if (heldItem.isItemStackEqual(CDOrb)){
          par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(Items.diamond));
        }
    }
   return false;
}

It says "The method isItemStackEqual(ItemStack) from the type ItemStack is not visible"

It says "The method isItemStackEqual(ItemStack) from the type ItemStack is not visible"

So open up the ItemStack class or browse the methods from the package explorer to find one that is. There is a public class method that compares the Item and damage values (but not NBT) and a public static method for comparing two ItemStacks that also accounts for NBT.

unfortunately I can't view any of the source classes.

You can still open the class hierarchy in the package explorer and see what methods are available, even if you can't see the code implementations.

 

The left-hand pane in Eclipse is the package explorer; go to "Referenced Libraries" and expand the forgeSrc->net->minecraft-> etc. folders. If you expand a class, all the methods will be listed.

there we go, I figured it out. i used the are itemStacksEqual(), and didn't come and post every time I had a problem.

 

 

Oh and by the way, the reason I can't see the source code is for some reason I don't have that src folder visible

In Eclipse, if you highlight the object (i.e. ItemStack) and press F3 (in Windows, don't know anything about Mac or Linux) it will open the class for you.  At least that is how I've been doing it.