Jump to content

Recommended Posts

Posted

I am trying to give a person an item if they right click on a block. I have this:

 

@Override

public boolean onBlockActivated(World par1World, int x, int y, int z, EntityPlayer par5EntityPlayer, int par6, float par7, float par8, float par9) {

ItemStack heldItem = par5EntityPlayer.inventory.getCurrentItem();

ItemStack CDOrb = new ItemStack(MagicksMod.CDiamondOrb, 1);

if (heldItem == new ItemStack(MagicksMod.CDiamondOrb, 1)){

par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(Items.diamond));

}

 

 

 

return false;

}

 

But it doesn't work. What am I doing wrong?

 

PS It doesn't have any error, it just doesn't do anything.

Posted

That doesn't work because they are 2 different objects. Try someting like this:

@Override
public boolean onBlockActivated(World par1World, int x, int y, int z, EntityPlayer par5EntityPlayer, int par6, float par7, float par8, float par9){
   if(!par1World.isRemote){
        ItemStack heldItem = par5EntityPlayer.inventory.getCurrentItem();
        ItemStack CDOrb = new ItemStack(MagicksMod.CDiamondOrb, 1);
        if (heldItem.isItemStackEqual(CDOrb)){
          par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(Items.diamond));
        }
    }
   return false;
}

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Posted

It says "The method isItemStackEqual(ItemStack) from the type ItemStack is not visible"

So open up the ItemStack class or browse the methods from the package explorer to find one that is. There is a public class method that compares the Item and damage values (but not NBT) and a public static method for comparing two ItemStacks that also accounts for NBT.

Posted

You can still open the class hierarchy in the package explorer and see what methods are available, even if you can't see the code implementations.

 

The left-hand pane in Eclipse is the package explorer; go to "Referenced Libraries" and expand the forgeSrc->net->minecraft-> etc. folders. If you expand a class, all the methods will be listed.

Posted

there we go, I figured it out. i used the are itemStacksEqual(), and didn't come and post every time I had a problem.

 

 

Oh and by the way, the reason I can't see the source code is for some reason I don't have that src folder visible

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • i dont have any crash reports i only have the latest log https://mclo.gs/DONwR2g
    • Maybe it is an issue with one of the Create addons Create_The_Kitchen_Must_Grow is the last mentioned mod
    • I cannot find any information on why this is specifically happening in any of the logs and i'm getting annoyed. it manifests primarily as lag when breaking and placing blocks, or picking up items. Items will be picked up than disappear, only to appear in my inventory many seconds later, blocks will not place for over 30 seconds at a time. observable shows 100459 μs/t on minecraft:player spark profile doesnt seem to show anything strange as far as i can tell though except for that about 20% of the usage is something called crusty_chunks and another 20% is distant horizons, even when i have distant rendering disabled. I've attached the latest.log, spark profile and observable exports.
    • [16:07:39] [main/INFO]:Mixins added to allowed list: [main.ClientPacketListenerMixin] [16:07:39] [main/INFO]:Class dev.uncandango.alltheleaks.leaks.client.mods.ae2wtlib.UntrackedIssue002 will NOT be loaded as mod ae2wtlib is not present [16:07:39] [main/INFO]:Class dev.uncandango.alltheleaks.leaks.client.mods.ae2wtlib.UntrackedIssue001 will NOT be loaded as mod ae2wtlib is not present [16:07:39] [main/INFO]:Class dev.uncandango.alltheleaks.fix.common.mods.modernfix.CancelRLMixin will be loaded as it matches versions: 5.20.2+mc1.20.1 in [5.0.0,) [16:07:39] [main/INFO]:Mixins added to cancel list: [org.embeddedt.modernfix.common.mixin.perf.deduplicate_location.MixinResourceLocation] [16:07:39] [main/INFO]:Skipping feature ResourceLocation Deduplication from mod minecraft as it's feature flag is not activated! [16:07:39] [main/INFO]:Skipping feature Ingredient Deduplication from mod minecraft as it's feature flag is not activated! [16:07:39] [main/INFO]:Skipping feature Prevent Search Ignored Items from mod jei as it's feature flag is not activated! [16:07:39] [main/WARN]:Error loading class: com/jozufozu/flywheel/util/WorldAttached (java.lang.ClassNotFoundException: com.jozufozu.flywheel.util.WorldAttached) [16:07:39] [main/WARN]:@Mixin target com.jozufozu.flywheel.util.WorldAttached was not found alltheleaks.mixins.json:main.WorldAttachedMixin from mod alltheleaks [16:07:39] [main/INFO]:Loaded config for: betterfpsdist.json [16:07:39] [main/INFO]:Loaded config for: structureessentials.json [16:07:39] [main/WARN]:Error loading class: dev/tr7zw/skinlayers/render/CustomizableModelPart (java.lang.ClassNotFoundException: dev.tr7zw.skinlayers.render.CustomizableModelPart) [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.BackgroundRendererMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.BiomeAccessAccessor [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.ChunkLightProviderMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.ChunkLightProviderMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.ChunkLightProviderMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.ClientChunkManagerMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.ClientSettingsC2SPacketMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.ClientWorldAccessor [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.GameOptionsMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.GameRendererMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.IntegratedServerMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.LightingProviderMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.MinecraftClientMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.SimpleOptionAccessor [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.ValidatingIntSliderCallbacksAccessor [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.sodium.SodiumChunkManagerMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.sodium.SodiumClientPlayNetworkHandlerMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.sodium.SodiumGameOptionPagesMixin [16:07:40] [main/INFO]:Replaced 1 calls to Enchantment#getMaxLevel() in net/minecraft/world/entity/npc/VillagerTrades$EnchantBookForEmeralds [16:07:40] [main/INFO]:Replaced 1 calls to Enchantment#isTreasureOnly() in net/minecraft/world/entity/npc/VillagerTrades$EnchantBookForEmeralds [16:07:40] [main/INFO]:Replaced 1 calls to Enchantment#isTradeable() in net/minecraft/world/entity/npc/VillagerTrades$EnchantBookForEmeralds [16:07:40] [main/INFO]:Loaded config for: recipeessentials.json [16:07:40] [main/INFO]:Patching FishingHook#catchingFish
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.