Okay, so, I'm trying to set up something that uses hasItem or hasItemStack in an if statement, but my if statement seems to be ignoring that bit

 

my code is

ItemStack itemstack4 = new ItemStack(BaseWeapon.kokiriSword);

if(this.getZuboraType() == 1 && itemstack != itemstack2 && !par1EntityPlayer.inventory.hasItemStack(itemstack4))
    		{
    			Strings.addChatMessage("Zubora: If you bring me a Kokiri Sword and 64 rupees,");
    			Strings.addChatMessage("Zubora: I can reforge your sword for you.");
    		}
    		
    		if(this.getZuboraType() == 1 && itemstack != itemstack2 && par1EntityPlayer.inventory.hasItemStack(itemstack4));
    		{
    			Strings.addChatMessage("Zubora: I see you've got a Kokiri Sword there");
    			Strings.addChatMessage("Zubora: If you pay me 64 rupees, I can forge it for you.");
    		}

 

And it's being put in the Interact method of an entity

 

When I click the entity, it displays the text from both if statements

 

I've tried with

 

par1EntityPlayer.inventory.hasItem(BaseWeapon.kokiriSword)

 

And it's the same result

 

Is there something I'm missing here? Am I supposed to use a different method?

 

(I've also tried using == true and == false, but, from my understanding of booleans, the code should be sound as it is in the bit posted)

Well, if you want the player's held item, I'd suggest using

 player.inventory.getCurrentItem() 

Additionally, it's java coding convention to separate the parts of your if statement with parenthesis:

 if ((blarg < -1) && (cat > 12) {} 

 

Unless you just wanted to check if you had the item in the player's inventory?

It's just if it's in the inventory

 

And ahh right, I'll make sure to format it like that in future then haha

Can you show me the rest of your method?

Doesn't matter now

I fixed it

 

I reformatted it so it wasn't a series of individual if's but a series linked together

and then used an else

 

if(this.getZuboraType() == 1)
    		{
    			if((itemstack != itemstack2) || (itemstack != itemstack3))
    			{
    				if(par1EntityPlayer.inventory.hasItem(BaseWeapon.kokiriSword))
            		{
    					Strings.addChatMessage("Zubora: I see you've got a Kokiri Sword there");
            			Strings.addChatMessage("Zubora: If you pay me 64 rupees, I can forge it for you.");
            			
            		}
            		
    				else
            		{
            			Strings.addChatMessage("Zubora: If you bring me a Kokiri Sword and 64 rupees,");
            			Strings.addChatMessage("Zubora: I can reforge your sword for you.");
            		}
    			}
    		}

 

like so

 

I don't know exactly why it wasn't working properly, but I've got a work-around for it now at least

I see you cleaned up your if statements. (Y)