Jump to content

Recommended Posts

Posted

I followed a tutorial to make a multiblock stucture (Click here for link!). I modified it a little bit so the master block is in the middle-middle, instead of the middle-bottom. It instantiates the structure fine, but if i try opening the gui, It doesn't open. I tested a little bit, and i figured out that that the master block is the only block in the structure that has the hasMaster value set to true. But if i understand the tutorial correctly, it should set the value hasMaster to true of all blocks in the structure.

 

Relavent code for the structure:

TileEntity:

 

 

private boolean hasMaster, isMaster;
private int masterX, masterY, masterZ;

@Override
public void updateEntity()
{
	if (!worldObj.isRemote)
	{
		if (hasMaster())
		{
			if (isMaster())
			{
				if (checkMultiBlockForm())
				{
					//THINGS THAT THE MULTIBLOCK WILL DO WHEN INITIALIZED
				}
				else
				{
					//THINGS THAT THE MULTIBLOCK WILL DO WHEN BROKEN
					resetStructure();
				}
			}
			else
			{
				if (checkForMaster())
				{
					reset();
				}
			}
		}
		else
		{
			if (checkMultiBlockForm())
			{
				setupStructure();
			}
		}
	}
}

public boolean checkMultiBlockForm()
{
	int i = 0;
	for (int x = xCoord - 1; x < xCoord + 2; x++)
	{
		for (int y = yCoord - 1; y < yCoord + 2; y++)
		{
			for (int z = zCoord - 1; z < zCoord + 2; z++)
			{
				TileEntity tile = worldObj.getTileEntity(x, y, z);
				if (tile != null && (tile instanceof TileEntityDatabase)) i++;
			}
		}
	}
	return i == 27;
}

/** Setup all the blocks in the structure */
public void setupStructure()
{
	for (int x = xCoord - 1; x < xCoord + 2; x++)
	{
		for (int y = yCoord - 1; y < yCoord + 2; y++)
		{
			for (int z = zCoord - 1; z < zCoord + 2; z++)
			{
				TileEntity tile = worldObj.getTileEntity(x, y, z);
				boolean master = (x == xCoord && y == yCoord && z == zCoord);
				if (tile != null && (tile instanceof TileEntityDatabase))
				{
					((TileEntityDatabase) tile).setMasterCoords(xCoord, yCoord, zCoord);
					((TileEntityDatabase) tile).setHasMaster(true);
					((TileEntityDatabase) tile).setIsMaster(master);
				}
			}
		}
	}
}

public void reset()
{
	masterX = 0;
	masterY = 0;
	masterZ = 0;
	hasMaster = false;
	isMaster = false;
}

public boolean checkForMaster()
{
	TileEntity tile = worldObj.getTileEntity(masterX, masterY, masterZ);
	return (tile != null && (tile instanceof TileEntityDatabase));
}

public void resetStructure()
{
	for (int x = xCoord - 1; x < xCoord + 2; x++)
	{
		for (int y = yCoord - 1; y < yCoord + 2; y++)
		{
			for (int z = zCoord - 1; z < zCoord + 2; z++)
			{
				TileEntity tile = worldObj.getTileEntity(x, y, z);
				if (tile != null && (tile instanceof TileEntityDatabase)) ((TileEntityDatabase) tile).reset();
			}
		}
	}
}

@Override
public void writeToNBT(NBTTagCompound tag)
{
	super.writeToNBT(tag);
	tag.setInteger("masterX", masterX);
	tag.setInteger("masterY", masterY);
	tag.setInteger("masterZ", masterZ);
	tag.setBoolean("hasMaster", hasMaster);
	tag.setBoolean("isMaster", isMaster);
	if (hasMaster() && isMaster())
	{
		//VALUES TO BE SAVED TO THE MASTER
	}
}

@Override
public void readFromNBT(NBTTagCompound tag)
{
	super.readFromNBT(tag);
	masterX = tag.getInteger("masterX");
	masterY = tag.getInteger("masterY");
	masterZ = tag.getInteger("masterZ");
	hasMaster = tag.getBoolean("hasMaster");
	isMaster = tag.getBoolean("isMaster");
	if (hasMaster() && isMaster())
	{
		//VALUES TO BE SAVED TO THE MASTER
	}
}

public boolean hasMaster()
{
	return hasMaster;
}

public boolean isMaster()
{
	return isMaster;
}

public int getMasterX()
{
	return masterX;
}

public int getMasterY()
{
	return masterY;
}

public int getMasterZ()
{
	return masterZ;
}

public void setHasMaster(boolean bool)
{
	hasMaster = bool;
}

public void setIsMaster(boolean bool)
{
	isMaster = bool;
}

public void setMasterCoords(int x, int y, int z)
{
	masterX = x;
	masterY = y;
	masterZ = z;
}

 

 

Block class:

 

 

public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int side, float hitX, float hitY, float hitZ)
{
	if (!world.isRemote)
	{
		TileEntityDatabase tileentity = (TileEntityDatabase)world.getTileEntity(x, y, z);
//			if(tileentity.hasMaster())
//			{
//				player.openGui(ModernCities.instance, GuiIds.DATABASE, world, tileentity.getMasterX(), tileentity.getMasterY(), tileentity.getMasterZ());
//				return true;
//			}
		System.out.println(tileentity.hasMaster());
		return tileentity.hasMaster();
	}
	return false;
}

 

 

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Posted

After some more debugging, i found out that if i place this line to the onBlockActivated method in my block class:

System.out.println(tileentity.getMasterX() + ":" + tileentity.getMasterY() + ":" + tileentity.getMasterZ());

it prints this to the console: 0:0:0, so the master isn't actually set anywhere, but i don't know why.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Posted

i dont know about a solve to this but im interested in finding out, but if the master block is center of  the whole structure wouldnt its coordinate actually be 0,0,0 and the block above it 0,0,1 block below be 0,0,-1 etc? if you get what i mean

Posted

I kinda get what i mean. If i place my structure right on world spawn (61,1835), i crashes if iright click on the block, because there's no block of that type at the coordinates 0,0,0. But if i actualle place a block of that type at 0,0,0, it opens the same gui on every block of the multiblock structure. So the only problem is the coordinate system, as why they aren't set to the current coords.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Posted

Fixed it! I checked if the multiblock structure i correct, and if so, reset. I needed to check if the multiblock structure is NOT correct, and then reset. I always hated that sort minor mistakes that makes your whole thing not work.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

  • 2 months later...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.