Jump to content

Recommended Posts

Posted

I followed a tutorial to make a multiblock stucture (Click here for link!). I modified it a little bit so the master block is in the middle-middle, instead of the middle-bottom. It instantiates the structure fine, but if i try opening the gui, It doesn't open. I tested a little bit, and i figured out that that the master block is the only block in the structure that has the hasMaster value set to true. But if i understand the tutorial correctly, it should set the value hasMaster to true of all blocks in the structure.

 

Relavent code for the structure:

TileEntity:

 

 

private boolean hasMaster, isMaster;
private int masterX, masterY, masterZ;

@Override
public void updateEntity()
{
	if (!worldObj.isRemote)
	{
		if (hasMaster())
		{
			if (isMaster())
			{
				if (checkMultiBlockForm())
				{
					//THINGS THAT THE MULTIBLOCK WILL DO WHEN INITIALIZED
				}
				else
				{
					//THINGS THAT THE MULTIBLOCK WILL DO WHEN BROKEN
					resetStructure();
				}
			}
			else
			{
				if (checkForMaster())
				{
					reset();
				}
			}
		}
		else
		{
			if (checkMultiBlockForm())
			{
				setupStructure();
			}
		}
	}
}

public boolean checkMultiBlockForm()
{
	int i = 0;
	for (int x = xCoord - 1; x < xCoord + 2; x++)
	{
		for (int y = yCoord - 1; y < yCoord + 2; y++)
		{
			for (int z = zCoord - 1; z < zCoord + 2; z++)
			{
				TileEntity tile = worldObj.getTileEntity(x, y, z);
				if (tile != null && (tile instanceof TileEntityDatabase)) i++;
			}
		}
	}
	return i == 27;
}

/** Setup all the blocks in the structure */
public void setupStructure()
{
	for (int x = xCoord - 1; x < xCoord + 2; x++)
	{
		for (int y = yCoord - 1; y < yCoord + 2; y++)
		{
			for (int z = zCoord - 1; z < zCoord + 2; z++)
			{
				TileEntity tile = worldObj.getTileEntity(x, y, z);
				boolean master = (x == xCoord && y == yCoord && z == zCoord);
				if (tile != null && (tile instanceof TileEntityDatabase))
				{
					((TileEntityDatabase) tile).setMasterCoords(xCoord, yCoord, zCoord);
					((TileEntityDatabase) tile).setHasMaster(true);
					((TileEntityDatabase) tile).setIsMaster(master);
				}
			}
		}
	}
}

public void reset()
{
	masterX = 0;
	masterY = 0;
	masterZ = 0;
	hasMaster = false;
	isMaster = false;
}

public boolean checkForMaster()
{
	TileEntity tile = worldObj.getTileEntity(masterX, masterY, masterZ);
	return (tile != null && (tile instanceof TileEntityDatabase));
}

public void resetStructure()
{
	for (int x = xCoord - 1; x < xCoord + 2; x++)
	{
		for (int y = yCoord - 1; y < yCoord + 2; y++)
		{
			for (int z = zCoord - 1; z < zCoord + 2; z++)
			{
				TileEntity tile = worldObj.getTileEntity(x, y, z);
				if (tile != null && (tile instanceof TileEntityDatabase)) ((TileEntityDatabase) tile).reset();
			}
		}
	}
}

@Override
public void writeToNBT(NBTTagCompound tag)
{
	super.writeToNBT(tag);
	tag.setInteger("masterX", masterX);
	tag.setInteger("masterY", masterY);
	tag.setInteger("masterZ", masterZ);
	tag.setBoolean("hasMaster", hasMaster);
	tag.setBoolean("isMaster", isMaster);
	if (hasMaster() && isMaster())
	{
		//VALUES TO BE SAVED TO THE MASTER
	}
}

@Override
public void readFromNBT(NBTTagCompound tag)
{
	super.readFromNBT(tag);
	masterX = tag.getInteger("masterX");
	masterY = tag.getInteger("masterY");
	masterZ = tag.getInteger("masterZ");
	hasMaster = tag.getBoolean("hasMaster");
	isMaster = tag.getBoolean("isMaster");
	if (hasMaster() && isMaster())
	{
		//VALUES TO BE SAVED TO THE MASTER
	}
}

public boolean hasMaster()
{
	return hasMaster;
}

public boolean isMaster()
{
	return isMaster;
}

public int getMasterX()
{
	return masterX;
}

public int getMasterY()
{
	return masterY;
}

public int getMasterZ()
{
	return masterZ;
}

public void setHasMaster(boolean bool)
{
	hasMaster = bool;
}

public void setIsMaster(boolean bool)
{
	isMaster = bool;
}

public void setMasterCoords(int x, int y, int z)
{
	masterX = x;
	masterY = y;
	masterZ = z;
}

 

 

Block class:

 

 

public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int side, float hitX, float hitY, float hitZ)
{
	if (!world.isRemote)
	{
		TileEntityDatabase tileentity = (TileEntityDatabase)world.getTileEntity(x, y, z);
//			if(tileentity.hasMaster())
//			{
//				player.openGui(ModernCities.instance, GuiIds.DATABASE, world, tileentity.getMasterX(), tileentity.getMasterY(), tileentity.getMasterZ());
//				return true;
//			}
		System.out.println(tileentity.hasMaster());
		return tileentity.hasMaster();
	}
	return false;
}

 

 

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Posted

After some more debugging, i found out that if i place this line to the onBlockActivated method in my block class:

System.out.println(tileentity.getMasterX() + ":" + tileentity.getMasterY() + ":" + tileentity.getMasterZ());

it prints this to the console: 0:0:0, so the master isn't actually set anywhere, but i don't know why.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Posted

i dont know about a solve to this but im interested in finding out, but if the master block is center of  the whole structure wouldnt its coordinate actually be 0,0,0 and the block above it 0,0,1 block below be 0,0,-1 etc? if you get what i mean

Posted

I kinda get what i mean. If i place my structure right on world spawn (61,1835), i crashes if iright click on the block, because there's no block of that type at the coordinates 0,0,0. But if i actualle place a block of that type at 0,0,0, it opens the same gui on every block of the multiblock structure. So the only problem is the coordinate system, as why they aren't set to the current coords.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Posted

Fixed it! I checked if the multiblock structure i correct, and if so, reset. I needed to check if the multiblock structure is NOT correct, and then reset. I always hated that sort minor mistakes that makes your whole thing not work.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

  • 2 months later...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.