So I have 2 classes for 2 different swords. The water sword which gives you waterbreathing and Speed underwater and the fire sword which gives you fireaspect 2 upon crafting. The water sword gets fireaspect 2 when I craft it.

 

Fire Sword

 
public class ItemFireDiremondSword extends ItemSword
{

public ItemFireDiremondSword(int par1, EnumToolMaterial par2EnumToolMaterial) 
{
	super(par1, par2EnumToolMaterial);
}

public void onCreated(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)
{
	System.out.println("Made the sword");
	par1ItemStack.addEnchantment(Enchantment.fireAspect, 2);
}


}

 

Water Sword

public class ItemWaterDiremondSword extends ItemSword
{
public ItemWaterDiremondSword(int par1, EnumToolMaterial par2EnumToolMaterial) 
{
	super(par1, par2EnumToolMaterial);
}

public void onUpdate(ItemStack itemstack, World world, Entity entity, int i, boolean flag)
{
	EntityPlayer Player;
	if(entity instanceof EntityPlayer)
	{
		Player = (EntityPlayer) entity;

	if(Player.getCurrentEquippedItem().equals(this))
		{
			if(Player.isInWater())
				{
					Player.addPotionEffect((new PotionEffect(Potion.waterBreathing.getId(), 0, 1)));
					Player.addPotionEffect((new PotionEffect(Potion.moveSpeed.getId(), 0, 10)));	
				}
			}
			else
				{
					Player.curePotionEffects(itemstack);
				}
		}
}

I was really confused because in the basemod class, they are instantiated as using different materials and different items.

Could you show us the code where you declare and instantiate the items? I suspect you may have accidentally mixed them up, as in "waterSword = new ItemFireDiremondSword".

so... I would always recheck the instantiations and I would never see that the water sword was pointing to the fire sword the whole time.

Thanks!