[1.7.2]Entity Item spawns client side

[Jdb100]

I have a block replacing itself with an item when clicked but it isn't called server side so any entities added would be client side and the blocks isn't set to air because it is only removed client side then syncs with the server and reappears. i should easily be able to make it spawn client side only with.

if(!world.isRemote)

however the onBlockActivated() seems to only be called client side even though it is supposed to be on both

 

onBlockActivated()

@Override
    public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int what, float are, float these, float For)
    {
	if(player.inventory.getCurrentItem() == null || player.inventory.getCurrentItem().getItem() == null)
	{
		return false;
	}
    	if(player.inventory.getCurrentItem().getItem() instanceof ItemKnife && !tileEntity.carved)
    	{
    		tileEntity.carved = true;
    		return true;
    	}
    	if(player.inventory.getCurrentItem().getItem() instanceof ItemSoulJar)
    	{
    		if(player.inventory.getCurrentItem().stackTagCompound != null)
    		{
    			if(player.inventory.getCurrentItem().stackTagCompound.getInteger("Entity Id") != 0)
    			{
    				if(tileEntity.carved)
    				{
    					tileEntity.setEntityId(player.inventory.getCurrentItem().stackTagCompound.getInteger("Entity Id"));
    					player.inventory.getCurrentItem().stackTagCompound.setInteger("Entity Id", 0);
    					return true;
    				}
    			}
    		}
    	}
    	if(player.inventory.getCurrentItem().getItem() instanceof ItemAsh && player.inventory.getCurrentItem().stackSize > 2 && tileEntity.getEntityId() != 0 && tileEntity.getEscapeTime() != 9600 && tileEntity.getEscapeTime() != -100)
    	{
    		tileEntity.addToEscapeTime(60);
    		player.inventory.getCurrentItem().stackSize -= 2;
    		return true;
    	}
    	if(player.inventory.getCurrentItem().getItem() instanceof ItemAsh && player.inventory.getCurrentItem().stackSize == 2 && tileEntity.getEntityId() != 0 && tileEntity.getEscapeTime() != 9600 && tileEntity.getEscapeTime() != -100)
    	{
    		tileEntity.addToEscapeTime(60);
    		player.inventory.setInventorySlotContents(player.inventory.currentItem, null);
    		return true;
    	}
    	if(player.inventory.getCurrentItem().getItem() instanceof ItemStickyIronCork && tileEntity.getEscapeTime() >= 7200)
    	{
    		tileEntity.setEscapeTime(-5);
    		player.inventory.setInventorySlotContents(player.inventory.currentItem, null);
    		return true;
    	}
    	if(player.inventory.getCurrentItem().getItem() instanceof ItemKnife && tileEntity.getEscapeTime() == -100)
    	{
    		tileEntity.setClicks(tileEntity.getClicks() + 1);
    		if(tileEntity.getClicks() == 7)
    		{
    			System.out.println("7 clicks");
    			if(!world.isRemote)
    			{	
    				System.out.println("is server");
    				ItemStack itemStack = new ItemStack(BaseMod.items.totem, 1);
    				itemStack.setTagCompound(new NBTTagCompound());
    				itemStack.stackTagCompound.setInteger("Entity Id", tileEntity.getEntityId());
    				EntityItem item = new EntityItem(world, x, y + 1.2F, z, new ItemStack(itemStack.getItem(), itemStack.stackSize, itemStack.getItemDamage()));
                	float f3 = 0.05F;
                	item.motionX = (double)((float)this.rand.nextGaussian() * f3);
                	item.motionY = (double)((float)this.rand.nextGaussian() * f3 + 0.2F);
                	item.motionZ = (double)((float)this.rand.nextGaussian() * f3);
    				if(itemStack.hasTagCompound())
    				{
    					item.getEntityItem().setTagCompound((NBTTagCompound) itemStack.getTagCompound().copy());
    				}
    				world.setBlockToAir(x, y, z);
    				world.spawnEntityInWorld(item);
    			}
    		}
    		return true;
    	}
    	
    	return false;
    }

[sequituri]

Your event method has quite a few references to a nonexistant variable/parameter/property vis-a-vis tileentity.

Since you never set that variable, I think you will get NPE's.

By the way, variables cannot be saved in items or blocks - except statically.

 

Arguments explained:

public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int side, float hitX, float hitY, float hitZ)

 

[Jdb100]

Sorry but I don't understand what you are trying to say as I think all the variables exist and they all have there data saved by nbt either in the tile entity or itemstack. Also I am not storing any data in the block all the data is stored in the tile entity and storing the item data in the item stack. Thanks for explaining the arguments I couldn't figure out even though I won't be needing them after I found what they do.

[sequituri]

Is this not your code?

@Override
public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int what, float are, float these, float For)
{
    if(player.inventory.getCurrentItem() == null || player.inventory.getCurrentItem().getItem() == null)
    {
        return false;
    }
    if(player.inventory.getCurrentItem().getItem() instanceof ItemKnife && >>>>>>!tileEntity.carved<<<<<<)
    {
    	tileEntity.carved = true;
    	return true;
    }

Where did you set this >>>>>>variable<<<<<<< above?

[Jdb100]

That is set in the constructor. That variable seems to work fine as by default it is saved as false which I could see when debugging. Also a println in there saw it being called. All the other parts seem to work, I just provided them in case there was something wrong but the problematic section is:

 

@Override
    public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int side, float hitX, float hitY, float hitZ)
    	if(player.inventory.getCurrentItem().getItem() instanceof ItemKnife && tileEntity.getEscapeTime() == -100)
    	{
    		tileEntity.setClicks(tileEntity.getClicks() + 1);
    		if(tileEntity.getClicks() == 7)
    		{
    			System.out.println("7 clicks");
    			if(!world.isRemote)
    			{	
    				System.out.println("is server");
    				ItemStack itemStack = new ItemStack(BaseMod.items.totem, 1);
    				itemStack.setTagCompound(new NBTTagCompound());
    				itemStack.stackTagCompound.setInteger("Entity Id", tileEntity.getEntityId());
    				EntityItem item = new EntityItem(world, x, y + 1.2F, z, new ItemStack(itemStack.getItem(), itemStack.stackSize, itemStack.getItemDamage()));
                	float f3 = 0.05F;
                	item.motionX = (double)((float)this.rand.nextGaussian() * f3);
                	item.motionY = (double)((float)this.rand.nextGaussian() * f3 + 0.2F);
                	item.motionZ = (double)((float)this.rand.nextGaussian() * f3);
    				if(itemStack.hasTagCompound())
    				{
    					item.getEntityItem().setTagCompound((NBTTagCompound) itemStack.getTagCompound().copy());
    				}
    				world.setBlockToAir(x, y, z);
    				world.spawnEntityInWorld(item);
    			}

[sequituri]

So you have created an instance variable in a block. That variable will be shared and exactly duplicated in every block like that in the world. How is that working fine?

 

For future reference: A TileEntity can only be created in World. Not in a block or an item. Every block gets its TE from World.getTileEntity(). not by using an instance variable.

 

Your code will not work when more than one of your blocks is ever placed, if at all.

[Jdb100]

Ok i removed setting the default values even though I had no variables in the block besides the instance of the tile entity which I get with world.getTileEntity(). I never make the tile entity in the block it just contains the instance of it. The tile entity is created in the world with the createNewTileEntity(). All the other parts  are working with multiple blocks down just not spawning the entity item on server.