Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[Solved] [1.7.2] Adding New Drops To Existing Blocks (Sticks From Leaves)

qpwoeiruty

By qpwoeiruty
in Modder Support

 Share

Recommended Posts

qpwoeiruty Creeper Killer

qpwoeiruty

Posted
Posted

Hi to pretty much complete the first version of my mod, I require a way to make it so the when the player breaks a leaf block it drops a stick. Everywhere I have looked previously has supplied me with very contrasting information and so I thought I would try here as all the topics I have previously read have been very useful. Any help at all would great, thanks.

larsgerrits Reality Controller

larsgerrits

Posted
Posted

You can use the HarvestDropsEvent and check if the block is leaves and then add sticks to the drops list in the event.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

qpwoeiruty Creeper Killer

qpwoeiruty

Posted
  • Author
Posted

Hrmmm, I believe I have done it correctly but so far, no sticks have been dropped.

 

if(event.block == Blocks.leaves || event.block == Blocks.leaves2) {

 

event.drops.add(new ItemStack(Items.stick, 1));

 

}

qpwoeiruty Creeper Killer

qpwoeiruty

Posted
  • Author
Posted

Thanks, the top section is just for what blocks can be broken by hand.

 

package com.willr27survivalplus.handler;

import net.minecraft.init.Blocks;
import net.minecraft.init.Items;
import net.minecraft.item.ItemStack;
import net.minecraftforge.common.ForgeHooks;
import net.minecraftforge.event.entity.player.PlayerEvent;
import net.minecraftforge.event.world.BlockEvent.HarvestDropsEvent;
import cpw.mods.fml.common.eventhandler.SubscribeEvent;

public class WSPEventHandler {

@SubscribeEvent
public void setBreakableBlocks(PlayerEvent.BreakSpeed event) {

	ItemStack item = event.entityPlayer.getCurrentEquippedItem();

	if(item == null && event.block == Blocks.bed
	|| item == null && event.block == Blocks.brown_mushroom_block
	|| item == null && event.block == Blocks.cactus
	|| item == null && event.block == Blocks.cake
	|| item == null && event.block == Blocks.carpet
	|| item == null && event.block == Blocks.carrots
	|| item == null && event.block == Blocks.clay
	|| item == null && event.block == Blocks.cocoa
	|| item == null && event.block == Blocks.dirt
	|| item == null && event.block == Blocks.flower_pot
	|| item == null && event.block == Blocks.grass
	|| item == null && event.block == Blocks.gravel
	|| item == null && event.block == Blocks.nether_wart
	|| item == null && event.block == Blocks.potatoes
	|| item == null && event.block == Blocks.red_mushroom_block
	|| item == null && event.block == Blocks.redstone_torch
	|| item == null && event.block == Blocks.reeds
	|| item == null && event.block == Blocks.sand
	|| item == null && event.block == Blocks.sapling
	|| item == null && event.block == Blocks.skull
	|| item == null && event.block == Blocks.snow
	|| item == null && event.block == Blocks.snow_layer
	|| item == null && event.block == Blocks.standing_sign
	|| item == null && event.block == Blocks.tnt
	|| item == null && event.block == Blocks.torch
	|| item == null && event.block == Blocks.tripwire
	|| item == null && event.block == Blocks.unlit_redstone_torch
	|| item == null && event.block == Blocks.vine
	|| item == null && event.block == Blocks.wall_sign
	|| item == null && event.block == Blocks.waterlily
	|| item == null && event.block == Blocks.web
	|| item == null && event.block == Blocks.wheat
	|| item == null && event.block == Blocks.wool
	|| item == null && event.block == Blocks.brown_mushroom
	|| item == null && event.block == Blocks.deadbush
	|| item == null && event.block == Blocks.double_plant
	|| item == null && event.block == Blocks.fire
	|| item == null && event.block == Blocks.grass
	|| item == null && event.block == Blocks.leaves
	|| item == null && event.block == Blocks.leaves2
	|| item == null && event.block == Blocks.mycelium
	|| item == null && event.block == Blocks.red_flower
	|| item == null && event.block == Blocks.red_mushroom
	|| item == null && event.block == Blocks.redstone_wire
	|| item == null && event.block == Blocks.tallgrass
	|| item == null && event.block == Blocks.tripwire_hook
	|| item == null && event.block == Blocks.yellow_flower

	|| item != null && event.block == Blocks.bed
	|| item != null && event.block == Blocks.brown_mushroom_block
	|| item != null && event.block == Blocks.cactus
	|| item != null && event.block == Blocks.cake
	|| item != null && event.block == Blocks.carpet
	|| item != null && event.block == Blocks.carrots
	|| item != null && event.block == Blocks.clay
	|| item != null && event.block == Blocks.cocoa
	|| item != null && event.block == Blocks.dirt
	|| item != null && event.block == Blocks.flower_pot
	|| item != null && event.block == Blocks.grass
	|| item != null && event.block == Blocks.gravel
	|| item != null && event.block == Blocks.nether_wart
	|| item != null && event.block == Blocks.potatoes
	|| item != null && event.block == Blocks.red_mushroom_block
	|| item != null && event.block == Blocks.redstone_torch
	|| item != null && event.block == Blocks.reeds
	|| item != null && event.block == Blocks.sand
	|| item != null && event.block == Blocks.sapling
	|| item != null && event.block == Blocks.skull
	|| item != null && event.block == Blocks.snow
	|| item != null && event.block == Blocks.snow_layer
	|| item != null && event.block == Blocks.standing_sign
	|| item != null && event.block == Blocks.tnt
	|| item != null && event.block == Blocks.torch
	|| item != null && event.block == Blocks.tripwire
	|| item != null && event.block == Blocks.unlit_redstone_torch
	|| item != null && event.block == Blocks.vine
	|| item != null && event.block == Blocks.wall_sign
	|| item != null && event.block == Blocks.waterlily
	|| item != null && event.block == Blocks.web
	|| item != null && event.block == Blocks.wheat
	|| item != null && event.block == Blocks.wool
	|| item != null && event.block == Blocks.brown_mushroom
	|| item != null && event.block == Blocks.deadbush
	|| item != null && event.block == Blocks.double_plant
	|| item != null && event.block == Blocks.fire
	|| item != null && event.block == Blocks.grass
	|| item != null && event.block == Blocks.leaves
	|| item != null && event.block == Blocks.leaves2
	|| item != null && event.block == Blocks.mycelium
	|| item != null && event.block == Blocks.red_flower
	|| item != null && event.block == Blocks.red_mushroom
	|| item != null && event.block == Blocks.redstone_wire
	|| item != null && event.block == Blocks.tallgrass
	|| item != null && event.block == Blocks.tripwire_hook
	|| item != null && event.block == Blocks.yellow_flower) {

		event.setCanceled(false);

	} else if(item == null || !ForgeHooks.isToolEffective(item, event.block, event.metadata)){

		event.setCanceled(true);

	}

}

@SubscribeEvent
public void checkDrops(HarvestDropsEvent event) {

	if(event.block == Blocks.leaves || event.block == Blocks.leaves2) {

		event.drops.add(new ItemStack(Items.stick, 1));

	}

}

}

 

I registered it like so:

 

@EventHandler
public void Init(FMLInitializationEvent Event) {

	FMLCommonHandler.instance().bus().register(new CraftingHandler());
	MinecraftForge.EVENT_BUS.register(new WSPEventHandler());	

	WSPRecipeCreator.createRecipes();

}

coolboy4531 Dragon Slayer

coolboy4531

Posted
Posted

Don't know the cause, but I usually put my events in PreInit (see if that makes a difference - in fact, I never use Init, only PreInit for everything).

 

Another thing:

- Try adding System.out.println methods around that event and see if it's actually being called. It could be side issues.

 

EDIT:

I think I may have found your issue.

HarvestDropsEvent is only called when an item is "dropped" from your block (in this case: saplings or apples).

Since leaves only drop those items in a low chance, it will only drop your item (which is a stick) if it drops a sapling or apple of itself.

 

To fix this issue you should not use HarvestDropsEvent and use BreakEvent, I think you can figure which "BreakEvent" to use.

(lazy:  BlockEvent.BreakEvent)

qpwoeiruty Creeper Killer

qpwoeiruty

Posted
  • Author
Posted

I changed it to this:

 

@SubscribeEvent
public void checkDrops(BlockEvent.BreakEvent event) {

	if(event.block == Blocks.leaves || event.block == Blocks.leaves2) {

		//Drops

	}

}

 

However, now I am unsure on setting the drop as it has changed, sorry if I am overlooking something simple.

wesserboy Stone Miner

wesserboy

Posted
Posted

for the top section i would recommend making an arraylist of blocks you can still break as a field, something like:

 

ArrayList<Block> blocklist = new ArrayList<Block>(Arrays.asList(new Block[]{Blocks.bed, Blocks.brown_mushroom_block, etc...}));

 

this way you can use blocklist.contains(event.block)

 

your code would then look something like this:

 

 
ArrayList<Block> blocklist = new ArrayList<Block>(Arrays.asList(new Block[]{Blocks.bed, Blocks.brown_mushroom_block, etc...}));

       @SubscribeEvent
public void setBreakableBlocks(PlayerEvent.BreakSpeed event) {

	ItemStack item = event.entityPlayer.getCurrentEquippedItem();

	if(blocklist.contains(event.block) {

		event.setCanceled(false);

	} else if(item == null || !ForgeHooks.isToolEffective(item, event.block, event.metadata)){

		event.setCanceled(true);

	}

}

 

but it's up to you if you use it or not ;)

I made the Mob Particles mod, you can check it out here: http://www.minecraftforum.net/topic/2709242-172-forge-mob-particles/

larsgerrits Reality Controller

larsgerrits

Posted
Posted

Can't you still use the HarvestDropsEvent and set the dropChance to 1.0f? By lokking at this line:

 public float dropChance; // Change to e.g. 1.0f, if you manipulate the list and want to guarantee it always drops

it should actually work.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • vals_kenway
      Problem Sync Client-server for Entity Mount

      By vals_kenway · Posted

      Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • TileEntity
      Trying to play any world is stuck on 100% loading and shuts down computer

      By TileEntity · Posted

      Also make a test without EMF (Entity Model Features)
    • TileEntity
      Server Keeps Crashing When I Press E in Creative only

      By TileEntity · Posted

      Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • TileEntity
      Duplicate mod issue on modpack startup

      By TileEntity · Posted

      Keep on this thread:  
    • TileEntity
      Duplicate mod issue on modpack startup

      By TileEntity · Posted

      Remove rubidium - you are already using embeddium, which is a fork of rubidium

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept