Jump to content

[1.7.2] Looping through players inventory to check for best item.


Shamboozle

Recommended Posts

I wondering if anyone can help me...

 

Here's my code

private Minecraft mc = Minecraft.getMinecraft();
private List<ItemStack> playerItems = new ArrayList<ItemStack>();

@SideOnly(Side.CLIENT)
@SubscribeEvent
public void onPlayerRender(RenderPlayerEvent.Specials.Post event) {
	if (event.isCanceled())
		return;

	ItemStack stackToRender = getSelectItem(event.entityPlayer.inventory);

	if (stackToRender != null && stackToRender != event.entityPlayer.getCurrentEquippedItem()) {
		System.out.println(stackToRender.getDisplayName());
		renderItemIn3D(stackToRender);
	}

}

private ItemStack getSelectItem(InventoryPlayer inventory){

	ItemStack selectedItem = null;

	for(int i = 0; i < inventory.getSizeInventory(); i++){
		ItemStack curStack = inventory.getStackInSlot(i);

		if (curStack != null) {
			if ((curStack.getItem() instanceof ItemSword) && !(playerItems.contains(curStack))) {
				playerItems.add(curStack);
			}
		}
	}

	for(int j = 0; j < playerItems.size(); j++){

		ItemStack currItem = playerItems.get(j);

		if(currItem.getItem() == Items.wooden_sword){
			selectedItem = currItem;
			return selectedItem;
		} else if(currItem.getItem() == Items.stone_sword){
			selectedItem = currItem;
			return selectedItem;
		} else if(currItem.getItem() == Items.iron_sword){
			selectedItem = currItem;
			return selectedItem;
		} else if(currItem.getItem() == Items.stone_sword){
			selectedItem = currItem;
			return selectedItem;
		} else if(currItem.getItem() == Items.wooden_sword){
			selectedItem = currItem;
			return selectedItem;
		}

	}

	return selectedItem;
}

 

I am trying to get it so I can render the best Sword on the players inventory, but it only renders a wooden sword even though I check for all the swords and It should render the diamond one if that is the best in the inventory, then gold, then iron etc. But it doesn't work so can some one point me in the right direction. (I have tried the if statements the other way round starting with the diamond sword btw)

Link to comment
Share on other sites

Hi!

 

I can't see in the code (but I'm not so expert with FML, so I just trying to give you an idea) the point where it should check the inventory. You should execute, I think, three checks:

 

1) if the player has got any sword.

 

2) check each sword and value.

 

3) the best value obtained will determinate the stack to render.

 

 

About the 2nd point, I wonder.... How do you "know" the value of the item? May I suggest a check variable, eg. "maxValuable"?

If wood = 1, gold = 2, iron = 3, diamond = 4 (just samples), on every item check, if the item value is better than maxValuable value (that start with 0 = not rendering anything) so update maxValuable. At the end, check maxValuable and render what is appropriate.

 

Hope this could help you!

Federico Nuzzo

Programmer and Developer

Link to comment
Share on other sites

I think the problem is that you're returning from the method as soon as you find a match, and worse you're checking for wooden first.  I think the way you've got it coded will probably return the first sword of any type (not the best).

 

If you're trying to find the best one, you need to loop through the whole inventory only looking for the best sword, and then loop through the whole inventory again looking for the next best, and so on.

 

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

"Best" with weapons is a very subjective assessment. Most damage? (against what? Arthropods?) Most enchantable? Most durable? Most undamaged?

 

Yeah, so... you have to decide on a guideline that makes sense. And, what about mod swords from other mods? Some of those are uber!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.