[1.7.2]Custom EntityFX crashes randomly

[Vtec234]

Hello!

I already made a thread about this issue, but then I thought that I managed to fix the issue, so I posted about that in forementioned thread. Sadly, it still errors, and now I have no clue why that happens, so I have to make another thread. The issue I have is that I created a custom EntityFX, and it crashes randomly when it's rendering. Here's the code for the entity:

public class EntityRainbowFX extends EntityFX {
private static final ResourceLocation textureFile = new ResourceLocation(Reference.MODID, "textures/particle/rainbow.png");

public EntityRainbowFX(World world, double x, double y, double z) {
	super(world, x, y, z);
	this.particleMaxAge = 50;
	this.particleScale = 1.5F;
	Random rand = new Random();
	this.motionX = rand.nextDouble() * 0.1D - 0.05D;
	this.motionY = rand.nextDouble() * 0.1D;
	this.motionZ = rand.nextDouble() * 0.1D - 0.05D;
}

@Override
public void renderParticle(Tessellator tess, float tick, float par3, float par4, float par5, float par6, float par7) {
	Minecraft.getMinecraft().renderEngine.bindTexture(textureFile);
	glDepthMask(false);
	glEnable(GL_BLEND);
	glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA);
	glAlphaFunc(GL_GREATER, 0.003921569F);
	tess.startDrawingQuads();
	tess.setBrightness(getBrightnessForRender(tick));
	float scale = 0.1F * particleScale;
	float x = (float)(this.prevPosX + (this.posX - this.prevPosX) * (double)tick - interpPosX);
	float y = (float)(this.prevPosY + (this.posY - this.prevPosY) * (double)tick - interpPosY);
	float z = (float)(this.prevPosZ + (this.posZ - this.prevPosZ) * (double)tick - interpPosZ);
	tess.addVertexWithUV((double)(x - par3 * scale - par6 * scale), (double)(y - par4 * scale), (double)(z - par5 * scale - par7 * scale), 1, 1);
	tess.addVertexWithUV((double)(x - par3 * scale + par6 * scale), (double)(y + par4 * scale), (double)(z - par5 * scale + par7 * scale), 1, 0);
	tess.addVertexWithUV((double)(x + par3 * scale + par6 * scale), (double)(y + par4 * scale), (double)(z + par5 * scale + par7 * scale), 0, 0);
	tess.addVertexWithUV((double)(x + par3 * scale - par6 * scale), (double)(y - par4 * scale), (double)(z + par5 * scale - par7 * scale), 0, 1);
	tess.draw();
	glDisable(GL_BLEND);
	glDepthMask(true);
	glAlphaFunc(GL_GREATER, 0.1F);
}

@Override
public int getFXLayer() {
	return 3;
}

@Override
public void onUpdate() {
	this.prevPosX = this.posX;
	this.prevPosY = this.posY;
	this.prevPosZ = this.posZ;

	if (this.particleAge++ >= this.particleMaxAge)
		this.setDead();

	this.moveEntity(this.motionX, this.motionY, this.motionZ);
	System.out.println(this.motionX + " " + this.motionY + " " + this.motionZ);
}
}

 

I spawn it when an item is used, like this:

public boolean onItemUse(ItemStack itemStack, EntityPlayer player, World world, int x, int y, int z, int side, float offsetX, float offsetY, float offsetZ){
Minecraft.getMinecraft().effectRenderer.addEffect(new EntityRainbowFX(world, (double)(x + offsetX), (double)(y + offsetY), (double)(z + offsetZ)));
return false;
}

 

Now what happens, is that I hold RMB with this item on the ground for some time, and the particles keep spawning and flying away. But, sometimes if I hold it for about 3 to 7 seconds, it errors and Minecraft exits. I have no idea what is causing this, I tried moving the random number generation (motionX, motionY, motionZ) to different methods, and then to the constructor (like it is in the posted code), but it still doesn't work. Here's the Forge log:

https://gist.github.com/anonymous/bdcb82c8f9692556ccdc

 

The crash happens at line 1682, all those digits before it are caused by me calling println on the motion variables.

[TheGreyGhost]

Hi

 

The crash is happening on the server, but EntityFX are client-side only.  Probably something to do with onItemUse accessing the client side minecraft from the server.  onItemUse is called on both client and server

 

You need to use

if (world.isRemote) {

  spawn here

}

 

-TGG

[Vtec234]

Thanks, this seems to actually have fixed it.

[TheGreyGhost]

  On 6/21/2014 at 7:55 PM, Vtec234 said:

Thanks, this seems to actually have fixed it.

you sound surprised? :-P