[1.7.2] Changing A Mobs Max Health

[loawkise]

I have tried using getEntityAttribute(SharedMonsterAttributes.maxHealth); but that returns this "net.minecraft.entity.ai.attributes.ModifiableAttributeInstance@59721257"

[Alix_The_Alicorn]

Need more info. Also, did you try casting the float(I think it's a float, but you didnt give much info) to an int?

[coolboy4531]

Try and get an instance of the entity.

To get the max hp use Entity#getMaxHealth() but set it as an int (casting).

Java automatically rounds up from that float (like before casting).

 

int maxHealth = entity.getMaxHealth();

[loawkise]

I'm doing it a completely different way because I want to make sure that I can change keep the max health after the player leaves the world so I am now using a class that extends IExtendedEntityProperties. What I have done for all my other values works fine but when I put a variable inside of this.getEntityAttribute(SharedMonsterAttributes.maxHealth).setBaseValue(maxHealth) like this instead of just a double (this.getEntityAttribute(SharedMonsterAttributes.maxHealth).setBaseValue(maxHealth)), the entity dies immediately (so the maxHealth is 0) even though when I check my classes it is set to a base of 10.0D. Here are the classes use:

 

The entities class.

 

 

package com.blocklings.entity;

 

import net.minecraft.entity.Entity;

import net.minecraft.entity.EntityAgeable;

import net.minecraft.entity.EntityLivingBase;

import net.minecraft.entity.SharedMonsterAttributes;

import net.minecraft.entity.ai.EntityAIAttackOnCollide;

import net.minecraft.entity.ai.EntityAIAvoidEntity;

import net.minecraft.entity.ai.EntityAIFollowOwner;

import net.minecraft.entity.ai.EntityAIOwnerHurtByTarget;

import net.minecraft.entity.ai.EntityAIOwnerHurtTarget;

import net.minecraft.entity.ai.EntityAIWander;

import net.minecraft.entity.ai.EntityAIWatchClosest;

import net.minecraft.entity.passive.EntityTameable;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.init.Blocks;

import net.minecraft.item.Item;

import net.minecraft.item.ItemStack;

import net.minecraft.pathfinding.PathEntity;

import net.minecraft.util.ChatComponentText;

import net.minecraft.util.DamageSource;

import net.minecraft.world.World;

 

import com.blocklings.network.CreatePacketServerSide;

import com.blocklings.stats.BlocklingStats;

 

import cpw.mods.fml.client.FMLClientHandler;

import cpw.mods.fml.relauncher.Side;

import cpw.mods.fml.relauncher.SideOnly;

 

public class EntityBlockling extends EntityTameable {

 

public BlocklingStats properties = BlocklingStats.get(this);

public double maxHealth = properties.getMaxHealth();

 

public EntityBlockling(World world) {

 

super(world);

 

this.setSize(0.91F, 0.91F);

this.getNavigator().setAvoidsWater(true);

this.getNavigator().setCanSwim(false);

this.tasks.addTask(0, new EntityAIAttackOnCollide(this, 1.0D, true));

this.tasks.addTask(1, new EntityAIWatchClosest(this, EntityPlayer.class, 16.0F));

        this.tasks.addTask(2, new EntityAIFollowOwner(this, 1.0D, 8.0F, 5.0F));

        this.tasks.addTask(3, this.aiSit);

        this.tasks.addTask(4, new EntityAIAvoidEntity(this, EntityPlayer.class, 16.0F, 1.5D, 1.5D));

        this.tasks.addTask(5, new EntityAIWander(this, 1.0D));

        this.targetTasks.addTask(0, new EntityAIOwnerHurtByTarget(this));

        this.targetTasks.addTask(1, new EntityAIOwnerHurtTarget(this));

        this.targetTasks.addTask(2, new EntityAIAttackOnCollide(this, 1.0D, true));

        this.setTamed(false);

       

}

 

protected void applyEntityAttributes() {

 

super.applyEntityAttributes();

this.getEntityAttribute(SharedMonsterAttributes.maxHealth).setBaseValue(maxHealth);

this.getEntityAttribute(SharedMonsterAttributes.movementSpeed).setBaseValue(0.25D);

this.getAttributeMap().registerAttribute(SharedMonsterAttributes.attackDamage);

    this.getEntityAttribute(SharedMonsterAttributes.attackDamage).setBaseValue(5.0D);

 

}

 

public boolean interact(EntityPlayer par1EntityPlayer)

    {

        ItemStack itemstack = par1EntityPlayer.inventory.getCurrentItem();

       

        if (itemstack != null && itemstack.getItem() == Item.getItemFromBlock(Blocks.red_flower))

        {

            if (!par1EntityPlayer.capabilities.isCreativeMode)

            {

                --itemstack.stackSize;

            }

 

            if (itemstack.stackSize <= 0)

            {

                par1EntityPlayer.inventory.setInventorySlotContents(par1EntityPlayer.inventory.currentItem, (ItemStack)null);

            }

 

            if (par1EntityPlayer.getCommandSenderName().equalsIgnoreCase(this.getOwnerName()) && !this.worldObj.isRemote)

            {

                this.aiSit.setSitting(!this.isSitting());

                this.isJumping = false;

                this.setPathToEntity((PathEntity)null);

                this.setTarget((Entity)null);

                this.setAttackTarget((EntityLivingBase)null);

                FMLClientHandler.instance().getClient().ingameGUI.getChatGUI().printChatMessage(new ChatComponentText("XP: " + Integer.toString(properties.getXP()) + "/" + properties.getRequiredXP() + " | " + "Level: " + properties.getLevel() + " | " + "Health: " + this.getHealth() + "/" + (int)properties.getMaxHealth()));

            }

           

            if (!this.worldObj.isRemote && !this.isTamed())

            {

                if (this.rand.nextInt(3) == 0)

                {

                    this.setTamed(true);

                    this.setPathToEntity((PathEntity)null);

                    this.setAttackTarget((EntityLivingBase)null);

                    this.setOwner(par1EntityPlayer.getCommandSenderName());

                    this.playTameEffect(true);

                    this.aiSit.setSitting(!this.isSitting());

                    this.worldObj.setEntityState(this, (byte)7);

                }

                else

                {

                    this.playTameEffect(false);

                    this.worldObj.setEntityState(this, (byte)6);

                }

            }

 

            return true;

        }

 

        return super.interact(par1EntityPlayer);

    }

 

public boolean attackEntityAsMob(Entity par1Entity) {

 

properties.addXP(50);

 

        return par1Entity.attackEntityFrom(DamageSource.causeMobDamage(this), (float) getEntityAttribute(SharedMonsterAttributes.attackDamage).getAttributeValue());

       

}

 

@SideOnly(Side.CLIENT)

    public int getLevel() {

 

        return properties.getLevel();

       

    }

 

@Override

public EntityAgeable createChild(EntityAgeable var1) {

 

return null;

 

}

 

public boolean isAIEnabled() {

 

return true;

 

}

 

}

 

 

 

 

package com.blocklings.stats;

 

import net.minecraft.entity.Entity;

import net.minecraft.nbt.NBTTagCompound;

import net.minecraft.world.World;

import net.minecraftforge.common.IExtendedEntityProperties;

import net.minecraftforge.event.entity.living.LivingAttackEvent;

 

import com.blocklings.entity.EntityBlockling;

 

import cpw.mods.fml.common.eventhandler.SubscribeEvent;

 

public class BlocklingStats implements IExtendedEntityProperties {

 

public final static String EXT_PROP_NAME = "BlocklingXP";

 

public EntityBlockling blockling;

public int xp = 0;

public int level = 1;

public int requiredXP = 256;

public double maxHealth = 10.0D;

 

public BlocklingStats(EntityBlockling blockling) {

 

this.blockling = blockling;

 

}

 

public static final void register(EntityBlockling blockling) {

 

blockling.registerExtendedProperties(BlocklingStats.EXT_PROP_NAME, new BlocklingStats(blockling));

 

}

 

public static final BlocklingStats get(EntityBlockling entity) {

 

return (BlocklingStats) entity.getExtendedProperties(EXT_PROP_NAME);

 

}

 

@Override

public void saveNBTData(NBTTagCompound compound) {

 

compound.setInteger("xp", this.xp);

compound.setInteger("level", this.level);

compound.setInteger("requiredXP", this.requiredXP);

compound.setDouble("maxHealth", this.maxHealth);

 

}

 

@Override

public void loadNBTData(NBTTagCompound compound) {

 

this.xp = compound.getInteger("xp");

this.level = compound.getInteger("level");

this.requiredXP = compound.getInteger("requiredXP");

this.maxHealth = compound.getDouble("maxHealth");

 

}

 

@Override

public void init(Entity entity, World world) {

 

 

 

}

 

public void addXP(int addedXP) {

 

xp = xp + addedXP;

onLevelUp();

 

}

 

public void onLevelUp() {

 

if(xp >= requiredXP) {

 

this.xp = 0;

this.level++;

calculateRequiredXP();

 

}

 

}

 

public void calculateRequiredXP() {

 

this.requiredXP = level * level * 8 * (8 + level);

 

}

 

public int getXP() {

 

return xp;

 

}

 

public int getRequiredXP() {

 

return requiredXP;

 

}

 

public int getLevel() {

 

return level;

 

}

 

public double getMaxHealth() {

 

return maxHealth;

 

}

 

}

 

[loawkise]

Anyone have any ideas?

[jabelar]

Okay, the problem is your initialization of the properties field.  You're initializing with:

public BlocklingStats properties = BlocklingStats.get(this);

But that is a class field before you've called the constructor.  In other words, I don't think there really is a "this" at that point ot pass to the BlockingState.get() method.

You might be able to do this by calling the method within the constructor instead.

 

In any case, I'm pretty sure that properties is coming back such that you're not getting the 10.0D property, probably because of this.

 

Anyway, you should simply put System.out.println() statements in your code at key points in each class and print out the value of what is being processed in the code.  You should quickly see that you're getting either 0.0D or null back at some point when you don't expect it.

[loawkise]

I'm not entirely sure that's the problem because even when I do it like this the entity still dies instantly.

 

 

public class EntityBlockling extends EntityTameable {

 

public BlocklingStats properties = BlocklingStats.get(this);

public int level = properties.getLevel();

public double maxHealth = 10.0D;

 

public EntityBlockling(World world) {

 

super(world);

System.out.println(maxHealth);

this.setSize(0.91F, 0.91F);

this.getNavigator().setAvoidsWater(true);

this.getNavigator().setCanSwim(false);

this.tasks.addTask(0, new EntityAIAttackOnCollide(this, 1.0D, true));

this.tasks.addTask(1, new EntityAIWatchClosest(this, EntityPlayer.class, 16.0F));

        this.tasks.addTask(2, new EntityAIFollowOwner(this, 1.0D, 8.0F, 5.0F));

        this.tasks.addTask(3, this.aiSit);

        this.tasks.addTask(4, new EntityAIAvoidEntity(this, EntityPlayer.class, 16.0F, 1.5D, 1.5D));

        this.tasks.addTask(5, new EntityAIWander(this, 1.0D));

        this.targetTasks.addTask(0, new EntityAIOwnerHurtByTarget(this));

        this.targetTasks.addTask(1, new EntityAIOwnerHurtTarget(this));

        this.targetTasks.addTask(2, new EntityAIAttackOnCollide(this, 1.0D, true));

        this.setTamed(false);

       

}

 

protected void applyEntityAttributes() {

 

super.applyEntityAttributes();

 

this.getEntityAttribute(SharedMonsterAttributes.maxHealth).setBaseValue(maxHealth);

this.getEntityAttribute(SharedMonsterAttributes.movementSpeed).setBaseValue(0.25D);

this.getAttributeMap().registerAttribute(SharedMonsterAttributes.attackDamage);

    this.getEntityAttribute(SharedMonsterAttributes.attackDamage).setBaseValue(5.0D);

 

}

 

public boolean interact(EntityPlayer par1EntityPlayer)

    {

        ItemStack itemstack = par1EntityPlayer.inventory.getCurrentItem();

       

        if (itemstack != null && itemstack.getItem() == Item.getItemFromBlock(Blocks.red_flower))

        {

            if (!par1EntityPlayer.capabilities.isCreativeMode)

            {

                --itemstack.stackSize;

            }

 

            if (itemstack.stackSize <= 0)

            {

                par1EntityPlayer.inventory.setInventorySlotContents(par1EntityPlayer.inventory.currentItem, (ItemStack)null);

            }

 

            if (par1EntityPlayer.getCommandSenderName().equalsIgnoreCase(this.getOwnerName()) && !this.worldObj.isRemote)

            {

                this.aiSit.setSitting(!this.isSitting());

                this.isJumping = false;

                this.setPathToEntity((PathEntity)null);

                this.setTarget((Entity)null);

                this.setAttackTarget((EntityLivingBase)null);

                FMLClientHandler.instance().getClient().ingameGUI.getChatGUI().printChatMessage(new ChatComponentText("XP: " + Integer.toString(properties.getXP()) + "/" + properties.getRequiredXP() + " | " + "Level: " + properties.getLevel() + " | " + "Health: " + (int)this.getHealth() + "/" + maxHealth));

            }

           

            if (!this.worldObj.isRemote && !this.isTamed())

            {

                if (this.rand.nextInt(3) == 0)

                {

                    this.setTamed(true);

                    this.setPathToEntity((PathEntity)null);

                    this.setAttackTarget((EntityLivingBase)null);

                    this.setOwner(par1EntityPlayer.getCommandSenderName());

                    this.playTameEffect(true);

                    this.aiSit.setSitting(!this.isSitting());

                    this.worldObj.setEntityState(this, (byte)7);

                }

                else

                {

                    this.playTameEffect(false);

                    this.worldObj.setEntityState(this, (byte)6);

                }

            }

 

            return true;

        }

 

        return super.interact(par1EntityPlayer);

    }

 

public boolean attackEntityAsMob(Entity par1Entity) {

 

properties.addXP(50);

 

        return par1Entity.attackEntityFrom(DamageSource.causeMobDamage(this), (float) getEntityAttribute(SharedMonsterAttributes.attackDamage).getAttributeValue());

       

}

 

@SideOnly(Side.CLIENT)

    public int getLevel() {

 

        return properties.getLevel();

       

    }

 

@Override

public EntityAgeable createChild(EntityAgeable var1) {

 

return null;

 

}

 

public boolean isAIEnabled() {

 

return true;

 

}

 

}

 

 

[jabelar]

You don't understand, at the point where you have this code:

public BlocklingStats properties = BlocklingStats.get(this);

 

The "this" that you're passing hasn't even been constructed yet.  You're trying to get properties for an entity that doesn't exist yet.

 

So all that stuff should be moved into your constructor.  Maybe something more like:

public class EntityBlockling extends EntityTameable {
   
   public BlocklingStats properties ;
   public int level;
   public double maxHealth = 10.0D;
   
   public EntityBlockling(World world) {
      
      super(world);

      properties = BlocklingStats.get(this); // <-- now the "this" should properly exist
      level = properties.getLevel();

      System.out.println("Constructing EntityBlockling");
      System.out.println("maxHealth field = "+maxHealth);
      System.out.println("properties.getMaxHeath() ="+properties.getMaxHealth());  // <-- add more debugging statements
      this.setSize(0.91F, 0.91F);

 

Now I'm not sure the above will fully fix your problem, but you should do it.  I think we also need to see what is happening in the applyEntityAttributes() method.  Add debug statement like this:

 protected void applyEntityAttributes() {

      super.applyEntityAttributes();
      
      System.out.println("Applying entity attributes");
      System.out.println("Before setting, maxHealth attribute = "+this.getEntityAttribute(SharedMonsterAttributes.maxHealth).getBaseValue());
      this.getEntityAttribute(SharedMonsterAttributes.maxHealth).setBaseValue(maxHealth);   
      System.out.println("After setting, maxHealth attribute = "+this.getEntityAttribute(SharedMonsterAttributes.maxHealth).getBaseValue());
      this.getEntityAttribute(SharedMonsterAttributes.movementSpeed).setBaseValue(0.25D);
      this.getAttributeMap().registerAttribute(SharedMonsterAttributes.attackDamage);
       this.getEntityAttribute(SharedMonsterAttributes.attackDamage).setBaseValue(5.0D);
      
   }

 

Run the code with the debug statements I added above and post the console output here.

[loawkise]

Sorry I misunderstood before, changed it up, thanks. Here is the console after doing what you said.

 

Applying entity attributes

Before setting, maxHealth attribute = 20.0

After setting, maxHealth attribute = 0.0

Applying entity attributes

Before setting, maxHealth attribute = 20.0

After setting, maxHealth attribute = 0.0

[jabelar]

Okay, so you can see that it is actually setting max health to 0 at point where you're setting the attribute.

 

Can you add debug statement so we can confirm that maxHealth is actually 0 at that point:

protected void applyEntityAttributes() {

 

      super.applyEntityAttributes();

     

      System.out.println("Applying entity attributes");

      System.out.println("maxHealth field ="+maxHealth);

      System.out.println("Before setting, maxHealth attribute = "+this.getEntityAttribute(SharedMonsterAttributes.maxHealth).getBaseValue());

      this.getEntityAttribute(SharedMonsterAttributes.maxHealth).setBaseValue(maxHealth); 

      System.out.println("After setting, maxHealth attribute = "+this.getEntityAttribute(SharedMonsterAttributes.maxHealth).getBaseValue());

      this.getEntityAttribute(SharedMonsterAttributes.movementSpeed).setBaseValue(0.25D);

      this.getAttributeMap().registerAttribute(SharedMonsterAttributes.attackDamage);

      this.getEntityAttribute(SharedMonsterAttributes.attackDamage).setBaseValue(5.0D);

     

  }

 

Run it again and post the console output here.  Please include the console output related to the constructor println statements I asked you to add earlier.

[loawkise]

Okay, I have added the extra println() and here is the console output in the order it comes out.

 

Applying entity attributes

maxHealth field =0.0

Before setting, maxHealth attribute = 20.0

After setting, maxHealth attribute = 0.0

Constructing EntityBlockling

maxHealth field = 10.0

properties.getMaxHeath() =10.0

[jabelar]

Okay, so it is obvious that the problem is that your maxHealth field is set to 0 at the point you're setting the attribute.

 

You just need to figure out why.  Can you post the full code for your class now since you've been editing it a bit?

 

In the worst case, instead of using a field, you could just set the attribute directly to the value you want, but it would be good to understand why this is happening.

[loawkise]

Yeah, I pretty much have to use a field as I will be changing it depending on the entities level. Here is the whole entity class:

 

 

public class EntityBlockling extends EntityTameable {

 

public BlocklingStats properties;

public int level;

public double maxHealth;

 

public EntityBlockling(World world) {

 

super(world);

 

properties = BlocklingStats.get(this);

level = properties.getLevel();

maxHealth = properties.getMaxHealth();

 

System.out.println("Constructing EntityBlockling");

System.out.println("maxHealth field = "+maxHealth);

      System.out.println("properties.getMaxHeath() =" + properties.getMaxHealth());

 

this.setSize(0.91F, 0.91F);

this.getNavigator().setAvoidsWater(true);

this.getNavigator().setCanSwim(false);

this.tasks.addTask(0, new EntityAIAttackOnCollide(this, 1.0D, true));

this.tasks.addTask(1, new EntityAIWatchClosest(this, EntityPlayer.class, 16.0F));

        this.tasks.addTask(2, new EntityAIFollowOwner(this, 1.0D, 8.0F, 5.0F));

        this.tasks.addTask(3, this.aiSit);

        this.tasks.addTask(4, new EntityAIAvoidEntity(this, EntityPlayer.class, 16.0F, 1.5D, 1.5D));

        this.tasks.addTask(5, new EntityAIWander(this, 1.0D));

        this.targetTasks.addTask(0, new EntityAIOwnerHurtByTarget(this));

        this.targetTasks.addTask(1, new EntityAIOwnerHurtTarget(this));

        this.targetTasks.addTask(2, new EntityAIAttackOnCollide(this, 1.0D, true));

        this.setTamed(false);

       

}

 

protected void applyEntityAttributes() {

 

super.applyEntityAttributes();

 

System.out.println("Applying entity attributes");

System.out.println("maxHealth field =" + maxHealth);

System.out.println("Before setting, maxHealth attribute = "+this.getEntityAttribute(SharedMonsterAttributes.maxHealth).getBaseValue());

this.getEntityAttribute(SharedMonsterAttributes.maxHealth).setBaseValue(maxHealth); 

System.out.println("After setting, maxHealth attribute = "+this.getEntityAttribute(SharedMonsterAttributes.maxHealth).getBaseValue());

this.getEntityAttribute(SharedMonsterAttributes.movementSpeed).setBaseValue(0.25D);

this.getAttributeMap().registerAttribute(SharedMonsterAttributes.attackDamage);

this.getEntityAttribute(SharedMonsterAttributes.attackDamage).setBaseValue(5.0D);

 

}

 

public boolean interact(EntityPlayer par1EntityPlayer)

    {

        ItemStack itemstack = par1EntityPlayer.inventory.getCurrentItem();

       

        if (itemstack != null && itemstack.getItem() == Item.getItemFromBlock(Blocks.red_flower))

        {

            if (!par1EntityPlayer.capabilities.isCreativeMode)

            {

                --itemstack.stackSize;

            }

 

            if (itemstack.stackSize <= 0)

            {

                par1EntityPlayer.inventory.setInventorySlotContents(par1EntityPlayer.inventory.currentItem, (ItemStack)null);

            }

 

            if (par1EntityPlayer.getCommandSenderName().equalsIgnoreCase(this.getOwnerName()) && !this.worldObj.isRemote)

            {

                this.aiSit.setSitting(!this.isSitting());

                this.isJumping = false;

                this.setPathToEntity((PathEntity)null);

                this.setTarget((Entity)null);

                this.setAttackTarget((EntityLivingBase)null);

                FMLClientHandler.instance().getClient().ingameGUI.getChatGUI().printChatMessage(new ChatComponentText("XP: " + Integer.toString(properties.getXP()) + "/" + properties.getRequiredXP() + " | " + "Level: " + properties.getLevel() + " | " + "Health: " + (int)this.getHealth() + "/" + maxHealth));

            }

           

            if (!this.worldObj.isRemote && !this.isTamed())

            {

                if (this.rand.nextInt(3) == 0)

                {

                    this.setTamed(true);

                    this.setPathToEntity((PathEntity)null);

                    this.setAttackTarget((EntityLivingBase)null);

                    this.setOwner(par1EntityPlayer.getCommandSenderName());

                    this.playTameEffect(true);

                    this.aiSit.setSitting(!this.isSitting());

                    this.worldObj.setEntityState(this, (byte)7);

                }

                else

                {

                    this.playTameEffect(false);

                    this.worldObj.setEntityState(this, (byte)6);

                }

            }

 

            return true;

        }

 

        return super.interact(par1EntityPlayer);

    }

 

public boolean attackEntityAsMob(Entity par1Entity) {

 

properties.addXP(10);

 

        return par1Entity.attackEntityFrom(DamageSource.causeMobDamage(this), (float) getEntityAttribute(SharedMonsterAttributes.attackDamage).getAttributeValue());

       

}

 

@SideOnly(Side.CLIENT)

    public int getLevel() {

 

        return properties.getLevel();

       

    }

 

@Override

public EntityAgeable createChild(EntityAgeable var1) {

 

return null;

 

}

 

public boolean isAIEnabled() {

 

return true;

 

}

 

}

 

 

 

Also here is the "properties" class:

 

 

public class BlocklingStats implements IExtendedEntityProperties {

 

public final static String EXT_PROP_NAME = "BlocklingXP";

 

public EntityBlockling blockling;

public int xp = 0;

public int level = 1;

public int requiredXP = 256;

public double maxHealth = 10.0D;

 

public BlocklingStats(EntityBlockling blockling) {

 

this.blockling = blockling;

 

}

 

public static final void register(EntityBlockling blockling) {

 

blockling.registerExtendedProperties(BlocklingStats.EXT_PROP_NAME, new BlocklingStats(blockling));

 

}

 

public static final BlocklingStats get(EntityBlockling entity) {

 

return (BlocklingStats) entity.getExtendedProperties(EXT_PROP_NAME);

 

}

 

@Override

public void saveNBTData(NBTTagCompound compound) {

 

compound.setInteger("xp", this.xp);

compound.setInteger("level", this.level);

compound.setInteger("requiredXP", this.requiredXP);

compound.setDouble("maxHealth", this.maxHealth);

 

}

 

@Override

public void loadNBTData(NBTTagCompound compound) {

 

this.xp = compound.getInteger("xp");

this.level = compound.getInteger("level");

this.requiredXP = compound.getInteger("requiredXP");

this.maxHealth = compound.getDouble("maxHealth");

 

}

 

@Override

public void init(Entity entity, World world) {

 

 

 

}

 

public void addXP(int addedXP) {

 

xp = xp + addedXP;

onLevelUp();

 

}

 

public void onLevelUp() {

 

if(xp >= requiredXP) {

 

this.xp = 0;

this.level++;

calculateRequiredXP();

 

}

 

}

 

public void calculateRequiredXP() {

 

this.requiredXP = level * level * 8 * (8 + level);

 

}

 

public int getXP() {

 

return xp;

 

}

 

public int getRequiredXP() {

 

return requiredXP;

 

}

 

public int getLevel() {

 

return level;

 

}

 

public double getMaxHealth() {

 

return maxHealth;

 

}

 

}

 

 

[jabelar]

Okay, what I believe is happening is that your loadNBT is being called and overwriting your maxHealth value in the properties class.

 

Again, you can debug this stuff easily yourself if you put in console statements for every method.  When I'm coding I seriously put in a System.out.println in every method so I can follow the execution to confirm it is correct.  So please add statements in your properties class, in all of the constructor, the loadNBT, and the getMaxHealth methods.  You should be very easily able to figure out where the problem is if you check the values at every point.

[loawkise]

Okay I will just try to figure this out because I just got it to a stage where it seemed to work but it required me being able to call the applyEntityAttributes() method again so I go register the new max health, but this just leads to a crash because the entity is already spawned so it says in the console "attributes already registered". Hopefully I will get to the bottom of this, but at the moment I don't think I can update the entities max health without registering the attributes again which doesn't work.

[jabelar]

Okay I will just try to figure this out because I just got it to a stage where it seemed to work but it required me being able to call the applyEntityAttributes() method again so I go register the new max health, but this just leads to a crash because the entity is already spawned so it says in the console "attributes already registered". Hopefully I will get to the bottom of this, but at the moment I don't think I can update the entities max health without registering the attributes again which doesn't work.

 

I don't think you're thinking this through.  To fix a problem you need to "trace" the execution of the code.  Pretend you're the computer and execute your code.  And use println statements to help you.  Don't just experiment, that isn't the way to fix things.

 

In this case, are you sure that the maxHealth isn't being changed to 0 when the loadNBT happens?  Something in your code is changing maxHealth value to 0, and that is the only place in the code that changes that field.  So look at that.

 

Just make sure every line of code is doing what you expect by confirming with println.  It should only take you about 3 minutes to figure this out if you trace the execution to the point where maxHealth is being changed to 0.

[loawkise]

I figured out now why it wasn't working by adding println() statements like you said. Basically when the mob spawns the applyEntityAttributes() method is called before the constructor and I was initializing the maxHealth field in the constructor which meant it only happened after the attributes were applied so it now works. But I have one last problem, I cannot reapply entity attributes to a mob as I get the error mentioned before where it says "Attribute is already registered!" and the game crashes which makes sense. So I am wondering if there is a way around this. I know that the wolves are able to update their max health when they are tamed but there is no indication of the applyEntityAttributes() method being called again so I don't understand why their health updates but not mine. If anyone knows that would be great but if not I will just continue to try and figure it out.

[jabelar]

If you look closely at your apply attributes method you are registering the attackDamage attribute in that method and you're also calling the super method which registers other attributes.  So if you called the apply attributes method again there would be an error.

 

So if you want to update attributes later, you should create different method called setAttributes() that doesn't include the lines that do registrations.  Or if you only want to update the max health then create an setMaxHealthAttribute() method that only does that:

   public void setMaxHealthAttribute(double parMaxHealth) 
{
      maxHealth = parMaxHealth;
      
      System.out.println("Setting maxHealth attribute");
     System.out.println("Before setting, maxHealth attribute = "+this.getEntityAttribute(SharedMonsterAttributes.maxHealth).getBaseValue());
      this.getEntityAttribute(SharedMonsterAttributes.maxHealth).setBaseValue(maxHealth);   
      System.out.println("After setting, maxHealth attribute = "+this.getEntityAttribute(SharedMonsterAttributes.maxHealth).getBaseValue());      
   }

 

Honestly, what I'm trying to teach you is to go through your code line by line and "trace" what would happen.  It should be very easy to see that if you get an error that says "already registered" and you go back to your code and see that you are in fact registering again, so fix it...

[loawkise]

Okay, I have spent a good 3 hours sat doing what you said and I now fully understand and appreciate the importance of doing as much as you can yourself. I actually managed to solve it by myself and realised why it was happening and I can apply it to other situations. So I guess I should thank you for persevering with me (I could tell it was frustrating you a bit) and pushing to get the point across because it has and will benefit me greatly in the future

[jabelar]

Okay, I have spent a good 3 hours sat doing what you said and I now fully understand and appreciate the importance of doing as much as you can yourself. I actually managed to solve it by myself and realised why it was happening and I can apply it to other situations. So I guess I should thank you for persevering with me (I could tell it was frustrating you a bit) and pushing to get the point across because it has and will benefit me greatly in the future

 

Awesome.  The reason I perservered with you is because I knew you were close and just needed the push.  Programming is about details and understanding every line of execution.  Printing to console can get you a long way to helping you trace the execution and detect what is going wrong.  With that skill alone you'll advance very quickly.

 

Cheers!