Search the Forums BEFORE making a new post.

[1.7.2] Potential Memory Leak

Posted June 27, 201411 yr

I'm getting this in my console:

[09:55:14] [server thread/ERROR] [FML]: Detected ongoing potential memory leak. 100 packets have leaked. Top offenders
[09:55:14] [server thread/ERROR] [FML]: 	 ttm : 100

I'm partially worried, because this packet is from the client to the server, and is gonna be sent a lot.

Packet:

package ttm.network;

import io.netty.buffer.ByteBuf;
import io.netty.channel.ChannelHandlerContext;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraftforge.common.ForgeHooks;
import ttm.Reference;

public class PacketMessage extends AbstractPacket {
public int msgID;

public PacketMessage(int msgID) {
	super();
	this.msgID = msgID;
}

public PacketMessage() {
	this(0);
}

@Override
public void encodeInto(ChannelHandlerContext ctx, ByteBuf buffer) {
	buffer.writeInt(msgID);
}

@Override
public void decodeInto(ChannelHandlerContext ctx, ByteBuf buffer) {
	msgID = buffer.readInt();
}

@Override
public void handleClientSide(EntityPlayer player) {
}

@Override
public void handleServerSide(EntityPlayer player) {
	switch(msgID) {
	case Reference.PacketMessages.JUMP: {
		ForgeHooks.onLivingJump(player);
		break;
	}
	}
}
}

Should I be worried about this?

Kain

Quote

June 27, 201411 yr

Is your packet system based on this tutorial? http://www.minecraftforge.net/wiki/Netty_Packet_Handling

You'll see that there is now a warning on that tutorial saying it creates memory leaks and should not be used.

Instead you need to use the new SimpleNetworkWrapper system: http://www.minecraftforge.net/forum/index.php/topic,20135.0.html

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Quote

June 27, 201411 yr

Author

I've run into a problem.

Whenever I send the message to the server, it never arrives. It only writes to the byte buffer.

Message:

package ttm.network;

import io.netty.buffer.ByteBuf;
import net.minecraftforge.common.ForgeHooks;
import ttm.Reference;
import cpw.mods.fml.common.network.simpleimpl.IMessage;
import cpw.mods.fml.common.network.simpleimpl.IMessageHandler;
import cpw.mods.fml.common.network.simpleimpl.MessageContext;

public class SimpleServerMessage extends AbstractMessage {
public int msgID;

public SimpleServerMessage(int msgID) {
	super();
	this.msgID = msgID;
}

public SimpleServerMessage() {
	this(0);
}

@Override
public void toBytes(ByteBuf buf) {
	buf.writeInt(msgID);
}

@Override
public void fromBytes(ByteBuf buf) {
	msgID = buf.readInt();
}

public static class Handler implements IMessageHandler<SimpleServerMessage, IMessage> {
	public IMessage onMessage(SimpleServerMessage message, MessageContext ctx) {
		switch(message.msgID) {
		case Reference.PacketMessages.JUMP: {
			ForgeHooks.onLivingJump(ctx.getServerHandler().playerEntity);
			break;
		}
		}

		return null;
	}
}
}

Basic Message:

package ttm.network;

import io.netty.buffer.ByteBuf;
import net.minecraft.entity.player.EntityPlayerMP;
import ttm.TtM;
import cpw.mods.fml.common.network.simpleimpl.IMessage;
import cpw.mods.fml.common.network.simpleimpl.IMessageHandler;
import cpw.mods.fml.common.network.simpleimpl.MessageContext;

public abstract class BasicMessage implements IMessage {
@Override
public abstract void fromBytes(ByteBuf buf);

@Override
public abstract void toBytes(ByteBuf buf);

public void sendToAll() {
	TtM.networkChannel.sendToAll(this);
}

public void sendTo(EntityPlayerMP player) {
	TtM.networkChannel.sendTo(this, player);
}

public void sendToServer() {
	TtM.networkChannel.sendToServer(this);
	System.err.println("TO THE SERVER!");
}
}

Kain

Quote

June 27, 201411 yr

Author

Ok, I only had the IDs because that message class was only for short messages.

None of my other messages are being received either.

Mod:

package ttm;

import static ttm.Reference.ID;
import static ttm.Reference.NAME;
import static ttm.Reference.VERSION;
import ttm.handler.GuiHandler;
import ttm.network.MessageJump;
import ttm.network.MessageOpenGui;
import ttm.network.MessageQuickStack;
import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.Mod.EventHandler;
import cpw.mods.fml.common.Mod.Instance;
import cpw.mods.fml.common.SidedProxy;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;
import cpw.mods.fml.common.network.NetworkRegistry;
import cpw.mods.fml.common.network.simpleimpl.SimpleNetworkWrapper;
import cpw.mods.fml.relauncher.Side;

@Mod(name = NAME, modid = ID, version = VERSION)
public class TtM {
@Instance(ID)
public static TtM instance;
@SidedProxy(serverSide = ID + ".ServerProxy", clientSide = ID + ".ClientProxy")
public static ServerProxy proxy;

public static GuiHandler guiHandler = new GuiHandler();
public static SimpleNetworkWrapper networkChannel;

@EventHandler
public void preInit(FMLPreInitializationEvent event) {
	NetworkRegistry.INSTANCE.registerGuiHandler(this, guiHandler);
	networkChannel = NetworkRegistry.INSTANCE.newSimpleChannel("TtM");
	loadPackets();

	proxy.loadServer();
	proxy.loadClient();
}

public void loadPackets() {
	networkChannel.registerMessage(MessageJump.Handler.class, MessageJump.class, 0, Side.SERVER);
	networkChannel.registerMessage(MessageOpenGui.Handler.class, MessageOpenGui.class, 0, Side.SERVER);
	networkChannel.registerMessage(MessageQuickStack.Handler.class, MessageQuickStack.class, 0, Side.SERVER);
}
}

Message:

package ttm.network;

import io.netty.buffer.ByteBuf;
import net.minecraft.entity.player.EntityPlayer;
import ttm.TtM;
import cpw.mods.fml.common.network.simpleimpl.IMessage;
import cpw.mods.fml.common.network.simpleimpl.IMessageHandler;
import cpw.mods.fml.common.network.simpleimpl.MessageContext;

public class MessageOpenGui extends BasicMessage {
public int guiID;

public MessageOpenGui(int guiID) {
	super();
	this.guiID = guiID;
}

public MessageOpenGui() {
	this(0);
}

@Override
public void toBytes(ByteBuf buf) {
	buf.writeInt(guiID);

	System.err.println("HI2");
}

@Override
public void fromBytes(ByteBuf buf) {
	guiID = buf.readInt();

	System.err.println("HI");
}

public static class Handler implements IMessageHandler<MessageOpenGui, IMessage> {
	public IMessage onMessage(MessageOpenGui message, MessageContext ctx) {
		EntityPlayer player = ctx.getServerHandler().playerEntity;

		player.openGui(TtM.instance, message.guiID, player.worldObj, (int) player.posX, (int) player.posY, (int) player.posZ);

		return null;
	}
}
}

BasicMessage:

package ttm.network;

import io.netty.buffer.ByteBuf;
import net.minecraft.entity.player.EntityPlayerMP;
import ttm.TtM;
import cpw.mods.fml.common.network.simpleimpl.IMessage;
import cpw.mods.fml.common.network.simpleimpl.IMessageHandler;
import cpw.mods.fml.common.network.simpleimpl.MessageContext;

public abstract class BasicMessage implements IMessage {
@Override
public abstract void fromBytes(ByteBuf buf);

@Override
public abstract void toBytes(ByteBuf buf);

public void sendToAll() {
	TtM.networkChannel.sendToAll(this);
}

public void sendTo(EntityPlayerMP player) {
	TtM.networkChannel.sendTo(this, player);
}

public void sendToServer() {
	TtM.networkChannel.sendToServer(this);
	System.err.println("TO THE SERVER!");
}
}

Kain

Quote

June 27, 201411 yr

Author

Ohhhhhhhhhhhhhhhhhhh

Thanks for catching that.

Kain

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/20364-172-potential-memory-leak/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

(((SOLVED))) Loading into certain worlds stuck on "Reading world data" then stops responding.

So, I tried this, and the world did load, but ALL of the modded items and things I had completely disappeared, as well as many unmodded things like my chests and items I was carrying. Any solutions?

By SyntaxError · 3 hours ago3 hr
How do I remove 3d headlayer on NPC's skin in CustomNpc? (1.16.5)

I do have to add that this is my answer for 1.12.2 but it should ALSO work for future versions.

By Tiny_Sly · Yesterday at 12:11 AM1 day
How do I remove 3d headlayer on NPC's skin in CustomNpc? (1.16.5)

I know this was posted almost 3 years ago but this is for anyone who is still looking for an answer.

First, find your config folder. -> C:\Users\ (desktop user's name) \curseforge(or the application where you've downloaded you mod)\minecraft\Instances\config (The config folder should be in the same folder as your mods folder.) Once you click on the config folder, search for CustomNpcs.cfg. Once found, click on it (you can edit it using notepad) and search for the line "headweartype". Set the value to 0 if you want a 2d head layer, set it to 1 for a 3d head layer. Then save the options and you should be good to go from there! :)

By Tiny_Sly · Yesterday at 12:05 AM1 day
[1.16.1]Render enchanted glint to item

ik this was 5 years ago but is this the same in 1.20? or is there a different method?

By FireDude123 · Sunday at 08:55 PM2 days
🎯 Elivius Needs You! Staff Wanted In All Positions! [Looking for Staff]

🌍 Elivius — Building a Legendary Minecraft Experience

Elivius is more than just a Minecraft server — it’s a vision. For years, our world has been in development, on and off, shaped by a small but passionate team. Now, we’re pushing forward with full force to create something unforgettable: a Towny-based survival experience enriched with custom quests, seasonal events, minigames, immersive builds, and unique features you won’t find anywhere else.

✨ Our Vision & Goals
Create a community-first server that feels alive, fair, and fun.
Build immersive seasonal events that keep players engaged year-round.
Develop custom content that brings personality and depth to Towny survival.
Grow Elivius into a credible, long-term project with transparency, quality, and heart.

We’ve already built the foundation, tested systems, and proven our resilience. Now, we’re looking for talented volunteers to join us and help Elivius become everything we know it can be.

⚒️ Recruiting Passionate Volunteers

Elivius is a volunteer project. While we don’t offer pay, we do provide:
🎁 Staff-exclusive giveaways (Nitro, rewards, in-game perks).
🏆 A chance to shape one of the most ambitious Towny servers.
💡 An opportunity to learn, grow, and leave your mark on something players will remember.
❤️ A welcoming, close-knit team that feels more like family.

We’re currently looking for:

🟦 Helper (Moderation Team)
Front-line moderators who answer questions, enforce rules, and keep the server safe and welcoming.

🟩 Builder
Creative builders who design spawns, event maps, and breathtaking seasonal builds.

🟨 Content Team
Configuration editors who bring features to life using plugins, resource packs, quests, menus, and systems.

🟦 Developer
Backend coders who create and maintain custom plugins, optimize performance, and bring new mechanics to life.

🟪 Media Team
Artists, editors, and designers who create graphics, trailers, animations, and promo content.

🟧 Content Creator
Streamers and YouTubers who help grow our player base. Creators get promotions and commissions on purchases through their codes.

🚀 Be Part of the Future of Elivius

We’re still small, but our ambitions are huge. With your help, we can turn Elivius into a legendary community where players feel at home and excited to return.

📌 All requirements are currently waived to help motivated applicants get started.
💬 Join our Discord and apply in the #staff-applications channel today!
👉 https://discord.gg/4HBU5tBDqc

Elivius wants YOU. Let’s build something unforgettable, together.

By AidenJules_ · Posted Sunday at 03:58 AM3 days

Sign In

[1.7.2] Potential Memory Leak

Featured Replies

Join the conversation

Posts

(((SOLVED))) Loading into certain worlds stuck on "Reading world data" then stops responding.

How do I remove 3d headlayer on NPC's skin in CustomNpc? (1.16.5)

How do I remove 3d headlayer on NPC's skin in CustomNpc? (1.16.5)

[1.16.1]Render enchanted glint to item

🎯 Elivius Needs You! Staff Wanted In All Positions! [Looking for Staff]

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)