Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[Resolved] Blocks changing into other blocks

altorac12

By altorac12
in Modder Support

 Share

Recommended Posts

altorac12 Tree Puncher

altorac12

Posted
Posted

I'm running into an issue while creating a new mod for 1.7.2.  I'm adding blocks then running the debug version of Minecraft in eclipse to place them to verify they are working properly and the textures are displaying as expected, and a couple of times now after a code change I've had blocks "shift" on me, where all of the block x's will turn into block y's, all the y's become z's and so on in the debug world.

 

I'm not changing the names of anything, and after the second time it happened I started playing around and figured out that if I changed the configuration file to remove a block, launched minecraft, then changed the configuration back I could get this sort of behavior.

 

I have quite a bit of programming/java experience but this is the first time I've tried to mod minecraft and I'm not sure what I could be doing to cause this, I'm hoping someone here might have some ideas.

 

I'm using Forge 10.12.1.1060.

Link to comment
Share on other sites
altorac12 Tree Puncher

altorac12

Posted
  • Author
Posted

Here is my main code file, if you want to see some of the individual item/block files I can post those too but they're pretty straight forward subclasses of the standard minecraft versions of those blocks/items.  The general idea is to add birch/spruce/etc. versions of some of the standard oak only blocks.

 

https://gist.github.com/anonymous/dedb9ca7a4124178f0dd

 

Edit: fixed link

Link to comment
Share on other sites
TheGreyGhost Reality Controller

TheGreyGhost

Posted
Posted

Hi

 

My guess is that your ID allocation code (using i++) is getting out of step on save vs reload.  If you change your code, the numbers allocated to your blocks change, but of course they don't change in the saved world.

 

I'd suggest either changing to a more fixed ID allocation (at least - for debugging), or just regenerating your test world each time and don't worry about it.

 

-TGG

Link to comment
Share on other sites
altorac12 Tree Puncher

altorac12

Posted
  • Author
Posted

I don't quite understand what you mean.  It was my impression that with 1.7 you didn't have to manually assign Block/Item IDs so I don't have "ID allocation code".  The i variable here is just keeping track of which wood I'm on and passing i+1 to some of the constructors is just so they know what texture to use (for items like fence/buttons that use the plank texture rather than having their own) and corresponds to the plank metadata value for the wood that item is made out of.  That is why it's only incremented at the end of the loop.

 

If this is for some reason something I'll only ever see in debug I don't have a problem with it, as you say I can regen the debug world each time and it's only a minor inconvenience.  However I'm concerned that if I publish version 1 of this mod, then make changes and release version 2 later then if I don't know what's causing this bug/how to avoid it it's going to end up scrambling all user's saved worlds which is obviously a huge problem.  So I would like to find some explanation so I can be sure a user isn't ever going to run into this issue when changing versions of my mod.

 

I can experiment with how to assign fixed Block IDs in 1.7 (I think I saw somewhere how this is possible) but it was my understanding that this wasn't necessary anymore and going forward the block IDs were eventually going to be removed outright so I'm not sure if that solution is going to work when porting to 1.8 and beyond.

Link to comment
Share on other sites
TheGreyGhost Reality Controller

TheGreyGhost

Posted
Posted

Hmmm ok.  I'd assumed your code was still for 1.6.4 (didn't read  your original post properly!), but you're right you shouldn't manually allocate IDs for 1.7.

 

I have heard rumours that the world load/save should automatically reassign IDs to the correct block names, although I don't know how that works.  Probably deep in the bowels of GameData.

 

Sorry, no ideas on how to fix it, and yes it does sound like a potential problem...

 

-TGG

 

 

Link to comment
Share on other sites
altorac12 Tree Puncher

altorac12

Posted
  • Author
Posted

Well I don't know if I should be relieved that I didn't do something too boneheaded or disappointed that this doesn't sound like a quick fix... If forge should be handling this under the covers is it possible this is a forge bug?  If so I would think someone else would have run into the same thing by now but from what I can tell I seem to be the only one with this problem so I assume it's something in my code.

 

My debug console has several lines saying things like "Found item id mismatch altorac12_woodcompatibility:big_oak_fence : 209 214" after making code changes, but it happens even if there isn't an issue so I don't think it this is necessarily a problem.  It does appear that forge is doing some id remapping though, and most of the time it appears to be successful.

 

On times that I'm reproducing the issue I'm seeing things like the following:

 

[09:40:48] [server thread/ERROR] [FML]: There are unidentified mappings in this world - it cannot be loaded

java.lang.RuntimeException: Mod IDs are missing

at cpw.mods.fml.common.Loader.fireMissingMappingEvent(Loader.java:865)

        ...

 

Given that I took blocks out to reproduce the issue though I would expect the unidentified mappings and the missing mod IDs error, but it's the only thing out of the ordinary I see in the console output.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • SKYsource
      Server WARN

      By SKYsource · Posted

      How to fix file server-1.20.1-20230612.114412-srg.jar  
    • houman
      New tiered support policy

      By houman · Posted

      Bagus   Bagus
    • Gianka1485
      [1.20.1] Getting players skin texture by their UUID

      By Gianka1485 · Posted

      Just a few months ago I was creating my own plugin for Minecraft 1.20.2 spigot that did the same thing, but the skins were not saved, if you can understand this code that I made a long time ago it may help you.   //This is a class method private static String APIRequest(String value, String url, String toSearch) { try { URL api = new URL(url + value); HttpURLConnection connection = (HttpURLConnection) api.openConnection(); connection.setRequestMethod("GET"); int responseCode = connection.getResponseCode(); if (responseCode == HttpURLConnection.HTTP_OK) { BufferedReader reader = new BufferedReader(new InputStreamReader(connection.getInputStream())); StringBuilder response = new StringBuilder(); for (String responseChar; (responseChar = reader.readLine()) != null; ) response.append(responseChar); reader.close(); JSONObject responseObject = new JSONObject(response.toString()); if (!toSearch.equals("id")) return responseObject .getJSONArray("properties") .getJSONObject(0) .getString("value"); else return responseObject.getString("id"); } else { AntiGianka.ConsoleMessage(ChatColor.RED, String.format( "Could not get %s. Response code: %s", ((toSearch.equals("id")) ? "UUID" : "texture"), responseCode )); } } catch (MalformedURLException error) { AntiGianka.ConsoleMessage(ChatColor.RED, "An error occurred while trying to access the URL. Error: " + error); } catch (IOException error) { AntiGianka.ConsoleMessage(ChatColor.RED, "An error occurred while attempting to connect to the URL. Error: " + error); } return ""; } //other class method private void SkinGetter() { String uuid; String textureCoded; if ((uuid = APIRequest(args[0], "https://api.mojang.com/users/profiles/minecraft/", "id")).isEmpty() || (textureCoded = APIRequest(uuid, "https://sessionserver.mojang.com/session/minecraft/profile/", "value")).isEmpty() ) sender.sendMessage(ChatColor.RED + String.format( "An error has occurred while trying to obtain the %s player skin, please check if the name %s is spelled correctly or try again later.", args[0], args[0] ) ); else SkinSetter(textureCoded); } //other more private void SkinSetter(String textureCoded) { JSONObject profile = new JSONObject(new String(Base64.getDecoder().decode(textureCoded))); try { URL textureUrl = new URL(profile.getJSONObject("textures"). getJSONObject("SKIN"). getString("url")); if (sender instanceof Player && args.length == 1) { PlayerTextures playerTextures = ((Player) sender).getPlayerProfile().getTextures(); playerTextures.setSkin(textureUrl); ((Player) sender).getPlayerProfile().setTextures(playerTextures); if (((Player) sender).getPlayerProfile().getTextures().getSkin() != null) sender.sendMessage(((Player) sender).getPlayerProfile().getTextures().getSkin().toString()); else sender.sendMessage("Null"); sender.sendMessage("Skin changed successfully.a"); } else { } AntiGianka.ConsoleMessage(ChatColor.GREEN, "Skin command executed successfully."); } catch (MalformedURLException error) { sender.sendMessage(ChatColor.RED + String.format( "An error has occurred while trying to obtain the %s player skin, please check if the name %s is spelled correctly or try again later.", args[0], args[0] ) ); AntiGianka.ConsoleMessage(ChatColor.RED, "An error occurred while trying to access the URL. Error: " + error); } }  
    • TileEntity
      How to locate deeper and darker structures ?

      By TileEntity · Posted

      Use /locate structure The chat should show all available structures as suggestion For the Ancient City it is /locate structure ancient_city
    • TileEntity
      HELP

      By TileEntity · Posted

      So does it work without this mod? Did you test it with other builds?

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept