Jump to content

Handing block updates


Roboguy99

Recommended Posts

I'm trying to make a cable system, where cables join together. My system at the moment is showing to be very buggy and I'm having trouble with block updating, specifically neighbour block updates. This is my code for block updates:

 

public void onNeighborBlockChange(World world, int x, int y, int z, Block block)
{
	Main.print("Block update detected at " + x + ", " + y + ", " + z);
	world.markBlockForUpdate(x, y, z);
	world.scheduleBlockUpdate(x, y, z, block, tickRate(world));
	tileEntityCable.getAllConnectedWires(x, y, z, world);
}

public void updateTick(World world, int x, int y, int z, Random rand)
{
	world.markBlockForUpdate(x, y, z);
	tileEntityCable.getAllConnectedWires(x, y, z, world);
}

public void onBlockAdded(World world, int x, int y, int z)
{
	world.markBlockForUpdate(x, y, z);
	tileEntityCable.getAllConnectedWires(x, y, z, world);
}

public void breakBlock(World world, int x, int y, int z, Block block, int thingNoOneKnowsWhatItDoes) //What does this last int do?
{
	world.markBlockForUpdate(x, y, z);
	tileEntityCable.getAllConnectedWires(x, y, z, world);
}

 

I have noticed that the neighbour block updates are appearing in the wrong place, in such a way that if I update the block to the north, it gives the co-ordinates of a block to the east instead. Also, placing two cables next to each other only causes the 2nd one to be placed to update, and sometimes they don't update at all.

 

I can't find any documentation on any of this anywhere, so if anyone can help me that would be great.

 

As for the rest of my system, here is my entire tileEntity class for checking connected wires:

 

package foodTech.tileEntities;

import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.world.World;
import foodTech.blocks.CreateBlocks;

public class TileEntityCable extends TileEntity 
{	
private boolean isWireAbove = false;
private boolean isWireBelow = false;
private boolean isWireNorth = false;
private boolean isWireSouth = false;
private boolean isWireEast = false;
private boolean isWireWest = false;
private boolean[] allConnectionStates = new boolean[6];

public void getAllConnectedWires(int x, int y, int z, World world)
 { 
	if (world.getBlock(x, y+1, z).equals(CreateBlocks.blockCable)) this.isWireAbove = true;
	if (world.getBlock(x, y-1, z).equals(CreateBlocks.blockCable)) this.isWireBelow = true;
	if (world.getBlock(x, y, z+1).equals(CreateBlocks.blockCable)) this.isWireNorth = true;
	if (world.getBlock(x, y, z-1).equals(CreateBlocks.blockCable)) this.isWireSouth = true;
	if (world.getBlock(x+1, y, z+1).equals(CreateBlocks.blockCable)) this.isWireEast = true;
	if (world.getBlock(x-1, y, z-1).equals(CreateBlocks.blockCable)) this.isWireWest = true;

	this.allConnectionStates[0] = this.isWireAbove;
	this.allConnectionStates[1] = this.isWireBelow;
	this.allConnectionStates[2] = this.isWireNorth;
	this.allConnectionStates[3] = this.isWireSouth;
	this.allConnectionStates[4] = this.isWireEast;
	this.allConnectionStates[5] = this.isWireWest;
 }

 public void readFromNBT(NBTTagCompound nbt)
 {
	 super.readFromNBT(nbt);

	 this.isWireAbove = nbt.getBoolean("isWireAbove");
	 this.isWireBelow = nbt.getBoolean("isWireBelow");
	 this.isWireNorth = nbt.getBoolean("isWireNorth");
	 this.isWireSouth = nbt.getBoolean("isWireSouth");
	 this.isWireEast = nbt.getBoolean("isWireEast");
	 this.isWireWest = nbt.getBoolean("isWireWest");
 }

 public void writeToNBT(NBTTagCompound nbt)
 {
	 super.writeToNBT(nbt);

	 nbt.setBoolean("isWireAbove", isWireAbove);
	 nbt.setBoolean("isWireBelow", isWireBelow);
	 nbt.setBoolean("isWireNorth", isWireNorth);
	 nbt.setBoolean("isWireSouth", isWireSouth);
	 nbt.setBoolean("isWireEast", isWireEast);
	 nbt.setBoolean("isWireWest", isWireWest);
 }

 public boolean getWireAboveConnected()
 {
	 return this.isWireAbove;
 }
 public boolean getWireBelowConnected()
 {
	 return this.isWireBelow;
 }
 public boolean getWireNorthConnected()
 {
	 return this.isWireNorth;
 }
 public boolean getWireSouthConnected()
 {
	 return this.isWireSouth;
 }
 public boolean getWireEastConnected()
 {
	 return this.isWireEast;
 }
 public boolean getWireWestConnected()
 {
	 return this.isWireWest;
 }
}

 

I have no idea what I'm doing.

Link to comment
Share on other sites

Take a look at my code, it handles connections and energy transfer: https://github.com/Larsg310/PowerCraft

 

P.S. You don't have to use the

.equals()

method for comparing blocks and items, as there's always 1 instance of them, so you can use the

==

comparison.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

BTW if someone has any tips, ideas or comments about my system of doing it, you can just say so, so i can make system better.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.