Handing block updates

[Roboguy99]

I'm trying to make a cable system, where cables join together. My system at the moment is showing to be very buggy and I'm having trouble with block updating, specifically neighbour block updates. This is my code for block updates:

 

public void onNeighborBlockChange(World world, int x, int y, int z, Block block)
{
	Main.print("Block update detected at " + x + ", " + y + ", " + z);
	world.markBlockForUpdate(x, y, z);
	world.scheduleBlockUpdate(x, y, z, block, tickRate(world));
	tileEntityCable.getAllConnectedWires(x, y, z, world);
}

public void updateTick(World world, int x, int y, int z, Random rand)
{
	world.markBlockForUpdate(x, y, z);
	tileEntityCable.getAllConnectedWires(x, y, z, world);
}

public void onBlockAdded(World world, int x, int y, int z)
{
	world.markBlockForUpdate(x, y, z);
	tileEntityCable.getAllConnectedWires(x, y, z, world);
}

public void breakBlock(World world, int x, int y, int z, Block block, int thingNoOneKnowsWhatItDoes) //What does this last int do?
{
	world.markBlockForUpdate(x, y, z);
	tileEntityCable.getAllConnectedWires(x, y, z, world);
}

 

I have noticed that the neighbour block updates are appearing in the wrong place, in such a way that if I update the block to the north, it gives the co-ordinates of a block to the east instead. Also, placing two cables next to each other only causes the 2nd one to be placed to update, and sometimes they don't update at all.

 

I can't find any documentation on any of this anywhere, so if anyone can help me that would be great.

 

As for the rest of my system, here is my entire tileEntity class for checking connected wires:

 

package foodTech.tileEntities;

import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.world.World;
import foodTech.blocks.CreateBlocks;

public class TileEntityCable extends TileEntity 
{	
private boolean isWireAbove = false;
private boolean isWireBelow = false;
private boolean isWireNorth = false;
private boolean isWireSouth = false;
private boolean isWireEast = false;
private boolean isWireWest = false;
private boolean[] allConnectionStates = new boolean[6];

public void getAllConnectedWires(int x, int y, int z, World world)
 { 
	if (world.getBlock(x, y+1, z).equals(CreateBlocks.blockCable)) this.isWireAbove = true;
	if (world.getBlock(x, y-1, z).equals(CreateBlocks.blockCable)) this.isWireBelow = true;
	if (world.getBlock(x, y, z+1).equals(CreateBlocks.blockCable)) this.isWireNorth = true;
	if (world.getBlock(x, y, z-1).equals(CreateBlocks.blockCable)) this.isWireSouth = true;
	if (world.getBlock(x+1, y, z+1).equals(CreateBlocks.blockCable)) this.isWireEast = true;
	if (world.getBlock(x-1, y, z-1).equals(CreateBlocks.blockCable)) this.isWireWest = true;

	this.allConnectionStates[0] = this.isWireAbove;
	this.allConnectionStates[1] = this.isWireBelow;
	this.allConnectionStates[2] = this.isWireNorth;
	this.allConnectionStates[3] = this.isWireSouth;
	this.allConnectionStates[4] = this.isWireEast;
	this.allConnectionStates[5] = this.isWireWest;
 }

 public void readFromNBT(NBTTagCompound nbt)
 {
	 super.readFromNBT(nbt);

	 this.isWireAbove = nbt.getBoolean("isWireAbove");
	 this.isWireBelow = nbt.getBoolean("isWireBelow");
	 this.isWireNorth = nbt.getBoolean("isWireNorth");
	 this.isWireSouth = nbt.getBoolean("isWireSouth");
	 this.isWireEast = nbt.getBoolean("isWireEast");
	 this.isWireWest = nbt.getBoolean("isWireWest");
 }

 public void writeToNBT(NBTTagCompound nbt)
 {
	 super.writeToNBT(nbt);

	 nbt.setBoolean("isWireAbove", isWireAbove);
	 nbt.setBoolean("isWireBelow", isWireBelow);
	 nbt.setBoolean("isWireNorth", isWireNorth);
	 nbt.setBoolean("isWireSouth", isWireSouth);
	 nbt.setBoolean("isWireEast", isWireEast);
	 nbt.setBoolean("isWireWest", isWireWest);
 }

 public boolean getWireAboveConnected()
 {
	 return this.isWireAbove;
 }
 public boolean getWireBelowConnected()
 {
	 return this.isWireBelow;
 }
 public boolean getWireNorthConnected()
 {
	 return this.isWireNorth;
 }
 public boolean getWireSouthConnected()
 {
	 return this.isWireSouth;
 }
 public boolean getWireEastConnected()
 {
	 return this.isWireEast;
 }
 public boolean getWireWestConnected()
 {
	 return this.isWireWest;
 }
}

 

[larsgerrits]

Take a look at my code, it handles connections and energy transfer: https://github.com/Larsg310/PowerCraft

 

P.S. You don't have to use the

.equals()

method for comparing blocks and items, as there's always 1 instance of them, so you can use the

==

comparison.

[Roboguy99]

Ok thanks I'll have a look through and see if it helps.

[larsgerrits]

BTW if someone has any tips, ideas or comments about my system of doing it, you can just say so, so i can make system better.