Jump to content

[1.7.2][SOLVED] Textures not working properly


Guest Abrynos

Recommended Posts

Guest Abrynos

I've got a problem with my saplings textures. I've made 2 Saplings for 2 trees. In the inventory they got the same texture, but if I plant them on the ground they got their own texture and different trees are growing. I'll give you my block sapling code and a screenshot, because I can't figure out, what to do.

 

I would be grateful if you could help me!

 

Picture:

lld2fc8k48.png

Code:

 

public class AbrBlockSapling extends BlockSapling {

public static final String[] saplings = new String[] {"Whitecherry", "Pinkcherry"};

    private static final IIcon[] saplingicon = new IIcon[saplings.length];

 

    protected AbrBlockSapling()

    {

        float f = 0.4F;

        this.setBlockBounds(0.5F - f, 0.0F, 0.5F - f, 0.5F + f, f * 2.0F, 0.5F + f);

        this.setCreativeTab(AbrCreativeTabs.Abrynosplants);

    }

 

    /**

    * Ticks the block if it's been scheduled

    */

    public void updateTick(World world, int x, int y, int z, Random random)

    {

        if (!world.isRemote)

        {

            super.updateTick(world, x, y, z, random);

 

            if (world.getBlockLightValue(x, y + 1, z) >= 9 && random.nextInt(7) == 0)

            {

                this.func_149879_c(world, x, y, z, random);

            }

        }

    }

 

    /**

    * Gets the block's texture. Args: side, meta

    */

    @SideOnly(Side.CLIENT)

    public IIcon getIcon(int side, int meta)

    {

        if(meta == 0){

        return saplingicon[0];

        }

        else{

        return saplingicon[1];

        }

    }

 

    //markOreGrowMarked

    public void func_149879_c(World world, int x, int y, int z, Random random)

    {

        int l = world.getBlockMetadata(x, y, z);

 

        if ((l & 8) == 0)

        {

            world.setBlockMetadataWithNotify(x, y, z, l | 8, 4);

        }

        else

        {

            this.func_149878_d(world, x, y, z, random);

        }

    }

 

    //growTree

    public void func_149878_d(World world, int x, int y, int z, Random random)

    {

        if (!net.minecraftforge.event.terraingen.TerrainGen.saplingGrowTree(world, random, x, y, z)) return;

        int l = world.getBlockMetadata(x, y, z) & 7;

        Object object = random.nextInt(10) == 0 ? new WorldGenBigTree(true) : new WorldGenTrees(true);

        int i1 = 0;

        int j1 = 0;

        boolean flag = false;

 

        switch (l) {

            case 0: //Whitecherry...   ID's of log & leaf = 0, 0

            object = new FeatureGenTrees(TreeRegistry.blockLog, TreeRegistry.blockLeaf, 0, 0, false, 5, 6, false);

            break;

            case 1: //Pinkcherry...   ID's of log & leaf = 1, 1

            object = new FeatureGenTrees(TreeRegistry.blockLog, TreeRegistry.blockLeaf, 0, 1, false, 5, 6, false);

                break;

            case 2:

                break;

            case 3:

                break;

            case 4:

                break;

            case 5:

            break;

            default:

            break;

        }

 

        Block block = Blocks.air;

 

        if (flag)

        {

            world.setBlock(x + i1, y, z + j1, block, 0, 4);

            world.setBlock(x + i1 + 1, y, z + j1, block, 0, 4);

            world.setBlock(x + i1, y, z + j1 + 1, block, 0, 4);

            world.setBlock(x + i1 + 1, y, z + j1 + 1, block, 0, 4);

        }

        else

        {

            world.setBlock(x, y, z, block, 0, 4);

        }

 

        if (!((WorldGenerator)object).generate(world, random, x + i1, y, z + j1))

        {

            if (flag)

            {

                world.setBlock(x + i1, y, z + j1, this, l, 4);

                world.setBlock(x + i1 + 1, y, z + j1, this, l, 4);

                world.setBlock(x + i1, y, z + j1 + 1, this, l, 4);

                world.setBlock(x + i1 + 1, y, z + j1 + 1, this, l, 4);

            }

            else

            {

                world.setBlock(x, y, z, this, l, 4);

            }

        }

    }

 

//isSameSapling

    public boolean func_149880_a(World world, int x, int y, int z, int par1)

    {

        return world.getBlock(x, y, z) == this && (world.getBlockMetadata(x, y, z) & 7) == par1;

    }

 

    /**

    * Determines the damage on the item the block drops. Used in cloth and wood.

    */

    public int damageDropped(int par1)

    {

        return MathHelper.clamp_int(par1 & 7, 0, 5);

    }

 

    /**

    * returns a list of blocks with the same ID, but different meta (eg: wood returns 4 blocks)

    */

    @Override

    public void getSubBlocks(Item item, CreativeTabs tabs, List list)

    {

    for(int i = 0; i < saplings.length; i++){

list.add(new ItemStack(item, 1, i));

}

    }

 

    //RegisterIcons

    @SideOnly(Side.CLIENT)

    public void registerBlockIcons(IIconRegister iconRegister)

    {       

    for (int i = 0; i < saplingicon.length; ++i)

        {

        saplingicon = iconRegister.registerIcon("Abrynos:Sapling" + saplings);

        }

    }

 

 

    public boolean func_149851_a(World world, int x, int y, int z, boolean par1)

    {

        return true;

    }

 

    public boolean func_149852_a(World world, Random random, int x, int y, int z)

    {

        return (double)world.rand.nextFloat() < 0.45D;

    }

 

    public void func_149853_b(World world, Random random, int x, int y, int z)

    {

        this.func_149879_c(world, x, y, z, random);

    }

   

    @Override

public int getRenderColor(int p_149741_1_)

    {

        return -2;

    }

   

    @Override

public int colorMultiplier(IBlockAccess iBlockAccess, int x, int y, int z) {

return 0xf6cbec;

    }

}

 

Link to comment
Share on other sites

You need to use this method:

    /**
     * Gets the block's texture. Args: side, meta
     */
    @SideOnly(Side.CLIENT)
    public IIcon getIcon(int p_149691_1_, int p_149691_2_)

 

In BlockSapling the body is this:

    {
        p_149691_2_ &= 7;
        return field_149881_b[MathHelper.clamp_int(p_149691_2_, 0, 5)];
    }

 

So looking at your code the body should look something like this:

    {
        p_149691_2_ &= 7; // Though I don't know exactly what this is for, I would keep it as long as it won't cause a problem.
                          // This is a binary and on binary 0111 if you're curious, should have the same effect as %= 7 if I'm not mistaken.
        return saplingicon[MathHelper.clamp_int(p_149691_2_, 0, 1)]; // 0, 1 in clamp_int is to make sure you don't overIndex your saplingicon[]
                                                                     //which currently has two icons in it (at indexes 0 and 1).
    }

 

And as always, feel free to rename parameter names in overridden code, you don't need to keep the parameter names just the types.

Link to comment
Share on other sites

Guest Abrynos

Sorry but this doesn't work!

 

 

 

 

@diesieben08: du kannst es mir auch auf deutsch erklären wenns nicht zu viele umstände macht

Link to comment
Share on other sites

Hi.

 

Is the problem that your inventory shows the same icon for both different types of tree?

Or that the two trees are different when planted?

 

This line doesn't look right and I'm not sure how it compiles even

 

       for (int i = 0; i < saplingicon.length; ++i)
        {
           saplingicon = iconRegister.registerIcon("Abrynos:Sapling" + saplings);  // ?
        }

 

The icon shown in your inventory depends on the Item for this block, not the Block.  So for example BlockWood has an ItemMultiTexture; BlockWool has an ItemCloth.

 

Look at those vanilla to see how they do it (getIconFromDamage - since the damage value for the item corresponds to the Block metadata);

 

-TGG

 

 

 

 

Link to comment
Share on other sites

Guest Abrynos

It's like you said: My problem is, that the inventory shows the same texture for both saplings!

 

The code you showed up tells minecraft to register 2 icons (do this as long as i is less than the amount of saplings = saplingicon.length) and then it tells minecraft where to find the textures: assets.abrynos.textures.blocks (shortened with "abrynos:") and that there are 2 textures (because of the for loop) the textures names are SaplingPinkcherry.png and SaplingWhitecherry.png defined with "Abrynos:Saplings" + saplings what links to

 public static final String[] saplings = new String[] {"Whitecherry", "Pinkcherry"};

Link to comment
Share on other sites

Guest Abrynos

Ok i figured it out! I had to change 2 methods in my ItemSaplingBlocks.class...

 

For others to learn from this I'll add the code.

 

 

 

public static final String[] saplings = new String[] {"Whitecherry", "Pinkcherry"};
private static final IIcon[] saplingicon = new IIcon[saplings.length];

@SideOnly(Side.CLIENT)
public IIcon getIconFromDamage(int par1){
par1 &= 7;
return saplingicon[MathHelper.clamp_int(par1, 0, 1)];
}

@SideOnly(Side.CLIENT)
public void registerIcons(IIconRegister iconRegister){
for (int i = 0; i < saplingicon.length; ++i){
        	saplingicon[i] = iconRegister.registerIcon("Abrynos:Sapling" + saplings[i]);
        }
}

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I am working on a modpack. When I try to access my server, Minecraft suddenly stops responding for no apparent reason, but I tested the same modpack on my friend's PC and it functions flawlessly there. One thing I have noticed is that the message "[Render thread/WARN] [io.gi.ap.ap.Apoli/]: Received unknown attacker" appears in the log each time my game crashes. My frame rate is high, about 100, and I do not have any mods called Apoli. 9000 MB of the 16000 MB of RAM are allotted to me. Almost everything I could do has been done (updating drivers, removing some mods, lowering the graphic settings, testing singleplayer, etc.) I will leave the moderator list and the latest.log down here.   https://mclo.gs/pYqKP15 (Cannot upload due to file size on pastebin.) Mods: [✔] [1.18.2]-Medieval-Siege-Machines-v1.17 [✔] [1.18.2-forge]-Epic-Knights-8.2 [✔] AchievementOptimizer-1.18.2-1.0.2 [✔] AdvancementPlaques-1.18.2-1.4.5.1 [✔] alexsmobs-1.18.6 [✔] antiqueatlas-7.1.1-forge-mc1.18.2 [✔] Apotheosis-1.18.2-5.8.1 [✔] appleskin-forge-mc1.18.2-2.5.1 [✔] Aquaculture-1.18.2-2.3.12 [✔] aquamirae-5.api10 [✔] archbows-1.0.9-1.18.2 [✔] architectury-4.12.94-forge [✔] armorunder-mc1.18.2-3.0.1 [✔] astikorcarts-1.18.2-1.1.2 [✔] Atlas-Lib-1.18.2-1.1.8 [✔] BetterAdvancements-1.18.2-0.2.0.146 [✔] betteranimalsplus-1.18.2-11.0.10-forge [✔] betterbiomeblend-1.18.2-1.3.5-forge [✔] BetterCompatibilityChecker-1.1.21-build.48+mc1.18.2 [✔] betterfpsdist-1.18.2-1.5 [✔] BetterPingDisplay-1.18.2-1.1 [✔] blockui-1.18.2-0.0.71-ALPHA [✔] BloodAndMadness-Forge1.18.2-v2.1.4 [✔] blueprint-1.18.2-5.5.0 [✔] BOMD-Forge-1.18.2-1.0.6 [✔] Bonfires-1.18.2-1.2.18-2062213 [✔] Bookshelf-Forge-1.18.2-13.3.56 [✔] born_in_chaos_[Forge]1.18.2_1.17 [✔] BrassAmberBattleTowers-1.18.2-2.3.12 [✔] caelus-forge-1.18.1-3.0.0.2 [✔] callablehorses-1.18.2-1.2.2.5 [✔] cameraoverhaul-1.0-1.18.2 [✔] carrotslib-mc1.18.2-4.0 [✔] catalogue-1.6.2-1.18.2 [✔] champions-forge-1.18.2-2.1.6.3 [✔] citadel-1.11.3-1.18.2 [✔] cloth-config-6.5.116-forge [✔] ColdSweat-2.3-b04f [✔] collective-1.18.2-7.7 [✔] configured-2.0.1-1.18.2 [✔] connectedness-1.18.2-2.0.1a [✔] Controlling-forge-1.18.2-9.0+23 [✔] corpse-1.18.2-1.0.2 [✔] CosmeticArmorReworked-1.18.2-v2a [✔] create-1.18.2-0.5.1.f [✔] Croptopia-1.18.2-FORGE-2.1.0 [✔] ctov-2.9.4 [✔] CullLessLeaves-Reforged-1.18.2-1.0.5 [✔] curios-forge-1.18.2-5.0.9.2 [✔] DarkerSouls1.18.2Forgev1.3.1 [✔] Divine Weaponry v1.4 1.18.2 [✔] DoggyTalentsNext-1.18.2-1.18.18 [✔] domum_ornamentum-1.18.2-1.0.77-ALPHA-universal [✔] dragonmagicandrelics-1.18.2-2.1.38 [✔] dragonseeker-1.1.1-1.18.2 [✔] dungeons_enhanced-1.18.2-3.2.1 [✔] DungeonsArise-1.18.2-2.1.52-release [✔] dungeonsweaponry-1.12.2-1.18.2 [✔] EFMCompat 18.2.0 [✔] EnchantmentDescriptions-Forge-1.18.2-10.0.17 [✔] EnigmaticLegacy-2.25.0 [✔] Entity_Collision_FPS_Fix-forge-1.18.2-1.0.0 [✔] entity_model_features_forge_1.18.2-2.0.2 [✔] entity_texture_features_forge_1.18.2-6.0.1 [✔] entityculling-forge-1.6.1-mc1.18.2 [✔] epic_fight_battle_styles-1.0.2 [✔] EpicFight-18.5.24 [✔] falchionmoveset-18.5.0 [✔] FarmersDelight-1.18.2-1.2.3 [✔] Fastload-Reforged-mc1.18.2-3.4.0 [✔] ferritecore-4.2.2-forge [✔] finsandtails-1.18.2-1.1.1 [✔] fish_of_thieves-mc1.18.2-v1.1.1-forge [✔] Forge 1.18.2 Minecraft Middle Ages 0.0.4 [✔] francium-1.18.2-1.0.1 [✔] ftb-essentials-1802.2.2-build.83 [✔] ftb-library-forge-1802.3.11-build.177 [✔] geckolib-forge-1.18-3.0.57 [✔] getittogetherdrops-forge-1.18.2-1.3 [✔] Gobber2-Forge-1.18.2-2.6.37 [✔] goblintraders-1.8.0-1.18.2 [✔] goodall-1.0.2-forge [✔] gpumemleakfix-1.18.2-1.6 [✔] guardvillagers-1.18.2.1.4.4 [✔] healingcampfire-1.18.2-5.2 [✔] hexerei-0.2.2 [✔] horsecombatcontrols-1.18.2-1.0.1 [✔] iceandfire-2.1.13-1.18.2-beta-3 [✔] Iceberg-1.18.2-forge-1.0.49 [✔] ImmediatelyFastReforged-1.18.2-1.1.10 [✔] immersive_melodies-0.1.2+1.18.2-forge [✔] ironchest-1.18.2-13.2.11 [✔] ironfurnaces-1.18.2-3.3.3 [✔] irons_spellbooks-1.18.2-1.1.4.5 [✔] ItemBorders-1.18.1-1.1.5 [✔] ItShallNotTick-1.0.22-build.34 [✔] Jade-1.18.2-forge-5.3.2 [✔] JadeAddons-1.18.2-forge-2.5.0 [✔] jecalculation-forge-1.18.2-4.0.4 [✔] jeed-1.18.2-1.11 [✔] jei-1.18.2-forge-10.2.1.1008 [✔] jepp-1.18-1.0.0 [✔] JustEnoughAdvancements-1.18.2-3.2.0 [✔] justenoughbreeding-forge-1.18.2-1.2.1 [✔] JustEnoughProfessions-1.18.2-1.3.0 [✔] JustEnoughResources-1.18.2-0.14.2.206 [✔] Kobolds-2.9.3-1.18.2-final [✔] kotlinforforge-3.12.0-all [✔] L_Enders Cataclysm-0.51-changed Them -1.18.2 [✔] lazydfu-1.0-1.18+ [✔] leaky-1.18.2-1.3 [✔] LegendaryTooltips-1.18.2-1.3.1 [✔] letmedespawn-1.18.x-1.19.x-forge-1.0.3 [✔] LibX-1.18.2-3.2.19 [✔] lightspeed-1.18.2-1.0.5 [✔] lodestone-1.18.2-1.4.2 [✔] loot_journal-1.1.0-1.18 [✔] lootr-forge-1.18.2-0.3.29.71 [✔] malum-1.18.2-1.5.0.1 [✔] medieval_paintings-1.18.2-7.0 [✔] memoryleakfix-forge-1.17+-1.1.2 [✔] MerchantMarkers-1.18.2-forge-1.3.1 [✔] minecolonies-1.18.2-1.1.148-BETA [✔] MmmMmmMmmMmm-1.18.2-1.5.2 [✔] mna-2.0.0.33 [✔] modernfix-forge-5.18.0+mc1.18.2 [✔] modonomicon-1.18.2-1.33.1 [✔] mowziesmobs-1.6.3 [✔] multi-piston-1.18.2-1.2.15-ALPHA [✔] mythicmounts-18.2-7.2-forge [✔] NefsFarmDecoExpGear+v0.3(1.18.2) [✔] nutritionalbalance-1.18.2-3.2.4 [✔] obscure_api-10 [✔] occultism-1.18.2-1.84.0 [✔] octolib-1.18.2-0.3 [✔] oculus-mc1.18.2-1.6.4 [✔] OfflineSkins-1.18.2-v2 [✔] Orcz_0.83_1.18.2 [AI FIXES] [✔] origins-classes-forge-1.1.6 [✔] origins-forge-1.18.2-1.5.0.2-all [✔] Paraglider-1.18.2-1.6.0.6 [✔] Patchouli-1.18.2-71.1 [✔] physics-mod-pro-v153-forge-1.18.2 [✔] Placebo-1.18.2-6.6.7 [✔] player-animation-lib-forge-1.0.2+1.18 [✔] pluto-mc1.18.2-0.0.6 [✔] polymorph-forge-1.18.2-0.50 [✔] Prism-1.18.2-1.0.1 [✔] projectvibrantjourneys-1.18.2-4.1.1 [✔] puffish_attributes-0.5.0-1.18.2-forge [✔] puffish_skills-0.13.1-1.18.2-forge [✔] realmrpg_imps_and_demons_0.9.0_forge_1.18.2 [✔] recruits-1.18.2-1.11.4.2 [✔] reforgium-1.18.2-1.0.12a [✔] Reldas+Medieval+Armor+1.18.2(2.0) [✔] relics-1.18.2-0.6.2.4 [✔] reputation-1.18.2-1.0.0 [✔] RPG_style_more_weapons_4.9.6R [✔] Rrls-1.18.2-3.1.0-forge [✔] rubidium-0.5.6 [✔] rubidium-extra-0.4.18+mc1.18.2-build.86 [✔] saturn-mc1.18.2-0.1.5 [✔] savage_and_ravage-1.18.2-4.0.1 [✔] seaborgium-mc1.18.2-0.1.3b [✔] SereneSeasons-1.18.2-7.0.0.15 [✔] ShoulderSurfing-Forge-1.18.2-4.2.1 [✔] SimpleLogin-1.18.2-1.0.0 [✔] simplyswords-forge-1.40-1.18.2 [✔] SleepingOverhaul-2.0.2-Forge-1.18.2 [✔] smallships-forge-1.18.2-2.0.0-b1.3.1 [✔] SmartBrainLib-forge-1.18.2-1.9 [✔] smoothboot(reloaded)-mc1.18.2-0.0.4 [✔] sophisticatedbackpacks-1.18.2-3.20.2.1036 [✔] sophisticatedcore-1.18.2-0.6.4.604 [✔] soul_like_armors_reworked_1.18.2_(v138) [✔] SpartanShields-1.18.2-3.0.1 [✔] SpartanWeaponry-1.18.2-3.0.5-all [✔] SpitItOut-1.18.2-1.0.1 [✔] starterkit-1.18.2-5.3 [✔] Structory-1.18.2-1.0.2 [✔] structure_gel-1.18.2-2.4.8 [✔] structurize-1.18.2-1.0.424-ALPHA [✔] swem-forge-1.18.2-1.4.6 [✔] takesapillage-1.0.3-1.18.2 [✔] TerraForged-1.18.2-0.3.1-alpha-2 [✔] TextruesRubidiumOptions-1.0.8-mc1.18.2 [✔] theimpossiblelibrary-1.18.2-0.3.1 [✔] torchmaster-18.2.1 [✔] Totemic-forge-1.18.2-0.12.9.1 [✔] tov-0.1(ALPHA) [✔] towns_and_towers_forge-1.10.0.1+1.18.2 [✔] TravelersTitles-1.18.2-Forge-2.1.1 [✔] unoriginal-datapack [✔] untamedwilds-1.18.2-2.4.3 [✔] upgrade_aquatic-1.18.2-4.0.0 [✔] valhelsia_core-forge-1.18.2-0.4.0 [✔] valhelsia_structures-1.18.2-0.1.1 [✔] Vampirism-1.18.2-1.8.8 [✔] WeaponsOfMiracles-18.1.7.38 [✔] Werewolves-1.18.2-1.0.0.1 [✔] workers-1.18.2-1.7.8 [✔] YouDied-1.18.1-1.0.2.9 [✔] YungsApi-1.18.2-Forge-2.2.9 [✔] YungsBetterMineshafts-1.18.2-Forge-2.2 [✔] YungsBetterStrongholds-1.18.2-Forge-2.1.1 [✔] zoomerzoom-1.4
    • Turn casual moments into unforgettable dates – choose the best casual dating site! Sexy Womans from your town
    • I am trying to make a Modpack for me and my friend and the buddycard expansion mod keeps crashing is there anything I can do, I'll copy and paste the crash message and the attack a link to the crash log below: Buddycards Expainsion (buddycardsexp) encountered an error during the common_setup event phase java.lang.NoSuchMethodError: 'void com.wildcard.buddycards.item.BuddycardBinderItem.<init>(com.wildcard.buddycards.registries.BuddycardsItems$BuddycardRequirement, net.minedcraft.world.item.Item$Properties, com.wildcard.buddycards.core.BuddycardSet)'   https://drive.google.com/file/d/1XlEYKVi2uUyS_UxRKByqCKlfnVswvHbb/view?usp=sharing
    • So, my friend and I are playing modpack on version 1.20.1. Sometimes, when a friend dies, he crashes from the server and cant rejoin anymore, so I have to load backup of the world. After loading the backup, everything goes well, but then sometimes it crashes again after death. Here is lof file: https://pastebin.com/KaZTmvhc The lines where the friend crashes start at line 2471 
    • The Minecraft launcher is now "preparing" the game but is taking forever. Any suggestions?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.