Jump to content

[1.7.10] special crafting recipe does not work, not sure what causes it


Recommended Posts

Posted

i made a new special crafting recipe (it has its own class instead of using the normal way of making crafting recipes) and the first times i tried it, putting the materials in the crafting slots would cause a crash, so it is being called properly, i know that for sure and i have another crafting recipe that works and is called the excact same way, but with different arguments and of course with a different class. after i fixed that i realized that it didnt produce anything at all as if i didnt have the crafting recipe there at all! my code is a mess and i cant figure out what i have done wrong. can anyone help?

public class RecipeWeaponReload implements IRecipe
{
private int ammount;
private int ammoType;

private Item weapon;
private Item ammo1;
private Item ammo2;
private Item ammo3;

private ItemStack itemstack;

public RecipeWeaponReload(Item weapon, Item ammo1, Item ammo2, Item ammo3)
{
	this.weapon = weapon;
	this.ammo1 = ammo1;
	this.ammo2 = ammo2;
	this.ammo3 = ammo3;
}

@Override
public boolean matches(InventoryCrafting crafting, World world)
{
	ItemStack itemstack1 = null;
	ItemStack itemstack2 = null;
	int w = 0;
	int a = 0;
	int a1 = 0;
	int a2 = 0;
	int a3 = 0;
	int at = 0;

	for (int k1 = 0; k1 < crafting.getSizeInventory(); ++k1)
	{
		itemstack1 = crafting.getStackInSlot(k1);

		if (itemstack1 != null)
		{
			if(itemstack1.getItem() == this.ammo1)
			{
				++a;
				++a1;
				at = 1;
			}
			else if(itemstack1.getItem() == this.ammo2)
			{
				++a;
				++a2;
				at = 2;
			}
			else if(itemstack1.getItem() == this.ammo3)
			{
				++a;
				++a3;
				at = 3;
			}
			else if(itemstack1.getItem() == this.weapon)
			{
				++w;
				itemstack2 = itemstack1;
			}
			else
			{
				return false;
			}
		}
	}

	if(itemstack2 != null && ((w == 1 && a1 > 0 && a2 == 0 && a3 == 0) || (w == 1 && a1 == 0 && a2 > 0 && a3 == 0) || (w == 1 && a1 == 0 && a2 == 0 && a3 > 0)))
	{
		String t = null;
		if(itemstack2.getItem() instanceof ItemWeaponPistol)
		{
			if(at == 1)
			{
				t = ((ItemWeaponPistol)itemstack2.getItem()).ammo1Name;
			}
			else if(at == 2)
			{
				t = ((ItemWeaponPistol)itemstack2.getItem()).ammo2Name;
			}
			else if(at == 3)
			{
				t = ((ItemWeaponPistol)itemstack2.getItem()).ammo3Name;
			}
		}
		if(itemstack2.stackTagCompound.getInteger("Ammo")+a > itemstack2.stackTagCompound.getInteger("Capacity") && itemstack2.stackTagCompound.getString("AmmoType") == t)
		{
			return false;
		}
		else
		{
			this.ammount = a;
			this.ammoType = at;
			return true;
		}
	}
	else
	{
		this.itemstack = null;
		return false;
	}
}

@Override
public ItemStack getCraftingResult(InventoryCrafting crafting)
{
	if(this.itemstack != null)
	{
		ItemStack itemstack1 = ItemStack.copyItemStack(this.itemstack);
		if(itemstack1.getItem() instanceof ItemWeaponPistol)
		{
			((ItemWeaponPistol)itemstack1.getItem()).createNbt(itemstack1);
		}
		if(itemstack1.stackTagCompound.getInteger("Ammo")+this.ammount > itemstack1.stackTagCompound.getInteger("Capacity"))
		{
			itemstack1.stackTagCompound.setInteger("Ammo", itemstack1.stackTagCompound.getInteger("Capacity"));
		}
		else
		{
			itemstack1.stackTagCompound.setInteger("Ammo", itemstack1.stackTagCompound.getInteger("Ammo")+this.ammount);
		}
		if(itemstack1.getItem() instanceof ItemWeaponPistol)
		{
			if(this.ammoType == 1)
			{
				itemstack1.stackTagCompound.setString("AmmoType", ((ItemWeaponPistol)itemstack1.getItem()).ammo1Name);
			}
			else if(this.ammoType == 2)
			{
				itemstack1.stackTagCompound.setString("AmmoType", ((ItemWeaponPistol)itemstack1.getItem()).ammo2Name);
			}
			else if(this.ammoType == 3)
			{
				itemstack1.stackTagCompound.setString("AmmoType", ((ItemWeaponPistol)itemstack1.getItem()).ammo3Name);
			}
		}
		return itemstack1;
	}
	else
	{
		return null;
	}
}

@Override
public int getRecipeSize()
{
	return 1;
}

@Override
public ItemStack getRecipeOutput()
{
	if(this.itemstack != null)
	{
		return this.itemstack;
	}
	else
	{
		return new ItemStack(this.weapon);
	}
}
}

http://www.planetminecraft.com/member/sigurd4

I'm making the bioshock mod!

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • If you’ve lost crypto to a scam, don’t let shame or fear keep you silent. There are real experts out there who know how to fight back. Dexdert Net Recovery did the impossible for me, and they can do it for others too. Contact Dexdet Net Recovery For Help Visa Information Below:    
    • Hi everyone, I'm currently developing a Forge 1.21 mod for Minecraft and I want to display a custom HUD overlay for a minigame. My goal: When the game starts, all players should see an item/block icon (from the base game, not a custom texture) plus its name/text in the HUD – similar to how the bossbar overlay works. The HUD should appear centered above the hotbar (or at a similar prominent spot), and update dynamically (icon and name change as the target item changes). What I've tried: I looked at many online tutorials and several GitHub repos (e.g. SeasonHUD, MiniHUD), but most of them use NeoForge or Forge versions <1.20 that provide the IGuiOverlay API (e.g. implements IGuiOverlay, RegisterGuiOverlaysEvent). In Forge 1.21, it seems that neither IGuiOverlay nor RegisterGuiOverlaysEvent exist anymore – at least, I can't import them and they are missing from the docs and code completion. I tried using RenderLevelStageEvent as a workaround but it is probably not intended for custom HUDs. I am not using NeoForge, and switching the project to NeoForge is currently not an option for me. I tried to look at the original minecraft source code to see how elements like hearts, hotbar etc are drawn on the screen but I am too new to Minecraft modding to understand. What I'm looking for: What is the correct way to add a custom HUD element (icon + text) in Forge 1.21, given that the previous overlay API is missing? Is there a new recommended event, callback, or method in Forge 1.21 for custom HUD overlays, or is everyone just using a workaround? Is there a minimal open-source example repo for Forge 1.21 that demonstrates a working HUD overlay without relying on NeoForge or deprecated Forge APIs? My ideal solution: Centered HUD element with an in-game item/block icon (from the base game's assets, e.g. a diamond or any ItemStack / Item) and its name as text, with a transparent background rectangle. It should be visible to the players when the mini game is running. Easy to update the item (e.g. static variable or other method), so it can change dynamically during the game. Any help, code snippets, or up-to-date references would be really appreciated! If this is simply not possible right now in Forge 1.21, it would also help to know that for sure. Thank you very much in advance!
    • The simple answer is there is not an easy way. You would need to know how to program in Java, as well as at least some familiarity with how Forge works so you could port the differences. You would also need the sourcecode for the original mod, and permission from the author to modify it, if they did not use some sort of open source license. So it's not impossible, but it would take some effort, but doing so would open up a whole new world of possibilities for you!
    • Does it still crash if you remove holdmyitems? Looks like that mod doesn't work on a server as far as I can tell from the error.  
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.