[1.7.10][SOLVED]detecting Item right click crash

thewaterwell · August 3, 2014

hello,

I want to operate a piece of code when a item is right clicked.

I get a crash from the following code:

@SubscribeEvent
public void ExpCatalyst (PlayerInteractEvent event)
{
//crash here
if(event.entityPlayer.getItemInUse().getItem().getUnlocalizedName().contains(ModItems.expCatalyst.getUnlocalizedName()) && ModItems.expCatalyst.getUnlocalizedName().contains(event.entityPlayer.getItemInUse().getItem().getUnlocalizedName()) )

the crash report is here

---- Minecraft Crash Report ----

// You should try our sister game, Minceraft!

Time: 16:05 03/08/14

Description: Unexpected error

java.lang.NullPointerException: Unexpected error

at com.thewaterwell.letsmodreboot.handler.EventHandler.ExpCatalyst(EventHandler.java:28)

at cpw.mods.fml.common.eventhandler.ASMEventHandler_6_EventHandler_ExpCatalyst_PlayerInteractEvent.invoke(.dynamic)

at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:51)

at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:122)

at net.minecraftforge.event.ForgeEventFactory.onPlayerInteract(ForgeEventFactory.java:67)

at net.minecraft.client.Minecraft.func_147121_ag(Minecraft.java:1527)

at net.minecraft.client.Minecraft.runTick(Minecraft.java:2043)

at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1038)

at net.minecraft.client.Minecraft.run(Minecraft.java:961)

at net.minecraft.client.main.Main.main(Main.java:164)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

at java.lang.reflect.Method.invoke(Unknown Source)

at net.minecraft.launchwrapper.Launch.launch(Launch.java:134)

at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

at java.lang.reflect.Method.invoke(Unknown Source)

at GradleStart.bounce(GradleStart.java:108)

at GradleStart.startClient(GradleStart.java:101)

at GradleStart.main(GradleStart.java:56)

A detailed walkthrough of the error, its code path and all known details is as follows:

---------------------------------------------------------------------------------------

-- Head --

Stacktrace:

at com.thewaterwell.letsmodreboot.handler.EventHandler.ExpCatalyst(EventHandler.java:28)

at cpw.mods.fml.common.eventhandler.ASMEventHandler_6_EventHandler_ExpCatalyst_PlayerInteractEvent.invoke(.dynamic)

at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:51)

at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:122)

at net.minecraftforge.event.ForgeEventFactory.onPlayerInteract(ForgeEventFactory.java:67)

at net.minecraft.client.Minecraft.func_147121_ag(Minecraft.java:1527)

-- Affected level --

Details:

Level name: MpServer

All players: 1 total; [EntityClientPlayerMP['ForgeDevName'/105, l='MpServer', x=-703.45, y=5.62, z=-527.30]]

Chunk stats: MultiplayerChunkCache: 625, 625

Level seed: 0

Level generator: ID 01 - flat, ver 0. Features enabled: false

Level generator options:

Level spawn location: World: (-704,4,-540), Chunk: (at 0,0,4 in -44,-34; contains blocks -704,0,-544 to -689,255,-529), Region: (-2,-2; contains chunks -64,-64 to -33,-33, blocks -1024,0,-1024 to -513,255,-513)

Level time: 117721 game time, 7843 day time

Level dimension: 0

Level storage version: 0x00000 - Unknown?

Level weather: Rain time: 0 (now: false), thunder time: 0 (now: false)

Level game mode: Game mode: survival (ID 0). Hardcore: false. Cheats: false

Forced entities: 55 total; [EntityCow['Cow'/30, l='MpServer', x=-768.28, y=4.00, z=-553.28], EntityCow['Cow'/31, l='MpServer', x=-770.69, y=4.00, z=-545.25], EntityCow['Cow'/32, l='MpServer', x=-774.06, y=4.00, z=-517.03], EntityChicken['Chicken'/33, l='MpServer', x=-766.47, y=4.00, z=-561.47], EntityCow['Cow'/34, l='MpServer', x=-762.28, y=4.00, z=-497.31], EntityChicken['Chicken'/35, l='MpServer', x=-765.38, y=4.00, z=-482.44], EntityChicken['Chicken'/36, l='MpServer', x=-759.59, y=4.00, z=-487.44], EntityChicken['Chicken'/37, l='MpServer', x=-764.56, y=4.00, z=-467.44], EntityCow['Cow'/38, l='MpServer', x=-748.97, y=4.00, z=-548.94], EntityChicken['Chicken'/39, l='MpServer', x=-739.35, y=4.00, z=-540.41], EntitySheep['Sheep'/40, l='MpServer', x=-738.97, y=4.00, z=-496.06], EntitySheep['Sheep'/41, l='MpServer', x=-737.25, y=4.00, z=-491.63], EntityChicken['Chicken'/42, l='MpServer', x=-737.53, y=4.00, z=-484.53], EntitySheep['Sheep'/43, l='MpServer', x=-735.94, y=4.00, z=-479.97], EntityCow['Cow'/44, l='MpServer', x=-744.34, y=4.00, z=-452.22], EntitySheep['Sheep'/45, l='MpServer', x=-735.13, y=4.00, z=-568.81], EntitySheep['Sheep'/46, l='MpServer', x=-726.69, y=4.00, z=-483.84], EntityCow['Cow'/47, l='MpServer', x=-730.19, y=4.00, z=-470.16], EntitySheep['Sheep'/48, l='MpServer', x=-719.22, y=4.00, z=-541.75], EntitySheep['Sheep'/49, l='MpServer', x=-717.09, y=4.00, z=-490.94], EntityChicken['Chicken'/50, l='MpServer', x=-710.44, y=4.00, z=-465.38], EntityChicken['Chicken'/51, l='MpServer', x=-712.44, y=4.00, z=-454.41], EntitySheep['Sheep'/53, l='MpServer', x=-689.25, y=4.00, z=-525.34], EntityClientPlayerMP['ForgeDevName'/105, l='MpServer', x=-703.45, y=5.62, z=-527.30], EntityCow['Cow'/54, l='MpServer', x=-684.97, y=4.00, z=-500.91], EntityChicken['Chicken'/55, l='MpServer', x=-700.47, y=4.00, z=-485.53], EntitySheep['Sheep'/56, l='MpServer', x=-689.22, y=4.00, z=-491.84], EntityChicken['Chicken'/60, l='MpServer', x=-672.66, y=4.00, z=-584.44], EntityChicken['Chicken'/61, l='MpServer', x=-687.53, y=4.00, z=-519.44], EntityCow['Cow'/62, l='MpServer', x=-676.03, y=4.00, z=-494.09], EntityCow['Cow'/63, l='MpServer', x=-679.69, y=4.00, z=-472.25], EntitySheep['Sheep'/68, l='MpServer', x=-655.63, y=4.00, z=-602.25], EntitySheep['Sheep'/69, l='MpServer', x=-662.81, y=4.00, z=-605.63], EntityCow['Cow'/70, l='MpServer', x=-661.84, y=4.00, z=-538.84], EntitySheep['Sheep'/71, l='MpServer', x=-662.69, y=4.00, z=-528.22], EntityCow['Cow'/72, l='MpServer', x=-671.25, y=4.00, z=-484.69], EntityPig['Pig'/73, l='MpServer', x=-658.78, y=4.00, z=-481.84], EntityChicken['Chicken'/74, l='MpServer', x=-664.53, y=4.00, z=-456.44], EntityChicken['Chicken'/82, l='MpServer', x=-649.44, y=4.00, z=-592.56], EntityChicken['Chicken'/83, l='MpServer', x=-651.38, y=4.00, z=-578.56], EntityChicken['Chicken'/84, l='MpServer', x=-653.38, y=4.00, z=-571.63], EntityChicken['Chicken'/85, l='MpServer', x=-642.47, y=4.00, z=-567.56], EntityPig['Pig'/86, l='MpServer', x=-652.56, y=4.00, z=-567.22], EntityPig['Pig'/87, l='MpServer', x=-645.13, y=4.00, z=-534.56], EntityCow['Cow'/88, l='MpServer', x=-650.91, y=4.00, z=-529.84], EntityPig['Pig'/89, l='MpServer', x=-646.19, y=4.00, z=-517.56], EntitySheep['Sheep'/90, l='MpServer', x=-654.13, y=4.00, z=-489.09], EntityCow['Cow'/91, l='MpServer', x=-649.25, y=4.00, z=-491.78], EntitySheep['Sheep'/92, l='MpServer', x=-642.38, y=4.00, z=-494.19], EntityCow['Cow'/93, l='MpServer', x=-660.06, y=4.00, z=-466.09], EntityChicken['Chicken'/94, l='MpServer', x=-658.34, y=4.00, z=-459.56], EntityChicken['Chicken'/97, l='MpServer', x=-622.53, y=4.00, z=-599.53], EntityPig['Pig'/98, l='MpServer', x=-632.78, y=4.00, z=-563.09], EntityCow['Cow'/99, l='MpServer', x=-635.22, y=4.00, z=-489.84], EntityChicken['Chicken'/100, l='MpServer', x=-638.56, y=4.00, z=-459.59]]

Retry entities: 0 total; []

Server brand: fml,forge

Server type: Integrated singleplayer server

Stacktrace:

at net.minecraft.client.multiplayer.WorldClient.addWorldInfoToCrashReport(WorldClient.java:417)

at net.minecraft.client.Minecraft.addGraphicsAndWorldToCrashReport(Minecraft.java:2567)

at net.minecraft.client.Minecraft.run(Minecraft.java:990)

at net.minecraft.client.main.Main.main(Main.java:164)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

at java.lang.reflect.Method.invoke(Unknown Source)

at net.minecraft.launchwrapper.Launch.launch(Launch.java:134)

at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

at java.lang.reflect.Method.invoke(Unknown Source)

at GradleStart.bounce(GradleStart.java:108)

at GradleStart.startClient(GradleStart.java:101)

at GradleStart.main(GradleStart.java:56)

-- System Details --

Details:

Minecraft Version: 1.7.10

Operating System: Windows Vista (amd64) version 6.0

Java Version: 1.8.0_05, Oracle Corporation

Java VM Version: Java HotSpot 64-Bit Server VM (mixed mode), Oracle Corporation

Memory: 912597232 bytes (870 MB) / 1056309248 bytes (1007 MB) up to 1056309248 bytes (1007 MB)

JVM Flags: 3 total; -Xincgc -Xmx1024M -Xms1024M

AABB Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used

IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0

FML: MCP v9.05 FML v7.10.25.1188 Minecraft Forge 10.13.0.1188 4 mods loaded, 4 mods active

mcp{9.05} [Minecraft Coder Pack] (minecraft.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available

FML{7.10.25.1188} [Forge Mod Loader] (forgeSrc-1.7.10-10.13.0.1188.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available

Forge{10.13.0.1188} [Minecraft Forge] (forgeSrc-1.7.10-10.13.0.1188.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available

LetsModReboot{1.7.10-1.4} [learning from pahimar] (bin) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available

Launched Version: 1.7.10

LWJGL: 2.9.1

OpenGL: GeForce 9800 GT/PCIe/SSE2 GL version 3.3.0, NVIDIA Corporation

GL Caps: Using GL 1.3 multitexturing.

Using framebuffer objects because OpenGL 3.0 is supported and separate blending is supported.

Anisotropic filtering is supported and maximum anisotropy is 16.

Shaders are available because OpenGL 2.1 is supported.

Is Modded: Definitely; Client brand changed to 'fml,forge'

Type: Client (map_client.txt)

Resource Packs: []

Current Language: English (US)

Profiler Position: N/A (disabled)

Vec3 Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used

Anisotropic Filtering: Off (1)

From what I tried, I saw the crash was caused because "getItemInUse()" returned null, but I right clicked the Item.

If anyone could help, I would highly appreciate.

Jacky2611 · August 3, 2014

Please check if the item is null before you execute that code.

I believe that it returns null if your hand is empty.

thewaterwell · August 3, 2014

my hand was not empty, I was holding the Item. I tried holding bottles of enchanting from vanilla and empty hand, all crashed.

Jacky2611 · August 3, 2014

Wait, this is a custom Item, right?

Why don't you check if its right clicked inside the Item? like this:



public class ItemDust extends Item {

public ItemDust(int maxStackSize, String name) {
        setUnlocalizedName(name);
        setTextureName(DimensionShift.MODID + ":" + name);

}

@Override
    public boolean onItemUse(ItemStack itemstack, EntityPlayer player, World world, int x, int y, int z, int side, float px, float py, float pz){
	System.out.println("ON ITEM USE");

        return true;
    }

}

thewaterwell · August 3, 2014

hi,

I tried it, but in the code I try to create and set NBT to the stack but it crashes with the following:

---- Minecraft Crash Report ----

// But it works on my machine.

Time: 17:27 03/08/14

Description: Unexpected error

java.lang.NullPointerException: Unexpected error

at com.thewaterwell.letsmodreboot.utility.NBTHelper.initNBTTagCompound(NBTHelper.java:29)

at com.thewaterwell.letsmodreboot.utility.NBTHelper.getInt(NBTHelper.java:125)

at com.thewaterwell.letsmodreboot.handler.EventHandler.ExpCatalyst(EventHandler.java:42)

at cpw.mods.fml.common.eventhandler.ASMEventHandler_6_EventHandler_ExpCatalyst_PlayerInteractEvent.invoke(.dynamic)

at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:51)

at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:122)

at net.minecraftforge.event.ForgeEventFactory.onPlayerInteract(ForgeEventFactory.java:67)

at net.minecraft.client.Minecraft.func_147121_ag(Minecraft.java:1555)