[1.7.10][Forge-new] Block/Item Override Troubles

[zombiepig333]

Hello, folks.  I saw that the 'new' forge branch had support for overriding minecraft blocks and items, so I wanted to try and do something with it.  Sadly, being the n00b I am, I cannot get it to work for the life of me.

 

This is what I have been doing as a test.  First, I made a class to override BlockClay like so...

 

public class TweakClay extends BlockClay {
    public TweakClay() {
        super();
    }

    @Override
    public Item getItemDropped(int p_149650_1_, Random p_149650_2_, int p_149650_3_)
    {
        return Item.getItemFromBlock(Blocks.brick_block);
    }
}

 

...then I registered it using the addSubsitutionAlias method provided by forge during the preInit phase...

 

try {
            GameRegistry.addSubstitutionAlias("clay", GameRegistry.Type.BLOCK, new TweakClay());
        } catch (ExistingSubstitutionException e) {
            e.printStackTrace();
        }

 

...then loaded the game.  No crashes, but nothing happens- clay still drops clay balls.

 

If somebody could tell me where I have derped up, it would be appreciated greatly .

 

-zombiepig333

[Eternaldoom]

I haven't tried the new branch, but for changing clay drops you should use the HarvestDropsEvent

[zombiepig333]

Right, I know, I was just using this as a test of the block override system for some more advanced stuff I want to do that does require such an override.  The fact that it isn't doing anything for this implies (to me) that I am doing something wrong.

[ShetiPhian]

When replacing a block you must replace the item also.

 

and currently registerBlockIcons isn't called on replacement blocks, so you need to call it from another blocks registerBlockIcons for now.

[Reika]

I have a similar problem, trying to add ItemBlocks for vanilla blocks which do not have them (and thus would crash if you tried to render them in the inventory as an item). Manually creating the ItemBlocks is trivial, as is adding them to the game, but the problem is that the FML namespace registry automatically and forcibly prepends your mod name on the item, resulting in a Frankenstein mess of "DragonAPI:minecraft:unlit_redstone_torch" which causes FML to freak out:

[15:50:03] [Client thread/WARN] [FML]: ****************************************

[15:50:03] [Client thread/WARN] [FML]: * Block <-> ItemBlock name mismatch, block name minecraft:unlit_redstone_torch, item name DragonAPI:minecraft:unlit_redstone_torch

[15:50:03] [Client thread/WARN] [FML]: *  at cpw.mods.fml.common.registry.GameData.verifyItemBlockName(GameData.java:927)

[15:50:03] [Client thread/WARN] [FML]: *  at cpw.mods.fml.common.registry.GameData.registerItem(GameData.java:795)

[15:50:03] [Client thread/WARN] [FML]: *  at cpw.mods.fml.common.registry.GameData.register(GameData.java:744)

[15:50:03] [Client thread/WARN] [FML]: *  at cpw.mods.fml.common.registry.FMLControlledNamespacedRegistry.addObject(FMLControlledNamespacedRegistry.java:117)

[15:50:03] [Client thread/WARN] [FML]: *  at Reika.DragonAPI.DragonAPIInit.registerTechnicalBlocks(DragonAPIInit.java:176)

[15:50:03] [Client thread/WARN] [FML]: *  at Reika.DragonAPI.DragonAPIInit.preload(DragonAPIInit.java:140)...

[15:50:03] [Client thread/WARN] [FML]: ****************************************

 

Granted, this could be avoided with careful use of reflection, but I strongly suspect that would be a very strongly criticized decision - maybe even deliberately broken by Forge - and one I would like to avoid.

[ShetiPhian]

Reflection will not be possible in the future, cpw will be locking down the registry once he knows the replacement system is working.

 

From playing with the system,

- You don not register replacement blocks or items outside of the addSubstitutionAlias  (this will log an error otherwise)

- The first parameter is the block/item id (found in Blocks and Items) with the prefix 'minecraft:'  (if your not replacing a mod added one that is)

- When replacing a block you must replace the item also (an error is caused otherwise and the worlds backup file is used)

- The replacement class needs to extend original (at least this appears to be the case)

[zombiepig333]

@ShetiPhian- yep, just as you said, it all works for Items if you do that.  Blocks, though, do require that ItemBlock override, and that is being a huge pain.  I have been busy with classes this week, but if I get a way working(well, if nobody else has already ) I will say something.  Otherwise, well, the system kinda works.  Yay for new forge!

 

[Reika]

Reflection will not be possible in the future, cpw will be locking down the registry once he knows the replacement system is working.

 

From playing with the system,

- You don not register replacement blocks or items outside of the addSubstitutionAlias  (this will log an error otherwise)

- The first parameter is the block/item id (found in Blocks and Items) with the prefix 'minecraft:'  (if your not replacing a mod added one that is)

- When replacing a block you must replace the item also (an error is caused otherwise and the worlds backup file is used)

- The replacement class needs to extend original (at least this appears to be the case)

 

As of Forge 1208, addSubstitutionAlias is gone and the only public method that accesses the alias system for mod use is deprecated with the javadoc "DANGEROUS! EVIL! DO NOT USE!". GameRegistry also has an addAlias function, but it is a no-op.

[ShetiPhian]

Its not in the pre-1210 branches, you need to use the 'new' branch.

 

http://files.minecraftforge.net/minecraftforge/new

[ganymedes01]

Block mySand = new MySand();
GameRegistry.addSubstitutionAlias("minecraft:sand", GameRegistry.Type.BLOCK, mySand);
GameRegistry.addSubstitutionAlias("minecraft:sand", GameRegistry.Type.ITEM, new ItemMultiTexture(mySand, mySand, new String[] { "default", "red", "my" }).setUnlocalizedName("sand"));

 

The above works for me

[hilburn]

Block mySand = new MySand();
GameRegistry.addSubstitutionAlias("minecraft:sand", GameRegistry.Type.BLOCK, mySand);
GameRegistry.addSubstitutionAlias("minecraft:sand", GameRegistry.Type.ITEM, new ItemMultiTexture(mySand, mySand, new String[] { "default", "red", "my" }).setUnlocalizedName("sand"));

 

The above works for me

 

I've tried this method (1210-new) and it does work, however it does not seem to update crafting recipes, in my case for BlockChest my alternative chest is not usable in a hopper recipe and the vanilla chest recipe produces an invalid recipe. Is this an issue that can be resolved to updating to latest or intended behaviour?

[ShetiPhian]

Found another issue.

Clients can't connect to a server after replacements have been made.

 

SinglePlayer works fine, and the Server launches but clients can't connect.

 

 

Short Message:

java.lang.IllegalStateException: Can't map item minecraft:tallgrass to id 31 (seen at: 280), already occupied by null, blocked false, ItemBlock false

 

and uncut:

 

 

HandshakeMessageHandler exception
java.lang.IllegalStateException: Can't map item minecraft:tallgrass to id 31 (seen at: 280), already occupied by null, blocked false, ItemBlock false
at cpw.mods.fml.common.registry.GameData.injectWorldIDMap(GameData.java:525) ~[GameData.class:?]
at cpw.mods.fml.common.registry.GameData.injectWorldIDMap(GameData.java:430) ~[GameData.class:?]
at cpw.mods.fml.common.network.handshake.FMLHandshakeClientState$4.accept(FMLHandshakeClientState.java:88) ~[FMLHandshakeClientState$4.class:?]
at cpw.mods.fml.common.network.handshake.FMLHandshakeClientState$4.accept(FMLHandshakeClientState.java:82) ~[FMLHandshakeClientState$4.class:?]
at cpw.mods.fml.common.network.handshake.HandshakeMessageHandler.channelRead0(HandshakeMessageHandler.java:27) ~[HandshakeMessageHandler.class:?]
at cpw.mods.fml.common.network.handshake.HandshakeMessageHandler.channelRead0(HandshakeMessageHandler.java:9) ~[HandshakeMessageHandler.class:?]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:98) ~[simpleChannelInboundHandler.class:?]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [DefaultChannelHandlerContext.class:?]
at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) [MessageToMessageDecoder.class:?]
at io.netty.handler.codec.MessageToMessageCodec.channelRead(MessageToMessageCodec.java:111) [MessageToMessageCodec.class:?]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [DefaultChannelHandlerContext.class:?]
at cpw.mods.fml.common.network.handshake.ChannelRegistrationHandler.channelRead0(ChannelRegistrationHandler.java:32) [ChannelRegistrationHandler.class:?]
at cpw.mods.fml.common.network.handshake.ChannelRegistrationHandler.channelRead0(ChannelRegistrationHandler.java:15) [ChannelRegistrationHandler.class:?]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:98) [simpleChannelInboundHandler.class:?]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:785) [DefaultChannelPipeline.class:?]
at io.netty.channel.embedded.EmbeddedChannel.writeInbound(EmbeddedChannel.java:169) [EmbeddedChannel.class:?]
at cpw.mods.fml.common.network.handshake.NetworkDispatcher.handleClientSideCustomPacket(NetworkDispatcher.java:257) [NetworkDispatcher.class:?]
at cpw.mods.fml.common.network.handshake.NetworkDispatcher.channelRead0(NetworkDispatcher.java:185) [NetworkDispatcher.class:?]
at cpw.mods.fml.common.network.handshake.NetworkDispatcher.channelRead0(NetworkDispatcher.java:43) [NetworkDispatcher.class:?]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:98) [simpleChannelInboundHandler.class:?]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [DefaultChannelHandlerContext.class:?]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:173) [byteToMessageDecoder.class:?]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [DefaultChannelHandlerContext.class:?]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:173) [byteToMessageDecoder.class:?]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [DefaultChannelHandlerContext.class:?]
at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) [MessageToMessageDecoder.class:?]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [DefaultChannelHandlerContext.class:?]
at io.netty.handler.timeout.ReadTimeoutHandler.channelRead(ReadTimeoutHandler.java:149) [ReadTimeoutHandler.class:?]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:785) [DefaultChannelPipeline.class:?]
at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:100) [AbstractNioByteChannel$NioByteUnsafe.class:?]
at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:480) [NioEventLoop.class:?]
at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:447) [NioEventLoop.class:?]
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:341) [NioEventLoop.class:?]
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:101) [singleThreadEventExecutor$2.class:?]
at java.lang.Thread.run(Unknown Source) [?:1.7.0_67]
[01:43:22] [Netty Client IO #3/ERROR] [FML/]: NetworkDispatcher exception
java.lang.IllegalStateException: Can't map item minecraft:tallgrass to id 31 (seen at: 280), already occupied by null, blocked false, ItemBlock false
at cpw.mods.fml.common.registry.GameData.injectWorldIDMap(GameData.java:525) ~[GameData.class:?]
at cpw.mods.fml.common.registry.GameData.injectWorldIDMap(GameData.java:430) ~[GameData.class:?]
at cpw.mods.fml.common.network.handshake.FMLHandshakeClientState$4.accept(FMLHandshakeClientState.java:88) ~[FMLHandshakeClientState$4.class:?]
at cpw.mods.fml.common.network.handshake.FMLHandshakeClientState$4.accept(FMLHandshakeClientState.java:82) ~[FMLHandshakeClientState$4.class:?]
at cpw.mods.fml.common.network.handshake.HandshakeMessageHandler.channelRead0(HandshakeMessageHandler.java:27) ~[HandshakeMessageHandler.class:?]
at cpw.mods.fml.common.network.handshake.HandshakeMessageHandler.channelRead0(HandshakeMessageHandler.java:9) ~[HandshakeMessageHandler.class:?]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:98) ~[simpleChannelInboundHandler.class:?]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) ~[DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) ~[DefaultChannelHandlerContext.class:?]
at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) ~[MessageToMessageDecoder.class:?]
at io.netty.handler.codec.MessageToMessageCodec.channelRead(MessageToMessageCodec.java:111) ~[MessageToMessageCodec.class:?]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) ~[DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) ~[DefaultChannelHandlerContext.class:?]
at cpw.mods.fml.common.network.handshake.ChannelRegistrationHandler.channelRead0(ChannelRegistrationHandler.java:32) ~[ChannelRegistrationHandler.class:?]
at cpw.mods.fml.common.network.handshake.ChannelRegistrationHandler.channelRead0(ChannelRegistrationHandler.java:15) ~[ChannelRegistrationHandler.class:?]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:98) ~[simpleChannelInboundHandler.class:?]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:785) ~[DefaultChannelPipeline.class:?]
at io.netty.channel.embedded.EmbeddedChannel.writeInbound(EmbeddedChannel.java:169) ~[EmbeddedChannel.class:?]
at cpw.mods.fml.common.network.handshake.NetworkDispatcher.handleClientSideCustomPacket(NetworkDispatcher.java:257) ~[NetworkDispatcher.class:?]
at cpw.mods.fml.common.network.handshake.NetworkDispatcher.channelRead0(NetworkDispatcher.java:185) ~[NetworkDispatcher.class:?]
at cpw.mods.fml.common.network.handshake.NetworkDispatcher.channelRead0(NetworkDispatcher.java:43) ~[NetworkDispatcher.class:?]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:98) ~[simpleChannelInboundHandler.class:?]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [DefaultChannelHandlerContext.class:?]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:173) [byteToMessageDecoder.class:?]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [DefaultChannelHandlerContext.class:?]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:173) [byteToMessageDecoder.class:?]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [DefaultChannelHandlerContext.class:?]
at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) [MessageToMessageDecoder.class:?]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [DefaultChannelHandlerContext.class:?]
at io.netty.handler.timeout.ReadTimeoutHandler.channelRead(ReadTimeoutHandler.java:149) [ReadTimeoutHandler.class:?]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [DefaultChannelHandlerContext.class:?]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:785) [DefaultChannelPipeline.class:?]
at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:100) [AbstractNioByteChannel$NioByteUnsafe.class:?]
at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:480) [NioEventLoop.class:?]
at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:447) [NioEventLoop.class:?]
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:341) [NioEventLoop.class:?]
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:101) [singleThreadEventExecutor$2.class:?]
at java.lang.Thread.run(Unknown Source) [?:1.7.0_67]

 

 

 

And for those wanting it, my replacement code;

Values.blockTallGrass = new AltBlockTallGrass();
ItemColored itemTallGrass = (new ItemColored(Values.blockTallGrass, true)).func_150943_a(new String[] { "shrub", "grass", "fern" });
try {
GameRegistry.addSubstitutionAlias("minecraft:tallgrass", GameRegistry.Type.BLOCK, Values.blockTallGrass);
GameRegistry.addSubstitutionAlias("minecraft:tallgrass", GameRegistry.Type.ITEM, itemTallGrass);
} catch (Exception e) {
Values.logCore.error("Could not replace tall grass");
}