Posted November 1, 201410 yr I want my block to emit light when it's metadata is a certain value. I use this code to try to archive that: @Override public int getLightValue(IBlockAccess world, int x, int y, int z) { //this.maxMetaData is a value in my block's class, in this case 2. if (world.getBlockMetadata(x, y, z) >= this.maxMetaData) { return 16; } return 0; } This code only sets the light value of the block itself, the block doesn't actually emit light. How can I solve that?
November 1, 201410 yr Author My block is a crop, so the metadata is the growthstage. (Me being dumb) I use this class to create different crops, this is the constructor. public CropMC(String name, int stages) { this(); this.name = name; this.stages = stages; this.maxMetaData = stages - 1; this.setBlockName(Reference.NAME_PREFIX + name); } public CropMC() { //Stolen from BlockCrops this.setTickRandomly(true); float f = 0.5F; this.setBlockBounds(0.5F - f, 0.0F, 0.5F - f, 0.5F + f, 0.25F, 0.5F + f); this.setCreativeTab(null); this.setHardness(0.0F); this.setStepSound(soundTypeGrass); this.disableStats(); } Shouldn't matter in this case, as the if is working. The crop looks light, but doesn't emit light. Screenshot to illustrate:
November 1, 201410 yr Author Two reasons: 1) To separate the code I wrote and the code I stole from the BlockCrops class. 2) If I (hypoteticcaly) ever want to use this class but set all the fields manually myself for whatever reason. But I don't think that matters for my problem about the light level. Maybe I'm using the wrong function?
November 1, 201410 yr Author I currently have no access to my computer, I'm on mobile. I'll post the search data tomorrow. But how can something with that field be the problem? Do you think this only works on the client, so the server can't process the light?
November 2, 201410 yr Author This is the usage search: As you can see, the value is set once, in the constructor. Then it is mostly used in comparisons. This is the full code of my crop class: package com.flaghacker.mysteriumcraft.blocks; import com.flaghacker.mysteriumcraft.reference.Reference; import cpw.mods.fml.relauncher.Side; import cpw.mods.fml.relauncher.SideOnly; import net.minecraft.block.Block; import net.minecraft.block.BlockBush; import net.minecraft.block.IGrowable; import net.minecraft.client.renderer.texture.IIconRegister; import net.minecraft.init.Blocks; import net.minecraft.item.Item; import net.minecraft.item.ItemStack; import net.minecraft.util.IIcon; import net.minecraft.world.IBlockAccess; import net.minecraft.world.World; import net.minecraftforge.common.EnumPlantType; import java.util.ArrayList; import java.util.Random; public class CropMC extends BlockBush implements IGrowable { private Block soil = Blocks.farmland; private String name; private int stages; private int maxMetaData; private Item seedItem; private Item cropItem; //onRandomTick: random.nextInt(10) <= growthAmplifier -> grow(1) private int growthAmplifier = 3; //onBonemeal: random.nextInt(10) <= bonemealSuccessAmplifier -> grow(random.nextInt(bonemealStageAmplifier)) private int bonemealSuccessAmplifier = 10; private int bonemealStageAmplifier = 3; //onBreakAndFullyGrown: drop(seed, random.nextInt(seedDropAmplifier - 1) + 1) // drop(crop, random.nextInt(cropDropAmplifier - 1) + 1) private int seedDropAmplifier = 3; private int cropDropAmplifier = 3; private IIcon[] iIcons; //Constructors public CropMC(String name, int stages) { this(); this.name = name; this.stages = stages; this.maxMetaData = stages - 1; this.setBlockName(Reference.NAME_PREFIX + name); } public CropMC() { //Stolen from BlockCrops this.setTickRandomly(true); float f = 0.5F; this.setBlockBounds(0.5F - f, 0.0F, 0.5F - f, 0.5F + f, 0.25F, 0.5F + f); this.setCreativeTab(null); this.setHardness(0.0F); this.setStepSound(soundTypeGrass); this.disableStats(); } //Setters public void setSoil(Block soil) { this.soil = soil; } public void setGrowthAmplifier(int growthAmplifier) { this.growthAmplifier = growthAmplifier; } public void setBonemealSuccessAmplifier(int bonemealSuccessAmplifier) { this.bonemealSuccessAmplifier = bonemealSuccessAmplifier; } public void setBonemealStageAmplifier(int bonemealStageAmplifier) { this.bonemealStageAmplifier = bonemealStageAmplifier; } public void setCropDropAmplifier(int cropDropAmplifier) { this.cropDropAmplifier = cropDropAmplifier; } public void setSeedDropAmplifier(int seedDropAmplifier) { this.seedDropAmplifier = seedDropAmplifier; } public void setCropItem(Item cropItem) { this.cropItem = cropItem; } public void setSeedItem(Item seedItem) { this.seedItem = seedItem; } //General @Override public ArrayList<ItemStack> getDrops(World world, int x, int y, int z, int metadata, int fortune) { ArrayList<ItemStack> drops = new ArrayList<ItemStack>(); if (metadata >= this.maxMetaData) { drops.add(new ItemStack(this.seedItem, world.rand.nextInt(this.seedDropAmplifier - 1) + 1)); drops.add(new ItemStack(this.cropItem, world.rand.nextInt(this.cropDropAmplifier - 1) + 1)); } else { drops.add(new ItemStack(this.seedItem)); } return drops; } @Override public boolean canPlaceBlockOn(Block block) { return block == this.soil; } @Override public EnumPlantType getPlantType(IBlockAccess world, int x, int y, int z) { return EnumPlantType.Crop; } //Rendering @SideOnly(Side.CLIENT) @Override public IIcon getIcon(int side, int metaData) { try { return iIcons[metaData]; } catch (Exception e) { return null; } } @SideOnly(Side.CLIENT) public void registerBlockIcons(IIconRegister iIconRegister) { this.iIcons = new IIcon[this.stages]; for(int i = 0; i <= maxMetaData; i++) { this.iIcons[i] = iIconRegister.registerIcon(Reference.RESOURCE_PREFIX + this.name + "_stage_" + i); } } @SideOnly(Side.CLIENT) @Override public int getRenderType() { return 6; } @Override public int getLightValue(IBlockAccess world, int x, int y, int z) { if (world.getBlockMetadata(x, y, z) >= this.maxMetaData) { return 16; } return 0; } //Grow functions private void growPlant(World world, Random random, int x, int y, int z, boolean bonemeal) { int addMeta; int oldMeta = world.getBlockMetadata(x, y, z); int newMeta; if (bonemeal) { addMeta = random.nextInt(this.bonemealStageAmplifier); } else { addMeta = 1; } newMeta = oldMeta + addMeta; if (newMeta > this.maxMetaData) { newMeta = this.maxMetaData; } world.setBlockMetadataWithNotify(x, y, z, newMeta, 2); } @Override public void updateTick(World world, int x, int y, int z, Random random) { if (random.nextInt(10) <= this.growthAmplifier) { growPlant(world, random, x, y, z, false); } } //Bonemeal functions, implementing IGrowable //canBonemeal() @Override public boolean func_149851_a(World world, int x, int y, int z, boolean isRemote) { return world.getBlockMetadata(x, y, z) < this.maxMetaData; } //bonemealWorks() @Override public boolean func_149852_a(World world, Random random, int x, int y, int z) { return random.nextInt(10) <= this.bonemealSuccessAmplifier; } //doBonemeal() @Override public void func_149853_b(World world, Random random, int x, int y, int z) { growPlant(world, random, x, y, z, true); } } I tried changing it to a constant, 2 in this case: @Override public int getLightValue(IBlockAccess world, int x, int y, int z) { if (world.getBlockMetadata(x, y, z) >= 2) { return 16; } return 0; } But that gives the same problem.
November 2, 201410 yr The problem is very simple! You set the ligh level too high. 'return 16' MAX value should be 15!!! So in your case 'return 15'! If the light value is in float the MAX is '1.0F'! Be careful with that!
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.