Jump to content

[1.7.10] BiomeEvent.GetVillageBlockID biome sometimes null


Recommended Posts

Posted

Hello,

 

We are creating a custom village by just replacing the blocks with other blocks styled to fit the biome. We do this by listening to the BiomeEvent.GetVillageBlockID event, like this:

 

 

@SubscribeEvent
public void event(BiomeEvent.GetVillageBlockID event){
    if (WorldChunkManagerNorthrend.allowedBiomes.indexOf(event.biome) != -1){
        event.setResult(Event.Result.DENY);
        event.replacement = ...;
}

 

What we has found is that there are two reasons why the biome can be null:

  • The structure is a well, in which case mojang sets startPiece to null, for understandable reasons since the well is the origin of the village. Even though we would like to get the biome here as well, I can understand and accept this.
  • For some strange reason, whole villages sometimes has a null biome. Sadly enough, we've not been able to find the cause of this.

 

The only way out seems to be making a custom version of all the biome gen things, which is several really fat files. As you probably can understand, we would love to avoid that.

 

What would you suggest we should do?

Posted

Maybe this solution is to simple, but I think(I don't know exactly what you mean) but if you get a numm pinter Exception, you could try it with a !null statement :D

Creator of Extra Shoes

 

Watch out, I'm total jerk, and I'll troll anybody if it feels like its necessary. Pls report me then

Posted

Maybe this solution is to simple, but I think(I don't know exactly what you mean) but if you get a numm pinter Exception, you could try it with a !null statement :D

The problem with it being null is that we don't know if it's a vanilla village or one of our own villages, so that would not work :(

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • i dont have any crash reports i only have the latest log https://mclo.gs/DONwR2g
    • Maybe it is an issue with one of the Create addons Create_The_Kitchen_Must_Grow is the last mentioned mod
    • I cannot find any information on why this is specifically happening in any of the logs and i'm getting annoyed. it manifests primarily as lag when breaking and placing blocks, or picking up items. Items will be picked up than disappear, only to appear in my inventory many seconds later, blocks will not place for over 30 seconds at a time. observable shows 100459 μs/t on minecraft:player spark profile doesnt seem to show anything strange as far as i can tell though except for that about 20% of the usage is something called crusty_chunks and another 20% is distant horizons, even when i have distant rendering disabled. I've attached the latest.log, spark profile and observable exports.
    • [16:07:39] [main/INFO]:Mixins added to allowed list: [main.ClientPacketListenerMixin] [16:07:39] [main/INFO]:Class dev.uncandango.alltheleaks.leaks.client.mods.ae2wtlib.UntrackedIssue002 will NOT be loaded as mod ae2wtlib is not present [16:07:39] [main/INFO]:Class dev.uncandango.alltheleaks.leaks.client.mods.ae2wtlib.UntrackedIssue001 will NOT be loaded as mod ae2wtlib is not present [16:07:39] [main/INFO]:Class dev.uncandango.alltheleaks.fix.common.mods.modernfix.CancelRLMixin will be loaded as it matches versions: 5.20.2+mc1.20.1 in [5.0.0,) [16:07:39] [main/INFO]:Mixins added to cancel list: [org.embeddedt.modernfix.common.mixin.perf.deduplicate_location.MixinResourceLocation] [16:07:39] [main/INFO]:Skipping feature ResourceLocation Deduplication from mod minecraft as it's feature flag is not activated! [16:07:39] [main/INFO]:Skipping feature Ingredient Deduplication from mod minecraft as it's feature flag is not activated! [16:07:39] [main/INFO]:Skipping feature Prevent Search Ignored Items from mod jei as it's feature flag is not activated! [16:07:39] [main/WARN]:Error loading class: com/jozufozu/flywheel/util/WorldAttached (java.lang.ClassNotFoundException: com.jozufozu.flywheel.util.WorldAttached) [16:07:39] [main/WARN]:@Mixin target com.jozufozu.flywheel.util.WorldAttached was not found alltheleaks.mixins.json:main.WorldAttachedMixin from mod alltheleaks [16:07:39] [main/INFO]:Loaded config for: betterfpsdist.json [16:07:39] [main/INFO]:Loaded config for: structureessentials.json [16:07:39] [main/WARN]:Error loading class: dev/tr7zw/skinlayers/render/CustomizableModelPart (java.lang.ClassNotFoundException: dev.tr7zw.skinlayers.render.CustomizableModelPart) [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.BackgroundRendererMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.BiomeAccessAccessor [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.ChunkLightProviderMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.ChunkLightProviderMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.ChunkLightProviderMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.ClientChunkManagerMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.ClientSettingsC2SPacketMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.ClientWorldAccessor [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.GameOptionsMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.GameRendererMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.IntegratedServerMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.LightingProviderMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.MinecraftClientMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.SimpleOptionAccessor [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.ValidatingIntSliderCallbacksAccessor [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.sodium.SodiumChunkManagerMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.sodium.SodiumClientPlayNetworkHandlerMixin [16:07:39] [main/INFO]:Loading mixin: de.johni0702.minecraft.bobby.mixin.sodium.SodiumGameOptionPagesMixin [16:07:40] [main/INFO]:Replaced 1 calls to Enchantment#getMaxLevel() in net/minecraft/world/entity/npc/VillagerTrades$EnchantBookForEmeralds [16:07:40] [main/INFO]:Replaced 1 calls to Enchantment#isTreasureOnly() in net/minecraft/world/entity/npc/VillagerTrades$EnchantBookForEmeralds [16:07:40] [main/INFO]:Replaced 1 calls to Enchantment#isTradeable() in net/minecraft/world/entity/npc/VillagerTrades$EnchantBookForEmeralds [16:07:40] [main/INFO]:Loaded config for: recipeessentials.json [16:07:40] [main/INFO]:Patching FishingHook#catchingFish
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.