Jump to content

Recommended Posts

Posted

Hi, so I'm making a custom model for an item. But when I launch the game, I merely get the black and purple error texture on a flat square. I think it may be something wrong with my proxies. I am rather new to coding so please forgive me of any stupid mistakes.

 

Main.class

package io.github.mrnegablox.mythos;


import net.minecraft.client.Minecraft;
import net.minecraftforge.common.MinecraftForge;
import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.Mod.EventHandler;
import cpw.mods.fml.common.Mod.Instance;
import cpw.mods.fml.common.SidedProxy;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.event.FMLPostInitializationEvent;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;
import cpw.mods.fml.common.network.NetworkRegistry;
import cpw.mods.fml.common.registry.GameRegistry;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import io.github.mrnegablox.mythos.gui.GuiBook;
import io.github.mrnegablox.mythos.gui.GuiHandler;
import io.github.mrnegablox.mythos.items.ModItems;
import io.github.mrnegablox.mythos.omnomicon.CatagoriesBase;

@Mod(modid = Main.MODID, name = Main.MODNAME, version = Main.VERSION)
public class Main {


	//public CatagoriesBase bc = CatagoriesBase.Instance;
        public static final String MODID = "mythosnega";
        public static final String MODNAME = "Mythos";
        public static final String VERSION = "1.0.0";
        
        @Instance
        public static Main instance = new Main();
        
        @SidedProxy(clientSide="io.github.mrnegablox.mythos.ClientProxy", serverSide="io.github.mrnegablox.mythos.ServerProxy")
        public static CommonProxy proxy;
        


        
        /**
         * Run before anything else. Read your config, create blocks, items, etc, and 
         * register them with the GameRegistry.
         */
        @EventHandler
        public void preInit(FMLPreInitializationEvent e) {
        	
        	ModItems.init();

        	
        }
        



	/**
         * Do your mod setup. Build whatever data structures you care about. Register recipes.
         */
        @EventHandler
        public void init(FMLInitializationEvent e) {
        	proxy.registerRenderers();
        	//bc.RegisterCatagories();
        }
        
        /**
         * Handle interaction with other mods, complete your setup based on this.
         */
        @EventHandler
        public void postInit(FMLPostInitializationEvent e) {
        	NetworkRegistry.INSTANCE.registerGuiHandler(this, new GuiHandler());
        	
        }
}

 

Common Proxy

package io.github.mrnegablox.mythos;

import io.github.mrnegablox.mythos.items.ItemOmnomicon;
import io.github.mrnegablox.mythos.items.ItemSoulJar;
import io.github.mrnegablox.mythos.render.RenderSoulJar;
import net.minecraftforge.client.IItemRenderer;
import net.minecraftforge.client.MinecraftForgeClient;



public class CommonProxy {

private ItemSoulJar isj;

public void registerRenderers(){
	MinecraftForgeClient.registerItemRenderer(isj, (IItemRenderer)new RenderSoulJar());
}

    
}

 

Client Proxy

package io.github.mrnegablox.mythos;


import io.github.mrnegablox.mythos.items.ItemOmnomicon;
import io.github.mrnegablox.mythos.items.ItemSoulJar;
import io.github.mrnegablox.mythos.render.RenderSoulJar;
import net.minecraftforge.client.IItemRenderer;
import net.minecraftforge.client.MinecraftForgeClient;
import cpw.mods.fml.client.registry.ClientRegistry;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.event.FMLPostInitializationEvent;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;

public class ClientProxy extends CommonProxy {


private ItemSoulJar isj;

public ClientProxy(){
	isj = new ItemSoulJar();
}

@Override
public void registerRenderers(){
	MinecraftForgeClient.registerItemRenderer(isj, (IItemRenderer)new RenderSoulJar());
}



}


 

Item

package io.github.mrnegablox.mythos.items;

import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import io.github.mrnegablox.mythos.Main;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.IIcon;

public class ItemSoulJar extends Item {

public ItemSoulJar() {
}

 @Override
     @SideOnly(Side.CLIENT)
     public void registerIcons(IIconRegister iconRegister)
     {
             itemIcon = iconRegister.registerIcon(Main.MODID + ":textures/model/ModelSoulJar.png");
     }

}

 

ModItems

package io.github.mrnegablox.mythos.items;

import io.github.mrnegablox.mythos.Main;
import cpw.mods.fml.common.registry.GameRegistry;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;

public class ModItems {
public static Item ItemOmnomicon;
public static Item ItemSoulJar;

public static void init(){
	ItemOmnomicon = new ItemOmnomicon().setFull3D().setUnlocalizedName("mythosomnomicon").setCreativeTab(CreativeTabs.tabMisc).setTextureName(Main.MODID + ":mythosomnomicon");
	ItemSoulJar = new ItemSoulJar().setFull3D().setCreativeTab(CreativeTabs.tabMisc).setUnlocalizedName("mythossouljar").setTextureName(Main.MODID + ":mythosOmnomicon");
	RegisterItems();
}

private static void RegisterItems() {
	GameRegistry.registerItem(ItemOmnomicon, "mythosonomicon");
	GameRegistry.registerItem(ItemSoulJar, "mythossouljar");
}

}

 

Renderer

package io.github.mrnegablox.mythos.render;

import io.github.mrnegablox.mythos.Main;

import org.lwjgl.opengl.GL11;

import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.entity.RenderItem;
import net.minecraft.entity.Entity;
import net.minecraft.item.ItemStack;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.client.IItemRenderer;

public class RenderSoulJar implements IItemRenderer{

protected ModelSoulJar souljarmodel;
private static RenderItem renderItem = new RenderItem();
public RenderSoulJar(){
	souljarmodel = new ModelSoulJar();
}

@Override
public boolean handleRenderType(ItemStack item, ItemRenderType type) {
	// TODO Auto-generated method stub
	switch(type)
	{
	case EQUIPPED: return true;
	default: return false;
	}

}

@Override
public boolean shouldUseRenderHelper(ItemRenderType type, ItemStack item,
		ItemRendererHelper helper) {

	return false;
}

@Override
public void renderItem(ItemRenderType type, ItemStack item, Object... data) {
	System.out.println("render!");
	switch(type) {


	case EQUIPPED:
	{
		GL11.glPushMatrix();

		Minecraft.getMinecraft().renderEngine.bindTexture(new ResourceLocation(Main.MODID, "textures/model/ModelSoulJar.png"));

		souljarmodel.render((Entity)data[1], 0.0F, 0.0F, 0.0F, 0.0F, 0.0F, 0.0625F);

		GL11.glPopMatrix();
	}
	default:
		break;

	}

}

}

 

model

// Date: 12/13/2014 7:48:41 AM
// Template version 1.1
// Java generated by Techne
// Keep in mind that you still need to fill in some blanks
// - ZeuX






package io.github.mrnegablox.mythos.render;

import net.minecraft.client.model.ModelBase;
import net.minecraft.client.model.ModelRenderer;
import net.minecraft.entity.Entity;

public class ModelSoulJar extends ModelBase
{
//fields
public ModelRenderer Top;
public ModelRenderer Side_3;
public ModelRenderer Side_1;
public ModelRenderer Side_2;
public ModelRenderer Side_4;
public ModelRenderer Base;
public ModelRenderer Cap;
public ModelRenderer Shape1;

public ModelSoulJar()
{
	textureWidth = 64;
	textureHeight = 32;

	Top = new ModelRenderer(this, 0, 0);
	Top.addBox(0F, 0F, 0F, 9, 1, 9);
	Top.setRotationPoint(-1F, -11F, -1F);
	Top.setTextureSize(64, 32);
	Top.mirror = true;
	setRotation(Top, 0F, 0F, 0F);
	Side_3 = new ModelRenderer(this, 36, 0);
	Side_3.addBox(0F, 0F, 0F, 7, 10, 0);
	Side_3.setRotationPoint(0F, -10F, 0F);
	Side_3.setTextureSize(64, 32);
	Side_3.mirror = true;
	setRotation(Side_3, 0F, 0F, 0F);
	Side_1 = new ModelRenderer(this, 36, 0);
	Side_1.addBox(0F, 0F, 0F, 7, 10, 0);
	Side_1.setRotationPoint(0F, -10F, 7F);
	Side_1.setTextureSize(64, 32);
	Side_1.mirror = true;
	setRotation(Side_1, 0F, 0F, 0F);
	Side_2 = new ModelRenderer(this, 36, -7);
	Side_2.addBox(0F, 0F, 0F, 0, 10, 7);
	Side_2.setRotationPoint(0F, -10F, 0F);
	Side_2.setTextureSize(64, 32);
	Side_2.mirror = true;
	setRotation(Side_2, 0F, 0F, 0F);
	Side_4 = new ModelRenderer(this, 36, -7);
	Side_4.addBox(0F, 0F, 0F, 0, 10, 7);
	Side_4.setRotationPoint(7F, -10F, 0F);
	Side_4.setTextureSize(64, 32);
	Side_4.mirror = true;
	setRotation(Side_4, 0F, 0F, 0F);
	Base = new ModelRenderer(this, 0, 0);
	Base.addBox(0F, 0F, 0F, 9, 1, 9);
	Base.setRotationPoint(-1F, 0F, -1F);
	Base.setTextureSize(64, 32);
	Base.mirror = true;
	setRotation(Base, 0F, 0F, 0F);
	Cap = new ModelRenderer(this, 0, 10);
	Cap.addBox(0F, 0F, 0F, 5, 1, 5);
	Cap.setRotationPoint(1F, -12F, 1F);
	Cap.setTextureSize(64, 32);
	Cap.mirror = true;
	setRotation(Cap, 0F, 0F, 0F);
	Shape1 = new ModelRenderer(this, 20, 10);
	Shape1.addBox(0F, 0F, 0F, 5, 8, 5);
	Shape1.setRotationPoint(1F, -9F, 1F);
	Shape1.setTextureSize(64, 32);
	Shape1.mirror = true;
	setRotation(Shape1, 0F, 0F, 0F);
}

public void render(Entity entity, float f, float f1, float f2, float f3, float f4, float f5)
{
	super.render(entity, f, f1, f2, f3, f4, f5);
	setRotationAngles(f, f1, f2, f3, f4, f5, entity);
	Top.render(f5);
	Side_3.render(f5);
	Side_1.render(f5);
	Side_2.render(f5);
	Side_4.render(f5);
	Base.render(f5);
	Cap.render(f5);
}

private void setRotation(ModelRenderer model, float x, float y, float z)
{
	model.rotateAngleX = x;
	model.rotateAngleY = y;
	model.rotateAngleZ = z;
}

public void setRotationAngles(float f, float f1, float f2, float f3, float f4, float f5, Entity ent)
{
	super.setRotationAngles(f, f1, f2, f3, f4, f5, ent);
}

}

 

Thank you in advance

Posted

Renderers should't be called on common proxy, never ever.

 

It should look like this: (notice that i am refering to Item object registered by your mod, not a new one like you did in proxy)

public class CommonProxy {
public void registerRenderers(){}
}

public class ClientProxy extends CommonProxy {
@Override
public void registerRenderers(){
	MinecraftForgeClient.registerItemRenderer(ModItems.ItemSoulJar, (IItemRenderer)new RenderSoulJar());
}
}

 

Is your renderer ever called? (I only took a glance on code, so if it still won't work I ll check it in eclipse)

1.7.10 is no longer supported by forge, you are on your own.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I know that this may be a basic question, but I am very new to modding. I am trying to have it so that I can create modified Vanilla loot tables that use a custom enchantment as a condition (i.e. enchantment present = item). However, I am having trouble trying to implement this; the LootItemRandomChanceWithEnchantedBonusCondition constructor needs a Holder<Enchantment> and I am unable to use the getOrThrow() method on the custom enchantment declared in my mod's enchantments class. Here is what I have so far in the GLM:   protected void start(HolderLookup.Provider registries) { HolderLookup.RegistryLookup<Enchantment> registrylookup = registries.lookupOrThrow(Registries.ENCHANTMENT); LootItemRandomChanceWithEnchantedBonusCondition lootItemRandomChanceWithEnchantedBonusCondition = new LootItemRandomChanceWithEnchantedBonusCondition(0.0f, LevelBasedValue.perLevel(0.07f), registrylookup.getOrThrow(*enchantment here*)); this.add("nebu_from_deepslate", new AddItemModifier(new LootItemCondition[]{ LootItemBlockStatePropertyCondition.hasBlockStateProperties(Blocks.DEEPSLATE).build(), LootItemRandomChanceCondition.randomChance(0.25f).build(), lootItemRandomChanceWithEnchantedBonusCondition }, OrichalcumItems.NEBU.get())); }   Inserting Enchantments.[vanilla enchantment here] actually works but trying to declare an enchantment from my custom enchantments class as [mod enchantment class].[custom enchantment] does not work even though they are both a ResourceKey and are registered in Registries.ENCHANTMENT. Basically, how would I go about making it so that a custom enchantment declared as a ResourceKey<Enchantment> of value ResourceKey.create(Registries.ENCHANTMENT, ResourceLocation.fromNamespaceAndPath([modid], [name])), declared in a seperate enchantments class, can be used in the LootItemRandomChanceWithEnchantedBonusCondition constructor as a Holder? I can't use getOrThrow() because there is no level or block entity/entity in the start() method and it is running as datagen. It's driving me nuts.
    • Hi here is an update. I was able to fix the code so my mod does not crash Minecraft. Please understand that I am new to modding but I honestly am having a hard time understanding how anyone can get this to work without having extensive programming and debugging experience as well as searching across the Internet, multiple gen AI bots (claude, grok, openai), and examining source code hidden in the gradle directory and in various github repositories. I guess I am wrong because clearly there are thousands of mods so maybe I am just a newbie. Ok, rant over, here is a step by step summary so others can save the 3 days it took me to figure this out.   1. First, I am using forge 54.1.0 and Minecraft 1.21.4 2. I am creating a mod to add a shotgun to Minecraft 3. After creating the mod and compiling it, I installed the .jar file to the proper directory in Minecraft and used 1.21.4-forge-54.1.0 4. The mod immediately crashed with the error: Caused by: java.lang.NullPointerException: Item id not set 5. Using the stack trace, I determined that the Exception was being thrown from the net.minecraft.world.item.Item.Properties class 6. It seems that there are no javadocs for this class, so I used IntelliJ which was able to provide a decompiled version of the class, which I then examined to see the source of the error. Side question: Are there javadocs? 7. This method, specifically, was the culprit: protected String effectiveDescriptionId() {      return this.descriptionId.get(Objects.requireNonNull(this.id, "Item id not set"));  } 8. Now my quest was to determine how to set this.id. Looking at the same source file, I determined there was another method:  public Item.Properties setId(ResourceKey<Item> pId) {             this.id = pId;             return this;   } 9. So now, I need to figure out how to call setId(). This required working backwards a bit. Starting from the constructor, I stubbed out the variable p which is of type Item.Properties public static final RegistryObject<Item> SHOTGUN = ITEMS.register("shotgun", () -> new ShotgunItem(p)); Rather than putting this all on one line, I split it up for readability like this: private static final Item.Properties p = new Item.Properties().useItemDescriptionPrefix().setId(rk); Here is was the missing function, setId(), which takes a type of ResourceKey<Item>. My next problem is that due to the apparent lack of documentation (I tried searching the docs on this site) I could not determine the full import path to ResourceKey. I did some random searching on the Internet and stumbled across a Github repository which gave two clues: import net.minecraft.resources.ResourceKey; import net.minecraft.resources.ResourceLocation; Then I created the rk variable like this: private static ResourceKey<Item> rk = ResourceKey.create(Registries.ITEM, ResourceLocation.parse("modid:shotgunmod")); And now putting it all together in order: private static ResourceKey<Item> rk = ResourceKey.create(Registries.ITEM, ResourceLocation.parse("modid:shotgunmod")); private static final Item.Properties p = new Item.Properties().useItemDescriptionPrefix().setId(rk); public static final RegistryObject<Item> SHOTGUN = ITEMS.register("shotgun", () -> new ShotgunItem(p)); This compiled and the mod no longer crashes. I still have more to do on it, but hopefully this will save someone hours. I welcome any feedback and if I missed some obvious modding resource or tutorial that has this information. If not, I might suggest we add it somewhere for people trying to write a mod that doesn't crash. Thank you !!!  
    • I will keep adding to this thread with more information in case anyone can help, or at the very least I can keep my troubleshooting organized. I decided to downgrade to 54.1.0 in the hopes that this would fix the issue but it didn't. At least now I am on a "recommended" version. The crash report did confirm my earlier post that the Exception is coming from effectiveDescriptionId(). I'll continue to see if I can find a way to set the ID manually.   Caused by: java.lang.NullPointerException: Item id not set         at java.base/java.util.Objects.requireNonNull(Objects.java:259) ~[?:?]         at TRANSFORMER/[email protected]/net.minecraft.world.item.Item$Properties.effectiveDescriptionId(Item.java:465) ~[forge-1.21.4-54.1.0-client.jar!/:?]         at TRANSFORMER/[email protected]/net.minecraft.world.item.Item.<init>(Item.java:111) ~[forge-1.21.4-54.1.0-client.jar!/:?]         at TRANSFORMER/[email protected]/com.example.shotgunmod.ShotgunItem.<init>(ShotgunItem.java:19) ~[shotgunmod-1.0.0.jar!/:1.0.0]         at TRANSFORMER/[email protected]/com.example.shotgunmod.ModItems.lambda$static$0(ModItems.java:15) ~[shotgunmod-1.0.0.jar!/:1.0.0]         at TRANSFORMER/[email protected]/net.minecraftforge.registries.DeferredRegister$EventDispatcher.lambda$handleEvent      
    • It just randomly stop working after a rebooted my dedicated server PLEASE HELP!   com.google.gson   Failed to start the minecraft server com.google.gson.JsonSyntaxException: Expected a com.google.gson.JsonObject but was com.google.gson.JsonPrimitive; at path $  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.