[1.7.10] Potion IDs

[Mr_Neeple]

Is there anyway in 1.7.10 to create potion ids over 32?

[Reika]

PotionIDs can be extended to max. 127. You can dynamically modify the array Potion.potionTypes (you'll have to set it via reflection). First check if the array is smaller than 127 (other mods might already expand it!) if so, expand it using Arrays.copyOf.

 

I actually found a way to safely extend it to 255 (and theoretically higher), but it required ASM into the PotionEffect packet and NBT methods to remove the byte casts.

[Reika]

"safely" and "ASM into vanilla classes" are pretty much mutually exclusive.

Not really. Barring a MC version change or another mod's conflicting ASM edit, there is no way for this to error out. Also, you seem to be implying, based on your wording of "ASM into vanilla classes" that using ASM is not necessarily dangerous, but using it on vanilla classes is. What else would you normally use it on? You could of course theoretically ASM Forge or other mods, but that is far more dangerous and will generate a huge amount of drama.

[f1rSt1kChannel]

public static void increaseArray(Class<?> clazz, int length, String... args){
	Object[] oldArray = null;
	for(Field field : clazz.getDeclaredFields()){
		try{
			for(String s : args){
				if(field.getName().equals(s)){
					field.setAccessible(true);
					if(Modifier.isFinal(field.getModifiers())){
						Field modfield = Field.class.getDeclaredField("modifiers");
						modfield.setAccessible(true);
						modfield.setInt(field, field.getModifiers() & ~Modifier.FINAL);
					}
					oldArray = (Object[])field.get(null);
					Object newArray = Array.newInstance(field.get(null).getClass().getComponentType(), length);
					System.arraycopy(oldArray, 0, newArray, 0, oldArray.length);
					field.set(null, newArray);
				}
			}
		}catch(ReflectiveOperationException e){
			e.printStackTrace();
		}
	}
}

And call in your main class:

increaseArray(Potion.class, 256, "potionTypes", "obfName");