Search the Forums BEFORE making a new post.

Crash with custom armour

Posted January 17, 201510 yr

Hey there, so I haven't really messed around with potion effects before, and I have this set of armour which works perfectly, until you come to remove it...

Here is the code:

public class BedrockArmour extends ItemArmor {
public BedrockArmour(ArmorMaterial material, int armorType) {
	super(material, 0, armorType);
}

@Override
public String getArmorTexture(ItemStack stack, Entity entity, int slot, String type)
{
	if(stack.getItem() == itemRegist.bedrockChest || stack.getItem() == itemRegist.bedrockHelmet || stack.getItem() == itemRegist.bedrockBoots)
	{
		return Reference.MODID + ":models/armor/bedrock_layer_1.png";
	}
	else if(stack.getItem() == itemRegist.bedrockLegs)
	{
		return Reference.MODID + ":models/armor/bedrock_layer_2.png";
	}
			else{
		System.out.println("Invalid Item for Bedrock Armour");
	return null;
			}
}

public void onArmorTick(World world, EntityPlayer player, ItemStack itemStack) {
	if(player.getCurrentArmor(3) != null || player.getCurrentArmor(2) != null || player.getCurrentArmor(1) != null || player.getCurrentArmor(0) != null){
		ItemStack helmet2 = player.getCurrentArmor(3);
		ItemStack plate2 = player.getCurrentArmor(2);
		ItemStack legs2 = player.getCurrentArmor(1);
		ItemStack boots = player.getCurrentArmor(0);
		if(helmet2.getItem() == itemRegist.bedrockHelmet || legs2.getItem() == itemRegist.bedrockLegs || plate2.getItem() == itemRegist.bedrockChest || boots.getItem() == itemRegist.bedrockBoots){
			player.addPotionEffect(new PotionEffect(Potion.moveSlowdown.getId(), 5, 0));
		}
	}







	if(player.getCurrentArmor(3) != null && player.getCurrentArmor(2) != null || player.getCurrentArmor(2) != null && player.getCurrentArmor(1) != null || player.getCurrentArmor(3) != null && player.getCurrentArmor(2) != null ||
			player.getCurrentArmor(1) != null && player.getCurrentArmor(0) != null || player.getCurrentArmor(0) != null && player.getCurrentArmor(2) != null || player.getCurrentArmor(3) != null && player.getCurrentArmor(0) != null){
		ItemStack helmet2 = player.getCurrentArmor(3);
		ItemStack plate2 = player.getCurrentArmor(2);
		ItemStack legs2 = player.getCurrentArmor(1);
		ItemStack boots = player.getCurrentArmor(0);
		if(helmet2.getItem() == itemRegist.bedrockHelmet && plate2.getItem() == itemRegist.bedrockChest || plate2.getItem() == itemRegist.bedrockChest && legs2.getItem() == itemRegist.bedrockLegs || 
				helmet2.getItem() == itemRegist.bedrockHelmet && plate2.getItem() == itemRegist.bedrockChest || legs2.getItem() == itemRegist.bedrockLegs && boots.getItem() == itemRegist.bedrockBoots ||
				boots.getItem() == itemRegist.bedrockBoots && plate2.getItem() == itemRegist.bedrockChest || helmet2.getItem() == itemRegist.bedrockHelmet && boots.getItem() == itemRegist.bedrockBoots)                                                                                                                                                  
		{
			player.addPotionEffect(new PotionEffect(Potion.moveSlowdown.getId(), 5, 1));
			player.addPotionEffect(new PotionEffect(Potion.resistance.getId(), 5, 0));
		}
}







	if(player.getCurrentArmor(3) != null && player.getCurrentArmor(2) != null && player.getCurrentArmor(1) != null || player.getCurrentArmor(3) != null && player.getCurrentArmor(2) != null && player.getCurrentArmor(0) != null
			|| player.getCurrentArmor(3) != null && player.getCurrentArmor(1) != null && player.getCurrentArmor(0) != null || player.getCurrentArmor(1) != null && player.getCurrentArmor(2) != null && player.getCurrentArmor(0) != null){
		ItemStack helmet2 = player.getCurrentArmor(3);
		ItemStack plate2 = player.getCurrentArmor(2);
		ItemStack legs2 = player.getCurrentArmor(1);
		ItemStack boots = player.getCurrentArmor(0);

		if(helmet2.getItem() == itemRegist.bedrockHelmet && plate2.getItem() == itemRegist.bedrockChest && legs2.getItem() == itemRegist.bedrockLegs || helmet2.getItem() == itemRegist.bedrockHelmet && plate2.getItem() == itemRegist.bedrockChest && boots.getItem() == itemRegist.bedrockBoots
				|| helmet2.getItem() == itemRegist.bedrockHelmet && legs2.getItem() == itemRegist.bedrockLegs && boots.getItem() == itemRegist.bedrockBoots || legs2.getItem() == itemRegist.bedrockLegs && plate2.getItem() == itemRegist.bedrockChest && boots.getItem() == itemRegist.bedrockBoots){
			player.addPotionEffect(new PotionEffect(Potion.moveSlowdown.getId(), 5, 2));
			player.addPotionEffect(new PotionEffect(Potion.resistance.getId(), 5, 1));
		}

	}




	if(player.getCurrentArmor(1) != null && player.getCurrentArmor(2) != null && player.getCurrentArmor(0) != null && player.getCurrentArmor(3) != null ){
		ItemStack helmet2 = player.getCurrentArmor(3);
		ItemStack plate2 = player.getCurrentArmor(2);
		ItemStack legs2 = player.getCurrentArmor(1);
		ItemStack boots = player.getCurrentArmor(0);

		if(legs2.getItem() == itemRegist.bedrockLegs && plate2.getItem() == itemRegist.bedrockChest && boots.getItem() == itemRegist.bedrockBoots && helmet2.getItem() == itemRegist.bedrockHelmet){
			player.addPotionEffect(new PotionEffect(Potion.moveSlowdown.getId(), 5, 3));
			player.addPotionEffect(new PotionEffect(Potion.resistance.getId(), 5, 2));
		}

	}


}



}

Here's a copy of the crashlog:

http://pastebin.com/4DRxBKJU

This crash happens when:

The armour isn't added (whether placed or shift clicked) in the order - Helmet, Chest, Legs, Boots

Armour is removed (via mouse or shift click) in an order that isn't - Boots, Legs, Chest, Helmet

If it is because of the very messy code, then ideas on how to fix it would be greatly appreciated.

Why bother?

Quote

January 17, 201510 yr

Author

So separate out the or statements into multiple if statements?

That way it would be:

if slot 1 != null{

}

if slot 2 != null {

}

if slot 3 != null{

}

if slot 4 != null{

}

Or am I going about this the wrong way?

Why bother?

Quote

January 17, 201510 yr

Author

The && operator exists.

Thanks for your help

Why bother?

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/26716-crash-with-custom-armour/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Bad pathfinding for big mobs (1.21.1)

Well I was mainly trying to figure out whether or not I was doing something wrong and if it could be fixed by just adding something (e.g. maybe I was missing an Attribute or something like that), but if that's not the case then my only option is to use custom pathfinding. If someone has one that functions and is willing to share it, then I'd gladly use that instead of suffering through making my own.

By VictorEvers · 10 hours ago10 hr
how do i change my username with forge?

In the future I do plan on adding optional OAuth to the new launcher in ForgeGradle 7. But yes, using --username and offline mode is a good workaround to not using accounts in the development environment, especially considering that the server is on LAN.

By Jonathing · 10 hours ago10 hr
how do i change my username with forge?

I came across this post looking for an answer to the OP's question. My use case is a classroom with one server in LAN and many clients of course participants that want to test their mods.

The answer is:
On the client
Edit build.gradle. In the section client add the following line before the closing curly brace: args '--username', '<YOUR NAME>'. Replace <YOUR NAME> with your actual username. E.g. if your username is lmoellendorf the client section should look like this:

client { // Comma-separated list of namespaces to load gametests from. Empty = all namespaces. property 'forge.enabledGameTestNamespaces', mod_id args '--username', 'lmoellendorf' }
Make sure that each username is unique on your server.

Start your Minecraft Client. Click Multiplayer then Direct Conection. Here enter the Server address which is the local IP of your server followed by colon : followed by the default port 25565. E.g. if your server's IP is 192.168.0.7 the entry should look like this:

192.168.0.7:25565
On the server

Be sure that in run/server.properties the line online-mode is set to false:

online-mode=false

By lmoellendorf · 10 hours ago10 hr
Forge 59.0 Minecraft 1.21.9

By Jonathing · Posted Thursday at 01:09 AM2 days
Forge 58.1 Minecraft 1.21.8

By Jonathing · Posted Thursday at 01:08 AM2 days

There are no registered users currently online

Sign In

Crash with custom armour

Featured Replies

Join the conversation

Posts

Bad pathfinding for big mobs (1.21.1)

how do i change my username with forge?

how do i change my username with forge?

Forge 59.0 Minecraft 1.21.9

Forge 58.1 Minecraft 1.21.8

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)