Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

So some might remember I am loading skills from external skill.jar files in runtime using modClassLoader. Now i'd like to also load resources placed there, how could I archieve this?

ResourceLoacetion allows me to only make modid:path.

To be more precise:

public static Skill loadSkill(File file)
{
	JarFile jarFile = null;
	try
	{
		jarFile = new JarFile(file);
		Enumeration<JarEntry> entries = jarFile.entries();

		while (entries.hasMoreElements())
		{
			JarEntry element = entries.nextElement();
			String name = element.getName();

			if (name.endsWith(".png"))
			{
				resourceMap.put(name, new ResourceLocation(***element I just read***);
				//above is an example, I will be obviously storing resources to more advanced holders.
			.....

How do I make something like it work?

1.7.10 is no longer supported by forge, you are on your own.

  • Author

I honestly have very little idea on how to work with it. ;/

 

I don't quite understand the logic behind resource management.

 

List<IResourcePack> defaultResourcePacks = ObfuscationReflectionHelper.getPrivateValue(Minecraft.class, Minecraft.getMinecraft(), "defaultResourcePacks", "field_110449_ao");

 

This gives me the list and then I can:

defaultResourcePacks.add(new MyIResourcePackImplementation())

 

But then what?

For what I am aware (from vanilla) - whenever you want to add resource to game you have to realod resources.

So i am assuming:

1. Load all Skill.jar

2. Get all .png files and save them in Map<String, File>

3. Create new MyIResourcePackImplementation(Map<String, File>)

4. Put MyIResourcePackImplementation into defaultResourcePacks using reflection code above.

 

Do I need to actually create new MyIResourcePackImplementation everytime or can I simply make this object once and put there files one by one?

 

Any neat explanation is appreciated. Just so I can get what is really happening there.

 

Edit: Also - does MC store all resources as simple directory link and use them from HDD? In that case wouldn't I need to copy files from .jar to some non-zipped dir first (to not open infinite number of JarFiles)?

 

1.7.10 is no longer supported by forge, you are on your own.

  • Author

FileResourcePack answers my Edit concerns (close() of zip).

 

I have literally no idea what am I doing.

 

public static void init()
{	
	List<IResourcePack> defaultResourcePacks = ObfuscationReflectionHelper.getPrivateValue(Minecraft.class, Minecraft.getMinecraft(), "defaultResourcePacks", "field_110449_ao");

	defaultResourcePacks.add(new SkillResourcePack(new File("C:/Users/Ernio/git/roa/RoA/Skills/SkillFireball.jar")));
}

 

For one I know:

[23:02:55] [Client thread/WARN]: Unable to parse metadata section of resourcepack: SkillFireball
net.minecraft.client.resources.ResourcePackFileNotFoundException: 'pack.mcmeta' in ResourcePack 'C:\Users\Ernio\git\roa\RoA\Skills\SkillFireball.jar'
at net.minecraft.client.resources.FileResourcePack.getInputStreamByName(FileResourcePack.java:49) ~[FileResourcePack.class:?]
at net.minecraft.client.resources.AbstractResourcePack.getPackMetadata(AbstractResourcePack.java:66) ~[AbstractResourcePack.class:?]
at net.minecraft.client.resources.LanguageManager.parseLanguageMetadata(LanguageManager.java:48) [LanguageManager.class:?]
at net.minecraft.client.Minecraft.refreshResources(Minecraft.java:740) [Minecraft.class:?]
at net.minecraftforge.fml.client.FMLClientHandler.finishMinecraftLoading(FMLClientHandler.java:306) [FMLClientHandler.class:?]
at net.minecraft.client.Minecraft.startGame(Minecraft.java:484) [Minecraft.class:?]
at net.minecraft.client.Minecraft.run(Minecraft.java:325) [Minecraft.class:?]
at net.minecraft.client.main.Main.main(Main.java:117) [Main.class:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_11]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_11]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_11]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_11]
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.11.jar:?]
at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.11.jar:?]
at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:78) [start/:?]
at GradleStart.main(GradleStart.java:45) [start/:?]

That it is somewhat working.

 

File structure:

-SkillFireball.jar

--com

----packages.with.code

--assets

----fireball.png

 

How can I work it so:

private static ResourceLocation fireball = new ResourceLocation("something:fireball");

Will work? (or actually anything that is ResourceLoction will work).

 

I just dont understand relations there.

 

Sorry for questions, but this is first time I actually can't understand it on my own (trying) ;c

1.7.10 is no longer supported by forge, you are on your own.

  • Author

I am still missing something. I'll try to explain best I can.

 

2ld9iu1.jpg

 

1 - How asset would look like if it would be loaded by mod itself.

2 - The Skill.jar location that is being dynamically class-loaded AND which contains assets required by this skill.

3 - How Skill.jar looks inside (assets).

 

Now since, as you told me, if I'd put virtual IResourcePack (SkillFireball.jar in this case) into defaultResourcePacks, it should start working:

List<IResourcePack> defaultResourcePacks = ObfuscationReflectionHelper.getPrivateValue(Minecraft.class, Minecraft.getMinecraft(), "defaultResourcePacks", "field_110449_ao");
	defaultResourcePacks.add(new SkillResourcePack(new File("C:/Users/Ernio/git/roa/RoA/Skills/SkillFireball.jar")));

 

But as far as I know (I am SURE OF IT) before I attempt on doing this:

ResourceLocation fireball = new ResourceLocation(InitUtil.ModID + ":" + "textures/skills/Fireball.png");

 

I need to actually LOAD (refresh) resources, becaouse if I don't I will get this:

[23:53:49] [Client thread/WARN]: Failed to load texture: roa:textures/skills/Fireball.png
java.io.FileNotFoundException: roa:textures/skills/Fireball.png
at net.minecraft.client.resources.FallbackResourceManager.getResource(FallbackResourceManager.java:70) ~[FallbackResourceManager.class:?]
at net.minecraft.client.resources.SimpleReloadableResourceManager.getResource(SimpleReloadableResourceManager.java:67) ~[simpleReloadableResourceManager.class:?]
at net.minecraft.client.renderer.texture.SimpleTexture.loadTexture(SimpleTexture.java:34) ~[simpleTexture.class:?]
.........

 

Now - how do I do that? That is what is bugging me. Next reply will probably solve this thread or cause me to rage quit and go to sleep, in any case - thank you :)

 

Note: I am not saying I wasn't alredy looking how MC loads resourcepacks, but that is being done on /resourcepacks/ directory.

The only way I noticed is to make use of this: this.mcResourceManager.reloadResources(arraylist); where array is list of all resourcepacks. Is this the right way? (do I have to reload whole game-resources to get mine working)

1.7.10 is no longer supported by forge, you are on your own.

  • Author

Oh my god, yes! For whole hour I've been getting closer to total rage, then I noticed:

new ResourceLocation(InitUtil.ModID + ":" + "textures/skills/Fireball.png"));
new ResourceLocation(InitUtil.ModID + ":" + "textures/skills/fireball.png"));

 

(one letter)

width=430 height=215http://d24w6bsrhbeh9d.cloudfront.net/photo/aQqBE67_460sa.gif[/img]

 

My face .__.

 

Thanks, thread closed :)

1.7.10 is no longer supported by forge, you are on your own.

  • Author

Question doesn't deserve whole thread and is not even Forge i think:

 

What happens if I'd load 2 virtual texturepacks that have one "same" element.

Which one takes priority? Last loaded? (I don't see LinkedMaps or Sets, so idk which one will be "last")

1.7.10 is no longer supported by forge, you are on your own.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.