Jump to content

[1.7.10] [SOLVED] Weird problems with map...


Elix_x

Recommended Posts

Hi there, so:

I'm using map to assign one object to another, and to find assigned value, i'm creating new first object and trying to find it in map with get, and as it is another object, in it's class i specified equals method to compare it...

So, i tested and for the moment:

equals method is working succesfully with 2 different objects, that are not the same but stored ints are equal...

map.get is not working with condition above, even know that map.get description says that .equals counts...

And also: minecraft uses same kind of system to assign tileentities to position, and it works...

DimBlockPos:

public int dim;

public int x;
public int y;
public int z;

public DimBlockPos(int dim, int x, int y, int z) {
	this.dim = dim;
	this.x = x;
	this.y = y;
	this.z = z;
}

@Override
public boolean equals(Object obj) {
	if(obj instanceof DimBlockPos){
		DimBlockPos pos = (DimBlockPos) obj;
		System.out.println("Comparing " + this + " with " + pos);
		return dim == pos.dim && x == pos.x && y == pos.y && z == pos.z;
	}
	return super.equals(obj);
}

@Override
public String toString() {
	return "DimBlockPos{ " + dim + ", " + x + ", " + y + ", " + z + "}";
}

Map map:

private static Map<DimBlockPos, RGBO> map = new HashMap<DimBlockPos, RGBO>();

Method that retrieves:

DimBlockPos pos = new DimBlockPos(player.worldObj.provider.dimensionId, x, y, z);
	RGBO rgbo = map.get(pos);
		System.out.println(map);
		System.out.println(pos);
	System.out.println(rgbo);
		System.out.println(new DimBlockPos(player.worldObj.provider.dimensionId, x, y, z).equals(new DimBlockPos(player.worldObj.provider.dimensionId, x, y, z)));
	System.out.println(pos.equals(new DimBlockPos(player.worldObj.provider.dimensionId, x, y, z)));

And finally what console prints:

[19:14:55] [Client thread/INFO] [sTDOUT]: [code.elix_x.coremods.colourfullblocks.color.ColourfullBlocksManager:renderBlock:27]: {DimBlockPos{ 0, 180, 68, 248}=RGBO{ 50.0, 0.0, -50.0, 15.0}, DimBlockPos{ 0, 180, 68, 248}=RGBO{ 50.0, 0.0, -50.0, 15.0}, DimBlockPos{ 0, 179, 68, 246}=RGBO{ 50.0, 0.0, -50.0, 15.0}, DimBlockPos{ 0, 179, 68, 246}=RGBO{ 50.0, 0.0, -50.0, 15.0}}
[19:14:55] [Client thread/INFO] [sTDOUT]: [code.elix_x.coremods.colourfullblocks.color.ColourfullBlocksManager:renderBlock:28]: DimBlockPos{ 0, 180, 68, 248}
[19:14:55] [Client thread/INFO] [sTDOUT]: [code.elix_x.coremods.colourfullblocks.color.ColourfullBlocksManager:renderBlock:29]: null
[19:14:55] [Client thread/INFO] [sTDOUT]: [code.elix_x.coremods.colourfullblocks.util.DimBlockPos:equals:22]: Comparing DimBlockPos{ 0, 180, 68, 248} with DimBlockPos{ 0, 180, 68, 248}
true
[19:14:55] [Client thread/INFO] [sTDOUT]: [code.elix_x.coremods.colourfullblocks.util.DimBlockPos:equals:22]: Comparing DimBlockPos{ 0, 180, 68, 248} with DimBlockPos{ 0, 180, 68, 248}
true

 

Any help is appreciated, andif you have any questions - just ask!

Link to comment
Share on other sites

If you override equals you always MUST override hashCode. Read the javadocs for both equals and hashCode, they tell you how the two interact. If you just override one, you create weird behavior like this.

 

Alternatively, use your IDE, it can generate both for you (Source > Generate equals/hashCode in eclipse iirc).

Thank you, it solved the problem!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • In the ever-evolving landscape of cryptocurrency, the challenge of recovering lost or stolen digital assets has long been a pressing concern. However, a pioneering company known as Washington Recovery Pro has emerged as a trailblazer in this domain, offering a revolutionary approach to the recovery of Bitcoin and other cryptocurrencies. Leveraging their deep expertise in blockchain technology and digital forensics, Washington Recovery Pro has developed a suite of innovative tools and techniques that empower individuals and organizations to track, trace, and reclaim their rightful digital holdings, even in the face of sophisticated theft and obfuscation tactics employed by cybercriminals. By tapping into the transparency and immutability of the blockchain, Washington Recovery Pro analysts are able to meticulously follow the digital breadcrumbs left behind by illicit transactions, unraveling complex money-laundering schemes and identifying the ultimate destinations of stolen funds. Through their tireless efforts and cutting-edge investigative methods, Washington Recovery Pro has successfully recovered millions of dollars' worth of cryptocurrency, restoring peace of mind and financial stability to countless victims of crypto-related crimes. As the adoption of digital assets continues to soar, the importance of Washington Recovery Pro work cannot be overstated, as they stand as a bulwark against the growing threat of cryptocurrency theft and a beacon of hope for those seeking to reclaim their rightful digital wealth. For more information, contact:          
    • Ive tried to disable all the mods and repair the installation in curseforge but that didnt change anything sadly.
    • Ive been trying to run some datapacks from vanilla tweaks like multiplayer sleep and Anti Creeper grief, but i cant seem to get them working on CurseForge while they work completely fine in Vanilla on the same version. They are loaded according to the game but they don´t work at all, ive tried using openloader but that doesnt change anything either.   Any ideas on what could be causing this?    Thank you in advance, Nap
    • I am having the same issue when I try to launch the modpack from the launcher. I am on Windows, running 32gb RAM, I have plenty of RAM dedicated to the modpack, but every time I try to launch the game, I get a message saying "Game Crashed - Exit Code: 1" For reference, I have 18.5k MB dedicated to running the game, and it still crashes. I am not sure what the issue is. Any help is appreciated!
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.