Jump to content

View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS

Tap the Share icon in Safari
Scroll the menu and tap Add to Home Screen.
Tap Add in the top-right corner.

To install this app on Android

Tap the 3-dot menu (⋮) in the top-right corner of the browser.
Tap Add to Home screen or Install app.
Confirm by tapping Install.

Forge Forums

Forge Forums

Forge Forums

Forge Forums

Existing user? Sign In
Sign In

Email Address

Password

Remember me
Not recommended on shared computers

Forgot your password?

Or sign in with...
Sign Up

Search the Forums BEFORE making a new post.

Currently supported: All versions

[1.7.10] Item with durability wont break

Posted April 29, 201510 yr

Hello everyone,

i have a problem with my durable item ...

in crafting it works fine but when im damaging item with itemstack.setItemDamage(itemstack.getItemDamage() + 1);

it just wont break i would appreciate any help

Thank you

Durable Item class

package fewmorethings.items;

import java.util.Random;

import net.minecraft.block.Block;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.init.Blocks;

import net.minecraft.init.Items;

import net.minecraft.item.Item;

import net.minecraft.item.ItemStack;

import net.minecraft.world.World;

import fewmorethings.Main;

import fewmorethings.handlers.BlocksHandler;

import fewmorethings.handlers.ItemsHandler;

import fewmorethings.help.LogHelper;

import fewmorethings.help.Reference;

public class ClickSmelt extends Item {

public ClickSmelt() {

this.setUnlocalizedName("ClickSmelt");

this.setTextureName(Reference.MODID + ":" + "ClickSmelt");

this.setCreativeTab(Main.fmtab);

this.setMaxDamage(64);

this.setMaxStackSize(1);

}

@Override

public boolean onItemUse(ItemStack itemstack, EntityPlayer player, World world, int x, int y, int z, int par1, float par2, float par3, float par4) {

Block blockoneye = world.getBlock(x, y, z);

int metadata = world.getBlockMetadata(x, y, z);

if(player.canPlayerEdit(x, y, z, par1, itemstack)) {

//Block to Block

if(blockoneye == Blocks.sand) {

world.setBlock(x, y, z, Blocks.glass);

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

}if(blockoneye == Blocks.glass) {

world.setBlock(x, y, z, BlocksHandler.ClearGlass);

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

}if(blockoneye == Blocks.cobblestone) {

world.setBlock(x, y, z, Blocks.stone);

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

}if(blockoneye == Blocks.clay) {

world.setBlock(x, y, z, Blocks.hardened_clay);

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

//Block to Item

}if(blockoneye == Blocks.iron_ore) {

world.setBlockToAir(x, y, z);

player.inventory.addItemStackToInventory(new ItemStack(Items.iron_ingot));

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

}if(blockoneye == Blocks.coal_ore) {

world.setBlockToAir(x, y, z);

player.inventory.addItemStackToInventory(new ItemStack(Items.coal));

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

}if(blockoneye == Blocks.gold_ore) {

world.setBlockToAir(x, y, z);

player.inventory.addItemStackToInventory(new ItemStack(Items.gold_ingot));

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

}if(blockoneye == Blocks.lapis_ore) {

world.setBlockToAir(x, y, z);

player.inventory.addItemStackToInventory(new ItemStack(Items.dye,1,4));

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

}if(blockoneye == Blocks.redstone_ore) {

world.setBlockToAir(x, y, z);

player.inventory.addItemStackToInventory(new ItemStack(Items.redstone));

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

}if(blockoneye == Blocks.diamond_ore) {

world.setBlockToAir(x, y, z);

player.inventory.addItemStackToInventory(new ItemStack(Items.diamond));

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

}if(blockoneye == Blocks.emerald_ore) {

world.setBlockToAir(x, y, z);

player.inventory.addItemStackToInventory(new ItemStack(Items.emerald));

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

}if(blockoneye == Blocks.log || blockoneye == Blocks.log2) {

world.setBlockToAir(x, y, z);

player.inventory.addItemStackToInventory(new ItemStack(Items.coal,1,1));

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

}if(blockoneye == Blocks.cactus) {

world.setBlockToAir(x, y, z);

player.inventory.addItemStackToInventory(new ItemStack(Items.dye,1,2));

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

}if(blockoneye == Blocks.netherrack) {

world.setBlockToAir(x, y, z);

player.inventory.addItemStackToInventory(new ItemStack(Items.netherbrick));

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

}if(blockoneye == Blocks.quartz_ore) {

world.setBlockToAir(x, y, z);

player.inventory.addItemStackToInventory(new ItemStack(Items.quartz));

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

}if(blockoneye == BlocksHandler.blockOres && metadata == 0) {

world.setBlockToAir(x, y, z);

player.inventory.addItemStackToInventory(new ItemStack(ItemsHandler.Ingots));

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

}if(blockoneye == BlocksHandler.blockOres && metadata == 1) {

world.setBlockToAir(x, y, z);

player.inventory.addItemStackToInventory(new ItemStack(ItemsHandler.Ingots,1,1));

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

}if(blockoneye == BlocksHandler.blockOres && metadata == 2) {

world.setBlockToAir(x, y, z);

player.inventory.addItemStackToInventory(new ItemStack(ItemsHandler.Ingots,1,2));

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

}if(blockoneye == BlocksHandler.blockOres && metadata == 3) {

world.setBlockToAir(x, y, z);

player.inventory.addItemStackToInventory(new ItemStack(ItemsHandler.Ingots,1,3));

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

}if(blockoneye == BlocksHandler.blockOres && metadata == 4) {

world.setBlockToAir(x, y, z);

player.inventory.addItemStackToInventory(new ItemStack(ItemsHandler.Ingots,1,4));

itemstack.setItemDamage(itemstack.getItemDamage() + 1);

}

}

return false;

}

@Override

public boolean getShareTag() {

return true;

}

public boolean hasContainerItem(ItemStack itemStack) {

return true;

}

@Override

public boolean doesContainerItemLeaveCraftingGrid(ItemStack itemStack) {

return false;

}

@Override

public ItemStack getContainerItem(ItemStack itemStack) {

ItemStack stack = itemStack.copy();

stack.setItemDamage(stack.getItemDamage() + 1);

return stack;

}

}

I'm beginner in java and in minecraft modding.

Please be specific.

Any code examples are appreciated.

Sorry for my english i'm from Czech republic.

Please hit that thank you button if i helped

Quote

April 29, 201510 yr

Author

Im sorry, but thats the only way i can do it Im trying to learn ...

If you could help me more i would appreciate that.

And how to do the stack size 0 to null conversion ??

Thank you

I'm beginner in java and in minecraft modding.

Please be specific.

Any code examples are appreciated.

Sorry for my english i'm from Czech republic.

Please hit that thank you button if i helped

Quote

April 29, 201510 yr

Author

Im gonna go look at some basic java tutorials

Thank you

I'm beginner in java and in minecraft modding.

Please be specific.

Any code examples are appreciated.

Sorry for my english i'm from Czech republic.

Please hit that thank you button if i helped

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/29721-1710-item-with-durability-wont-break/

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted 4 hours ago4 hr
Bad pathfinding for big mobs (1.21.1)

I've struggled with this for way too long now, so I have decided to ask for some assistance here because there is almost no information about this online.

I made a hostile mob and I built it like this:
public static final Supplier<EntityType<Bunyip>> BUNYIP = ENTITY_TYPES.register("bunyip" , () -> EntityType.Builder. of(Bunyip::new, MobCategory.MONSTER).sized(3f, 2.5f).eyeHeight(1.75f).build("bunyip"));

However, I have discovered that a BoundingBox of 3 is too big for the vanilla pathfinding to work well. In fact, anything bigger than a block will not work well. This is especially noticeable when having it chase a player in a negative X and/or negative Z direction. The mob starts spinning, walking backwards, walking diagonally, etc.

I am using the Goal system:
protected void registerGoals() { super.registerGoals(); this.goalSelector.addGoal(1, new MeleeAttackGoal(this, 1.25, true)); this.targetSelector.addGoal(2, new NearestAttackableTargetGoal<>(this, Player.class, true, true)); }

This does not seem to be a me issue as the ravager, one of the biggest vanilla mobs, also struggles with proper pathfinding. I am a bit familiar with how Minecraft's pathfinding works, but not enough to make a pathfinding system from scratch (or at least not in a reasonable amount of time). Is there any way to fix this with some tweaks or will I have to make a custom pathfinding system?

By VictorEvers · Posted 11 hours ago11 hr
New Forum Design/Update: Issues and Suggestions

Unfortunately, it seems that Invision has decided that everything is locked down and no longer customizable.
Their attitude to anyone who wants to edit anything is 'Just accept it we know best and screw you for even insinuating that you want to customize your own site'
So there isn't much we can do about the layout of actual features.
Best bet for the editor is that psudo markdown works, so typing ` around words make code blocks.
Only options is to start writing bespoke modifications to the forum's php code itself, which I really don't want to do.
I would of stayed on v4 but the version of PHP that it supports is going EOL and Invision has stated they have no intentions of upgrading it.
They also removed the central community for finding plugins/community addons.
Overall it is my feeling that they are intentionally trying to kill off self-hosting communities by removing features and locking things down, in an effort to force everyone into using their paid hosting services.

My HOPE is that someone in the overall forum community will write an exporter for Invision to something like SMF. Which is what we were originally on before old team members decided enterprise software is better.

By LexManos · 15 hours ago15 hr
Orbital strike cannon fishing rod mod

Yes i will be uploading the mod to curse forge and modrinth you can already find a early build

https://www.curseforge.com/minecraft/mc-mods/wemmbus-style-orbital-strike-cannon
https://modrinth.com/mod/wemmbus-style-orbital-strike-cannon

hopefully 1.21.5 fabric will be out by the weekend also please note that there is a lot more features im adding like cubic metres orbital arrow cannon type shot (basically a stab shot but with insta kill arrows)

@JayKing014
@Astoxy
@Astoxy
@JayKing014

By FoxyWoxy · Yesterday at 03:38 AM1 day
Orbital strike cannon fishing rod mod

@FoxyWoxy do you potentially have an estimated time for fabric 1.21.5 and what will it be posted on (modrinth, etc.)

By JayKing014 · Yesterday at 12:36 AM1 day

Choonster

Important Information

By using this site, you agree to our Terms of Use.

I accept

Chrome (Android)

Tap the lock icon next to the address bar.
Tap Permissions → Notifications.
Adjust your preference.

Chrome (Desktop)

Click the padlock icon in the address bar.
Select Site settings.
Find Notifications and adjust your preference.