[SOLVED][1.8] SmartblockModel weirdness (TheGreyGhost)

[Reygok]

Hi, I followed TheGreyGhost's tutorial for the 3D Web Model to handle the 255 possible states for my blocks, and I got it to work fine for one, but I have to repeat this code for a lot of blocks, but I can't get it to work for more than one.

This is my error:

 

[21:01:01] [Client thread/ERROR] [FML]: 2 loaders (com.reygok.octablocks.smartmodel.ModelLoaderTinyDirt@3f16a823 and com.reygok.octablocks.smartmodel.ModelLoaderTinyCobblestone@2165b170) want to load the same model octablocks:block/smartmodel/tinyDirtModel

[21:01:01] [Client thread/ERROR] [FML]: Exception checking if model octablocks:block/smartmodel/tinyDirtModel can be loaded with loader com.reygok.octablocks.smartmodel.ModelLoaderTinyCobblestone@2165b170, skipping

java.lang.IllegalStateException: 2 loaders want to load the same model

at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:80) [ModelLoaderRegistry.class:?]

at net.minecraftforge.client.model.ModelLoader.loadAnyModel(ModelLoader.java:228) [ModelLoader.class:?]

at net.minecraftforge.client.model.ModelLoader.getModel(ModelLoader.java:211) [ModelLoader.class:?]

at net.minecraftforge.client.model.ModelLoader$WeightedRandomModel.<init>(ModelLoader.java:490) [ModelLoader$WeightedRandomModel.class:?]

at net.minecraftforge.client.model.ModelLoader.registerVariant(ModelLoader.java:169) [ModelLoader.class:?]

at net.minecraft.client.resources.model.ModelBakery.loadVariants(ModelBakery.java:122) [ModelBakery.class:?]

at net.minecraftforge.client.model.ModelLoader.loadBlocks(ModelLoader.java:150) [ModelLoader.class:?]

at net.minecraftforge.client.model.ModelLoader.setupModelRegistry(ModelLoader.java:98) [ModelLoader.class:?]

at net.minecraft.client.resources.model.ModelManager.onResourceManagerReload(ModelManager.java:29) [ModelManager.class:?]

at net.minecraft.client.resources.SimpleReloadableResourceManager.registerReloadListener(SimpleReloadableResourceManager.java:130) [simpleReloadableResourceManager.class:?]

at net.minecraft.client.Minecraft.startGame(Minecraft.java:511) [Minecraft.class:?]

at net.minecraft.client.Minecraft.run(Minecraft.java:356) [Minecraft.class:?]

at net.minecraft.client.main.Main.main(Main.java:117) [Main.class:?]

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_45]

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_45]

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_45]

at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_45]

at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]

at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]

at net.minecraftforge.gradle.GradleStartCommon.launch(Unknown Source) [start/:?]

at GradleStart.main(Unknown Source) [start/:?]

 

 

 

The error says the two "***Model" classes try to load the same model, but how can they, since this is the code of the two:

 

package com.reygok.octablocks.smartmodel;

 

import net.minecraft.client.resources.IResourceManager;

import net.minecraft.util.ResourceLocation;

import net.minecraftforge.client.model.ICustomModelLoader;

import net.minecraftforge.client.model.IModel;

import net.minecraftforge.client.model.ModelLoaderRegistry;

 

public class ModelLoaderTinyDirt implements ICustomModelLoader

{

public final String SMART_MODEL_RESOURCE_LOCATION = "models/block/smartmodel/";

private IResourceManager resourceManager;

 

@Override

public void onResourceManagerReload(IResourceManager resourceManager)

{

this.resourceManager = resourceManager;

}

 

@Override

public boolean accepts(ResourceLocation modelLocation)

{

return modelLocation.getResourceDomain().equals("octablocks")

&& modelLocation.getResourcePath().startsWith(SMART_MODEL_RESOURCE_LOCATION);

}

 

@Override

public IModel loadModel(ResourceLocation modelLocation)

{

String resourcePath = modelLocation.getResourcePath();

    if (!resourcePath.startsWith(SMART_MODEL_RESOURCE_LOCATION)) {

      assert false : "loadModel expected " + SMART_MODEL_RESOURCE_LOCATION + " but found " + resourcePath;

    }

    String modelName = resourcePath.substring(SMART_MODEL_RESOURCE_LOCATION.length());

 

    if (modelName.equals("tinyDirtModel")) {

      return new TinyDirtModel();

    } else {

      return ModelLoaderRegistry.getMissingModel();

    }

}

 

}

 

 

package com.reygok.octablocks.smartmodel;

 

import net.minecraft.client.resources.IResourceManager;

import net.minecraft.util.ResourceLocation;

import net.minecraftforge.client.model.ICustomModelLoader;

import net.minecraftforge.client.model.IModel;

import net.minecraftforge.client.model.ModelLoaderRegistry;

 

public class ModelLoaderTinyCobblestone implements ICustomModelLoader

{

public final String SMART_MODEL_RESOURCE_LOCATION = "models/block/smartmodel/";

private IResourceManager resourceManager;

 

@Override

public void onResourceManagerReload(IResourceManager resourceManager)

{

this.resourceManager = resourceManager;

}

 

@Override

public boolean accepts(ResourceLocation modelLocation)

{

return modelLocation.getResourceDomain().equals("octablocks")

&& modelLocation.getResourcePath().startsWith(SMART_MODEL_RESOURCE_LOCATION);

}

 

@Override

public IModel loadModel(ResourceLocation modelLocation)

{

String resourcePath = modelLocation.getResourcePath();

    if (!resourcePath.startsWith(SMART_MODEL_RESOURCE_LOCATION)) {

      assert false : "loadModel expected " + SMART_MODEL_RESOURCE_LOCATION + " but found " + resourcePath;

    }

    String modelName = resourcePath.substring(SMART_MODEL_RESOURCE_LOCATION.length());

 

    if (modelName.equals("tinyCobblestoneModel")) {

      return new TinyCobblestoneModel();

    } else {

      return ModelLoaderRegistry.getMissingModel();

    }

}

 

}

 

 

As you can see at the end, I specify the right model in both cases. Why do I still get this error?

 

Here is the preInit from the main class:

 

@EventHandler

public void preInit(FMLPreInitializationEvent event)

{

tinyDirt = new TinyDirt();

GameRegistry.registerBlock(tinyDirt, ItemTinyBlock.class, "tinyDirt");

GameRegistry.registerTileEntity(TileEntityTinyBlock.class, "tinyDirt_TE");

StateMapperBase ignoreStateTinyDirt = new StateMapperBase() {

@Override

protected ModelResourceLocation getModelResourceLocation(IBlockState iBlockState) {

return new ModelResourceLocation("octablocks:tinyDirt");

}

};

ModelLoader.setCustomStateMapper(tinyDirt, ignoreStateTinyDirt);

ModelLoaderRegistry.registerLoader(new ModelLoaderTinyDirt());

 

tinyCobblestone = new TinyCobblestone();

GameRegistry.registerBlock(tinyCobblestone, ItemTinyBlock.class, "tinyCobblestone");

GameRegistry.registerTileEntity(TileEntityTinyBlock.class, "tinyCobblestone_TE");

StateMapperBase ignoreStateTinyCobblestone = new StateMapperBase() {

@Override

protected ModelResourceLocation getModelResourceLocation(IBlockState iBlockState) {

return new ModelResourceLocation("octablocks:tinyCobblestone");

}

};

ModelLoader.setCustomStateMapper(tinyCobblestone, ignoreStateTinyCobblestone);

ModelLoaderRegistry.registerLoader(new ModelLoaderTinyCobblestone());

 

}

 

 

 

Thanks in advance!

[TheGreyGhost]

Hi

 

Forge only expects your model to have one loader.

 

FOr example - Forge finds octablocks:tinyCobblestone, and looks through the custom loaders.

ModelLoaderTinyDirt.accepts() says "yes I am the one who should load that"

but also

ModelLoaderTinyCobblestone.accepst() says "yes I am the one who should load that".

If it has two loaders, how does it know which one it should use for the model?

 

I'd suggest you use just one loader for your 'octablocks' and return the right IModel based on the modelresourcelocation. 

 

-TGG

 

 

 

[Reygok]

Thanks a lot! I should have figured that out by myself...