[SOLVED][1.8] No texture when sapling dropped, even if it has in inventory

[JimiIT92]

I've bumped into a strange bug. I have a leave block that drops a sapling, but the sapling dropped has no texture, while the normal block have it in inventory. I'm sorry for my bad english, so here is some screenshots to better understand my problem:

 

This is how the sapling looks when taken from the inventory, as you can see it has a texture

 

And this is how it looks when is dropped from the leaves, as you can see it has no texture

 

If i pick another palm sapling from the inventory this stacks to the non-textured one, so this means they are the same object.

 

Here is the code of my block leaves, the other sapling (the apple one) has no problem.

package mw.blocks;

import java.util.List;
import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.BlockLeaves;
import net.minecraft.block.BlockPlanks;
import net.minecraft.block.BlockPlanks.EnumType;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyEnum;
import net.minecraft.block.state.BlockState;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.stats.StatList;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumWorldBlockLayer;
import net.minecraft.world.ColorizerFoliage;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

import com.google.common.base.Predicate;

import mw.core.MWBlocks;
import mw.core.MWMetadataBlocks;
import mw.core.utils.Utils;

public class BlockLeavesMW extends BlockLeaves {

public static final PropertyEnum VARIANT = PropertyEnum.create("variant", BlockPlanksMW.EnumType.class, new Predicate() {
	public boolean apply(BlockPlanksMW.EnumType type) {
		return type.getMetadata() < 4;
	}

	public boolean apply(Object par1) {
		return this.apply((BlockPlanksMW.EnumType) par1);
	}
});

public BlockLeavesMW() {
	this.setDefaultState(this.blockState.getBaseState().withProperty(VARIANT, BlockPlanksMW.EnumType.APPLE)
			.withProperty(CHECK_DECAY, Boolean.valueOf(true)).withProperty(DECAYABLE, Boolean.valueOf(true)));
	Utils.setLeaveInfo(this, "leaves");
}

@Override
@SideOnly(Side.CLIENT)
public EnumWorldBlockLayer getBlockLayer() {
	return Blocks.leaves.getBlockLayer();
}

public Item getItemDropped(IBlockState state, Random rand, int fortune) {
	if(state.getValue(VARIANT).equals(BlockPlanksMW.EnumType.APPLE))
		return Item.getItemFromBlock(MWMetadataBlocks.sapling);
	else
		return Item.getItemFromBlock(MWBlocks.palm_sapling.getDefaultState().getBlock());
}

public boolean isOpaqueCube()
    {
        return false;
    }

protected void dropApple(World worldIn, BlockPos pos, IBlockState state, int chance) {
	if (state.getValue(VARIANT) == BlockPlanksMW.EnumType.APPLE) {
		spawnAsEntity(worldIn, pos, new ItemStack(Items.apple, 1, 0));
	}
}

protected int getSaplingDropChance(IBlockState state) {
	return super.getSaplingDropChance(state);
}

@SideOnly(Side.CLIENT)
public void getSubBlocks(Item itemIn, CreativeTabs tab, List list) {
	list.add(new ItemStack(itemIn, 1, BlockPlanksMW.EnumType.APPLE.getMetadata()));
	list.add(new ItemStack(itemIn, 1, BlockPlanksMW.EnumType.PALM.getMetadata()));
}

protected ItemStack createStackedBlock(IBlockState state) {
	return new ItemStack(Item.getItemFromBlock(this), 1, ((BlockPlanksMW.EnumType) state.getValue(VARIANT)).getMetadata());
}

public IBlockState getStateFromMeta(int meta) {
	return this.getDefaultState().withProperty(VARIANT, BlockPlanksMW.EnumType.byMetadata((meta & 3) % 4))
			.withProperty(DECAYABLE, Boolean.valueOf((meta & 4) == 0)).withProperty(CHECK_DECAY, Boolean.valueOf((meta &  > 0));
}

public int getMetaFromState(IBlockState state) {
	byte b0 = 0;
	int i = b0 | ((BlockPlanksMW.EnumType) state.getValue(VARIANT)).getMetadata();

	if (!((Boolean) state.getValue(DECAYABLE)).booleanValue()) {
		i |= 4;
	}

	if (((Boolean) state.getValue(CHECK_DECAY)).booleanValue()) {
		i |= 8;
	}

	return i;
}

protected BlockState createBlockState() {
	return new BlockState(this, new IProperty[] { VARIANT, CHECK_DECAY, DECAYABLE });
}

public int damageDropped(IBlockState state) {
	return ((BlockPlanksMW.EnumType) state.getValue(VARIANT)).getMetadata();
}

public void harvestBlock(World worldIn, EntityPlayer player, BlockPos pos, IBlockState state, TileEntity te) {
	if (!worldIn.isRemote && player.getCurrentEquippedItem() != null && player.getCurrentEquippedItem().getItem() == Items.shears) {
		player.triggerAchievement(StatList.mineBlockStatArray[block.getIdFromBlock(this)]);
		spawnAsEntity(worldIn, pos,
				new ItemStack(Item.getItemFromBlock(this), 1, ((BlockPlanksMW.EnumType) state.getValue(VARIANT)).getMetadata()));
	} else {
		super.harvestBlock(worldIn, player, pos, state, te);
	}
}

@Override
public List<ItemStack> onSheared(ItemStack item, IBlockAccess world, BlockPos pos, int fortune) {
	IBlockState state = world.getBlockState(pos);
	return new java.util.ArrayList(
			java.util.Arrays.asList(new ItemStack(this, 1, ((BlockPlanksMW.EnumType) state.getValue(VARIANT)).getMetadata())));
}

@Override
public EnumType getWoodType(int meta) {
	return null;
}
}

 

And this is my Palm Sapling class

 

package mw.blocks;

import java.util.List;
import java.util.Random;

import mw.core.utils.Utils;
import mw.world.gen.feature.WorldGenBigPalmTree;
import mw.world.gen.feature.WorldGenPalmTree;
import net.minecraft.block.Block;
import net.minecraft.block.BlockBush;
import net.minecraft.block.IGrowable;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyEnum;
import net.minecraft.block.properties.PropertyInteger;
import net.minecraft.block.state.BlockState;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.init.Blocks;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockPos;
import net.minecraft.util.IStringSerializable;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraft.world.gen.feature.WorldGenerator;
import net.minecraftforge.common.EnumPlantType;
import net.minecraftforge.fml.common.registry.GameRegistry;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class BlockPalmSapling extends BlockBush implements IGrowable
{
    public static final PropertyEnum TYPE = PropertyEnum.create("type", BlockPalmSapling.EnumType.class);
    public static final PropertyInteger STAGE = PropertyInteger.create("stage", 0, 1);

    public static enum EnumType implements IStringSerializable
    {
        PALM(0, "palm");
        private static final BlockPalmSapling.EnumType[] META_LOOKUP = new BlockPalmSapling.EnumType[values().length];
        private final int meta;
        private final String name;
        private final String unlocalizedName;


        private EnumType(int meta, String name)
        {
            this(meta, name, name);
        }

        private EnumType(int meta, String name, String unlocalizedName)
        {
            this.meta = meta;
            this.name = name;
            this.unlocalizedName = unlocalizedName;
        }

        public int getMetadata()
        {
            return this.meta;
        }

        public String toString()
        {
            return this.name;
        }

        public static BlockPalmSapling.EnumType byMetadata(int meta)
        {
            if (meta < 0 || meta >= META_LOOKUP.length)
            {
                meta = 0;
            }

            return META_LOOKUP[meta];
        }

        public String getName()
        {
            return this.name;
        }

        public String getUnlocalizedName()
        {
            return this.unlocalizedName;
        }

        static
        {
            BlockPalmSapling.EnumType[] var0 = values();
            int var1 = var0.length;

            for (int var2 = 0; var2 < var1; ++var2)
            {
                BlockPalmSapling.EnumType var3 = var0[var2];
                META_LOOKUP[var3.getMetadata()] = var3;
            }
        }
    }
    
    public BlockPalmSapling()
    {
        this.setDefaultState(this.blockState.getBaseState().withProperty(TYPE, BlockPalmSapling.EnumType.PALM).withProperty(STAGE, Integer.valueOf(0)));
        Utils.setPlantBlockInfo(this, "palm_sapling");
        GameRegistry.registerBlock(this, "palm_sapling");
    }

    public void updateTick(World worldIn, BlockPos pos, IBlockState state, Random rand)
    {
        if (!worldIn.isRemote)
        {
            super.updateTick(worldIn, pos, state, rand);

            if (worldIn.getLightFromNeighbors(pos.up()) >= 9 && rand.nextInt(7) == 0)
            {
                this.grow(worldIn, pos, state, rand);
            }
        }
    }

    public void grow(World worldIn, BlockPos pos, IBlockState state, Random rand)
    {
        if (((Integer)state.getValue(STAGE)).intValue() == 0)
        {
            worldIn.setBlockState(pos, state.cycleProperty(STAGE), 4);
        }
        else
        {
            this.generateTree(worldIn, pos, state, rand);
        }
    }

    public void generateTree(World worldIn, BlockPos pos, IBlockState state, Random rand)
    {
        if (!net.minecraftforge.event.terraingen.TerrainGen.saplingGrowTree(worldIn, rand, pos)) return;
        Object object = rand.nextInt(10) == 0 ? new WorldGenBigPalmTree(true) : new WorldGenPalmTree();
        int i = 0;
        int j = 0;
        boolean flag = false;

        IBlockState iblockstate1 = Blocks.air.getDefaultState();

        if (flag)
        {
            worldIn.setBlockState(pos.add(i, 0, j), iblockstate1, 4);
            worldIn.setBlockState(pos.add(i + 1, 0, j), iblockstate1, 4);
            worldIn.setBlockState(pos.add(i, 0, j + 1), iblockstate1, 4);
            worldIn.setBlockState(pos.add(i + 1, 0, j + 1), iblockstate1, 4);
        }
        else
        {
            worldIn.setBlockState(pos, iblockstate1, 4);
        }

        if (!((WorldGenerator)object).generate(worldIn, rand, pos.add(i, 0, j)))
        {
            if (flag)
            {
                worldIn.setBlockState(pos.add(i, 0, j), state, 4);
                worldIn.setBlockState(pos.add(i + 1, 0, j), state, 4);
                worldIn.setBlockState(pos.add(i, 0, j + 1), state, 4);
                worldIn.setBlockState(pos.add(i + 1, 0, j + 1), state, 4);
            }
            else
            {
                worldIn.setBlockState(pos, state, 4);
            }
        }
    }

    /**
     * Check whether the given BlockPos has a Sapling of the given type
     */
    public boolean isTypeAt(World worldIn, BlockPos pos, BlockPalmSapling.EnumType type)
    {
        IBlockState iblockstate = worldIn.getBlockState(pos);
        return iblockstate.getBlock() == this && iblockstate.getValue(TYPE) == type;
    }

    /**
     * Get the damage value that this Block should drop
     */
    public int damageDropped(IBlockState state)
    {
        return ((BlockPalmSapling.EnumType)state.getValue(TYPE)).getMetadata();
    }

    /**
     * returns a list of blocks with the same ID, but different meta (eg: wood returns 4 blocks)
     */
    @SideOnly(Side.CLIENT)
    public void getSubBlocks(Item itemIn, CreativeTabs tab, List list)
    {
        BlockPalmSapling.EnumType[] aenumtype = BlockPalmSapling.EnumType.values();
        int i = aenumtype.length;

        for (int j = 0; j < i; ++j)
        {
            BlockPalmSapling.EnumType enumtype = aenumtype[j];
            list.add(new ItemStack(itemIn, 1, enumtype.getMetadata()));
        }
    }

    /**
     * Whether this IGrowable can grow
     */
    public boolean canGrow(World worldIn, BlockPos pos, IBlockState state, boolean isClient)
    {
        return true;
    }

    public boolean canUseBonemeal(World worldIn, Random rand, BlockPos pos, IBlockState state)
    {
        return (double)worldIn.rand.nextFloat() < 0.45D;
    }

    public void grow(World worldIn, Random rand, BlockPos pos, IBlockState state)
    {
        this.grow(worldIn, pos, state, rand);
    }

    /**
     * Convert the given metadata into a BlockState for this Block
     */
    public IBlockState getStateFromMeta(int meta)
    {
        return this.getDefaultState().withProperty(TYPE, BlockPalmSapling.EnumType.byMetadata(meta & 7)).withProperty(STAGE, Integer.valueOf((meta &  >> 3));
    }

    /**
     * Convert the BlockState into the correct metadata value
     */
    public int getMetaFromState(IBlockState state)
    {
        byte b0 = 0;
        int i = b0 | ((BlockPalmSapling.EnumType)state.getValue(TYPE)).getMetadata();
        i |= ((Integer)state.getValue(STAGE)).intValue() << 3;
        return i;
    }

    protected BlockState createBlockState()
    {
        return new BlockState(this, new IProperty[] {TYPE, STAGE});
    }

    static final class SwitchEnumType
        {
            static final int[] WOOD_TYPE_LOOKUP = new int[blockPalmSapling.EnumType.values().length];

            static
            {
                try
                {
                    WOOD_TYPE_LOOKUP[blockPalmSapling.EnumType.PALM.ordinal()] = 0;
                }
                catch (NoSuchFieldError var6)
                {
                    ;
                }
            }
        }
    /**
     * is the block grass, dirt or farmland
     */
    protected boolean canPlaceBlockOn(Block ground)
    {
        return ground == Blocks.sand;
    }
    
    /**
     * Whether this Block can be replaced directly by other blocks (true for e.g. tall grass)
     */
    public boolean isReplaceable(World worldIn, BlockPos pos)
    {
        return true;
    }
    
    @Override
public EnumPlantType getPlantType(IBlockAccess world, BlockPos pos) {
	return EnumPlantType.Desert;
}
}

 

Optional question: there is a way to have a metadata sapling wich every type can be placed on different blocks? For example, a sapling that coul be of two types (apple and palm), with apple-one that can be placed on grass and with palm-one that can be placed only on sand. Beacause actually i have two different classes for this two blocks

 

Thanks in advance for all who will help me

[JimiIT92]

Anyone? Please i really need to figure out why this happens, beacuse is really annoying

[TheGreyGhost]

Hi

 

It sounds pretty weird alright.  But there must be some subtle difference you're just not seeing.

 

I would suggest hold the weird texture item in your hand, then put a breakpoint in here

ItemRenderer.renderItem()

and trace it through to here and see why it can't get the right model:

    public void renderItemModelForEntity(ItemStack stack, EntityLivingBase entityToRenderFor, ItemCameraTransforms.TransformType cameraTransformType)

    {

        IBakedModel ibakedmodel = this.itemModelMesher.getItemModel(stack);

 

Then do the same for the good texture item in your hand, and see if you can spot the difference.

 

-TGG

 

[JimiIT92]

I'm sorry but i don't understand where in the code i have to place the breakpoint

Also, if needed, this are the JSON files of the sapling:

Blockstate file

{
"variants": {
	"stage=0,type=palm": { "model": "mw:palm_sapling" },
	"stage=1,type=palm": { "model": "mw:palm_sapling" }
}
}

 

Item file

{
    "parent": "builtin/generated",
    "textures": {
        "layer0": "mw:blocks/palm_sapling"
    },
    "display": {
        "thirdperson": {
            "rotation": [ -90, 0, 0 ],
            "translation": [ 0, 1, -3 ],
            "scale": [ 0.55, 0.55, 0.55 ]
        },
        "firstperson": {
            "rotation": [ 0, -135, 25 ],
            "translation": [ 0, 4, 2 ],
            "scale": [ 1.7, 1.7, 1.7 ]
        }
    }
}

 

Block model file

{
    "parent": "block/cross",
    "textures": {
        "cross": "mw:blocks/palm_sapling"
    }
}

[TheGreyGhost]

Hi

 

Have you done much debugging before?  If not, I reckon it's probably worth spending a couple of hours learning how to use Eclipse or IntelliJ to debug a running program- breakpoints, watchpoints, stack frames.

This one is for Eclipse which is pretty good start

http://www.vogella.com/tutorials/EclipseDebugging/article.html

 

The place I'm suggesting the breakpoint is in the minecraft / forge library

Look in the libaries for forgeSrc-1.8-11.14.1.xxxx and you will find the ItemRender class

 

[package]

package net.minecraft.client.renderer;

@SideOnly(Side.CLIENT)
public class ItemRenderer
{
    private static final ResourceLocation RES_MAP_BACKGROUND = new ResourceLocation("textures/map/map_background.png");
    private static final ResourceLocation RES_UNDERWATER_OVERLAY = new ResourceLocation("textures/misc/underwater.png");
    /** A reference to the Minecraft object. */
    private final Minecraft mc;
    private ItemStack itemToRender;
    /** How far the current item has been equipped (0 disequipped and 1 fully up) */
    private float equippedProgress;
    private float prevEquippedProgress;
    private final RenderManager renderManager;
    private final RenderItem itemRenderer;
    /** The index of the currently held item (0-8, or -1 if not yet updated) */
    private int equippedItemSlot = -1;
    private static final String __OBFID = "CL_00000953";

    public ItemRenderer(Minecraft mcIn)
    {
        this.mc = mcIn;
        this.renderManager = mcIn.getRenderManager();
        this.itemRenderer = mcIn.getRenderItem();
    }

    public void renderItem(EntityLivingBase entityIn, ItemStack heldStack, ItemCameraTransforms.TransformType p_178099_3_)
    {
        if (heldStack != null)
        {
            Item item = heldStack.getItem();
            Block block = Block.getBlockFromItem(item);
            GlStateManager.pushMatrix();

 

 

You can also use the search function to jump straight to a class definition, for example in IntelliJ it's ctrl-N  (don't know in Eclipse).

 

The problem might be something to do with the stage property but it's too hard to tell just by looking at the code, using the debugger really is the fastest way for you to track it down...

 

-TGG

[JimiIT92]

Yes, i do debug in Eclipse before (actually i can say i do it every day, i study Computer Science at University, lol .-.). I only asked where in the code to set the breakpoint, beacuse i thought it was going to place it in mods code, not in vanilla code Anyway thanks for pointing me where to debug, i'll let you know the results

[TheGreyGhost]

Hi

 

Ah ok, my bad

 

good luck dude, troubleshooting the 'missing model' errors can be a right pain in the butt

 

-TGG

[JimiIT92]

Ok, so doing debug i find that the item returned was the Palm Sapling but with a metadata value of 1 (wich doesn't exists). So, i've removed the damageDropped function from the BlockLeavesMW class and it worked. Now it returns the right sapling Fortunately was a dumb fix to do Thanks for the help, and for the tip. In the future i will sure do debug also in vanilla code if needed