Search the Forums BEFORE making a new post.

[1.7.10] Block get breaked but dont dissapear

Posted July 5, 201510 yr

Hey, ive a question: Im building a Thaumcraft-Addon and Im creating a Wand-Of-Excavation item. It should harvest a block when right-clicking... But it only breaks the block with a destroy-animation, the block don't disappear and still exist... How can I fix it?

Heres my source:

package de.xthelegend.tcwands;

import ibxm.Player;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;

import thaumcraft.common.Thaumcraft;
import thaumcraft.common.entities.projectile.EntityExplosiveOrb;
import thaumcraft.common.items.wands.WandManager;
import thaumcraft.common.lib.utils.BlockUtils;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.init.Blocks;
import net.minecraft.item.Item;
import net.minecraft.item.ItemFishingRod;
import net.minecraft.item.ItemStack;
import net.minecraft.util.MovingObjectPosition;
import net.minecraft.util.Vec3;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraft.world.WorldSettings;
import net.minecraftforge.common.ForgeHooks;
import net.minecraftforge.common.util.ForgeDirection;
import net.minecraftforge.event.ForgeEventFactory;
import net.minecraftforge.event.world.BlockEvent;

public class wand_of_excavation extends Item{
public wand_of_excavation()
{

	super();
	setUnlocalizedName(Reference.MODID + ":" + "wandexcavation");
	setTextureName(Reference.MODID + ":" + "wandexcavation");
	setMaxDamage(2500);
	canRepair = false;
	this.bFull3D = true;
	setCreativeTab(MainClass.tabWands);
}

@SideOnly(Side.CLIENT)
    public boolean isFull3D()
    {
        return true;
    }

    @SideOnly(Side.CLIENT)
    public boolean shouldRotateAroundWhenRendering()
    {
        return true;
    }
    
    @Override
    public ItemStack onItemRightClick(ItemStack stack, World world, EntityPlayer player)
    {
    	player.setItemInUse(stack, this.getMaxDamage());
    	return stack;
    }
    
    static HashMap<String, Long> soundDelay = new HashMap();
    static HashMap<String, Object> beam = new HashMap();
    static HashMap<String, Float> breakcount = new HashMap();
    static HashMap<String, Integer> lastX = new HashMap();
    static HashMap<String, Integer> lastY = new HashMap();
    static HashMap<String, Integer> lastZ = new HashMap();
    
    @Override
    public void onUsingTick(ItemStack stack, EntityPlayer p, int count) {
        
        String pp = "R" + p.getCommandSenderName();
        if (!p.worldObj.isRemote) {
            pp = "S" + p.getCommandSenderName();
        }
        if (soundDelay.get(pp) == null) {
            soundDelay.put(pp, 0L);
        }
        if (breakcount.get(pp) == null) {
            breakcount.put(pp, Float.valueOf(0.0f));
        }
        if (lastX.get(pp) == null) {
            lastX.put(pp, 0);
        }
        if (lastY.get(pp) == null) {
            lastY.put(pp, 0);
        }
        if (lastZ.get(pp) == null) {
            lastZ.put(pp, 0);
        }
        MovingObjectPosition mop = BlockUtils.getTargetBlock(p.worldObj, (Entity)p, false);
        Vec3 v = p.getLookVec();
        double tx = p.posX + v.xCoord * 10.0;
        double ty = p.posY + v.yCoord * 10.0;
        double tz = p.posZ + v.zCoord * 10.0;
        int impact = 0;
        if (mop != null) {
            tx = mop.hitVec.xCoord;
            ty = mop.hitVec.yCoord;
            tz = mop.hitVec.zCoord;
            impact = 5;
            if (!(p.worldObj.isRemote || soundDelay.get(pp) >= System.currentTimeMillis())) {
                p.worldObj.playSoundEffect(tx, ty, tz, "thaumcraft:rumble", 0.3f, 1.0f);
                soundDelay.put(pp, System.currentTimeMillis() + 1200);
            }
        } else {
            soundDelay.put(pp, 0L);
        }
        if (p.worldObj.isRemote) {
            beam.put(pp, Thaumcraft.proxy.beamCont(p.worldObj, p, tx, ty, tz, 2, 65382, false, impact > 0 ? 2.0f : 0.0f, beam.get(pp), impact));
        }
        if (mop != null && mop.typeOfHit == MovingObjectPosition.MovingObjectType.BLOCK && p.worldObj.canMineBlock(p, mop.blockX, mop.blockY, mop.blockZ)) {
            Block bi = p.worldObj.getBlock(mop.blockX, mop.blockY, mop.blockZ);
            int md = p.worldObj.getBlockMetadata(mop.blockX, mop.blockY, mop.blockZ);
            float hardness = bi.getBlockHardness(p.worldObj, mop.blockX, mop.blockY, mop.blockZ);
            if (hardness >= 0.0f) {
                int pot = 1;
                float speed = 0.05f + (float)pot * 0.1f;
                if (bi.getMaterial() == Material.rock || bi.getMaterial() == Material.grass || bi.getMaterial() == Material.ground || bi.getMaterial() == Material.sand) {
                    speed = 0.25f + (float)pot * 0.25f;
                }
                if (bi == Blocks.obsidian) {
                    speed*=3.0f;
                }
                if (lastX.get(pp) == mop.blockX && lastY.get(pp) == mop.blockY && lastZ.get(pp) == mop.blockZ) {
                    float bc = breakcount.get(pp).floatValue();
                    if (p.worldObj.isRemote && bc > 0.0f && bi != Blocks.air) {
                        int progress = (int)(bc / hardness * 9.0f);
                        Thaumcraft.proxy.excavateFX(mop.blockX, mop.blockY, mop.blockZ, p, Block.getIdFromBlock((Block)bi), md, progress);
                    }
                    if (p.worldObj.isRemote) {
                        if (bc >= hardness) {
                            breakcount.put(pp, Float.valueOf(0.0f));
                        } else {
                            breakcount.put(pp, Float.valueOf(bc + speed));
                        }
                    } else if (bc >= hardness ) {
                        if (this.excavate(p.worldObj, stack, p, bi, md, mop.blockX, mop.blockY, mop.blockZ)) 
                        {
                        	stack.damageItem(200,p);
                        }
                        lastX.put(pp, Integer.MAX_VALUE);
                        lastY.put(pp, Integer.MAX_VALUE);
                        lastZ.put(pp, Integer.MAX_VALUE);
                        breakcount.put(pp, Float.valueOf(0.0f));
                    } else {
                        breakcount.put(pp, Float.valueOf(bc + speed));
                    }
                } else {
                    lastX.put(pp, mop.blockX);
                    lastY.put(pp, mop.blockY);
                    lastZ.put(pp, mop.blockZ);
                    breakcount.put(pp, Float.valueOf(0.0f));
                }
            }
        } else {
            lastX.put(pp, Integer.MAX_VALUE);
            lastY.put(pp, Integer.MAX_VALUE);
            lastZ.put(pp, Integer.MAX_VALUE);
            breakcount.put(pp, Float.valueOf(0.0f));
        }
    }
    
    private boolean excavate(World world, ItemStack stack, EntityPlayer player, Block block, int md, int x, int y, int z) {
        BlockEvent.BreakEvent event;
        WorldSettings.GameType gt = WorldSettings.GameType.SURVIVAL;
        if (player.capabilities.allowEdit) {
            if (player.capabilities.isCreativeMode) {
                gt = WorldSettings.GameType.CREATIVE;
            }
        } else {
            gt = WorldSettings.GameType.ADVENTURE;
        }
        if (!(event = ForgeHooks.onBlockBreakEvent((World)world, (WorldSettings.GameType)gt, (EntityPlayerMP)((EntityPlayerMP)player), (int)x, (int)y, (int)z)).isCanceled()) {
            int fortune = 0;
            boolean silk =false;
            if (silk && block.canSilkHarvest(player.worldObj, player, x, y, z, md)) {
                ArrayList<ItemStack> items = new ArrayList<ItemStack>();
                ItemStack itemstack = BlockUtils.createStackedBlock(block, md);
                if (itemstack != null) {
                    items.add(itemstack);
                }
                ForgeEventFactory.fireBlockHarvesting(items, (World)world, (Block)block, (int)x, (int)y, (int)z, (int)md, (int)0, (float)1.0f, (boolean)true, (EntityPlayer)player);
                for (ItemStack is : items) {
                    BlockUtils.dropBlockAsItem(world, x, y, z, is, block);
                }
            } else {
                BlockUtils.dropBlockAsItemWithChance(world, block, x, y, z, md, 1.0f, fortune, player);
                block.dropXpOnBlockBreak(world, x, y, z, block.getExpDrop((IBlockAccess)world, md, fortune));
            }
            world.setBlockToAir(x, y, z);
            world.playAuxSFX(2001, x, y, z, Block.getIdFromBlock((Block)block) + (md << 12));
            return true;
        }
        return false;
    }
    
    boolean breakNeighbour(EntityPlayer p, int x, int y, int z, Block block, int md, ItemStack stack) {
        List<ForgeDirection> directions = Arrays.asList(new ForgeDirection[]{ForgeDirection.DOWN, ForgeDirection.UP, ForgeDirection.NORTH, ForgeDirection.SOUTH, ForgeDirection.EAST, ForgeDirection.WEST});
        Collections.shuffle(directions, p.worldObj.rand);
        for (ForgeDirection dir : directions) {
            if (p.worldObj.getBlock(x + dir.offsetX, y + dir.offsetY, z + dir.offsetZ) != block || p.worldObj.getBlockMetadata(x + dir.offsetX, y + dir.offsetY, z + dir.offsetZ) != md || !this.excavate(p.worldObj, stack, p, block, md, x + dir.offsetX, y + dir.offsetY, z + dir.offsetZ)) continue;
            return true;
        }
        return false;
    }
    
    @Override
    public void onPlayerStoppedUsing(ItemStack stack, World world, EntityPlayer p, int count) {
        String pp = "R" + p.getCommandSenderName();
        if (!p.worldObj.isRemote) {
            pp = "S" + p.getCommandSenderName();
        }
        if (soundDelay.get(pp) == null) {
            soundDelay.put(pp, 0L);
        }
        if (breakcount.get(pp) == null) {
            breakcount.put(pp, Float.valueOf(0.0f));
        }
        if (lastX.get(pp) == null) {
            lastX.put(pp, 0);
        }
        if (lastY.get(pp) == null) {
            lastY.put(pp, 0);
        }
        if (lastZ.get(pp) == null) {
            lastZ.put(pp, 0);
        }
        beam.put(pp, null);
        lastX.put(pp, Integer.MAX_VALUE);
        lastY.put(pp, Integer.MAX_VALUE);
        lastZ.put(pp, Integer.MAX_VALUE);
        breakcount.put(pp, Float.valueOf(0.0f));
    }
    
    @Override
    public void onUpdate(ItemStack stack, World world, Entity entity, int p_77663_4_, boolean p_77663_5_) {
        if (stack.stackTagCompound != null && stack.stackTagCompound.hasKey("ench")) {
            stack.stackTagCompound.removeTag("ench");
        }
        super.onUpdate(stack, world, entity, p_77663_4_, p_77663_5_);
    }
    
    
}

Quote

July 5, 201510 yr

Author

No, Im readding the Thaumcraft 3 Wand Of Excavation to Thaumcraft 4 by request of a friend :)) Youve a idea what the problem is?

Quote

July 6, 201510 yr

i recomend adding a debug line to excavate method

System.out.println("x="+x+" y="+y+" z="+z);

also change world.setBlockToAir(x, y, z); to set it to something else , to verify that x,y,z arnt pointing to a block that is already air

might help find the problem

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/31584-1710-block-get-breaked-but-dont-dissapear/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

Make sure you are using Java 17 JDK

In the start script, replace the word "java" with the java 17 path (javaw.exe) and put it into quotation marks

By TileEntity · 1 hour ago1 hr
NEED HELP ASAP - Failed to load datapacks, can't proceed with server load. You can either fix your datapacks or reset to vanilla

There are client-side-only mods in your server - start with removing justenoughbreeding

By TileEntity · 1 hour ago1 hr
NEED HELP ASAP - Failed to load datapacks, can't proceed with server load. You can either fix your datapacks or reset to vanilla

Hey there, I have a big modpack I'm trying to run that I've put together with two other rather large communities- we have a grand opening scheduled for next week so it's really important that this gets solved ASAP.

The game runs fine in singleplayer, but when trying to run as a server using a hosting website, I've run into quite a massive error log. I've whittled it down to this point- I'm currently not sure what to do, as I believe the main error is relating to the datapack message, but I don't know for sure. Removing the datapack folder doesn't change the message either.

https://mclo.gs/2aTdXII

If the fix is something very simple, I apologize. I'm not too experienced with hosting websites and running large modpacks like this on a server.
I'm also not completely sure of which mods are client-only- a large handful of which are already disabled but I could be missing some. I just don't know which ones they would be, if that's causing the issue.

By nyxxiea · Posted 6 hours ago6 hr
Orbital strike cannon fishing rod mod

ok i have a early build of the mod there is lots more to come trust me @ggggggg453
https://drive.google.com/file/d/1q1L5fXqNy3aclCk74K0FeAn9FmJ15Byx/view?usp=sharing

its for forge 1.20.1 and go to the ingame mods tab and read the description for info

or just type in chat /orbital nuke 20 1
or /orbital stab 300 1

By FoxyWoxy · 8 hours ago8 hr
Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

Okay so I was trying to boot an MC Eternal 2 Server, I downloaded the latest server files from Curse which include a 47.4.2 jar. Whenever I install the server files into my folder and attempt to boot the server, I get Error: Could not find or load main class @user_jvm_args.txt in the cmd and nothing else. Now, MCE2 does have its own custom args so I deleted those and tried simple xms and xmx args, but that didn't let the server boot either. I assumed that maybe my java version was out of date, but I have the latest version of Java Installed and I even installed the Java 17 SDK for good measure just in case Java 25 is too recent for the pack. Still no avail. I tried running a vanilla 1.20.1 and it boots just fine, but for some reason the forge server still won't boot. Does anyone know anything I could try?

By Linksapprentice · Posted 12 hours ago12 hr

There are no registered users currently online

Sign In

[1.7.10] Block get breaked but dont dissapear

Featured Replies

Join the conversation

Posts

Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

NEED HELP ASAP - Failed to load datapacks, can't proceed with server load. You can either fix your datapacks or reset to vanilla

NEED HELP ASAP - Failed to load datapacks, can't proceed with server load. You can either fix your datapacks or reset to vanilla

Orbital strike cannon fishing rod mod

Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)