[1.8] [SOLVED] Making the player go faster in water?

[Ferrettomato]

I'm trying to make an item that speeds up the player in water using attribute modifiers, but it's massively restrained by the apparently unstoppable force of water lowering the player's movement speed. Is there any way to stop this? Would removing water's attribute modifier work? If so, where can I find its UUID?

[Ferrettomato]

(shameless bump) If it'll help others understand what I'm trying to do, here's my code:

static final AttributeModifier attribute = new AttributeModifier(UUID.fromString("ABE2DC00-867B-4842-B773-FA91B0901CFE"), "movementSpeed", 1D, 2);
public void onArmorTick(World world, EntityPlayer player, ItemStack itemStack)
{
	if(player.getAir() < 300)
	{
		player.setAir(300);
	}

	if(KeyBindings.ability.isKeyDown())
	{
		if(player.isInWater())
		{
			if(player.getEntityAttribute(SharedMonsterAttributes.movementSpeed).getModifier(UUID.fromString("ABE2DC00-867B-4842-B773-FA91B0901CFE")) == null)
			{
				player.getEntityAttribute(SharedMonsterAttributes.movementSpeed).applyModifier(attribute);

			}
		}
		else
			player.getEntityAttribute(SharedMonsterAttributes.movementSpeed).removeModifier(attribute);
	}
}

(the AttributeModifier is created at the beginning of the class, I just cut out some unnecessary code)

[coolAlias]

The problem is that water and other fluids don't apply attribute modifiers, they modify the entity's motion directly in World#handleMaterialAcceleration.

 

The only way I've found to counteract this is to literally reverse it every single tick using a static helper method:

 

/**
 * Undoes whatever acceleration has been applied by materials such as flowing water (see {@link World#handleMaterialAcceleration})
 */
public static boolean reverseMaterialAcceleration(World world, AxisAlignedBB aabb, Material material, Entity entity) {
	int i = MathHelper.floor_double(aabb.minX);
	int j = MathHelper.floor_double(aabb.maxX + 1.0D);
	int k = MathHelper.floor_double(aabb.minY);
	int l = MathHelper.floor_double(aabb.maxY + 1.0D);
	int i1 = MathHelper.floor_double(aabb.minZ);
	int j1 = MathHelper.floor_double(aabb.maxZ + 1.0D);
	if (!WorldUtils.isAreaLoaded(world, i, k, i1, j, l, j1, true)) {
		return false;
	} else {
		boolean flag = false;
		Vec3 vec3 = new Vec3(0.0D, 0.0D, 0.0D);
		for (int k1 = i; k1 < j; ++k1) {
			for (int l1 = k; l1 < l; ++l1) {
				for (int i2 = i1; i2 < j1; ++i2) {
					BlockPos pos = new BlockPos(k1, l1, i2);
					IBlockState state = world.getBlockState(pos);
					Block block = state.getBlock();
					if (block.getMaterial() == material) {
						double liquidLevel = (double)((float)(l1 + 1) - BlockLiquid.getLiquidHeightPercent(((Integer) state.getValue(BlockLiquid.LEVEL)).intValue()));
						if ((double)l >= liquidLevel) {
							flag = true;
							vec3 = block.modifyAcceleration(world, pos, entity, vec3);
						}
					}
				}
			}
		}
		if (vec3.lengthVector() > 0.0D && entity.isPushedByWater()) {
			vec3 = vec3.normalize();
			double d1 = 0.014D;
			entity.motionX -= vec3.xCoord * d1;
			entity.motionY -= vec3.yCoord * d1;
			entity.motionZ -= vec3.zCoord * d1;
			entity.motionX *= 0.85D;
			entity.motionY *= 0.85D;
			entity.motionZ *= 0.85D;
		}
		return flag;
	}
}

 

That will let the player stand in any flowing liquid and be unmoved, but you do have to call it every tick for it to work, and let it run on both client and server side. In my own code for the heavy boots, I have it being called during Item#onArmorTick.

[Ferrettomato]

Thanks so much! By looking at your code, I learned about using the player's motionX/Y/Z along with their LookVec, and now it works like a charm! (if a little differently to my plans)